GNU bug report logs - #39858
[PATCH] gnu: ccache: Update to 3.7.7.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39858 in the body.
You can then email your comments to 39858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ccache: Update to 3.7.7.
Date: Sun, 1 Mar 2020 18:48:47 +0100

[Message part 1 (text/plain, inline)]

lightly tested: cache hits on trivial .c file compilation

Additions to native inputs: asciidoc autoconf gperf
Trivial ./etc/indent-code.el housekeeping

More infos from ccache news:
2016-06-06: Source code and bug tracker moved to github
2019-04-03: Web site moved to ccache.dev

--
Vincent Legoll

[0001-gnu-ccache-Update-to-3.7.7.patch (text/x-patch, attachment)]

Message #8 received at 39858 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> posteo.net>
To: 39858 <at> debbugs.gnu.org
Subject: Re: [bug#39858] [PATCH] gnu: ccache: Update to 3.7.7.
Date: Mon, 02 Mar 2020 00:49:18 -0600

Hi Vincent, thanks for the patch, some comments below:

On 01.03.2020 11:48, Vincent Legoll wrote:
> lightly tested: cache hits on trivial .c file compilation

And the tests still pass ;)

> Trivial ./etc/indent-code.el housekeeping

Could you move this to a separate patch, please?

> From 9718baa06727eb515030cf7b617a10e9fab8052a Mon Sep 17 00:00:00 2001
> From: Vincent Legoll <vincent.legoll <at> gmail.com>
> Date: Sun, 1 Mar 2020 17:59:10 +0100
> Subject: [PATCH] gnu: ccache: Update to 3.7.7.
> 
> * gnu/packages/ccache.scm (ccache): Update to 3.7.7.
> * gnu/packages/ccache.scm (ccache): Update source to github
> * gnu/packages/ccache.scm (ccache): Update home-page to ccache.dev
> * gnu/packages/ccache.scm (ccache): Add native inputs: asciidoc 
> autoconf gperf
> * gnu/packages/ccache.scm (ccache): Reindent arguments

Check the manual and other commit messages for formatting.  In 
particular, the file name only needs to be mentioned once, and the 
affected sections are mentioned in square brackets before the comment.

> ---
> gnu/packages/ccache.scm | 33 +++++++++++++++++++++------------
> 1 file changed, 21 insertions(+), 12 deletions(-)
> ...
> - (method url-fetch)
> - (uri (string-append "https://www.samba.org/ftp/ccache/ccache-"
> - version ".tar.xz"))
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ccache/ccache.git")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> (sha256
> - (base32 "07wv75xdcxpdkfsz9h5ffrm8pjbvr1dh6wnb02nyzz18cdbjkcd6"))))
> + (base32 "1s8mq832chk95wa5qwaalralwv3ln1m931nrgd9a4gi19lg55zln"))))
> (build-system gnu-build-system)

I think we can actually stick with the tarball available on the github 
release page: 
https://github.com/ccache/ccache/releases/download/v3.7.7/ccache-3.7.7.tar.xz 
which is already bootstrapped.

> (native-inputs `(("perl" ,perl) ; for test/run
> + ("asciidoc" ,asciidoc)
> + ("autoconf" ,autoconf)
> + ("gperf" ,gperf)

Using the distribution tarball should prevent needing to add these 
inputs.

> (description
> "Ccache is a compiler cache. It speeds up recompilation by caching

It seems based on the release notes that we also need to remove the 
mention of Fortran 77 support in the description.

Could you send updated patches?

Cheers,
`~Eric

Message #11 received at 39858 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Eric Bavier <bavier <at> posteo.net>
Cc: 39858 <at> debbugs.gnu.org,
 Guix-patches <guix-patches-bounces+bavier=posteo.net <at> gnu.org>
Subject: Re: [bug#39858] [PATCH] gnu: ccache: Update to 3.7.7.
Date: Mon, 2 Mar 2020 08:44:28 +0100

Hello

On Mon, Mar 2, 2020 at 7:24 AM Eric Bavier <bavier <at> posteo.net> wrote:
> Hi Vincent, thanks for the patch, some comments below:
> On 01.03.2020 11:48, Vincent Legoll wrote:
> > lightly tested: cache hits on trivial .c file compilation
>
> And the tests still pass ;)

Yes, I should have mentionned it

> Could you send updated patches?

Yes, I will, thanks for the review

-- 
Vincent Legoll

Message #14 received at 39858 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 39858 <at> debbugs.gnu.org
Subject: [PATCH, v2, 1/2] gnu: ccache: Update to 3.7.7.
Date: Wed, 4 Mar 2020 18:53:18 +0100

[Message part 1 (text/plain, inline)]

Here is the updated version:

split the reindent, use source tarball,
remove f77

Hope it's better...

-- 
Vincent Legoll

[0001-gnu-ccache-Update-to-3.7.7.patch (text/x-patch, attachment)]

Message #17 received at 39858 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 39858 <at> debbugs.gnu.org
Subject: [PATCH, v2, 2/2] gnu: ccache: Fix indentation
Date: Wed, 4 Mar 2020 18:54:44 +0100

[Message part 1 (text/plain, inline)]

here the split indentation fix

-- 
Vincent Legoll

[0002-gnu-ccache-Fix-indentation.patch (text/x-patch, attachment)]

Message #22 received at 39858-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 39858-done <at> debbugs.gnu.org
Subject: Re: [bug#39858] [PATCH, v2, 1/2] gnu: ccache: Update to 3.7.7.
Date: Sat, 07 Mar 2020 22:19:17 +0100

Hi Vincent,

Applied both patches, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.