GNU bug report logs - #39867
26.3; EWW does not show textarea content

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39867 in the body.
You can then email your comments to 39867 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xu Chunyang <xuchunyang56 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3; EWW does not show textarea content
Date: Mon, 2 Mar 2020 23:25:45 +0800

I notice EWW doesn't show the textarea element's contents, for example,
save the following to a.html

    <textarea>HELLO</textarea>

then 'M-x eww-open-file a.html' shows some empty lines without any text.

The following patch fixes the issue for me. And the old code seems
assuming <textarea value='HELLO'></textarea>, which is not correct.

diff -u --label /Users/xcy/src/emacs-mac/lisp/net/eww.el --label
\#\<buffer\ eww.el\> /Users/xcy/src/emacs-mac/lisp/net/eww.el
/var/folders/7f/s191h4q97p90374yw15ssrs00000gn/T/buffer-content-gR2Wn9
--- /Users/xcy/src/emacs-mac/lisp/net/eww.el
+++ #<buffer eww.el>
@@ -1168,7 +1168,7 @@

 (defun eww-tag-textarea (dom)
   (let ((start (point))
- (value (or (dom-attr dom 'value) ""))
+ (value (or (dom-text dom) ""))
  (lines (string-to-number (or (dom-attr dom 'rows) "10")))
  (width (string-to-number (or (dom-attr dom 'cols) "10")))
  end)

Diff finished.  Mon Mar  2 23:21:14 2020

Message #8 received at 39867 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Xu Chunyang <xuchunyang56 <at> gmail.com>
Cc: 39867 <at> debbugs.gnu.org
Subject: Re: bug#39867: 26.3; EWW does not show textarea content
Date: Fri, 17 Jul 2020 16:44:24 +0200

Xu Chunyang <xuchunyang56 <at> gmail.com> writes:

> I notice EWW doesn't show the textarea element's contents, for example,
> save the following to a.html
>
>     <textarea>HELLO</textarea>
>
> then 'M-x eww-open-file a.html' shows some empty lines without any text.
>
> The following patch fixes the issue for me. And the old code seems
> assuming <textarea value='HELLO'></textarea>, which is not correct.

[...]

> - (value (or (dom-attr dom 'value) ""))
> + (value (or (dom-text dom) ""))

Thanks; applied to Emacs 28.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.