GNU bug report logs - #39878
gnu: add emacs-bookmarks+

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39878 in the body.
You can then email your comments to 39878 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: nly <at> disroot.org (Amar M. Singh)
To: guix-patches <at> gnu.org
Subject: gnu: add emacs-bookmarks+
Date: Tue, 03 Mar 2020 11:41:13 +0530

[Message part 1 (text/plain, inline)]

Add package emacs-bookmarks+.

Can someone help me with this build?  Bookmarks+ requiers
bookmarks+-mac.el to be loaded to be able to compile the other files.

Emacswiki: https://www.emacswiki.org/emacs/BookmarkPlus
Richer bookmarks. They record more. They are more accurate.

Thanks,
Amar

[0001-gnu-Add-emacs-bookmark.patch (text/x-patch, attachment)]

Message #8 received at 39878 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: nly <at> disroot.org (Amar M. Singh)
Cc: 39878 <at> debbugs.gnu.org
Subject: Re: [bug#39878] gnu: add emacs-bookmarks+
Date: Sat, 25 Jul 2020 22:49:37 +0300

[Message part 1 (text/plain, inline)]

Hi,

So much time was passed, but maybe we could get this to work if the
package still helpful for Emacs users.

nly <at> disroot.org (Amar M. Singh) writes:

[…]

> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index be0e6a84c2..1ac5f77bb7 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -21536,3 +21536,39 @@ Values are stored in a directory in @code{user-emacs-directory}, using
>  one file per value.  This makes it easy to delete or remove unused
>  variables.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-bookmark+
> +  (package
> +    (name "emacs-bookmark+")
> +    (version "2020.01.22")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (map (lambda (x)
> +                          (string-append
> +                           "https://www.emacswiki.org/emacs/download/" x))
> +                        `("bookmark+.el"
> +                          "bookmark+-mac.el"
> +                          "bookmark+-bmu.el"
> +                          "bookmark+-key.el"
> +                          "bookmark+-lit.el"
> +                          "bookmark+-1.el")))

‘bookmarks+-mac.el’ and other files are missing because this ‘(origin
...)’ returns only a single file:
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build --no-grafts --no-offload 'emacs-bookmark+' -S
/gnu/store/p0lvca4zr1rh4bs9fd281hjh15ck28x8-bookmark+.el
--8<---------------cut here---------------end--------------->8---

You could use ‘(origin ...)’ inside ‘(inputs ...)’ to fetch all the
files, but in that case we could have an issue with more hashes as
described bellow.

To fix issue with hashes I think we could use url-fetch on
https://github.com/emacsmirror/emacswiki.org/blob/f2f216389097ada0172ebbfaaf594e397930682e/bookmark%2B.el
and other files.

> +              (sha256
> +               (base32
> +                "1dkpszmflik3yhv05w8rvi6vz1mzgapncb5y231r6mwy40rphyhi"))))

The hash was changed, even the version is the same.

> +    (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'build-mac
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (invoke "emacs" "-Q" "--batch"
> +                       "--eval='(byte-compile-file \"bookmark+-mac.el\"'")))))))

‘emacs-build-system’ provides a byte compilation AFAIK, so don't need
this ‘(arguments ...)’.

> +    (home-page "https://www.emacswiki.org/emacs/bookmark%2b.el")
> +    (synopsis "Bookmark+: extensions to standard library `bookmark.el'")

Rather “@code{bookmark}”.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 39878 <at> debbugs.gnu.org (full text, mbox):

From: "Amar M. Singh" <nly <at> disroot.org>
To: "Oleg Pykhalov" <go.wigust <at> gmail.com>
Cc: 39878 <at> debbugs.gnu.org
Subject: Re: [bug#39878] gnu: add emacs-bookmarks+
Date: Wed, 29 Jul 2020 01:32:36 +0000

On July 25, 2020 7:49:37 PM UTC, Oleg Pykhalov <go.wigust <at> gmail.com> wrote:

> Hi,
> 
> So much time was passed, but maybe we could get this to work if the
> package still helpful for Emacs users.
> 
> nly <at> disroot.org (Amar M. Singh) writes:
> 
> […]
> 
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index be0e6a84c2..1ac5f77bb7 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -21536,3 +21536,39 @@ Values are stored in a directory in
> 
> @code{user-emacs-directory}, using
>> one file per value. This makes it easy to delete or remove unused
>> variables.")
>> (license license:gpl3+)))
>> +
>> +(define-public emacs-bookmark+
>> + (package
>> + (name "emacs-bookmark+")
>> + (version "2020.01.22")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (map (lambda (x)
>> + (string-append
>> +
> 
> "https://www.emacswiki.org/emacs/download" x))
>> + `("bookmark+.el"
>> + "bookmark+-mac.el"
>> + "bookmark+-bmu.el"
>> + "bookmark+-key.el"
>> + "bookmark+-lit.el"
>> + "bookmark+-1.el")))
> 
> ‘bookmarks+-mac.el’ and other files are missing because this ‘(origin
> ...)’ returns only a single file:
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix build --no-grafts --no-offload 'emacs-bookmark+'
> -S
> /gnu/store/p0lvca4zr1rh4bs9fd281hjh15ck28x8-bookmark+.el
> --8<---------------cut here---------------end--------------->8---
> 
> You could use ‘(origin ...)’ inside ‘(inputs ...)’ to fetch all the
> files, but in that case we could have an issue with more hashes as
> described bellow.
> 
> To fix issue with hashes I think we could use url-fetch on
> https://github.com/emacsmirror/emacswiki.org/blob/f2f216389097ada0172ebbfaaf594e397930682e/bookmark+
> el
> and other files.
> 
>> + (sha256
>> + (base32
>> +
> 
> "1dkpszmflik3yhv05w8rvi6vz1mzgapncb5y231r6mwy40rphyhi"))))
> 
> The hash was changed, even the version is the same.
> 
>> + (build-system emacs-build-system)
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-before 'build 'build-mac
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out")))
>> + (invoke "emacs" "-Q" "--batch"
>> + "--eval='(byte-compile-file
> 
> \"bookmark+-mac.el\"'")))))))
> 
> ‘emacs-build-system’ provides a byte compilation AFAIK, so don't need
> this ‘(arguments ...)’.
> 
>> + (home-page "https://www.emacswiki.org/emacs/bookmark+.el")
>> + (synopsis "Bookmark+: extensions to standard library
> 
> `bookmark.el'")
> 
> Rather “@code{bookmark}”.
> 
> Oleg.

hello Oleg,

Thanks, great pointers. Clearly, a guix expert unlike me. But I don't think this needs to be
packaged. Don't want it.
You can close the issue.

Sorry, thanks.
Amar

Message #16 received at 39878-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 39878-done <at> debbugs.gnu.org
Subject: Re: [bug#39878] gnu: add emacs-bookmarks+
Date: Wed, 29 Jul 2020 08:12:55 +0300

[Message part 1 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 39878 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: control <at> debbugs.gnu.org, Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org, 39878 <at> debbugs.gnu.org
Subject: RE: Processed: control message for bug #39878
Date: Wed, 29 Jul 2020 08:43:14 -0700 (PDT)

I just noticed this close message.  Didn't notice
the bug report before this.

I don't understand what the problem reported was.

(The file names were written wrong in the bug
report; dunno whether that's relevant.  There's no
"s" at the end of each base file name.  E.g., it's
bookmark+-mac.el, not bookmarks+-mac.el.)

Each Lisp file that needs `bookmark+-mac.el' for
its compilation has this at the beginning, to make
sure `bookmark+-mac.el' is loaded when byte-compiling:

(eval-when-compile
 (or (condition-case nil
         ;; Use load-library to ensure latest .elc.
         (load-library "bookmark+-mac")
       (error nil))
     ;; Require, so can load separately if not on `load-path'.
     (require 'bookmark+-mac)))

> Processing commands for control <at> debbugs.gnu.org:
> 
> > close 39878
> bug#39878: gnu: add emacs-bookmarks+
> bug closed, send any further explanations to
> 39878 <at> debbugs.gnu.org and nly <at> disroot.org (Amar M. Singh)
> 
> > quit
> Stopping processing here.
> 
> Please contact help-debbugs <at> gnu.org if you need assistance.
> 
> GNU bugs database,
> https://urldefense.com/v3/__http://debbugs.gnu.org/__;!!GqivPVa7Brio!OA8tb25o
> mQdQHUL-s_aQrQ1a107RcffjZ7dxn_RqhAOl43oCyu9MCfkUCKRnMYwL$
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.