GNU bug report logs - #39906
[PATCH] Add libraqm

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39906 in the body.
You can then email your comments to 39906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add libraqm
Date: Wed, 04 Mar 2020 16:22:11 +0100

[Message part 1 (text/plain, inline)]

Hello,

The following patch adds Raqm library in "fontutils.scm".

Feedback welcome,

Regards,

-- 
Nicolas Goaziou

[0001-gnu-Add-libraqm.patch (text/x-diff, inline)]

From 068937976f60560a22aac2a47ec1e9d221fd4670 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Date: Wed, 4 Mar 2020 16:19:22 +0100
Subject: [PATCH] gnu: Add libraqm.

* gnu/packages/fontutils.scm (libraqm): New variable.
---
 gnu/packages/fontutils.scm | 41 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index 8d39730a7b..3fa99ab602 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2018, 2019 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2019 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Roel Janssen <roel <at> gnu.org>
+;;; Copyright © 2020 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29,6 +30,7 @@
 
 (define-module (gnu packages fontutils)
   #:use-module (gnu packages)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages check)
   #:use-module (gnu packages ghostscript)
@@ -45,6 +47,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gperf)
   #:use-module (gnu packages xorg)
+  #:use-module (gnu packages fribidi)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages sqlite)
@@ -836,3 +839,41 @@ work well with other GTK+ desktop environments.")
 samples that show coverage of the font and are similar in appearance to
 Unicode Charts.  It was developed for use with DejaVu Fonts project.")
     (license license:gpl3+)))
+
+(define-public libraqm
+  (package
+    (name "libraqm")
+    (version "0.7.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/HOST-Oman/libraqm.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0byxvrfb7g6wiykbzrfrvrcf178yjrfvix83bmxsvrdnyh7jqvfx"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags (list "--disable-static")))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("gtk-doc" ,gtk-doc)
+       ("libtool" ,libtool)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python-wrapper)
+       ("which" ,which)))
+    (inputs
+     `(("freetype" ,freetype)
+       ("fribidi" ,fribidi)
+       ("harfbuzz" ,harfbuzz)))
+    (home-page "https://github.com/HOST-Oman/libraqm")
+    (synopsis "Library for complex text layout")
+    (description "Raqm is a small library that encapsulates the logic
+for complex text layout and provides a convenient API.
+
+It currently provides bidirectional text support (using FriBiDi),
+shaping (using HarfBuzz), and proper script itemization.  As a result,
+Raqm can support most writing systems covered by Unicode.")
+    (license license:expat)))
-- 
2.25.1

Message #8 received at 39906 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39906 <at> debbugs.gnu.org
Subject: Re: [bug#39906] [PATCH] Add libraqm
Date: Wed, 4 Mar 2020 14:44:57 -0500

On Wed, Mar 04, 2020 at 04:22:11PM +0100, Nicolas Goaziou wrote:
> The following patch adds Raqm library in "fontutils.scm".

Thanks!

> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/HOST-Oman/libraqm.git")
> +             (commit (string-append "v" version))))

Did you try building from the tarball?

https://github.com/HOST-Oman/libraqm/releases/download/v0.7.0/raqm-0.7.0.tar.gz

If it works you should be able to drop the Autotools inputs.

Message #11 received at 39906 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Famulari <leo <at> famulari.name>
Cc: 39906 <at> debbugs.gnu.org
Subject: Re: [bug#39906] [PATCH] Add libraqm
Date: Thu, 05 Mar 2020 00:42:02 +0100

[Message part 1 (text/plain, inline)]

Hello,

Leo Famulari <leo <at> famulari.name> writes:

Thank you for the review.

> Did you try building from the tarball?
>
> https://github.com/HOST-Oman/libraqm/releases/download/v0.7.0/raqm-0.7.0.tar.gz
>
> If it works you should be able to drop the Autotools inputs.

Done. Here is the updated patch.

Regards,

-- 
Nicolas Goaziou

[0001-gnu-Add-libraqm.patch (text/x-diff, inline)]

From 6cb5b0b1621907ca35848bde54107583f90c9c7e Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Date: Wed, 4 Mar 2020 16:19:22 +0100
Subject: [PATCH] gnu: Add libraqm.

* gnu/packages/fontutils.scm (libraqm): New variable.
---
 gnu/packages/fontutils.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index a8c9e3ddc0..fcdf767e0f 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2018, 2019 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2019 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Roel Janssen <roel <at> gnu.org>
+;;; Copyright © 2020 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -45,6 +46,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gperf)
   #:use-module (gnu packages xorg)
+  #:use-module (gnu packages fribidi)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages sqlite)
@@ -836,3 +838,37 @@ work well with other GTK+ desktop environments.")
 samples that show coverage of the font and are similar in appearance to
 Unicode Charts.  It was developed for use with DejaVu Fonts project.")
     (license license:gpl3+)))
+
+(define-public libraqm
+  (package
+    (name "libraqm")
+    (version "0.7.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/HOST-Oman/libraqm/"
+                           "releases/download/v" version "/"
+                           "raqm-0.7.0.tar.gz"))
+       (sha256
+        (base32 "0hgry3fj2y3qaq2fnmdgd93ixkk3ns5jds4vglkiv2jfvpn7b1g2"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags (list "--disable-static")))
+    (native-inputs
+     `(("gtk-doc" ,gtk-doc)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python-wrapper)))
+    (inputs
+     `(("freetype" ,freetype)
+       ("fribidi" ,fribidi)
+       ("harfbuzz" ,harfbuzz)))
+    (home-page "https://github.com/HOST-Oman/libraqm")
+    (synopsis "Library for complex text layout")
+    (description
+     "Raqm is a small library that encapsulates the logic for complex text
+layout and provides a convenient API.
+
+It currently provides bidirectional text support (using FriBiDi),
+shaping (using HarfBuzz), and proper script itemization.  As a result, Raqm
+can support most writing systems covered by Unicode.")
+    (license license:expat)))
-- 
2.25.1

Message #14 received at 39906 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39906 <at> debbugs.gnu.org
Subject: Re: [bug#39906] [PATCH] Add libraqm
Date: Wed, 4 Mar 2020 23:14:47 -0500

On Thu, Mar 05, 2020 at 12:42:02AM +0100, Nicolas Goaziou wrote:
> From 6cb5b0b1621907ca35848bde54107583f90c9c7e Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Wed, 4 Mar 2020 16:19:22 +0100
> Subject: [PATCH] gnu: Add libraqm.
> 
> * gnu/packages/fontutils.scm (libraqm): New variable.

Thanks! LGTM

Message #19 received at 39906-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Famulari <leo <at> famulari.name>
Cc: 39906-done <at> debbugs.gnu.org
Subject: Re: [bug#39906] [PATCH] Add libraqm
Date: Thu, 05 Mar 2020 18:44:35 +0100

Hello,

Leo Famulari <leo <at> famulari.name> writes:

> On Thu, Mar 05, 2020 at 12:42:02AM +0100, Nicolas Goaziou wrote:
>> From 6cb5b0b1621907ca35848bde54107583f90c9c7e Mon Sep 17 00:00:00 2001
>> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
>> Date: Wed, 4 Mar 2020 16:19:22 +0100
>> Subject: [PATCH] gnu: Add libraqm.
>> 
>> * gnu/packages/fontutils.scm (libraqm): New variable.
>
> Thanks! LGTM

Applied as a1797f3244232946cfc65b49882dc44a564471e6 (and
67c525035f803fe9b17629c28a4fcfdbbefa63c3).

Thank you.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.