GNU bug report logs - #39960
28.0.50; Incompatible change to sql-add-product in Emacs 27

Previous Next

Package: emacs;

Reported by: Philipp <p.stephani2 <at> gmail.com>

Date: Fri, 6 Mar 2020 22:40:02 UTC

Severity: normal

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39960 in the body.
You can then email your comments to 39960 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Fri, 06 Mar 2020 22:40:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Philipp <p.stephani2 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 06 Mar 2020 22:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Incompatible change to sql-add-product in Emacs 27
Date: Fri, 06 Mar 2020 23:39:16 +0100
In Emacs 26, sql-add-product has the signature

(sql-add-product PRODUCT DISPLAY &rest PLIST)

However, in the Emacs 27 pretest the signature is now

(sql-add-product PRODUCT DISPLAY &optional PLIST)

Note the change from &rest to &optional.  This is a breaking change that
breaks all users of sql-add-product.  I've found quite a few uses of the
old signature in the wild,
e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59
or
https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68
or
https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71.
This change was introduced in commit
c124d5323c05a4010db9b2d330575d029936ade1.  I don't think we should
introduce such a breaking change to a widely-used public function; at
the very least, Emacs 27 should accept both signatures.


In GNU Emacs 28.0.50 (build 39, x86_64-apple-darwin19.3.0, NS appkit-1894.30 Version 10.15.3 (Build 19D76))
 of 2020-02-29
Repository revision: 3d2c82ac96a7f37e60b2b85a5c9c1d792084ab54
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.3

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-modules --without-xml2 --without-pop --with-mailutils
 --enable-gcc-warnings=warn-only --enable-checking=all
 --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''

Configured features:
NOTIFY KQUEUE ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS
JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util
rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton
derived edmacro kmacro pcase ffap thingatpt url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars
subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus
xml cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 60470 5746)
 (symbols 48 8045 0)
 (strings 32 20761 1931)
 (string-bytes 1 688813)
 (vectors 16 12996)
 (vector-slots 8 167493 10214)
 (floats 8 27 19)
 (intervals 56 196 0)
 (buffers 1000 11))




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Sat, 07 Mar 2020 07:44:01 GMT) Full text and rfc822 format available.

Message #8 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp <p.stephani2 <at> gmail.com>, Michael Mauger <michael <at> mauger.com>
Cc: 39960 <at> debbugs.gnu.org
Subject: Re: bug#39960: 28.0.50;
 Incompatible change to sql-add-product in Emacs 27
Date: Sat, 07 Mar 2020 09:43:39 +0200
> From: Philipp <p.stephani2 <at> gmail.com>
> Date: Fri, 06 Mar 2020 23:39:16 +0100
> 
> 
> In Emacs 26, sql-add-product has the signature
> 
> (sql-add-product PRODUCT DISPLAY &rest PLIST)
> 
> However, in the Emacs 27 pretest the signature is now
> 
> (sql-add-product PRODUCT DISPLAY &optional PLIST)
> 
> Note the change from &rest to &optional.  This is a breaking change that
> breaks all users of sql-add-product.  I've found quite a few uses of the
> old signature in the wild,
> e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59
> or
> https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68
> or
> https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71.
> This change was introduced in commit
> c124d5323c05a4010db9b2d330575d029936ade1.  I don't think we should
> introduce such a breaking change to a widely-used public function; at
> the very least, Emacs 27 should accept both signatures.

Thanks for reporting this.

Michael, could you please look into this ASAP?  TIA.

Btw, this change of a public API is not in NEWS, AFAICT; if we decide
eventually on keeping the change, we should announce it in NEWS.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Fri, 13 Mar 2020 09:55:01 GMT) Full text and rfc822 format available.

Message #11 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: michael <at> mauger.com
Cc: 39960 <at> debbugs.gnu.org, p.stephani2 <at> gmail.com
Subject: Re: bug#39960: 28.0.50;
 Incompatible change to sql-add-product in Emacs 27
Date: Fri, 13 Mar 2020 11:53:56 +0200
Ping!

> Date: Sat, 07 Mar 2020 09:43:39 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 39960 <at> debbugs.gnu.org
> 
> > From: Philipp <p.stephani2 <at> gmail.com>
> > Date: Fri, 06 Mar 2020 23:39:16 +0100
> > 
> > 
> > In Emacs 26, sql-add-product has the signature
> > 
> > (sql-add-product PRODUCT DISPLAY &rest PLIST)
> > 
> > However, in the Emacs 27 pretest the signature is now
> > 
> > (sql-add-product PRODUCT DISPLAY &optional PLIST)
> > 
> > Note the change from &rest to &optional.  This is a breaking change that
> > breaks all users of sql-add-product.  I've found quite a few uses of the
> > old signature in the wild,
> > e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59
> > or
> > https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68
> > or
> > https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71.
> > This change was introduced in commit
> > c124d5323c05a4010db9b2d330575d029936ade1.  I don't think we should
> > introduce such a breaking change to a widely-used public function; at
> > the very least, Emacs 27 should accept both signatures.
> 
> Thanks for reporting this.
> 
> Michael, could you please look into this ASAP?  TIA.
> 
> Btw, this change of a public API is not in NEWS, AFAICT; if we decide
> eventually on keeping the change, we should announce it in NEWS.
> 
> 
> 
> 




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Mon, 23 Mar 2020 01:21:02 GMT) Full text and rfc822 format available.

Message #14 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Michael Mauger <mmauger <at> protonmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "39960 <at> debbugs.gnu.org" <39960 <at> debbugs.gnu.org>,
 "michael <at> mauger.com" <michael <at> mauger.com>,
 "p.stephani2 <at> gmail.com" <p.stephani2 <at> gmail.com>
Subject: Re: bug#39960: 28.0.50;
 Incompatible change to sql-add-product in Emacs 27
Date: Mon, 23 Mar 2020 01:20:45 +0000
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, March 13, 2020 5:53 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Ping!
>
> > Date: Sat, 07 Mar 2020 09:43:39 +0200
> > From: Eli Zaretskii eliz <at> gnu.org
> > Cc: 39960 <at> debbugs.gnu.org
> >
> > > From: Philipp p.stephani2 <at> gmail.com
> > > Date: Fri, 06 Mar 2020 23:39:16 +0100
> > > In Emacs 26, sql-add-product has the signature
> > > (sql-add-product PRODUCT DISPLAY &rest PLIST)
> > > However, in the Emacs 27 pretest the signature is now
> > > (sql-add-product PRODUCT DISPLAY &optional PLIST)
> > > Note the change from &rest to &optional. This is a breaking change that
> > > breaks all users of sql-add-product. I've found quite a few uses of the
> > > old signature in the wild,
> >
> > Thanks for reporting this.
> > Michael, could you please look into this ASAP? TIA.
> > Btw, this change of a public API is not in NEWS, AFAICT; if we decide
> > eventually on keeping the change, we should announce it in NEWS.

Sorry for the delay. The massive switch to WFH and illness concerns at home
interfered. All are fine, and I actually do get work done occasionally.

I've got the following patch to make. I assume it needs to be made to the
emacs-27 branch and corresponding patches made to master as well. If I
should only commit to master (same change is needed there) for cherry-picking
for emacs-27, let me know.

$ git diff
diff --git a/ChangeLog.3 b/ChangeLog.3
index fc41c1f7dc..e6cad9ed7c 100644
--- a/ChangeLog.3
+++ b/ChangeLog.3
@@ -1,3 +1,11 @@
+2020-03-22  Michael R. Mauger  <michael <at> mauger.com>
+
+	* lisp/progmodes/sql.el (sql-add-product): Re-correct argument
+	spec.  Previous change was due to my own stupidity; I have
+	resolved prior behavior (Bug#39960).
+	* test/lisp/progmodes/sql-tests.el (sql-test-add-product): Added
+	test to insure I don't make the same mistake again.
+
 2020-02-27  Nicolas Petton  <nicolas <at> petton.fr>

 	* admin/authors.el (authors-ignored-files): Fix entries.
diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index 400e304ecf..a04c26d276 100644
--- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -2740,7 +2740,7 @@ sql-read-product
              nil 'require-match
              init 'sql-product-history init))))

-(defun sql-add-product (product display &optional plist)
+(defun sql-add-product (product display &rest plist)
   "Add support for a database product in `sql-mode'.

 Add PRODUCT to `sql-product-alist' which enables `sql-mode' to
diff --git a/test/lisp/progmodes/sql-tests.el b/test/lisp/progmodes/sql-tests.el
index d6f89341be..91805ab725 100644
--- a/test/lisp/progmodes/sql-tests.el
+++ b/test/lisp/progmodes/sql-tests.el
@@ -187,13 +187,19 @@ sql-test-add-product
       (sql-add-product 'xyz "XyzDb")

       (should (equal (pp-to-string (assoc 'xyz sql-product-alist))
-                     "(xyz :name \"XyzDb\")\n"))))
+                     "(xyz :name \"XyzDb\")\n")))
+
+  (sql-test-product-feature-harness
+      (sql-add-product 'stu "StuDb" :X 1 :Y "2")
+
+      (should (equal (pp-to-string (assoc 'stu sql-product-alist))
+                     "(stu :name \"StuDb\" :X 1 :Y \"2\")\n"))))

 (ert-deftest sql-test-add-existing-product ()
   "Add a product that already exists."

   (sql-test-product-feature-harness
-      (should-error (sql-add-feature 'a "Aaa"))
+      (should-error (sql-add-product 'a "Aaa"))
       (should (equal (pp-to-string (assoc 'a sql-product-alist))
                      "(a :X 1 :Y 2 :Z sql-test-feature-value-a)\n"))))




--
MICHAEL <at> MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Mon, 23 Mar 2020 14:25:01 GMT) Full text and rfc822 format available.

Message #17 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Mauger <mmauger <at> protonmail.com>
Cc: 39960 <at> debbugs.gnu.org, michael <at> mauger.com, p.stephani2 <at> gmail.com
Subject: Re: bug#39960: 28.0.50;
 Incompatible change to sql-add-product in Emacs 27
Date: Mon, 23 Mar 2020 16:24:24 +0200
> Date: Mon, 23 Mar 2020 01:20:45 +0000
> From: Michael Mauger <mmauger <at> protonmail.com>
> Cc: "michael <at> mauger.com" <michael <at> mauger.com>, "p.stephani2 <at> gmail.com" <p.stephani2 <at> gmail.com>, "39960 <at> debbugs.gnu.org" <39960 <at> debbugs.gnu.org>
> 
> Sorry for the delay. The massive switch to WFH and illness concerns at home
> interfered. All are fine, and I actually do get work done occasionally.

Good to hear you are fine.

> I've got the following patch to make. I assume it needs to be made to the
> emacs-27 branch and corresponding patches made to master as well. If I
> should only commit to master (same change is needed there) for cherry-picking
> for emacs-27, let me know.

Please push only to emacs-27.  It will be merged to master soon
enough, no need to push there as well.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Tue, 28 Jul 2020 20:07:02 GMT) Full text and rfc822 format available.

Message #20 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Michael Mauger <mmauger <at> protonmail.com>
Cc: "39960 <at> debbugs.gnu.org" <39960 <at> debbugs.gnu.org>,
 "michael <at> mauger.com" <michael <at> mauger.com>, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#39960: 28.0.50; Incompatible change to sql-add-product in
 Emacs 27
Date: Tue, 28 Jul 2020 22:06:00 +0200
Am Mo., 23. März 2020 um 02:20 Uhr schrieb Michael Mauger
<mmauger <at> protonmail.com>:
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Friday, March 13, 2020 5:53 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > Ping!
> >
> > > Date: Sat, 07 Mar 2020 09:43:39 +0200
> > > From: Eli Zaretskii eliz <at> gnu.org
> > > Cc: 39960 <at> debbugs.gnu.org
> > >
> > > > From: Philipp p.stephani2 <at> gmail.com
> > > > Date: Fri, 06 Mar 2020 23:39:16 +0100
> > > > In Emacs 26, sql-add-product has the signature
> > > > (sql-add-product PRODUCT DISPLAY &rest PLIST)
> > > > However, in the Emacs 27 pretest the signature is now
> > > > (sql-add-product PRODUCT DISPLAY &optional PLIST)
> > > > Note the change from &rest to &optional. This is a breaking change that
> > > > breaks all users of sql-add-product. I've found quite a few uses of the
> > > > old signature in the wild,
> > >
> > > Thanks for reporting this.
> > > Michael, could you please look into this ASAP? TIA.
> > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide
> > > eventually on keeping the change, we should announce it in NEWS.
>
> Sorry for the delay. The massive switch to WFH and illness concerns at home
> interfered. All are fine, and I actually do get work done occasionally.

No worries, and good to hear that!

>
> I've got the following patch to make. I assume it needs to be made to the
> emacs-27 branch and corresponding patches made to master as well. If I
> should only commit to master (same change is needed there) for cherry-picking
> for emacs-27, let me know.

Thanks for the patch! I noticed that it made it to master as commit
82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you
still planning to backport it?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Sun, 09 Aug 2020 02:15:02 GMT) Full text and rfc822 format available.

Message #23 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Michael Mauger <mmauger <at> protonmail.com>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: "39960 <at> debbugs.gnu.org" <39960 <at> debbugs.gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#39960: 28.0.50;
 Incompatible change to sql-add-product in Emacs 27
Date: Sun, 09 Aug 2020 02:13:55 +0000
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani <p.stephani2 <at> gmail.com> wrote:

> Am Mo., 23. März 2020 um 02:20 Uhr schrieb Michael Mauger
> mmauger <at> protonmail.com:
>
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii eliz <at> gnu.org wrote:
> >
> > > Ping!
> > >
> > > > Date: Sat, 07 Mar 2020 09:43:39 +0200
> > > > From: Eli Zaretskii eliz <at> gnu.org
> > > > Cc: 39960 <at> debbugs.gnu.org
> > > >
> > > > > From: Philipp p.stephani2 <at> gmail.com
> > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100
> > > > > In Emacs 26, sql-add-product has the signature
> > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST)
> > > > > However, in the Emacs 27 pretest the signature is now
> > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST)
> > > > > Note the change from &rest to &optional. This is a breaking change that
> > > > > breaks all users of sql-add-product. I've found quite a few uses of the
> > > > > old signature in the wild,
> > > >
> > > > Thanks for reporting this.
> > > > Michael, could you please look into this ASAP? TIA.
> > > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide
> > > > eventually on keeping the change, we should announce it in NEWS.
> >
> > Sorry for the delay. The massive switch to WFH and illness concerns at home
> > interfered. All are fine, and I actually do get work done occasionally.
>
> No worries, and good to hear that!
>
> > I've got the following patch to make. I assume it needs to be made to the
> > emacs-27 branch and corresponding patches made to master as well. If I
> > should only commit to master (same change is needed there) for cherry-picking
> > for emacs-27, let me know.
>
> Thanks for the patch! I noticed that it made it to master as commit
> 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you
> still planning to backport it?

Yes, it definitely needs to be backported. Eli, what do I need to do to get this
backported to Emacs 27? This was a bad breaking change to 27 that I fixed after
the release branch was cut. Let me know if I need to do a separate commit or take
other action to get this done...

--
MICHAEL <at> MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Sun, 09 Aug 2020 09:15:02 GMT) Full text and rfc822 format available.

Message #26 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Michael Mauger <mmauger <at> protonmail.com>
Cc: "39960 <at> debbugs.gnu.org" <39960 <at> debbugs.gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#39960: 28.0.50; Incompatible change to sql-add-product in
 Emacs 27
Date: Sun, 9 Aug 2020 11:14:24 +0200
Am So., 9. Aug. 2020 um 04:14 Uhr schrieb Michael Mauger
<mmauger <at> protonmail.com>:
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani <p.stephani2 <at> gmail.com> wrote:
>
> > Am Mo., 23. März 2020 um 02:20 Uhr schrieb Michael Mauger
> > mmauger <at> protonmail.com:
> >
> > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii eliz <at> gnu.org wrote:
> > >
> > > > Ping!
> > > >
> > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200
> > > > > From: Eli Zaretskii eliz <at> gnu.org
> > > > > Cc: 39960 <at> debbugs.gnu.org
> > > > >
> > > > > > From: Philipp p.stephani2 <at> gmail.com
> > > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100
> > > > > > In Emacs 26, sql-add-product has the signature
> > > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST)
> > > > > > However, in the Emacs 27 pretest the signature is now
> > > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST)
> > > > > > Note the change from &rest to &optional. This is a breaking change that
> > > > > > breaks all users of sql-add-product. I've found quite a few uses of the
> > > > > > old signature in the wild,
> > > > >
> > > > > Thanks for reporting this.
> > > > > Michael, could you please look into this ASAP? TIA.
> > > > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide
> > > > > eventually on keeping the change, we should announce it in NEWS.
> > >
> > > Sorry for the delay. The massive switch to WFH and illness concerns at home
> > > interfered. All are fine, and I actually do get work done occasionally.
> >
> > No worries, and good to hear that!
> >
> > > I've got the following patch to make. I assume it needs to be made to the
> > > emacs-27 branch and corresponding patches made to master as well. If I
> > > should only commit to master (same change is needed there) for cherry-picking
> > > for emacs-27, let me know.
> >
> > Thanks for the patch! I noticed that it made it to master as commit
> > 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you
> > still planning to backport it?
>
> Yes, it definitely needs to be backported. Eli, what do I need to do to get this
> backported to Emacs 27? This was a bad breaking change to 27 that I fixed after
> the release branch was cut. Let me know if I need to do a separate commit or take
> other action to get this done...
>

Typically you'd cherry-pick the commit onto the release branch. But
since Emacs 27 is about to be released (tomorrow), it might be too
late now.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Sun, 09 Aug 2020 14:03:01 GMT) Full text and rfc822 format available.

Message #29 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 39960 <at> debbugs.gnu.org, mmauger <at> protonmail.com
Subject: Re: bug#39960: 28.0.50; Incompatible change to sql-add-product in
 Emacs 27
Date: Sun, 09 Aug 2020 17:02:22 +0300
> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sun, 9 Aug 2020 11:14:24 +0200
> Cc: Eli Zaretskii <eliz <at> gnu.org>, "39960 <at> debbugs.gnu.org" <39960 <at> debbugs.gnu.org>
> 
> Typically you'd cherry-pick the commit onto the release branch. But
> since Emacs 27 is about to be released (tomorrow), it might be too
> late now.

Indeed, it's too late for 27.1.  Let's try to cherry-pick after 27.1
is released, so that the fix ends up in 27.2.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Thu, 01 Oct 2020 18:37:01 GMT) Full text and rfc822 format available.

Message #32 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 39960 <at> debbugs.gnu.org, Philipp Stephani <p.stephani2 <at> gmail.com>,
 mmauger <at> protonmail.com
Subject: Re: bug#39960: 28.0.50; Incompatible change to sql-add-product in
 Emacs 27
Date: Thu, 01 Oct 2020 20:36:10 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> Indeed, it's too late for 27.1.  Let's try to cherry-pick after 27.1
> is released, so that the fix ends up in 27.2.

I've now cherry-picked Michael's patch and pushed it to the Emacs 27
branch.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 28.1, send any further explanations to 39960 <at> debbugs.gnu.org and Philipp <p.stephani2 <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 01 Oct 2020 18:37:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39960; Package emacs. (Sun, 04 Oct 2020 18:50:01 GMT) Full text and rfc822 format available.

Message #37 received at 39960 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 39960 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Michael Mauger <mmauger <at> protonmail.com>
Subject: Re: bug#39960: 28.0.50; Incompatible change to sql-add-product in
 Emacs 27
Date: Sun, 4 Oct 2020 20:49:34 +0200
Am Do., 1. Okt. 2020 um 20:36 Uhr schrieb Lars Ingebrigtsen <larsi <at> gnus.org>:
>
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> > Indeed, it's too late for 27.1.  Let's try to cherry-pick after 27.1
> > is released, so that the fix ends up in 27.2.
>
> I've now cherry-picked Michael's patch and pushed it to the Emacs 27
> branch.

Thanks. Unfortunately, now that Emacs 27.1 is already released, this
created a second incompatible change.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 02 Nov 2020 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 147 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.