GNU bug report logs - #39963
[PATCH] fd bash_completion typo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39963 in the body.
You can then email your comments to 39963 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mike <at> rohleder.de
To: guix-patches <at> gnu.org
Subject: [PATCH] fd bash_completion typo
Date: Sat, 07 Mar 2020 01:03:02 +0100

[Message part 1 (text/plain, inline)]

Hey guix!

* The "fd" package installs its bash_completion file in the wrong directory.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm
index 72c982f23c..ce50562228 100644
--- a/gnu/packages/rust-apps.scm
+++ b/gnu/packages/rust-apps.scm
@@ -184,11 +184,11 @@ also knows about symlinks, extended attributes, and Git.")
                ;; Manpages
                (install-file "doc/fd.1" (string-append out "/share/man/man1"))
                ;; Completions
-               (install-completion "^fd.bash$" "/etc/bash-completion.d")
+               (install-completion "^fd.bash$" "/etc/bash_completion.d")
                (install-completion "^fd.fish$" "/share/fish/vendor_completions.d")
                (install-completion "^_fd$" "/share/zsh/site-functions")
-               (rename-file (string-append out "/etc/bash-completion.d/fd.bash")
-                            (string-append out "/etc/bash-completion.d/fd"))
+               (rename-file (string-append out "/etc/bash_completion.d/fd.bash")
+                            (string-append out "/etc/bash_completion.d/fd"))
                #t))))))
     (inputs `(("jemalloc" ,jemalloc)))
     (home-page "https://github.com/sharkdp/fd")

[Message part 3 (text/plain, inline)]

-- 
APL is a write-only language.  I can write programs in APL, but I can't
read any of them.
		-- Roy Keir

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 39963-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: mike <at> rohleder.de
Cc: 39963-done <at> debbugs.gnu.org
Subject: Re: [PATCH] fd bash_completion typo
Date: Sat, 7 Mar 2020 19:05:52 +0100

[Message part 1 (text/plain, inline)]

On Sat, Mar 07, 2020 at 01:03:02AM +0100, mike <at> rohleder.de wrote:
> Hey guix!
> 
> * The "fd" package installs its bash_completion file in the wrong directory.
> 

Thanks! I added a copyright line for you, wrote a commit message and
pushed to master as commit 9eed0a74f92ed4e1b631f4658d98a5f46ad1664d

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.