GNU bug report logs - #39966
[PATCH 0/3] add compiledb

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39966 in the body.
You can then email your comments to 39966 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] add compiledb
Date: Sat, 7 Mar 2020 03:30:20 +0000

This patchset adds the compiledb, which is similar to bear.

FWIW, I was having trouble using bear (seems to segfault during ld
preload, before main(), so I was unable to generate a stacktrace).

Yuval Kogman (3):
  gnu: Add python-bashlex.
  gnu: Add python-shutilwhich.
  gnu: Add python-compiledb.

 gnu/packages/build-tools.scm | 30 ++++++++++++++++++++
 gnu/packages/python-xyz.scm  | 66 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 96 insertions(+)

--
2.11.0

Message #8 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: 39966 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add python-bashlex.
Date: Sat, 7 Mar 2020 04:22:07 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/python-xyz.scm (python-bashlex): New variable.
* gnu/packages/python-xyz.scm (python2-bashlex): New variable.
---
 gnu/packages/python-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

[0001-gnu-Add-python-bashlex.patch (application/x-patch, attachment)]

Message #11 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: 39966 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: Add python-shutilwhich.
Date: Sat, 7 Mar 2020 04:22:16 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/python-xyz.scm (python-shutilwhich): New variable.
* gnu/packages/python-xyz.scm (python2-shutilwhich): New variable.
---
 gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

[0002-gnu-Add-python-shutilwhich.patch (application/x-patch, attachment)]

Message #14 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: 39966 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: Add python-compiledb.
Date: Sat, 7 Mar 2020 04:22:25 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/built-tools.scm (python-compiledb): New variable.
---
 gnu/packages/build-tools.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

[0003-gnu-Add-python-compiledb.patch (application/x-patch, attachment)]

Message #17 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Yuval Kogman <nothingmuch <at> woobling.org>
Cc: 39966 <at> debbugs.gnu.org
Subject: Re: [bug#39966] [PATCH 0/3] add compiledb
Date: Wed, 11 Mar 2020 15:12:07 -0400

On Sat, Mar 07, 2020 at 03:30:20AM +0000, Yuval Kogman wrote:
> This patchset adds the compiledb, which is similar to bear.
> 
> FWIW, I was having trouble using bear (seems to segfault during ld
> preload, before main(), so I was unable to generate a stacktrace).
> 
> Yuval Kogman (3):
>   gnu: Add python-bashlex.
>   gnu: Add python-shutilwhich.
>   gnu: Add python-compiledb.

Thanks!

Unless you specifically need the Python 2 variants of bashlex and
shutilwhich, we can omit them. We are not adding Python 2 package
variants by default anymore.

I wonder about shutilwhich, which is a backport of a feature from
Python 3.3. We are using Python 3.7 so this should not be necessary,
right? Does compiledb require it specifically?

Can you send a revised patch series addressing this feedback? And when
you do, please make sure to add copyright lines for yourself to the
files you edit, and generate the patches using `git format-patch`, or
even `git send-email`, sending the mail to this bug report address.

Message #20 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: 39966 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add python-bashlex.
Date: Thu, 12 Mar 2020 00:56:10 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/python-xyz.scm (python-bashlex): New variable.
---
 gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

[0001-gnu-Add-python-bashlex.patch (application/x-patch, attachment)]

Message #23 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: 39966 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add compiledb.
Date: Thu, 12 Mar 2020 00:56:19 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/built-tools.scm (compiledb): New variable.
---
 gnu/packages/build-tools.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

[0002-gnu-Add-compiledb.patch (application/x-patch, attachment)]

Message #26 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 39966 <at> debbugs.gnu.org
Subject: Re: [bug#39966] [PATCH 0/3] add compiledb
Date: Thu, 12 Mar 2020 00:58:07 +0000

oops, i forgot to update the copyright again, sorry for the spam

Message #29 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: 39966 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add python-bashlex.
Date: Thu, 12 Mar 2020 01:02:02 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/python-xyz.scm (python-bashlex): New variable.
---
 gnu/packages/python-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

[0001-gnu-Add-python-bashlex.patch (application/x-patch, attachment)]

Message #32 received at 39966 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Kogman <nothingmuch <at> woobling.org>
To: 39966 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add compiledb.
Date: Thu, 12 Mar 2020 01:02:04 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/built-tools.scm (compiledb): New variable.
---
 gnu/packages/build-tools.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

[0002-gnu-Add-compiledb.patch (application/x-patch, attachment)]

Message #37 received at 39966-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Yuval Kogman <nothingmuch <at> woobling.org>
Cc: 39966-done <at> debbugs.gnu.org
Subject: Re: [bug#39966] [PATCH 1/2] gnu: Add python-bashlex.
Date: Thu, 28 May 2020 20:32:26 -0400

On Thu, Mar 12, 2020 at 01:02:02AM +0000, Yuval Kogman wrote:
> * gnu/packages/python-xyz.scm (python-bashlex): New variable.

After waaaaaay too long, I pushed your patches as
6560c4976f775db5b494356df2beaa0fcec6f9c0

I'm sorry about the delay. We really need to improve how long it takes
to review patches :/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.