GNU bug report logs - #39969
Inconsistent specification of a file-system's device

Previous Next

To reply to this bug, email your comments to 39969 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: bug-guix <at> gnu.org
Subject: Inconsistent specification of a file-system's device
Date: Sat, 07 Mar 2020 10:05:40 +0100

Hi,

the manual says that file system labels should be specified with the
file-system-label procedure like this:

    (file-system
      (mount-point "/home")
      (type "ext4")
      (device (file-system-label "my-home")))


Nevertheless, system-qemu-image seems to expect only strings:

    (define* (system-qemu-image os
                                #:key
                                (file-system-type "ext4")
                                (disk-image-size (* 900 (expt 2 20))))
      (define file-systems-to-keep
        ;; Keep only file systems other than root and not normally bound to real
        ;; devices.
        (remove (lambda (fs)
                  (let ((target (file-system-mount-point fs))
                        (source (file-system-device fs)))
                    (or (string=? target "/")
                        (string-prefix? "/dev/" source))))
                (operating-system-file-systems os)))


The code above stores the result of file-system-device to the source
variable and then expects it to be a string.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.