GNU bug report logs - #39989
[PATCH 0/0] Thunar: fix launching applications

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39989 in the body.
You can then email your comments to 39989 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/0] Thunar: fix launching applications
Date: Sun, 8 Mar 2020 23:12:00 +0100

This patch fixes launching applications in Thunar by making
gio-launch-desktop visible to it.

Jan Wielkiewicz

Message #8 received at 39989 <at> debbugs.gnu.org (full text, mbox):

From: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
To: 39989 <at> debbugs.gnu.org
Cc: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
Subject: [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs.
Date: Sun,  8 Mar 2020 23:23:19 +0100

---
 gnu/packages/xfce.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 3aacfb0c7c..592b825812 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2019 Pkill -9 <pkill9 <at> runbox.com>
 ;;; Copyright © 2019 L  p R n  d n <guix <at> lprndn.info>
 ;;; Copyright © 2019 Ingo Ruhnke <grumbel <at> gmail.com>
+;;; Copyright © 2020 Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -660,6 +661,7 @@ like appearance, display, keyboard and mouse settings.")
        ("intltool" ,intltool)))
     (inputs
      `(("exo" ,exo)
+       ("glib:bin" ,glib "bin")
        ("libexif" ,libexif)
        ("libgudev" ,libgudev)
        ("libnotify" ,libnotify)
@@ -667,6 +669,17 @@ like appearance, display, keyboard and mouse settings.")
        ("pcre" ,pcre)
        ("xfce4-panel" ,xfce4-panel)
        ("startup-notification" ,startup-notification)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (glib-bin (assoc-ref inputs "glib:bin")))
+               (wrap-program (string-append out "/bin/thunar")
+                 `("PATH" ":" prefix (,(string-append glib-bin
+                                                      "/bin")))))
+             #t)))))
     (home-page "https://www.xfce.org/")
     (synopsis "Xfce file manager")
     (description
-- 
2.25.1

Message #11 received at 39989 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
Cc: 39989 <at> debbugs.gnu.org
Subject: Re: [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix
 launching programs.
Date: Mon, 9 Mar 2020 18:11:08 +0100

[Message part 1 (text/plain, inline)]

Hi,

I'm all for fixing this problem, but it would be great to add a comment on
which executables thunar tries to find in glib:bin.

I've checked glib:bin and it has:

gapplication
gdbus
gdbus-codegen
gio
gio-querymodules
glib-compile-resources
glib-compile-schemas
glib-genmarshal
glib-gettextize
glib-mkenums
gobject-query
gresource
gsettings
gtester
gtester-report

A lot of those make no sense for thunar to use anyway.

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at 39989 <at> debbugs.gnu.org (full text, mbox):

From: Jan <tona_kosmicznego_smiecia <at> interia.pl>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 39989 <at> debbugs.gnu.org
Subject: Re: [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix
 launching programs.
Date: Mon, 9 Mar 2020 21:08:04 +0100

On Mon, 9 Mar 2020 18:11:08 +0100
Danny Milosavljevic <dannym <at> scratchpost.org> wrote:

> Hi,
> 
> I'm all for fixing this problem, but it would be great to add a
> comment on which executables thunar tries to find in glib:bin.
Should I close the issue, add a commit and reopen the issue, or is
there a more clever way of doing so?

> I've checked glib:bin and it has:
> 
> gapplication
> gdbus
> gdbus-codegen
> gio
> gio-querymodules
> glib-compile-resources
> glib-compile-schemas
> glib-genmarshal
> glib-gettextize
> glib-mkenums
> gobject-query
> gresource
> gsettings
> gtester
> gtester-report
> 
> A lot of those make no sense for thunar to use anyway.

AFAIK it only needs gio-launch-desktop, and seems there's no way to
pick just one binary, is it?
Would changing this:
`("PATH" ":" prefix (,(string-append glib-bin
			"/bin")))))
to
`("PATH" ":" prefix (,(string-append glib-bin
			"/bin/gio-launch-desktop")))))
do the job? 

The macro (or whatever it is) was undocumented in the manual and
explanation in the source code was low level so it is possible I
misunderstood how it works.
I'll try the former.


Jan Wielkiewicz

Message #17 received at 39989 <at> debbugs.gnu.org (full text, mbox):

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: Jan <tona_kosmicznego_smiecia <at> interia.pl>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 39989 <at> debbugs.gnu.org
Subject: Re: [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix
 launching programs.
Date: Mon, 09 Mar 2020 22:43:13 +0100

Hi,

Jan <tona_kosmicznego_smiecia <at> interia.pl> writes:

> On Mon, 9 Mar 2020 18:11:08 +0100
> Danny Milosavljevic <dannym <at> scratchpost.org> wrote:
>
>> Hi,
>> 
>> I'm all for fixing this problem, but it would be great to add a
>> comment on which executables thunar tries to find in glib:bin.
> Should I close the issue, add a commit and reopen the issue, or is
> there a more clever way of doing so?
>
>> I've checked glib:bin and it has:
>> 
>> gapplication
>> gdbus
>> gdbus-codegen
>> gio
>> gio-querymodules
>> glib-compile-resources
>> glib-compile-schemas
>> glib-genmarshal
>> glib-gettextize
>> glib-mkenums
>> gobject-query
>> gresource
>> gsettings
>> gtester
>> gtester-report
>> 
>> A lot of those make no sense for thunar to use anyway.
>
> AFAIK it only needs gio-launch-desktop, and seems there's no way to
> pick just one binary, is it?
> Would changing this:
> `("PATH" ":" prefix (,(string-append glib-bin
> 			"/bin")))))
> to
> `("PATH" ":" prefix (,(string-append glib-bin
> 			"/bin/gio-launch-desktop")))))
> do the job? 
>
> The macro (or whatever it is) was undocumented in the manual and
> explanation in the source code was low level so it is possible I
> misunderstood how it works.
> I'll try the former.

I would like to point out — in case you don't already know — that the
issue addressed in this patch is not specific to thunar.  It also shows
up in MATE (https://debbugs.gnu.org/38135) and is caused by glib itself
looking for gio-launch-desktop in $PATH.  More importantly, it has
already been fixed on in commit 0bcc1b14fc3e2382406b97577c56e2292b96b8d4
on core-updates (which is why the aforementioned bug has been closed).

Regards,

Diego

Message #20 received at 39989 <at> debbugs.gnu.org (full text, mbox):

From: Jan <tona_kosmicznego_smiecia <at> interia.pl>
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 39989 <at> debbugs.gnu.org
Subject: Re: [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix
 launching programs.
Date: Mon, 9 Mar 2020 23:36:22 +0100

On Mon, 09 Mar 2020 22:43:13 +0100
Diego Nicola Barbato <dnbarbato <at> posteo.de> wrote:

> I would like to point out — in case you don't already know — that the
> issue addressed in this patch is not specific to thunar.  It also
> shows up in MATE (https://debbugs.gnu.org/38135) and is caused by
> glib itself looking for gio-launch-desktop in $PATH.  More
> importantly, it has already been fixed on in commit
> 0bcc1b14fc3e2382406b97577c56e2292b96b8d4 on core-updates (which is
> why the aforementioned bug has been closed).
> 
> Regards,
> 
> Diego

This explains why both Mate and Xfce were broken, I kept this in my
mind as one possibility, but the long time it took to fix it made me
think it's not.
Thanks for the information! 
At least I didn't completely waste my time, because I learned something
about wrappers :)


Jan Wielkiewicz

Message #25 received at 39989-done <at> debbugs.gnu.org (full text, mbox):

From: Jan <tona_kosmicznego_smiecia <at> interia.pl>
To: 39989-done <at> debbugs.gnu.org
Subject: Closing the issue
Date: Mon, 9 Mar 2020 23:43:43 +0100

I'm closing the issue, because it has been solved already.


Jan Wielkiewicz

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.