GNU bug report logs - #40021
gnu: Add mm-common.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40021 in the body.
You can then email your comments to 40021 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: dannym <at> scratchpost.org
Subject: gnu: Add mm-common.
Date: Tue, 10 Mar 2020 23:01:00 +0000

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch to add 'mm-common' package to guix.

Regards,
Raghav "RG" Gururajan.

[mm-common.patch (application/octet-stream, attachment)]

Message #8 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Wed, 11 Mar 2020 16:24:32 +0100

[Message part 1 (text/plain, inline)]

Hi RG,

On Tue, 10 Mar 2020 23:01:00 +0000
"Raghav Gururajan" <raghavgururajan <at> disroot.org> wrote:

> Please find the attached patch to add 'mm-common' package to guix.

I've tried it both with #:glib-or-gtk? #t and #:glib-or-gtk? #f and then compared
the result using diffoscope there's no functional difference.

Therefore, I suggest leaving the #:glib-or-gtk? off, or investigating why it
doesn't do anything.

This package contains unpatched references to perl, git, ln and other
programs, which means that those programs are looked up in $PATH and
most probably will not be found.

It also contains patched references to python.

That's not consistent.

Please research what the package is supposed to do.  If perl, git and
ln are internally required modules, let's patch them.

If they are external "composing" modules, let's leave them as-is.

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Thu, 19 Mar 2020 06:34:29 +0000

Hi Danny!

Thanks for the information. I will get back to you regarding the modules.

I also noticed that I didn't enable a build option that downloads gcc tag files. Can you help me with how to provide network access inside build container/process? The wget is unable to resolve domain name.

Resolving gcc.gnu.org (gcc.gnu.org)... failed: Name or service not known.
wget: unable to resolve host address ?gcc.gnu.org?

Regards,
RG.

Message #14 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>,
 Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: [bug#40021] gnu: Add mm-common.
Date: Thu, 19 Mar 2020 10:27:04 +0100

[Message part 1 (text/plain, inline)]

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hi Danny!
>
> Thanks for the information. I will get back to you regarding the modules.
>
> I also noticed that I didn't enable a build option that downloads gcc tag files. Can you help me with how to provide network access inside build container/process? The wget is unable to resolve domain name.
>
> Resolving gcc.gnu.org (gcc.gnu.org)... failed: Name or service not known.
> wget: unable to resolve host address ?gcc.gnu.org?

It is not possible to enable network access inside the build container.
If it were, build processes would no longer be deterministic, and we
would lose a lot of reproducibility guarantees!

You'll need to supply whatever external resources the package needs as
"native-inputs", and then tell the build system how to access those
inputs instead of downloading them from the network.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Sat, 21 Mar 2020 20:21:34 +0100

[Message part 1 (text/plain, inline)]

Hi Raghav,

On Thu, 19 Mar 2020 06:34:29 +0000
"Raghav Gururajan" <raghavgururajan <at> disroot.org> wrote:

> I also noticed that I didn't enable a build option that downloads gcc tag files. Can you help me with how to provide network access inside build container/process? The wget is unable to resolve domain name.

It is very dangerous to use wget for stuff like that.  For example the usual cryptographic signature check is skipped--which means that anyone could replace it by a bad version and nobody would notice.

I would advise to instead add it as "origin" in "native-inputs" and copy it manually.
That way its sha256 sum will be checked.

[Message part 2 (application/pgp-signature, inline)]

Message #20 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Sun, 22 Mar 2020 01:16:22 +0000

Hi Danny!

> It is very dangerous to use wget for stuff like that. For example the usual cryptographic signature
> check is skipped--which means that anyone could replace it by a bad version and nobody would
> notice.

Ah yes, you are right.

> I would advise to instead add it as "origin" in "native-inputs" and copy it manually.
> That way its sha256 sum will be checked.

That's a good idea. Could you help with a generic syntax for adding origin inside inputs?

Thank you!

Regards,
RG.

Message #23 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Sun, 22 Mar 2020 12:42:42 +0100

[Message part 1 (text/plain, inline)]

(native-inputs `(
         ("foobar"
          ,(origin
             (method git-fetch)
             (uri (git-reference
                   (url "https://foo/bar")
                   (commit (string-append "v" version))))
             (file-name (git-file-name "foo" version))
             (sha256
              (base32 "0i7gh99w4mi0hdv16261jcdiqyv1nkjdcwy9prw32s0lvplx8fdy")))))

then in a phase:

  (copy-recursively (assoc-ref native-inputs "foobar") target)

  (if it's from git)

[Message part 2 (application/pgp-signature, inline)]

Message #26 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Sun, 05 Apr 2020 04:05:50 +0000

[Message part 1 (text/plain, inline)]

Hi Danny!

> I've tried it both with #:glib-or-gtk? #t and #:glib-or-gtk? #f and then compared
> the result using diffoscope there's no functional difference.
> 
> Therefore, I suggest leaving the #:glib-or-gtk? off, or investigating why it
> doesn't do anything.

You are right, it is not required for this package.

> This package contains unpatched references to perl, git, ln and other
> programs, which means that those programs are looked up in $PATH and
> most probably will not be found.
> 
> It also contains patched references to python.
> 
> That's not consistent.
> 
> Please research what the package is supposed to do. If perl, git and
> ln are internally required modules, let's patch them.
> 
> If they are external "composing" modules, let's leave them as-is.

I have checked and they are not internally required. Only python is required which is already patched. :-)

Please find the revised patch, attached with this email.

Regards,
RG.

[0018-gnu-Add-mm-common.patch (application/octet-stream, attachment)]

Message #31 received at 40021-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40021-done <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Sun, 5 Apr 2020 20:59:22 +0200

[Message part 1 (text/plain, inline)]

/gnu/store/cxlagy3f68pg1rxhx101c62jv76iss9k-mm-common-1.0.0/bin/mm-common-prepare
contains references to both cp and ln, without store path.

That means either they won't work or it will have some spooky dependency to
coreutils that is not declared.

I've pushed a variant to guix master as
commit 4e8bdbf853f1f7e01e18f50c95204c0f39e6edba.

Changes are:

* Make sure to refer to coreutils and sed explicitly (non-native input now... hmm).

Pushed follow-up moving coreutils and sed to regular inputs to guix master
as commit 74a658857345b564fe0eb8e38c64044b5432289c.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.