GNU bug report logs - #40040
Submission of Patch for Package Description for CRAN Package r-crochet

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40040 in the body.
You can then email your comments to 40040 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Submission of Patch for Package Description for CRAN Package r-crochet
Date: Thu, 12 Mar 2020 17:16:49 +0530

[Message part 1 (text/plain, inline)]

Hi

I am submitting the patch file for CRAN Package Description (r-crochet).

This is my first ever package submission, i have gone through maillists 
as reference to build this.

-- 
Regards
NagaMalli

[0001-gnu-r-crochet-New-variable.patch (text/x-patch, attachment)]

Message #8 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: 40040 <at> debbugs.gnu.org
Subject: Re: Submission of Patch for Package Description for CRAN Package
 r-crochet
Date: Thu, 12 Mar 2020 18:06:29 +0100

[Message part 1 (text/plain, inline)]

Hi,

that patch does not apply to guix master.

Could you rebase it?

You can do that using

  git pull --rebase

Then you can regenerate the patch via

  git format-patch -1

and send it to this bug report as version 2.

Thanks!

Other than that, I did a license review and that seems fine.

Please do not add trailing newlines at the end of the file.

Please also make sure to use

  ./pre-inst-env guix lint r-crochet

in order to find out obvious problems with it, if any.

In this case, guix lint warns that '[' and other code-like things should be
enclosed in the texinfo tag @code instead, for example:

@code{[}

[Message part 2 (application/pgp-signature, inline)]

Message #13 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: 40040 <at> debbugs.gnu.org
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Tue, 17 Mar 2020 10:50:14 +0100

[Message part 1 (text/plain, inline)]

Hi,

there's a whitespace error at the bottom of the patch.  When I try to apply it
using "git am" I immediately get a warning message.

Also, the subject you used "gnu: r-crochet: New variable" would mean that
you add a new variable inside r-chochet, which you don't.

It should be: "gnu: Add r-crochet".

and

"* gnu/packages/cran.scm (r-crochet): New variable.".

Please examine some other commit messages in guix master for a template.

I've invoked guix lint and I get:

gnu/packages/cran.scm:20813:6: r-crochet <at> 2.2.0: use @code or similar ornament instead of quotes
/home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet <at> 2.2.0: trailing white space on line 20814
/home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet <at> 2.2.0: trailing white space on line 20815

Could you fix these problems and submit a new version (v3) of the patch
(using git send-email --to=40040 <at> debbugs.gnu.org , for example)?

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: 40040 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Thu, 19 Mar 2020 13:43:30 +0530

[Message part 1 (text/plain, inline)]

Hi

Resubmitting v3 of my patch. I really hope i did the changes right.

I am going through documentation and learning the things. For seeking 
clarification, Is there any other way i can communicate with you or the 
community. I have joined IRC channel as well #guix on freenode.

On 17/03/20 3:20 pm, Danny Milosavljevic wrote:
> Hi,
>
> there's a whitespace error at the bottom of the patch.  When I try to apply it
> using "git am" I immediately get a warning message.
>
> Also, the subject you used "gnu: r-crochet: New variable" would mean that
> you add a new variable inside r-chochet, which you don't.
>
> It should be: "gnu: Add r-crochet".
>
> and
>
> "* gnu/packages/cran.scm (r-crochet): New variable.".
>
> Please examine some other commit messages in guix master for a template.

I have done the changes and understood.

> I've invoked guix lint and I get:
>
> gnu/packages/cran.scm:20813:6: r-crochet <at> 2.2.0: use @code or similar ornament instead of quotes
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet <at> 2.2.0: trailing white space on line 20814
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet <at> 2.2.0: trailing white space on line 20815

I am a beginner at this stuff. I am understanding the standards. I have 
invoked lint and found no errors.


> Could you fix these problems and submit a new version (v3) of the patch
> (using git send-email --to=40040 <at> debbugs.gnu.org , for example)?

-- 
Regards
NagaMalli

[0001-gnu-Add-r-crochet.patch (text/x-patch, attachment)]

Message #19 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: 40040 <at> debbugs.gnu.org
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Thu, 19 Mar 2020 12:38:53 +0100

[Message part 1 (text/plain, inline)]

Hi Naga,

On Thu, 19 Mar 2020 13:43:30 +0530
Naga Malleswari <nagamalli <at> riseup.net> wrote:

> Resubmitting v3 of my patch. I really hope i did the changes right.

There's still an extra newline at the end of your file.
"git am" still complained.

Also, we are using automated tools to apply these patches.  For that to work
right without manual fiddling, please put eventual mail text below the "---"
and above the "diff" (so it's filtered out by the automated tool).

This time, I had to edit the commit message to remove this conversation
from the git log.

> I am going through documentation and learning the things. For seeking 
> clarification, Is there any other way i can communicate with you or the 
> community. I have joined IRC channel as well #guix on freenode.

For me, E-Mail is fine.  Some other Guix developers are on IRC in #guix
on freenode.

Note: It's better to put the version "v3" also in the subject line.

I've checked the license and I don't think that r-crochet is Free Software
or that the license is expat.  How did you determine the value of the
license field?

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 40040 <at> debbugs.gnu.org
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Thu, 19 Mar 2020 23:05:35 +0530

Hi

On 19/03/20 5:08 pm, Danny Milosavljevic wrote:
> Hi Naga,
>
> On Thu, 19 Mar 2020 13:43:30 +0530
> Naga Malleswari <nagamalli <at> riseup.net> wrote:
>
>> Resubmitting v3 of my patch. I really hope i did the changes right.
> There's still an extra newline at the end of your file.
> "git am" still complained.
Understood I will remove it. It dint showup in lint. I will fix that.
>
> Also, we are using automated tools to apply these patches.  For that to work
> right without manual fiddling, please put eventual mail text below the "---"
> and above the "diff" (so it's filtered out by the automated tool).

Actually i dint get the "Eventual mail text" part. All i have is this in
the patch file

---
 gnu/packages/cran.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff

> This time, I had to edit the commit message to remove this conversation
> from the git log.
>
>> I am going through documentation and learning the things. For seeking 
>> clarification, Is there any other way i can communicate with you or the 
>> community. I have joined IRC channel as well #guix on freenode.
> For me, E-Mail is fine.  Some other Guix developers are on IRC in #guix
> on freenode.
>
> Note: It's better to put the version "v3" also in the subject line.
>
> I've checked the license and I don't think that r-crochet is Free Software
> or that the license is expat.  How did you determine the value of the
> license field?

Yes, you are correct. I have downloaded package description through 
guix import cran -r <package>. This resulted expat licence.

But its showing as MIT in the following link.

https://cran.r-project.org/web/packages/crochet/

The authors github page shows a file licence. Does it mean there is no
proper licensing applied for the package? In that case what should we do.


I have tried to check with previous package contributions in cran.scm
and found mismatch to whats available in website, source page to that of
result from guix import cran -r

r-isoband is showing expat in guix import,   MIT in website(
https://cran.r-project.org/web/packages/isoband/index.html) ,  git page
shows a file https://github.com/wilkelab/isoband

r-hrbrthemes is showing expat in guix import,   MIT in website,  git
page shows a file 


 

-- 
Regards
NagaMalli

Message #25 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: 40040 <at> debbugs.gnu.org
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Thu, 19 Mar 2020 18:53:22 +0100

[Message part 1 (text/plain, inline)]

Hi Naga,

On Thu, 19 Mar 2020 23:05:35 +0530
Naga Malleswari <nagamalli <at> riseup.net> wrote:

> > Also, we are using automated tools to apply these patches.  For that to work
> > right without manual fiddling, please put eventual mail text below the "---"
> > and above the "diff" (so it's filtered out by the automated tool).  
> 
> Actually i dint get the "Eventual mail text" part. All i have is this in
> the patch file

Nevermind, I'll just edit it.

> Yes, you are correct. I have downloaded package description through 
> guix import cran -r <package>. This resulted expat licence.
> 
> But its showing as MIT in the following link.
> 
> https://cran.r-project.org/web/packages/crochet/

Hmm, that looks better.  Weird.

But just judging from https://github.com/agrueneberg/crochet , I wouldn't
have thought that that was under MIT license.  The only mention there
is in the DESCRIPTION file.  Is that enough for Guix?

> The authors github page shows a file licence. Does it mean there is no
> proper licensing applied for the package? In that case what should we do.

Let's wait until someone knowledgeable in CRAN posts.

Could you open an issue on https://github.com/agrueneberg/crochet asking
them to put an Expat license file into the project if that's their intention?

> r-isoband is showing expat in guix import,   MIT in website(
> https://cran.r-project.org/web/packages/isoband/index.html) ,  git page
> shows a file https://github.com/wilkelab/isoband

That has a file LICENSE.md which makes the situation a lot clearer
for that package.

> MIT [...] Expat

MIT is an ambiguous reference, actually it can be either Expat or X11.

See also https://en.wikipedia.org/wiki/MIT_License

[Message part 2 (application/pgp-signature, inline)]

Message #28 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 40040 <at> debbugs.gnu.org
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Thu, 19 Mar 2020 23:31:20 +0530

On 19/03/20 11:23 pm, Danny Milosavljevic wrote:
> Hi Naga,
>
> On Thu, 19 Mar 2020 23:05:35 +0530
> Naga Malleswari <nagamalli <at> riseup.net> wrote:
>
>>> Also, we are using automated tools to apply these patches.  For that to work
>>> right without manual fiddling, please put eventual mail text below the "---"
>>> and above the "diff" (so it's filtered out by the automated tool).  
>> Actually i dint get the "Eventual mail text" part. All i have is this in
>> the patch file
> Nevermind, I'll just edit it.
>
>> Yes, you are correct. I have downloaded package description through 
>> guix import cran -r <package>. This resulted expat licence.
>>
>> But its showing as MIT in the following link.
>>
>> https://cran.r-project.org/web/packages/crochet/
> Hmm, that looks better.  Weird.
>
> But just judging from https://github.com/agrueneberg/crochet , I wouldn't
> have thought that that was under MIT license.  The only mention there
> is in the DESCRIPTION file.  Is that enough for Guix?
>
>> The authors github page shows a file licence. Does it mean there is no
>> proper licensing applied for the package? In that case what should we do.
> Let's wait until someone knowledgeable in CRAN posts.
>
> Could you open an issue on https://github.com/agrueneberg/crochet asking
> them to put an Expat license file into the project if that's their intention?
I will do that. Meanwhile i will write package definition another
package. Would that be a correct?
>
>> r-isoband is showing expat in guix import,   MIT in website(
>> https://cran.r-project.org/web/packages/isoband/index.html) ,  git page
>> shows a file https://github.com/wilkelab/isoband
> That has a file LICENSE.md which makes the situation a lot clearer
> for that package.


Understood.

But r-hrbrthmes package in cran.scm no license file is found.

https://github.com/hrbrmstr/hrbrthemes

>
>> MIT [...] Expat
> MIT is an ambiguous reference, actually it can be either Expat or X11.
>
> See also https://en.wikipedia.org/wiki/MIT_License

-- 
Regards
NagaMalli

Message #31 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 40040 <at> debbugs.gnu.org
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Fri, 20 Mar 2020 23:10:19 +0530

Hi

On 19/03/20 11:23 pm, Danny Milosavljevic wrote:

> Yes, you are correct. I have downloaded package description through 
> guix import cran -r <package>. This resulted expat licence.
>
> But its showing as MIT in the following link.
>
> https://cran.r-project.org/web/packages/crochet/
> Hmm, that looks better.  Weird.
>
> But just judging from https://github.com/agrueneberg/crochet , I wouldn't
> have thought that that was under MIT license.  The only mention there
> is in the DESCRIPTION file.  Is that enough for Guix?
>
>> The authors github page shows a file licence. Does it mean there is no
>> proper licensing applied for the package? In that case what should we do.
> Let's wait until someone knowledgeable in CRAN posts.

I have raised the issue and the author said that he followed CRAN
Licensing and included in the description.

https://github.com/agrueneberg/crochet/issues/9

In this case can the patch be approved.

>
> Could you open an issue on https://github.com/agrueneberg/crochet asking
> them to put an Expat license file into the project if that's their intention?
>
>

-- 
Regards
NagaMalli

Message #36 received at 40040-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: 40040-done <at> debbugs.gnu.org
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Sat, 21 Mar 2020 14:18:57 +0100

[Message part 1 (text/plain, inline)]

Hi Naga,

thanks!

I have pushed the patch to guix master as commit
1163dacd4b4d9d274be5e8393072323435e9236a.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.