GNU bug report logs - #40061
Allow double-click select of URL in status

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40061 in the body.
You can then email your comments to 40061 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: guix-patches <at> gnu.org
Subject: Allow double-click select of URL in status
Date: Sat, 14 Mar 2020 15:01:03 +0100

[Message part 1 (text/plain, inline)]

While I've been playing with guix today I found this rather trivial patch
to be nice. Nice enough to maybe start, even though I'm still waiting for some 
compiles I'll submit this trivial patch untested.

Lets see how the social (as opposed to technical) part works.

Is this patch Ok?
-- 
Tom Zander

[0001-Allow-double-click-select-of-URL-in-status.patch (text/x-patch, attachment)]

Message #8 received at 40061 <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: 40061 <at> debbugs.gnu.org
Subject: Version two of the patch.
Date: Sat, 14 Mar 2020 18:16:52 +0100

[Message part 1 (text/plain, inline)]

Attached is an updated version of the patch, it fixes more of the same issues.

[0001-Allow-double-click-select-of-URL-in-status.patch (text/x-patch, attachment)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Tom Zander via Guix-patches via <guix-patches <at> gnu.org>
Cc: 40061 <at> debbugs.gnu.org
Subject: Re: [bug#40061] Version two of the patch.
Date: Sat, 14 Mar 2020 13:48:16 -0400

On Sat, Mar 14, 2020 at 06:16:52PM +0100, Tom Zander via Guix-patches via wrote:
> Attached is an updated version of the patch, it fixes more of the same issues.

> From 0b2a17de72825b9ca0d494ea8c4d9bf121689f4e Mon Sep 17 00:00:00 2001
> From: TomZ <tomz <at> freedommail.ch>
> Date: Sat, 14 Mar 2020 14:36:28 +0100
> Subject: [PATCH] Allow double-click select of URL in status
> 
> Various places while downloading or compiling guix
> prints the source URL. This change makes the URL be easier
> to be used by placing a space between the URL and the trailing
> dots.

Thanks, this is great. I get annoyed by this constantly.

Any other feedback?

Message #17 received at 40061 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 40061 <at> debbugs.gnu.org
Subject: [tomz <at> freedommail.ch: Re: [bug#40061] Version two of the patch.]
Date: Sat, 14 Mar 2020 14:45:31 -0400

----- Forwarded message from Tom Zander <tomz <at> freedommail.ch> -----

Date: Sat, 14 Mar 2020 19:32:40 +0100
From: Tom Zander <tomz <at> freedommail.ch>
To: Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#40061] Version two of the patch.

On zaterdag 14 maart 2020 18:48:16 CET Leo Famulari wrote:
> On Sat, Mar 14, 2020 at 06:16:52PM +0100, Tom Zander via Guix-patches via wrote:
> > Attached is an updated version of the patch, it fixes more of the same
> > issues.
> > 
> > From 0b2a17de72825b9ca0d494ea8c4d9bf121689f4e Mon Sep 17 00:00:00 2001
> > From: TomZ <tomz <at> freedommail.ch>
> > Date: Sat, 14 Mar 2020 14:36:28 +0100
> > Subject: [PATCH] Allow double-click select of URL in status
> > 
> > Various places while downloading or compiling guix
> > prints the source URL. This change makes the URL be easier
> > to be used by placing a space between the URL and the trailing
> > dots.
> 
> Thanks, this is great. I get annoyed by this constantly.
> 
> Any other feedback?


I wrote down some more silly things that I'm not sure I'll get to.

Imagine the following;

guix package -i guile-git
The following package will be upgraded:
guile-git    0.3.0 → 0.3.0   /gnu/store/h5y9c889q237a0sjzn68zflkmk3zz33f-guile-git-0.3.0

Instead of saying "upgraded" it should say "reinstalled".

then: the 'info guix' chapter 2.6.1 Locales
has this gem:
«Note that the ‘glibc-locales’ package contains data for all the
  locales supported by the GNU libc and weighs in at around 110 MiB.»

If you install it you'll note its well over 200MB, though. That at minimum should 
be updated in the info. Or more likely just stated that its large.


Thanks!
-- 
Tom Zander



----- End forwarded message -----

Message #20 received at 40061 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 40061 <at> debbugs.gnu.org
Subject: Re: Allow double-click select of URL in status
Date: Mon, 30 Mar 2020 12:05:56 +0200

LGTM, except maybe the following change to the
commit msg:

This change makes the URL be easier to be used
=>
This change makes the URL easier to use

But that may not warrant a new patch submission,
though, as the committer may do it himself...

Thanks

-- 
Vincent Legoll

Message #23 received at 40061 <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: 40061 <at> debbugs.gnu.org
Subject: [Patch] rebase  and fix wording
Date: Tue, 07 Apr 2020 21:43:39 +0200

[Message part 1 (text/plain, inline)]

-- 
Tom Zander

[0001-Allow-double-click-select-of-URL-in-status.patch (text/x-patch, attachment)]

Message #28 received at 40061-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Vincent Legoll <vincent.legoll <at> gmail.com>, 40061-done <at> debbugs.gnu.org
Subject: Re: [bug#40061] Allow double-click select of URL in status
Date: Tue, 07 Apr 2020 22:00:33 +0200

[Message part 1 (text/plain, inline)]

Vincent Legoll <vincent.legoll <at> gmail.com> writes:

> LGTM, except maybe the following change to the
> commit msg:
>
> This change makes the URL be easier to be used
> =>
> This change makes the URL easier to use
>
> But that may not warrant a new patch submission,
> though, as the committer may do it himself...

Whoops, I committed this without seeing this comment, oh well!

Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 40061-done <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40061-done <at> debbugs.gnu.org
Subject: Re: [bug#40061] Allow double-click select of URL in status
Date: Tue, 7 Apr 2020 22:05:19 +0200

Hello,

On Tue, Apr 7, 2020 at 10:00 PM Marius Bakke <mbakke <at> fastmail.com> wrote:
> Vincent Legoll <vincent.legoll <at> gmail.com> writes:
> > LGTM, except maybe the following change to the
> > commit msg:
> >
> > This change makes the URL be easier to be used
> > =>
> > This change makes the URL easier to use
> >
> > But that may not warrant a new patch submission,
> > though, as the committer may do it himself...
>
> Whoops, I committed this without seeing this comment, oh well!

Not really a problem ;-)

It was just in case...

-- 
Vincent Legoll

Message #36 received at 40061 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Vincent Legoll <vincent.legoll <at> gmail.com>, 40061 <at> debbugs.gnu.org
Subject: Re: [bug#40061] Allow double-click select of URL in status
Date: Tue, 07 Apr 2020 22:12:50 +0200

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.

I reverted this temporarily to avoid having to request updated
translations for Guix 1.1.0.

It will have to wait until after the 1.1.0 release.

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 40061-done <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: Vincent Legoll <vincent.legoll <at> gmail.com>, 40061-done <at> debbugs.gnu.org,
 Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: [bug#40061] Allow double-click select of URL in status
Date: Tue, 07 Apr 2020 22:33:47 +0200

On dinsdag 7 april 2020 22:00:33 CEST Marius Bakke wrote:
> Vincent Legoll <vincent.legoll <at> gmail.com> writes:
> > LGTM, except maybe the following change to the
> > commit msg:
> > 
> > This change makes the URL be easier to be used
> > =>
> > This change makes the URL easier to use
> > 
> > But that may not warrant a new patch submission,
> > though, as the committer may do it himself...
> 
> Whoops, I committed this without seeing this comment, oh well!
> 
> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.

No worries, I actually used Vincent's suggested words in the rebase, which is 
the patch you applied. 

-- 
Tom Zander

Message #44 received at 40061-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tom Zander <tomz <at> freedommail.ch>, Vincent Legoll <vincent.legoll <at> gmail.com>,
 40061-done <at> debbugs.gnu.org
Subject: Re: [bug#40061] Allow double-click select of URL in status
Date: Tue, 07 Apr 2020 22:43:01 +0200

[Message part 1 (text/plain, inline)]

Tom Zander <tomz <at> freedommail.ch> writes:

> On dinsdag 7 april 2020 22:00:33 CEST Marius Bakke wrote:
>> Vincent Legoll <vincent.legoll <at> gmail.com> writes:
>> > LGTM, except maybe the following change to the
>> > commit msg:
>> > 
>> > This change makes the URL be easier to be used
>> > =>
>> > This change makes the URL easier to use
>> > 
>> > But that may not warrant a new patch submission,
>> > though, as the committer may do it himself...
>> 
>> Whoops, I committed this without seeing this comment, oh well!
>> 
>> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.
>
> No worries, I actually used Vincent's suggested words in the rebase, which is 
> the patch you applied. 

Oh heh, patch overload I guess!

Note that the patch was temporarily reverted (I forgot to CC you in the
previous message to this issue):
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1c86577d624b97a03138640b4d849823b504570e

Feel free to ping this bug once 1.1.0 is out to get it re-applied.  :-)

[signature.asc (application/pgp-signature, inline)]

Message #47 received at 40061-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tom Zander <tomz <at> freedommail.ch>, Vincent Legoll <vincent.legoll <at> gmail.com>,
 40061-done <at> debbugs.gnu.org
Subject: Re: [bug#40061] Allow double-click select of URL in status
Date: Fri, 17 Apr 2020 17:28:02 +0200

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Note that the patch was temporarily reverted (I forgot to CC you in the
> previous message to this issue):
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1c86577d624b97a03138640b4d849823b504570e
>
> Feel free to ping this bug once 1.1.0 is out to get it re-applied.  :-)

Finally applied in 8fa4ac5be4d5f8a1e62635842b16486832ff49f1 after a
friendly ping on #guix:matrix.org :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.