GNU bug report logs - #40102
[PATCH] gnu packages gnome-xyz: Add topicons-redux

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40102 in the body.
You can then email your comments to 40102 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Tue, 17 Mar 2020 12:58:17 +0000

Hi,
Added TopiconsRedux because it's the only System Tray Icon
Manager I managed to work in our current GNOME version.

gnome-shell-extension-appindicator doesn't support clicks
or menus on the System Tray, TopiconsRedux does.

Best,
Ekaitz


From c0d51f07042aca537d4f550e2c5e9ed2fcbb6292 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Date: Tue, 17 Mar 2020 13:54:24 +0100
Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux

---
 gnu/packages/gnome-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index b8cd32db08..3c8b1f667b 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul <at> autistici.org>
 ;;; Copyright © 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,6 +27,7 @@
   #:use-module (guix build-system copy)
   #:use-module (guix build-system meson)
   #:use-module (guix git-download)
+  #:use-module (guix download)
   #:use-module (guix packages)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages base)
@@ -146,6 +148,52 @@ GNOME Shell.")
     (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")
     (license license:gpl2+)))

+(define-public gnome-shell-extension-topicons-redux
+  (package
+    (name "gnome-shell-extension-topicons-redux")
+    (version "6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri
+          (string-append
+            "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/"
+            version "/TopIcons-Redux-" version ".tar.gz"))
+        (sha256
+          (base32 "0diwb6l4wy4dwpwkls4cq8v0dbi99q194jfl39sv7f7mnbjjgi82"))))
+    (build-system gnu-build-system)
+    (native-inputs
+      `(("glib" ,glib "bin")))
+    (arguments
+      `(#:tests? #f
+        #:phases
+        (modify-phases
+          %standard-phases
+          (delete 'configure)
+          (delete 'build)
+          (replace 'install
+                   (lambda* (#:key outputs #:allow-other-keys)
+                            (let ((out (assoc-ref outputs "out")))
+                              (invoke "make"
+                                      "install"
+                                      (string-append
+                                        "INSTALL_PATH="
+                                        out
+                                        "/share/gnome-shell/extensions"))))))))
+
+    (home-page
+      "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master")
+    (synopsis "Displays legacy tray icons in the GNOME Shell top panel.
+Rewritten fork of TopIcons Plus.")
+    (description "Many applications, such as chat clients, downloaders, and
+some media players, are meant to run long-term in the background even after you
+close their window. These applications remain accessible by adding an icon to
+the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME
+3.26. TopIcons Redux brings those icons back into the top panel so that it's
+easier to keep track of apps running in the
+backround.")
+    (license license:gpl2)))
+
 (define-public gnome-shell-extension-dash-to-dock
   (package
     (name "gnome-shell-extension-dash-to-dock")
--
2.25.1

Message #8 received at 40102 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: ekaitz <at> elenq.tech
Cc: 40102 <at> debbugs.gnu.org
Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Tue, 17 Mar 2020 17:49:25 +0100

Hi Ekaitz,
> +    (home-page
> +      "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master";)
You should probably drop "-/tree/master" and uncomment the bracket. 
Otherwise LGTM.

Regards,
Leo

Message #11 received at 40102 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: "40102 <at> debbugs.gnu.org" <40102 <at> debbugs.gnu.org>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Tue, 17 Mar 2020 16:55:27 +0000

> Hi Ekaitz,
>
> > -   (home-page
> > -        "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master";)
> >
> >
>
> You should probably drop "-/tree/master" and uncomment the bracket.
> Otherwise LGTM.
>
> Regards,
> Leo

The comment was accidentally introduced in the email. I don't really know how tbh.

Thanks for the comment, here's the updated patch:



From 4bbe7c5061a04d07ad9b85ff63d32379f34f8dc8 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Date: Tue, 17 Mar 2020 13:54:24 +0100
Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux

---
 gnu/packages/gnome-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index b8cd32db08..abb8dab4f7 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul <at> autistici.org>
 ;;; Copyright © 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,6 +27,7 @@
   #:use-module (guix build-system copy)
   #:use-module (guix build-system meson)
   #:use-module (guix git-download)
+  #:use-module (guix download)
   #:use-module (guix packages)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages base)
@@ -146,6 +148,52 @@ GNOME Shell.")
     (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")
     (license license:gpl2+)))

+(define-public gnome-shell-extension-topicons-redux
+  (package
+    (name "gnome-shell-extension-topicons-redux")
+    (version "6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri
+          (string-append
+            "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/"
+            version "/TopIcons-Redux-" version ".tar.gz"))
+        (sha256
+          (base32 "0diwb6l4wy4dwpwkls4cq8v0dbi99q194jfl39sv7f7mnbjjgi82"))))
+    (build-system gnu-build-system)
+    (native-inputs
+      `(("glib" ,glib "bin")))
+    (arguments
+      `(#:tests? #f
+        #:phases
+        (modify-phases
+          %standard-phases
+          (delete 'configure)
+          (delete 'build)
+          (replace 'install
+                   (lambda* (#:key outputs #:allow-other-keys)
+                            (let ((out (assoc-ref outputs "out")))
+                              (invoke "make"
+                                      "install"
+                                      (string-append
+                                        "INSTALL_PATH="
+                                        out
+                                        "/share/gnome-shell/extensions"))))))))
+
+    (home-page
+      "https://gitlab.com/pop-planet/TopIcons-Redux/")
+    (synopsis "Displays legacy tray icons in the GNOME Shell top panel.
+Rewritten fork of TopIcons Plus.")
+    (description "Many applications, such as chat clients, downloaders, and
+some media players, are meant to run long-term in the background even after you
+close their window. These applications remain accessible by adding an icon to
+the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME
+3.26. TopIcons Redux brings those icons back into the top panel so that it's
+easier to keep track of apps running in the
+backround.")
+    (license license:gpl2)))
+
 (define-public gnome-shell-extension-dash-to-dock
   (package
     (name "gnome-shell-extension-dash-to-dock")
--
2.25.1

Message #14 received at 40102 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: "40102 <at> debbugs.gnu.org" <40102 <at> debbugs.gnu.org>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Fri, 20 Mar 2020 18:53:46 +0100

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> From 4bbe7c5061a04d07ad9b85ff63d32379f34f8dc8 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
> Date: Tue, 17 Mar 2020 13:54:24 +0100
> Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux

[...]

> +(define-public gnome-shell-extension-topicons-redux
> +  (package
> +    (name "gnome-shell-extension-topicons-redux")
> +    (version "6")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri
> +          (string-append
> +            "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/"
> +            version "/TopIcons-Redux-" version ".tar.gz"))

Such "autogenerated" tarballs from GitLab and GitHub are prone to
getting re-created with different time stamps, breaking the checksum.
Can you adjust this package to use git-fetch instead of url-fetch?

[...]

> +    (arguments
> +      `(#:tests? #f

Why are tests disabled?  Please leave a comment.

> +        #:phases
> +        (modify-phases
> +          %standard-phases
> +          (delete 'configure)
> +          (delete 'build)
> +          (replace 'install
> +                   (lambda* (#:key outputs #:allow-other-keys)
> +                            (let ((out (assoc-ref outputs "out")))
> +                              (invoke "make"
> +                                      "install"
> +                                      (string-append
> +                                        "INSTALL_PATH="
> +                                        out
> +                                        "/share/gnome-shell/extensions"))))))))

Indentation is off here.  If you are not using Emacs there is a script
that can help with indentation, see "Formatting Code" in the Guix manual.

> +
> +    (home-page
> +      "https://gitlab.com/pop-planet/TopIcons-Redux/")

The line break here is not necessary.

> +    (synopsis "Displays legacy tray icons in the GNOME Shell top panel.
> +Rewritten fork of TopIcons Plus.")

Please keep synopsis to single sentences.  The second sentence can be
removed IMO.

> +    (description "Many applications, such as chat clients, downloaders, and
> +some media players, are meant to run long-term in the background even after you
> +close their window. These applications remain accessible by adding an icon to
> +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME
> +3.26. TopIcons Redux brings those icons back into the top panel so that it's
> +easier to keep track of apps running in the
> +backround.")

'guix lint gnome-shell-extension-topicons-redux' will warn that
sentences should be separated by two spaces.  Can you adjust accordingly?

> +    (license license:gpl2)))

Is the license really GPL2 only?  Unless the source code says explicitly
"GPL2 only", this should probably be "gpl2+", i.e. "GPL2 or any later
version".

Can you send an updated patch?

TIA!

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 40102 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: "40102\\@debbugs.gnu.org" <40102 <at> debbugs.gnu.org>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Fri, 20 Mar 2020 19:34:51 +0000

Hi all,

Thanks Marius for the feedback.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, March 20, 2020 5:53 PM, Marius Bakke <mbakke <at> fastmail.com> wrote:

> Such "autogenerated" tarballs from GitLab and GitHub are prone to
> getting re-created with different time stamps, breaking the checksum.
> Can you adjust this package to use git-fetch instead of url-fetch?

I wasn't aware of that! Thank you very much.


> Why are tests disabled? Please leave a comment.

Project doesn't have any test.


> Indentation is off here. If you are not using Emacs there is a script
> that can help with indentation, see "Formatting Code" in the Guix manual.

I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't
work very well sometimes.


>
> The line break here is not necessary.

Solved

> > -   (synopsis "Displays legacy tray icons in the GNOME Shell top panel.
> >     +Rewritten fork of TopIcons Plus.")
> >
>
> Please keep synopsis to single sentences. The second sentence can be
> removed IMO.

Done.

> 'guix lint gnome-shell-extension-topicons-redux' will warn that
> sentences should be separated by two spaces. Can you adjust accordingly?

Done.

> > -   (license license:gpl2)))
>
> Is the license really GPL2 only? Unless the source code says explicitly
> "GPL2 only", this should probably be "gpl2+", i.e. "GPL2 or any later
> version".

Done.

>
> Can you send an updated patch?
>

Here it comes:


From e62251601732587409c18dfe3af0cd56ecf39d5f Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Date: Tue, 17 Mar 2020 13:54:24 +0100
Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux

---
 gnu/packages/gnome-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index b8cd32db08..39579bbea4 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul <at> autistici.org>
 ;;; Copyright © 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -146,6 +147,48 @@ GNOME Shell.")
     (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")
     (license license:gpl2+)))

+(define-public gnome-shell-extension-topicons-redux
+  (package
+    (name "gnome-shell-extension-topicons-redux")
+    (version "6")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://gitlab.com/pop-planet/TopIcons-Redux.git")
+               (commit version)))
+        (sha256
+          (base32 "1dli9xb545n3xlj6q4wl0y5gzkm903zs47p8fiq71pdvbr6v38rj"))))
+    (build-system gnu-build-system)
+    (native-inputs
+      `(("glib" ,glib "bin")))
+    (arguments
+      `(#:tests? #f ; No test defined in the project
+        #:phases
+        (modify-phases
+          %standard-phases
+          (delete 'configure)
+          (delete 'build)
+          (replace 'install
+                   (lambda* (#:key outputs #:allow-other-keys)
+                     (let ((out (assoc-ref outputs "out")))
+                       (invoke "make"
+                               "install"
+                               (string-append
+                                 "INSTALL_PATH="
+                                 out
+                                 "/share/gnome-shell/extensions"))))))))
+
+    (home-page "https://gitlab.com/pop-planet/TopIcons-Redux/")
+    (synopsis "Displays legacy tray icons in the GNOME Shell top panel.")
+    (description "Many applications, such as chat clients, downloaders, and
+some media players, are meant to run long-term in the background even after you
+close their window.  These applications remain accessible by adding an icon to
+the GNOME Shell Legacy Tray.  However, the Legacy Tray was removed in GNOME
+3.26.  TopIcons Redux brings those icons back into the top panel so that it's
+easier to keep track of apps running in the backround.")
+    (license license:gpl2+)))
+
 (define-public gnome-shell-extension-dash-to-dock
   (package
     (name "gnome-shell-extension-dash-to-dock")
--
2.25.1

Message #22 received at 40102-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "40102\\@debbugs.gnu.org" <40102-done <at> debbugs.gnu.org>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Sat, 21 Mar 2020 20:23:20 +0100

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

>> Indentation is off here. If you are not using Emacs there is a script
>> that can help with indentation, see "Formatting Code" in the Guix manual.
>
> I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't
> work very well sometimes.

In that case, please run ./etc/indent-code.el before submitting
patches to lessen the burden on committers.  I've fixed the indentation
locally by running C-M-q in Emacs.

>>
>> Can you send an updated patch?
>>
>
> Here it comes:

Thanks!  Please add it as an attachment next time so the commit message
is preserved (or send the whole patch directly with 'git send-email').

Also, './pre-inst-env guix lint gnome-shell-extension-topicons-redux'
reported these issues:

gnu/packages/gnome-xyz.scm:155:5: gnome-shell-extension-topicons-redux <at> 6: the source file name should contain the package name
gnu/packages/gnome-xyz.scm:181:14: gnome-shell-extension-topicons-redux <at> 6: no period allowed at the end of the synopsis

I've fixed these locally too, sorry for missing them in the first
review.

Finally I edited the commit message so it follows our conventions.
Pushed in e7c7912573111d5e86f3e3012a6edab948f7b302.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 40102-done <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: "40102\\\\\\@debbugs.gnu.org" <40102-done <at> debbugs.gnu.org>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Sat, 21 Mar 2020 19:34:02 +0000

> I've fixed these locally too, sorry for missing them in the first
> review.
> ...

Sorry for all the work I gave you.
I'll do it better next time. Promise!

Thanks for your time.

Best,
Ekaitz

Message #28 received at 40102-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "40102\\\\\\@debbugs.gnu.org" <40102-done <at> debbugs.gnu.org>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Sat, 21 Mar 2020 20:38:37 +0100

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

>> I've fixed these locally too, sorry for missing them in the first
>> review.
>> ...
>
> Sorry for all the work I gave you.
> I'll do it better next time. Promise!

No worries!  It takes a while to get the hang of these things.  :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.