GNU bug report logs - #40104
[PATCH 1/1] gnu: Add emacs-org-static-blog.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40104 in the body.
You can then email your comments to 40104 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/1] gnu: Add emacs-org-static-blog.
Date: Tue, 17 Mar 2020 15:12:53 +0100

* gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d45814379b..dfcf283283 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -62,6 +62,7 @@
 ;;; Copyright © 2020 Evan Straw <evan.straw99 <at> gmail.com>
 ;;; Copyright © 2020 Masaya Tojo <masaya <at> tojo.tokyo>
 ;;; Copyright © 2020 Martin Becze <mjbecze <at> riseup.net>
+;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21806,3 +21807,28 @@ All entries in a specified TODO state will be carried over to the next day.")
        "Daredevil SKK is a version of @acronym{SKK, Simple Kana to Kanji
 conversion program}, a Japanese input method on Emacs.")
       (license license:gpl2+))))
+
+(define-public emacs-org-static-blog
+  (package
+   (name "emacs-org-static-blog")
+   (version "20200117.800")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (string-append
+           "https://melpa.org/packages/org-static-blog-"
+           version ".el"))
+     (sha256
+      (base32
+       "0k1p43pvjvfzgqigybizg9pr8r7sqapbv18vhfg9smik09sjh0gd"))))
+   (build-system emacs-build-system)
+   (home-page
+    "https://github.com/bastibe/org-static-blog")
+   (synopsis
+    "Simple org-mode based static blog generator")
+   (description
+    "Org-static-blog is one more static blog generator, it focuses on being
+simple.  All files are simple org-mode files in a directory.  The only
+requirement is that every org file must have a #+TITLE and a #+DATE, and
+optionally, #+FILETAGS.")
+   (license license:bsd-3)))
-- 
2.25.0

Message #10 received at 40104 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 40104 <at> debbugs.gnu.org
Subject: Re: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.
Date: Tue, 17 Mar 2020 16:07:58 +0100

Hello,

Brice Waegeneire <brice <at> waegenei.re> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.

Thank you.

> +(define-public emacs-org-static-blog
> +  (package
> +   (name "emacs-org-static-blog")
> +   (version "20200117.800")

Could you explain in a comment why using an unstable release is
required?

> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (string-append
> +           "https://melpa.org/packages/org-static-blog-"
> +           version ".el"))

It seems upstream is at Github, not MELPA. Could you use Github instead?

> +   (home-page
> +    "https://github.com/bastibe/org-static-blog")
> +   (synopsis
> +    "Simple org-mode based static blog generator")

Nitpick: Simple Org mode based static blog generator

> +   (description
> +    "Org-static-blog is one more static blog generator, it focuses on being
> +simple.  All files are simple org-mode files in a directory.  

Nitpick: All file are simple Org files in a directory.

> The only
> +requirement is that every org file must have a #+TITLE and a #+DATE, and
> +optionally, #+FILETAGS.")

Nitpick: every Org file must have a @samp{title} and a @samp{date}
keywords, and optionally, a @samp{filetags} keyword.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #13 received at 40104 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: 40104 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add emacs-org-static-blog.
Date: Wed, 18 Mar 2020 09:24:43 +0100

* gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d45814379b..e09eb4a19f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -62,6 +62,7 @@
 ;;; Copyright © 2020 Evan Straw <evan.straw99 <at> gmail.com>
 ;;; Copyright © 2020 Masaya Tojo <masaya <at> tojo.tokyo>
 ;;; Copyright © 2020 Martin Becze <mjbecze <at> riseup.net>
+;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21806,3 +21807,30 @@ All entries in a specified TODO state will be carried over to the next day.")
        "Daredevil SKK is a version of @acronym{SKK, Simple Kana to Kanji
 conversion program}, a Japanese input method on Emacs.")
       (license license:gpl2+))))
+
+(define-public emacs-org-static-blog
+  ;; Use the latest commit as the last release only contains half of the
+  ;; current total commits.
+  (package
+    (name "emacs-org-static-blog")
+    (version "20200117")
+    (home-page "https://github.com/bastibe/org-static-blog")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit "5c19300d7634e94ae813b1b66abc716fbb1e5fc9")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1m7vmibjc6yk2npfrnnqd3g2099300r0q8mr8cvyivmk5ailbfrh"))))
+    (build-system emacs-build-system)
+    (synopsis
+     "Simple Org mode based static blog generator")
+    (description
+     "@code{emacs-org-static-blog} is one more static blog generator, it focuses on being
+simple.  All file are simple Org files in a directory.  The only requirement
+is that every Org file must have a @samp{title} and a @samp{date} keywords,
+and optionally, a @samp{filetags} keyword.")
+    (license license:bsd-3)))
-- 
2.25.0

Message #16 received at 40104 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40104 <at> debbugs.gnu.org,
 Guix-patches <guix-patches-bounces+brice+lists=waegenei.re <at> gnu.org>
Subject: Re: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.
Date: Wed, 18 Mar 2020 08:26:07 +0000

On 2020-03-17 15:07, Nicolas Goaziou wrote:
> Hello,
> 
> Brice Waegeneire <brice <at> waegenei.re> writes:
> 
>> * gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.
> 
> Thank you.
> 
>> +(define-public emacs-org-static-blog
>> +  (package
>> +   (name "emacs-org-static-blog")
>> +   (version "20200117.800")
> 
> Could you explain in a comment why using an unstable release is
> required?
> 
>> +   (source
>> +    (origin
>> +     (method url-fetch)
>> +     (uri (string-append
>> +           "https://melpa.org/packages/org-static-blog-"
>> +           version ".el"))
> 
> It seems upstream is at Github, not MELPA. Could you use Github 
> instead?
> 
>> +   (home-page
>> +    "https://github.com/bastibe/org-static-blog")
>> +   (synopsis
>> +    "Simple org-mode based static blog generator")
> 
> Nitpick: Simple Org mode based static blog generator
> 
>> +   (description
>> +    "Org-static-blog is one more static blog generator, it focuses on 
>> being
>> +simple.  All files are simple org-mode files in a directory.
> 
> Nitpick: All file are simple Org files in a directory.
> 
>> The only
>> +requirement is that every org file must have a #+TITLE and a #+DATE, 
>> and
>> +optionally, #+FILETAGS.")
> 
> Nitpick: every Org file must have a @samp{title} and a @samp{date}
> keywords, and optionally, a @samp{filetags} keyword.
> 
> Could you send an updated patch?
> 
> Regards,
V2 send with all your suggestions added. And I have requested a new 
release upstream: https://github.com/bastibe/org-static-blog/issues/50

Message #21 received at 40104-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 40104-done <at> debbugs.gnu.org,
 Guix-patches <guix-patches-bounces+brice+lists=waegenei.re <at> gnu.org>
Subject: Re: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.
Date: Wed, 18 Mar 2020 12:28:02 +0100

Hello,

Brice Waegeneire <brice <at> waegenei.re> writes:

> V2 send with all your suggestions added. And I have requested a new
> release upstream: https://github.com/bastibe/org-static-blog/issues/50

Great! Applied as 382ba7bad59ec7205cd883bb93b5e6cf33329d66.

Thank you.

Regards,

-- 
Nicolas Goaziou

Message #29 received at 40104 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, 40104 <at> debbugs.gnu.org
Subject: Re: [bug#40104] [PATCH v2] gnu: Add emacs-org-static-blog.
Date: Wed, 18 Mar 2020 13:15:21 -0400 (EDT)

[Message part 1 (text/plain, inline)]

I know this was already merged, but I found an additional nit-pick/typo:

On Wed, 18 Mar 2020, Brice Waegeneire wrote:

> +    (description
> +     "@code{emacs-org-static-blog} is one more static blog generator, it focuses on being
> +simple.  All file are simple Org files in a directory.  The only requirement

I believe it should read, "All files are simple Org files…". Note the lack 
of s on the first instance of file.

Hopefully you don't mind me pointing out such a small thing.

All the best,
Jack

Message #32 received at 40104 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: Brice Waegeneire <brice <at> waegenei.re>, 40104 <at> debbugs.gnu.org
Subject: Re: [bug#40104] [PATCH v2] gnu: Add emacs-org-static-blog.
Date: Wed, 18 Mar 2020 21:51:05 +0100

Hello,

Jack Hill <jackhill <at> jackhill.us> writes:

> I believe it should read, "All files are simple Org files…". Note the
> lack of s on the first instance of file.
>
> Hopefully you don't mind me pointing out such a small thing.

Not at all!

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.