GNU bug report logs - #40105
[PATCH] gnu: Add wol.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40105 in the body.
You can then email your comments to 40105 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add wol.
Date: Tue, 17 Mar 2020 16:04:51 +0100

[Message part 1 (text/plain, inline)]

Hello,

I don't know if having multiple packages doing the same is OK or not.
Nor do I know if there are differences between this "wol" and the
already packaged "wakelan"...

I initially put it in networking whereas wakelen is in admin...

Anyways, I did the work, I tested it works by waking a suspended
odroidn2 SBC with it...

So here it is, tell me if it is redundant to the point of not being useful.

FTR, I packaged this because my initial guix search was with the words
wol and wakeonlan, which did not find anything relevant, whereas
searching with "wake" would have found it...

There are a few packages with WoL capability:

etherwake,
http://gsd.di.uminho.pt/jpo/software/wakeonlan/

you can do it with netcat, etc...

-- 
Vincent Legoll

[0001-gnu-Add-wol-v3.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Add wol.
Date: Thu, 19 Mar 2020 13:55:27 +0100

[Message part 1 (text/plain, inline)]

On Tue, Mar 17, 2020 at 04:04:51PM +0100, Vincent Legoll wrote:
> I don't know if having multiple packages doing the same is OK or not.
> Nor do I know if there are differences between this "wol" and the
> already packaged "wakelan"...

I don't think having multiple packages for doing something is
necessarily bad.

> +    (description "Tool to send a @code{magic} packet to wake another host
> +on the network.  This must be enabled on the target host, usually in the
> +BIOS.")

If I may ask, what's the rationale behind putting "magic" in a @code tag
here?

Apart from that, LGTM.

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Add wol.
Date: Thu, 19 Mar 2020 15:57:42 +0100

hello,

On Thu, Mar 19, 2020 at 1:55 PM Jakub Kądziołka <kuba <at> kadziolka.net> wrote:
> On Tue, Mar 17, 2020 at 04:04:51PM +0100, Vincent Legoll wrote:
> > I don't know if having multiple packages doing the same is OK or not.
> > Nor do I know if there are differences between this "wol" and the
> > already packaged "wakelan"...
>
> I don't think having multiple packages for doing something is
> necessarily bad.

Yep, me too, but I think I'll refrain from doing the other WoL packages...

> > +    (description "Tool to send a @code{magic} packet to wake another host
> > +on the network.  This must be enabled on the target host, usually in the
> > +BIOS.")
>
> If I may ask, what's the rationale behind putting "magic" in a @code tag
> here?

I think I copied that desc from somewhere else (maybe nixos) and it had quoting
around, and then guix lint told me to use @code instead, I probably should just
have removed the quotes... Nothing more than that, you can remove them if
you want to commit, or if you want I can resubmit without...

-- 
Vincent Legoll

Message #16 received at 40105-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 40105-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add wol.
Date: Sun, 29 Mar 2020 00:09:35 +0100

[Message part 1 (text/plain, inline)]

On Thu, Mar 19, 2020 at 03:57:42PM +0100, Vincent Legoll wrote:
> > > +    (description "Tool to send a @code{magic} packet to wake another host
> > > +on the network.  This must be enabled on the target host, usually in the
> > > +BIOS.")
> >
> > If I may ask, what's the rationale behind putting "magic" in a @code tag
> > here?
> 
> I think I copied that desc from somewhere else (maybe nixos) and it had quoting
> around, and then guix lint told me to use @code instead, I probably should just
> have removed the quotes... Nothing more than that, you can remove them if
> you want to commit, or if you want I can resubmit without...

Sorry for taking a while to respond on this, but I pushed your patch as
commit 62b9ad19e3a6638f8e077753454fdf08ba586146 with two changes:
Firstly, I removed the @code tag as you suggested. Secondly, I removed
the references to `name' in the URL, since, as the contributing
guidelines suggest, the URL likely won't be valid if the name gets
changed.

Cheers!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 40105-done <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 40105-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add wol.
Date: Sun, 29 Mar 2020 10:26:47 +0200

Hello Jakub,

On Sun, Mar 29, 2020 at 12:09 AM Jakub Kądziołka <kuba <at> kadziolka.net> wrote:
> Sorry for taking a while to respond on this, but I pushed your patch as
> commit 62b9ad19e3a6638f8e077753454fdf08ba586146 with two changes:
> Firstly, I removed the @code tag as you suggested. Secondly, I removed
> the references to `name' in the URL, since, as the contributing
> guidelines suggest, the URL likely won't be valid if the name gets
> changed.

OK, no problem with taking time, and thanks for the fixes, I'll try to remember
doing those myself for the next patches.

Tchuss

-- 
Vincent Legoll

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.