GNU bug report logs - #40120
[PATCH] doc: guix.texi: Add console-font-service-type to Base Services.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40120 in the body.
You can then email your comments to 40120 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
 Services.
Date: Wed, 18 Mar 2020 15:45:01 +0000

[Message part 1 (text/plain, inline)]

Hi guix,

I struggled with the console-font-service-type for a long time (mostly
becase setfont does not state you can specify a path). Documenting it
in the info pages would have helped.

Thanks!

John

[0001-doc-guix.texi-Add-console-font-service-type-to-Base-.patch (text/x-patch, attachment)]

Message #8 received at 40120 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40120 <at> debbugs.gnu.org
Subject: Re: [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type
 to Base Services.
Date: Sat, 21 Mar 2020 23:42:54 +0100

Hi John,

Thanks for improving the manual!  Some comments:

John Soo <jsoo1 <at> asu.edu> skribis:

> From 6a7204a6396781c1bbc1db1defee362c0a8142f9 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Wed, 18 Mar 2020 08:33:59 -0700
> Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
>  Services.
>
> * doc/guix.texi (console-font-service-type): Add it.
                  ^
This should be the name of the section this is added in.

> +@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}

This should be @defvr because it’s a variable, not a procedure (and thus
has no arguments).

Could you change that accordingly?  You can take inspiration from other
service types.

TIA!

Ludo’.

Message #11 received at 40120 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40120 <at> debbugs.gnu.org
Subject: Re: [bug#40120] [PATCH] doc: guix.texi: Add
 console-font-service-type to Base Services.
Date: Sat, 21 Mar 2020 16:16:35 -0700

[Message part 1 (text/plain, inline)]

Hi Ludo,

>> * doc/guix.texi (console-font-service-type): Add it.
>                   ^
> This should be the name of the section this is added in.

>> +@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}
>
> This should be @defvr because it’s a variable, not a procedure (and thus
> has no arguments).

Done and done, thanks again!

John

[0001-doc-guix.texi-Add-console-font-service-type-to-Base-.patch (text/x-patch, inline)]

From 74e8c62c584ac33909036992dde7d4cf3a1c7588 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1 <at> asu.edu>
Date: Wed, 18 Mar 2020 08:33:59 -0700
Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
 Services.

* doc/guix.texi (Base Services): Add console-font-service-type.
---
 doc/guix.texi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index c2eff582f8..8c694a9e73 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -12287,6 +12287,23 @@ symlink:
 Return a service that sets the host name to @var{name}.
 @end deffn
 
+@defvr {Scheme Procedure} console-font-service-type @var{tty-font-pairs}
+Install the given fonts on the specified ttys (fonts are per
+virtual console on the kernel Linux).  The value of this service is a list of
+tty/font pairs.  The font can be the name of a font provided by the @code{kbd}
+package or any valid argument to @command{setfont}, as in this example:
+
+@lisp
+'((\"tty1\" . \"LatGrkCyr-8x16\")
+  (\"tty2\" . (file-append
+                font-tamzen
+                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))
+  (\"tty3\" . (file-append
+                font-terminus
+                \"/share/consolefonts/ter-132n\"))) ; for HDPI
+@end lisp
+@end deffn
+
 @deffn {Scheme Procedure} login-service @var{config}
 Return a service to run login according to @var{config}, a
 @code{<login-configuration>} object, which specifies the message of the day,
-- 
2.25.2

Message #14 received at 40120 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40120 <at> debbugs.gnu.org
Subject: Re: [bug#40120] [PATCH] doc: guix.texi: Add
 console-font-service-type to Base Services.
Date: Sat, 21 Mar 2020 19:40:32 -0700

[Message part 1 (text/plain, inline)]

Hi again,

I just realized I should also change "Scheme Procudure" to "Scheme
Variable".

Thanks again,

John

[0001-doc-guix.texi-Add-console-font-service-type-to-Base-.patch (text/x-patch, attachment)]

Message #17 received at 40120 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40120 <at> debbugs.gnu.org
Subject: Re: [bug#40120] [PATCH] doc: guix.texi: Add
 console-font-service-type to Base Services.
Date: Sat, 21 Mar 2020 20:12:27 -0700

[Message part 1 (text/plain, inline)]

Hi again,

Dang it I forgot to change the @end to @end defvr.

This fixes it.

- John

[0001-doc-guix.texi-Add-console-font-service-type-to-Base-.patch (text/x-patch, attachment)]

Message #22 received at 40120-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40120-done <at> debbugs.gnu.org
Subject: Re: [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type
 to Base Services.
Date: Sun, 22 Mar 2020 21:59:54 +0100

Hi,

John Soo <jsoo1 <at> asu.edu> skribis:

> From cb4cf2b72766d4416fe5d2dc69a03914ec3c06c4 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Wed, 18 Mar 2020 08:33:59 -0700
> Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
>  Services.
>
> * doc/guix.texi (Base Services): Add console-font-service-type.

Applied with this changes:

> +@defvr {Scheme Variable} console-font-service-type @var{tty-font-pairs}

Remove @var{tty-font-pairs}.

> +@lisp
> +'((\"tty1\" . \"LatGrkCyr-8x16\")
> +  (\"tty2\" . (file-append
> +                font-tamzen
> +                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))

Changed to quasiquote/unquote as needed (same in gnu/services/base.scm,
which had the same typo), and \" → ".

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.