GNU bug report logs - #40143
[PATCH] gnu: git: Return #t in install-man-pages phase.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40143 in the body.
You can then email your comments to 40143 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: git: Return #t in install-man-pages phase.
Date: Fri, 20 Mar 2020 10:20:05 +0100

* gnu/packages/version-control.scm (git)[arguments]: Return #t in
install-man-pages phase.
---
 gnu/packages/version-control.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index d25df4c63d..7eb85cc749 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -441,7 +441,8 @@ as well as the classic centralized workflow.")
                    (manpages (assoc-ref inputs "git-manpages")))
               (mkdir-p man)
               (with-directory-excursion man
-                (invoke "tar" "xvf" manpages))))))))
+                (invoke "tar" "xvf" manpages)))
+            #t)))))
 
    (native-search-paths
     ;; For HTTPS access, Git needs a single-file certificate bundle, specified

base-commit: 837644b48a5107a28acbdb6d172aff0040a8247d
prerequisite-patch-id: b9e1cb7e09e15cac4d607e985e2a3b5e301828e5
prerequisite-patch-id: e22ea3f99fc3d9f3e11ddfa31ba60212f2ed4d62
-- 
2.25.1

Message #8 received at 40143 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 40143 <at> debbugs.gnu.org
Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages
 phase.
Date: Fri, 20 Mar 2020 10:54:06 +0100

[Message part 1 (text/plain, inline)]

invoke already returns #t, so there's no technical bug.

That said, maybe for clarity?  Not sure...

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 40143 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Brice Waegeneire <brice <at> waegenei.re>, 40143 <at> debbugs.gnu.org
Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages
 phase.
Date: Fri, 20 Mar 2020 10:21:14 -0400

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> invoke already returns #t, so there's no technical bug.
>
> That said, maybe for clarity?  Not sure...

I don't see any technical nor clarity issue here.  The vision laid out
by Mark more than two years ago (!) was to get rid of all the boolean
return codes and move to an exception based system entirely, which I
find much more elegant.  The transition plan was outlined in this
message:
https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html.

I think we should go back to work on finishing the missing bits :-).

Maxim

Message #16 received at 40143-close <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40143-close <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages
 phase.
Date: Sat, 21 Mar 2020 15:29:52 +0100

Hello Brice,

> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>
>> invoke already returns #t, so there's no technical bug.
>>
>> That said, maybe for clarity?  Not sure...

I agree with Danny and Maxim here, we already return a boolean, or
raise an exception in case of error, so I think we are fine :)

Closing this bug,

Thanks,

Mathieu

Message #19 received at 40143-close <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40143-close <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Guix-patches <guix-patches-bounces+brice+lists=waegenei.re <at> gnu.org>
Subject: Re: bug#40143: [PATCH] gnu: git: Return #t in install-man-pages phase.
Date: Sat, 21 Mar 2020 14:43:56 +0000

On 2020-03-21 14:29, Mathieu Othacehe wrote:
> Hello Brice,
> 
>> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>> 
>>> invoke already returns #t, so there's no technical bug.
>>> 
>>> That said, maybe for clarity?  Not sure...
> 
> I agree with Danny and Maxim here, we already return a boolean, or
> raise an exception in case of error, so I think we are fine :)
> 
> Closing this bug,
> 
> Thanks,
> 
> Mathieu

Looks like a forgot to reply to all, I replied to Danny that it
should be closed. I missed the RTFM sign... I didn't knew about
Maxim's link and would like to know where are we in transitioning
away from getting rid of boolean return code in phases.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.