GNU bug report logs - #40158
mount point is not created if mount? is #f

Previous Next

Package: guix;

Reported by: maxim.cournoyer <at> gmail.com

Date: Fri, 20 Mar 2020 23:14:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40158 in the body.
You can then email your comments to 40158 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guix <at> gnu.org:
bug#40158; Package guix. (Fri, 20 Mar 2020 23:14:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to maxim.cournoyer <at> gmail.com:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Fri, 20 Mar 2020 23:14:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: bug-guix <bug-guix <at> gnu.org>
Subject: mount point is not created if mount? is #f
Date: Fri, 20 Mar 2020 19:13:36 -0400

Consider the following file system record:

(file-system
  (device "some-server:/mnt/scratch/yocto-sstate")"
  (mount-point "/mnt/scratch/yocto-sstate")
  (create-mount-point? #t)
  (type "nfs")
  (mount? #f)
  (options "soft")
  (flags '(no-exec)))

Even though a user would think the mount point would be created, it is
not, I'm guessing because mount? is #f.

Maxim
Information forwarded to bug-guix <at> gnu.org:
bug#40158; Package guix. (Thu, 05 Aug 2021 19:14:01 GMT) Full text and rfc822 format available.

Message #8 received at 40158 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 40158 <at> debbugs.gnu.org
Subject: Re: bug#40158: mount point is not created if mount? is #f
Date: Thu, 05 Aug 2021 15:13:41 -0400

[Message part 1 (text/plain, inline)]
Hello,

maxim.cournoyer <at> gmail.com writes:

> Consider the following file system record:
>
> (file-system
>   (device "some-server:/mnt/scratch/yocto-sstate")"
>   (mount-point "/mnt/scratch/yocto-sstate")
>   (create-mount-point? #t)
>   (type "nfs")
>   (mount? #f)
>   (options "soft")
>   (flags '(no-exec)))
>
> Even though a user would think the mount point would be created, it is
> not, I'm guessing because mount? is #f.
>
> Maxim

I had the "chance" again today to meet this issue, so I took it by the
horns and came up with the attached patch, which fixes it:


[0001-services-base-Honor-file-system-create-mount-point-a.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
Thanks,

Maxim
Added tag(s) patch. Request was from Maxim Cournoyer <maxim.cournoyer <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 09 Aug 2021 15:08:02 GMT) Full text and rfc822 format available.
Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Sun, 29 Aug 2021 06:09:01 GMT) Full text and rfc822 format available.
Notification sent to maxim.cournoyer <at> gmail.com:
bug acknowledged by developer. (Sun, 29 Aug 2021 06:09:01 GMT) Full text and rfc822 format available.

Message #15 received at 40158-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 40158-done <at> debbugs.gnu.org
Subject: Re: bug#40158: mount point is not created if mount? is #f
Date: Sun, 29 Aug 2021 02:08:35 -0400

Hello,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hello,
>
> maxim.cournoyer <at> gmail.com writes:
>
>> Consider the following file system record:
>>
>> (file-system
>>   (device "some-server:/mnt/scratch/yocto-sstate")"
>>   (mount-point "/mnt/scratch/yocto-sstate")
>>   (create-mount-point? #t)
>>   (type "nfs")
>>   (mount? #f)
>>   (options "soft")
>>   (flags '(no-exec)))
>>
>> Even though a user would think the mount point would be created, it is
>> not, I'm guessing because mount? is #f.
>>
>> Maxim
>
> I had the "chance" again today to meet this issue, so I took it by the
> horns and came up with the attached patch, which fixes it:
>
>
>
> Thanks,
>
> Maxim

Pushed with 8ad6624b96.  Closing!

Maxim
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 26 Sep 2021 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 207 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.