GNU bug report logs - #40164
Fix for libgccjit

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40164 in the body.
You can then email your comments to 40164 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Fix for libgccjit
Date: Sat, 21 Mar 2020 13:13:18 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-fix-libgccjit.patch (text/x-patch, attachment)]

Message #8 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: "40164 <at> debbugs.gnu.org" <40164 <at> debbugs.gnu.org>
Subject: information
Date: Sat, 21 Mar 2020 13:18:42 +0000

I forgot to say what it does - it adds «lib/gcc» to the CPATH so that we don't get errors like «ld: cannot find crtbeginS.o: No such file or directory».

Message #11 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: "40164 <at> debbugs.gnu.org" <40164 <at> debbugs.gnu.org>
Subject: a small correction
Date: Sat, 21 Mar 2020 13:21:14 +0000

it fixes LIBRARY_PATH, not CPATH

Message #14 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Formbi <formbi <at> protonmail.com>
Cc: 40164 <at> debbugs.gnu.org
Subject: Re: [bug#40164] Fix for libgccjit
Date: Sat, 21 Mar 2020 15:48:35 +0100

Hello Formbi,

> Empty Message

Could you explain what you are trying to fix with this patch?

Thanks,

Mathieu

Message #17 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Formbi <formbi <at> protonmail.com>
Cc: 40164 <at> debbugs.gnu.org
Subject: Re: [bug#40164] Fix for libgccjit
Date: Sat, 21 Mar 2020 23:32:05 +0100

Hello,

Formbi <formbi <at> protonmail.com> skribis:

> From 51511978f7e41392d9ed4d49f08c7ce154ff18d2 Mon Sep 17 00:00:00 2001
> From: Formbi <formbi <at> protonmail.com>
> Date: Sat, 21 Mar 2020 14:10:01 +0100
> Subject: [PATCH] fix libgccjit
>
> ---
>  gnu/packages/gcc.scm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
> index 08afd80358..2c9a8ba9df 100644
> --- a/gnu/packages/gcc.scm
> +++ b/gnu/packages/gcc.scm
> @@ -716,7 +716,17 @@ as the 'native-search-paths' field."
>                 (for-each delete-file
>                           (find-files (string-append (assoc-ref outputs "out") "/bin")
>                                       ".*(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)"))
> -               #t))))))))
> +               #t))))))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "C_INCLUDE_PATH")
> +            (files '("include")))
> +           (search-path-specification
> +            (variable "CPLUS_INCLUDE_PATH")
> +            (files '("include")))
> +           (search-path-specification
> +            (variable "LIBRARY_PATH")
> +            (files '("lib" "lib64" "lib/gcc")))))))

I think this has no effect because this ‘native-search-paths’ is already
inherited from ‘gcc-9’, which ‘libgccjit’ inherits from.

Can you confirm?

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> Could you explain what you are trying to fix with this patch?

From a discussion on IRC, this has to do with the fact that libgccjit
needs all these search paths defined at run time.

Thanks,
Ludo’.

Message #20 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: "40164 <at> debbugs.gnu.org" <40164 <at> debbugs.gnu.org>
Subject: Re: [bug#40164] Fix for libgccjit
Date: Sat, 21 Mar 2020 23:12:30 +0000

> I think this has no effect because this ‘native-search-paths’ is already
> inherited from ‘gcc-9’, which ‘libgccjit’ inherits from.

Nope, it does have an effect. I added "lib/gcc" to the original paths (and that was the needed thing).

(sending again because I forgot about the debbugs e-mail)

Message #23 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#40164] Fix for libgccjit
Date: Sat, 21 Mar 2020 22:56:18 +0000

> I think this has no effect because this ‘native-search-paths’ is already
> inherited from ‘gcc-9’, which ‘libgccjit’ inherits from.

Nope, it does have an effect. I added "lib/gcc" to the original paths (and that was the needed thing).

Message #26 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Formbi <formbi <at> protonmail.com>
Cc: 40164 <at> debbugs.gnu.org
Subject: Re: [bug#40164] Fix for libgccjit
Date: Sun, 22 Mar 2020 21:54:06 +0100

Hi,

(+Cc bug.)

Formbi <formbi <at> protonmail.com> skribis:

>> I think this has no effect because this ‘native-search-paths’ is already
>> inherited from ‘gcc-9’, which ‘libgccjit’ inherits from.
>
> Nope, it does have an effect. I added "lib/gcc" to the original paths (and that was the needed thing).

In that case, could you (1) arrange to write the search path in a way
that reuses (package-native-search-paths gcc-9), and (2) add a comment
explaining why “lib/gcc” is needed (it looks unusual)?

Thanks in advance,
Ludo’.

Message #31 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Formbi <formbi <at> protonmail.com>
Cc: 40164 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#40164: Fix for libgccjit
Date: Wed, 14 Jul 2021 08:40:45 -0400

Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> (+Cc bug.)
>
> Formbi <formbi <at> protonmail.com> skribis:
>
>>> I think this has no effect because this ‘native-search-paths’ is already
>>> inherited from ‘gcc-9’, which ‘libgccjit’ inherits from.
>>
>> Nope, it does have an effect. I added "lib/gcc" to the original paths (and that was the needed thing).
>
> In that case, could you (1) arrange to write the search path in a way
> that reuses (package-native-search-paths gcc-9), and (2) add a comment
> explaining why “lib/gcc” is needed (it looks unusual)?
>
> Thanks in advance,
> Ludo’.

Perhaps the original issue is the one reported/fix with a patch here [0]
?  Formbi, could you share a simple reproducer so that we can test if
the patches resolve it?  It seems it'd be useful to upstream as well (to
have a reproducer).

Thanks!

[0]  https://gcc.gnu.org/legacy-ml/gcc-patches/2019-03/msg01045.html

Message #34 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Formbi <formbi <at> protonmail.com>
Cc: 40164 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#40164: Fix for libgccjit
Date: Wed, 14 Jul 2021 12:50:24 -0400

Hello again,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Perhaps the original issue is the one reported/fix with a patch here [0]
> ?  Formbi, could you share a simple reproducer so that we can test if
> the patches resolve it?  It seems it'd be useful to upstream as well (to
> have a reproducer).
>
> Thanks!
>
> [0]  https://gcc.gnu.org/legacy-ml/gcc-patches/2019-03/msg01045.html

Another data point: this seems to be worked around in Nix using the fix
proposed by Formbi:
https://github.com/NixOS/nixpkgs/blob/8a815af4280f3e0d5ff740faa7d489e2b9e36829/pkgs/applications/editors/emacs/generic.nix#L87.

Maxim

Message #37 received at 40164 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 40164 <at> debbugs.gnu.org, Formbi <formbi <at> protonmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#40164: Fix for libgccjit
Date: Fri, 21 Feb 2025 23:04:07 +0100

Hi,

For reference: https://issues.guix.gnu.org/issue/40164

On Wed, 14 Jul 2021 at 12:50, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> Perhaps the original issue is the one reported/fix with a patch here [0]
>> ?  Formbi, could you share a simple reproducer so that we can test if
>> the patches resolve it?  It seems it'd be useful to upstream as well (to
>> have a reproducer).
>>
>> Thanks!
>>
>> [0]  https://gcc.gnu.org/legacy-ml/gcc-patches/2019-03/msg01045.html
>
> Another data point: this seems to be worked around in Nix using the fix
> proposed by Formbi:
> https://github.com/NixOS/nixpkgs/blob/8a815af4280f3e0d5ff740faa7d489e2b9e36829/pkgs/applications/editors/emacs/generic.nix#L87.

What is the status of all this?  The report is marked as moreinfo and
the last activity is very old.  I’m in favor to close.  WDYT?

Cheers,
simon

Message #42 received at 40164-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 40164-done <at> debbugs.gnu.org, Formbi <formbi <at> protonmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#40164: Fix for libgccjit
Date: Sat, 22 Feb 2025 21:54:17 +0900

Hi,

Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> For reference: https://issues.guix.gnu.org/issue/40164
>
> On Wed, 14 Jul 2021 at 12:50, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>>
>>> Perhaps the original issue is the one reported/fix with a patch here [0]
>>> ?  Formbi, could you share a simple reproducer so that we can test if
>>> the patches resolve it?  It seems it'd be useful to upstream as well (to
>>> have a reproducer).
>>>
>>> Thanks!
>>>
>>> [0]  https://gcc.gnu.org/legacy-ml/gcc-patches/2019-03/msg01045.html
>>
>> Another data point: this seems to be worked around in Nix using the fix
>> proposed by Formbi:
>> https://github.com/NixOS/nixpkgs/blob/8a815af4280f3e0d5ff740faa7d489e2b9e36829/pkgs/applications/editors/emacs/generic.nix#L87.
>
> What is the status of all this?  The report is marked as moreinfo and
> the last activity is very old.  I’m in favor to close.  WDYT?

Me too.  Done.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.