GNU bug report logs - #40193
27.0.50; nxml-newline-and-indent argument should be optional

Previous Next

Package: emacs;

Reported by: Sergey Trofimov <sarg <at> sarg.org.ru>

Date: Mon, 23 Mar 2020 05:48:02 UTC

Severity: normal

Tags: easy

Found in version 27.0.50

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40193 in the body.
You can then email your comments to 40193 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#40193; Package emacs. (Mon, 23 Mar 2020 05:48:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Sergey Trofimov <sarg <at> sarg.org.ru>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 23 Mar 2020 05:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; nxml-newline-and-indent argument should be optional
Date: Mon, 23 Mar 2020 06:47:02 +0100

According to the definition of comment-line-break-function:
  The function should take a single optional argument, which is a flag
  indicating whether it should use soft newlines.

But in nxml-mode:
  (setq-local comment-line-break-function #'nxml-newline-and-indent)
  (defun nxml-newline-and-indent (soft) ...)

Could you please make an argument optional?
Added tag(s) easy. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 31 Mar 2020 22:57:01 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#40193; Package emacs. (Sun, 18 Oct 2020 01:30:02 GMT) Full text and rfc822 format available.

Message #10 received at 40193 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: 40193 <at> debbugs.gnu.org
Subject: Re: bug#40193: 27.0.50;
 nxml-newline-and-indent argument should be optional
Date: Sun, 18 Oct 2020 01:29:16 +0000

close 40193 28.1
thanks

Sergey Trofimov <sarg <at> sarg.org.ru> writes:

> According to the definition of comment-line-break-function:
>   The function should take a single optional argument, which is a flag
>   indicating whether it should use soft newlines.
>
> But in nxml-mode:
>   (setq-local comment-line-break-function #'nxml-newline-and-indent)
>   (defun nxml-newline-and-indent (soft) ...)
>
> Could you please make an argument optional?

I've made this change on master; the fix will be in Emacs 28.1.
bug marked as fixed in version 28.1, send any further explanations to 40193 <at> debbugs.gnu.org and Sergey Trofimov <sarg <at> sarg.org.ru> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 18 Oct 2020 01:30:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 15 Nov 2020 12:24:08 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 163 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.