GNU bug report logs - #40212
[PATCH] gnu: xorriso: Build gui frontend.

Previous Next

Package: guix-patches;

Reported by: Efraim Flashner <efraim <at> flashner.co.il>

Date: Tue, 24 Mar 2020 14:55:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40212 in the body.
You can then email your comments to 40212 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40212; Package guix-patches. (Tue, 24 Mar 2020 14:55:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Efraim Flashner <efraim <at> flashner.co.il>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 24 Mar 2020 14:55:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: xorriso: Build gui frontend.
Date: Tue, 24 Mar 2020 16:53:21 +0200
* gnu/packages/cdrom.scm (xorriso)[outputs]: Add gui.
[arguments]: Add custom phase to install gui files to separate output
and wrap the binary.
[inputs]: Add tk.
---

A while ago I had to burn a CD (or I thought I did) and I realized I
didn't know how to do it anymore and for some reason it was easier to
build the GUI front-end for xorriso than other options.

Adding tk as an input increases the closure size from about 80 MiB to about
150 MiB so I moved it to a separate output.  Creating a separate package
entirely would be easier, it's literally just adding "tk" as an input.

---
 gnu/packages/cdrom.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index d6127d11f9..c760725ba3 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -3,7 +3,7 @@
 ;;; Copyright © 2013, 2014 Andreas Enge <andreas <at> enge.fr>
 ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli <at> gmail.com>
 ;;; Copyright © 2015 Paul van der Walt <paul <at> denknerd.org>
-;;; Copyright © 2015, 2016, 2017, 2018, 2019 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2015, 2016, 2017, 2018, 2019, 2020 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Alex Kost <alezost <at> gmail.com>
 ;;; Copyright © 2016 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 John Darrington <jmd <at> gnu.org>
@@ -66,6 +66,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages image)
   #:use-module (gnu packages photo)
+  #:use-module (gnu packages tcl)
   #:use-module (gnu packages video)
   #:use-module (gnu packages wget)
   #:use-module (gnu packages xiph))
@@ -156,6 +157,7 @@ libcdio.")
   (package
     (name "xorriso")
     (version "1.5.2")
+    (outputs '("out" "gui"))
     (source (origin
              (method url-fetch)
              (uri (string-append "mirror://gnu/xorriso/xorriso-"
@@ -172,10 +174,31 @@ libcdio.")
              (let* ((out (assoc-ref outputs "out"))
                     (out-bin (string-append out "/bin")))
                (install-file "frontend/grub-mkrescue-sed.sh" out-bin)
+               #t)))
+         (add-after 'install 'move-gui-to-separate-output
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (gui (assoc-ref outputs "gui"))
+                   (name "xorriso-tcltk"))
+               (mkdir-p (string-append gui "/bin"))
+               (mkdir-p (string-append gui "/share/info"))
+               (mkdir-p (string-append gui "/share/man/man1"))
+               (rename-file
+                 (string-append out "/bin/" name)
+                 (string-append gui "/bin/" name))
+               (rename-file
+                 (string-append out "/share/info/" name ".info")
+                 (string-append gui "/share/info/" name ".info"))
+               (rename-file
+                 (string-append out "/share/man/man1/" name ".1")
+                 (string-append gui "/share/man/man1/" name ".1"))
+               (wrap-program (string-append gui "/bin/" name)
+                 `("PATH" ":" prefix (,(string-append out "/bin"))))
                #t))))))
     (inputs
      `(("acl" ,acl)
        ("readline" ,readline)
+       ("tk" ,tk)
        ("zlib" ,zlib)))
     (home-page "https://www.gnu.org/software/xorriso/")
     (synopsis "Create, manipulate, burn ISO-9660 file systems")
-- 
2.26.0





Information forwarded to guix-patches <at> gnu.org:
bug#40212; Package guix-patches. (Thu, 26 Mar 2020 17:55:02 GMT) Full text and rfc822 format available.

Message #8 received at 40212 <at> debbugs.gnu.org (full text, mbox):

From: "Thomas Schmitt" <scdbackup <at> gmx.net>
To: 40212 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: xorriso: Build gui frontend.
Date: Thu, 26 Mar 2020 18:55:35 +0100
Hi,

the "[/]" buttons of xorriso-tcltk need the Tcl/Tk package "BWidget"
to display a file browser.

Without it, the up-popping windows only offer a text input field for
entering an absolute file path. That's quite unusual for a GUI program.
The file browser widget does not look fancy but provides the interface
which a GUI user probably expects.


Have a nice day :)

Thomas





Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Fri, 10 Apr 2020 10:52:01 GMT) Full text and rfc822 format available.

Notification sent to Efraim Flashner <efraim <at> flashner.co.il>:
bug acknowledged by developer. (Fri, 10 Apr 2020 10:52:01 GMT) Full text and rfc822 format available.

Message #13 received at 40212-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 40212-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: xorriso: Build gui frontend.
Date: Fri, 10 Apr 2020 13:51:12 +0300
[Message part 1 (text/plain, inline)]
Patch pushed with some code cleanup to make the phase shorter.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 08 May 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 326 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.