GNU bug report logs - #40221
Submission of GUI Package Description for 7kaa

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40221 in the body.
You can then email your comments to 40221 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Gábor Boskovits <boskovits <at> gmail.com>
Subject: Submission of GUI Package Description for 7kaa
Date: Wed, 25 Mar 2020 19:03:34 +0530

[Message part 1 (text/plain, inline)]

Hi

I had a discussion with rekado and guix-vits on IRC regarding which GUI
can be done and upon their suggestions i have chosen 7kaa game.

guix-vits have helped a lot with most of the package description and
with the manual provided by rekado i was able to write this package
description.


I have written sepearately as 7kaa.scm and

guix environment --ad-hoc 7kaa -L ./

and later 7kaa have run the game.


Hence i added to games.scm(assuming thats the actual location. Please
correct me) and done with the patch.

Lint have given me couple of corrections. I need your suggestions before
making the commit.


-- 
Regards
NagaMalli

[0001-gnu-Add-7kaa.patch (text/x-patch, attachment)]

Message #8 received at 40221 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Gábor Boskovits <boskovits <at> gmail.com>, 40221 <at> debbugs.gnu.org
Subject: Re: [bug#40221] Submission of GUI Package Description for 7kaa
Date: Wed, 25 Mar 2020 15:00:01 +0100

Hello,

Naga Malleswari <nagamalli <at> riseup.net> writes:

> Hence i added to games.scm(assuming thats the actual location. Please
> correct me) and done with the patch.

Thank you!

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/the3dfxdude/7kaa/archive/v"
> +                           version ".tar.gz"))

This URL is not stable. Home page provides a stable release at:

  https://github.com/the3dfxdude/7kaa/releases/download/v2.15.3/7kaa-2.15.3.tar.xz

I suggest to use this one, replacing 2.5.13 with `version', like you did. 

> +       (sha256
> +        (base32 "0bf90v1bm4zazwalfl9vd5dfbdcxwhi02rmggn5xc0yq0zkxwlqv"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("automake" ,automake)
> +       ("autoconf" ,autoconf)
> +       ("pkg-config" ,pkg-config)))

Could you re-order inputs alphabetically?

> +    (inputs
> +     `(("sdl2" ,sdl2)
> +       ("enet" ,enet)
> +       ("openal" ,openal)
> +       ("gettext" ,gettext-minimal)
> +       ("curl" ,curl)))

Ditto.

> +    (home-page "https://7kfans.com/")
> +    (synopsis "Seven Kingdoms Ancient Adversaries: real-time strategy game")
> +    (description
> +     "Seven Kingdoms, designed by Trevor Chan, brings a unique blend of
> +Real-Time Strategy with the addition of trade, diplomacy, and espionage.

We try to avoid adding "marketing" words or idioms in descriptions, like
"unique blend". I think "blend" is enough.

> +7kfans project is updating the game and
> +provides a community for fans.  A free Seven Kingdoms will help continue
> +the legacy.")

I suggest to drop this part, which is not informative in the
description. Besides, everything is Free in Guix.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #11 received at 40221 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Gábor Boskovits <boskovits <at> gmail.com>, 40221 <at> debbugs.gnu.org
Subject: Re: [bug#40221] Submission of GUI Package Description for 7kaa
Date: Wed, 25 Mar 2020 17:06:06 +0100

Completing myself,

>> +    (inputs
>> +     `(("sdl2" ,sdl2)
>> +       ("enet" ,enet)
>> +       ("openal" ,openal)
>> +       ("gettext" ,gettext-minimal)

gettext is a native input, you should move it in the appropriate
section.

Message #14 received at 40221 <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Gábor Boskovits <boskovits <at> gmail.com>, 40221 <at> debbugs.gnu.org
Subject: Re: [bug#40221] Submission of GUI Package Description for 7kaa v2
Date: Thu, 26 Mar 2020 01:33:54 +0530

[Message part 1 (text/plain, inline)]

Hi

I have made all the changes suggested by you in the trailing mail as
well. I had to change the hash. Please review the patch and suggest any
changes.

On 25/03/20 9:36 pm, Nicolas Goaziou wrote:
> Completing myself,
>
>>> +    (inputs
>>> +     `(("sdl2" ,sdl2)
>>> +       ("enet" ,enet)
>>> +       ("openal" ,openal)
>>> +       ("gettext" ,gettext-minimal)
> gettext is a native input, you should move it in the appropriate
> section.
>
-- 
Regards
NagaMalli

[0001-gnu-Add-7kaa.patch (text/x-patch, attachment)]

Message #19 received at 40221-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Naga Malleswari <nagamalli <at> riseup.net>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Gábor Boskovits <boskovits <at> gmail.com>,
 40221-done <at> debbugs.gnu.org
Subject: Re: [bug#40221] Submission of GUI Package Description for 7kaa v2
Date: Thu, 26 Mar 2020 18:22:38 +0100

Hello,

Naga Malleswari <nagamalli <at> riseup.net> writes:
>
> I have made all the changes suggested by you in the trailing mail as
> well. I had to change the hash. Please review the patch and suggest any
> changes.

Thank you.

I applied your patch (as db47adb0c767c373958d892411da2c89fe5503a3) with
the following changes:

- I removed dependency on autoconf and automake since, as a release, the
  code is already boostrapped.

- I removed the last sentence in the description.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.