GNU bug report logs - #40265
[PATCH] gnu: python-intervaltree: Update to 3.0.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40265 in the body.
You can then email your comments to 40265 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: guix-patches <at> gnu.org
Cc: rekado <at> elephly.net
Subject: [PATCH] gnu: python-intervaltree: Update to 3.0.2.
Date: Sat, 28 Mar 2020 00:51:25 +0100

* gnu/packages/bioinformatics.scm (python-intervaltree): Update to 3.0.2.
[arguments]: Don't skip the tests.
---

It turns out I need python-intervaltree 3.0 as a dependency for one of
the packages I'm working on.

Cc: Ricardo - you added python-pygenometracks, the only dependent. Could
you re-test it, just in case?

 gnu/packages/bioinformatics.scm | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index da3fe1d2c9..a8e4c830ae 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2019 Brian Leung <bkleung89 <at> gmail.com>
 ;;; Copyright © 2019 Brett Gilio <brettg <at> gnu.org>
 ;;; Copyright © 2020 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
+;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -13548,17 +13549,22 @@ allowing the insertion of arbitrary types into the tree.")
 (define-public python-intervaltree
   (package
     (name "python-intervaltree")
-    (version "2.1.0")
+    (version "3.0.2")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "intervaltree" version))
        (sha256
         (base32
-         "02w191m9zxkcjqr1kv2slxvhymwhj3jnsyy3a28b837pi15q19dc"))))
+         "0wz234g6irlm4hivs2qzmnywk0ss06ckagwh15nflkyb3p462kyb"))))
     (build-system python-build-system)
-    ;; FIXME: error when collecting tests
-    (arguments '(#:tests? #f))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'import-mismatch-error-workaround
+           (lambda _
+             (setenv "PY_IGNORE_IMPORTMISMATCH" "1")
+             #t)))))
     (propagated-inputs
      `(("python-sortedcontainers" ,python-sortedcontainers)))
     (native-inputs
-- 
2.26.0

Message #8 received at 40265 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jakub Kądziołka <kuba <at> kadziolka.net>,
 40265 <at> debbugs.gnu.org
Cc: rekado <at> elephly.net
Subject: Re: [bug#40265] [PATCH] gnu: python-intervaltree: Update to 3.0.2.
Date: Tue, 31 Mar 2020 16:58:43 +0200

[Message part 1 (text/plain, inline)]

Jakub Kądziołka <kuba <at> kadziolka.net> writes:

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'import-mismatch-error-workaround
> +           (lambda _
> +             (setenv "PY_IGNORE_IMPORTMISMATCH" "1")
> +             #t)))))

Can you add a comment about what this does?

Also, I guess this package should be moved out of bioinformatics.scm,
assuming the software you are packaging is not bioinfo-related?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40265 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Jakub Kądziołka <kuba <at> kadziolka.net>, rekado <at> elephly.net,
 40265 <at> debbugs.gnu.org
Subject: Re: [bug#40265] [PATCH] gnu: python-intervaltree: Update to 3.0.2.
Date: Wed, 1 Apr 2020 08:47:51 +0300

[Message part 1 (text/plain, inline)]

On Tue, Mar 31, 2020 at 04:58:43PM +0200, Marius Bakke wrote:
> Jakub Kądziołka <kuba <at> kadziolka.net> writes:
> 
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (add-before 'check 'import-mismatch-error-workaround
> > +           (lambda _
> > +             (setenv "PY_IGNORE_IMPORTMISMATCH" "1")
> > +             #t)))))
> 
> Can you add a comment about what this does?

It seems to me there is some import mismatch and this is a workaround
for it. I assume it's related to deprecated python naming/modules and
may break on a python upgrade. IMO the phase name is descriptive enough,
and I assume if we were to remove it then it'd make a lot more sense
after seeing the error message.

> 
> Also, I guess this package should be moved out of bioinformatics.scm,
> assuming the software you are packaging is not bioinfo-related?



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 40265 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 40265 <at> debbugs.gnu.org
Cc: mbakke <at> fastmail.com, efraim <at> flashner.co.il
Subject: [PATCH v2] gnu: python-intervaltree: Update to 3.0.2.
Date: Wed,  1 Apr 2020 16:24:48 +0200

* gnu/packages/bioinformatics.scm (python-intervaltree): Update to 3.0.2.
[arguments]: Don't skip the tests, work around the problematic
sanity-check instead.
---
Thanks for your helpful comments. I have added a comment, which, in
hindsight, should've been there in the first place :D

I will defer moving the package until committing the new dependent
(pwntools, #40265), as this is best done in a separate commit anyway.

 gnu/packages/bioinformatics.scm | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index d69c2aea63..943369b275 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2019 Brian Leung <bkleung89 <at> gmail.com>
 ;;; Copyright © 2019 Brett Gilio <brettg <at> gnu.org>
 ;;; Copyright © 2020 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
+;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -13552,17 +13553,27 @@ allowing the insertion of arbitrary types into the tree.")
 (define-public python-intervaltree
   (package
     (name "python-intervaltree")
-    (version "2.1.0")
+    (version "3.0.2")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "intervaltree" version))
        (sha256
         (base32
-         "02w191m9zxkcjqr1kv2slxvhymwhj3jnsyy3a28b837pi15q19dc"))))
+         "0wz234g6irlm4hivs2qzmnywk0ss06ckagwh15nflkyb3p462kyb"))))
     (build-system python-build-system)
-    ;; FIXME: error when collecting tests
-    (arguments '(#:tests? #f))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; pytest seems to have a check to make sure the user is testing
+         ;; their checked-out code and not an installed, potentially
+         ;; out-of-date copy. This is harmless here, since we just installed
+         ;; the package, so we disable the check to avoid skipping tests
+         ;; entirely.
+         (add-before 'check 'import-mismatch-error-workaround
+           (lambda _
+             (setenv "PY_IGNORE_IMPORTMISMATCH" "1")
+             #t)))))
     (propagated-inputs
      `(("python-sortedcontainers" ,python-sortedcontainers)))
     (native-inputs
-- 
2.26.0

Message #17 received at 40265 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jakub Kądziołka <kuba <at> kadziolka.net>,
 40265 <at> debbugs.gnu.org
Cc: efraim <at> flashner.co.il
Subject: Re: [PATCH v2] gnu: python-intervaltree: Update to 3.0.2.
Date: Thu, 02 Apr 2020 17:54:14 +0200

[Message part 1 (text/plain, inline)]

Jakub Kądziołka <kuba <at> kadziolka.net> writes:

> * gnu/packages/bioinformatics.scm (python-intervaltree): Update to 3.0.2.
> [arguments]: Don't skip the tests, work around the problematic
> sanity-check instead.

LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 40265-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: efraim <at> flashner.co.il, 40265-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: python-intervaltree: Update to 3.0.2.
Date: Sun, 5 Apr 2020 20:44:48 +0200

[Message part 1 (text/plain, inline)]

On Thu, Apr 02, 2020 at 05:54:14PM +0200, Marius Bakke wrote:
> Jakub Kądziołka <kuba <at> kadziolka.net> writes:
> 
> > * gnu/packages/bioinformatics.scm (python-intervaltree): Update to 3.0.2.
> > [arguments]: Don't skip the tests, work around the problematic
> > sanity-check instead.
> 
> LGTM.

Thanks! Pushed as 7fe746e071e3177e76dad9e2bcd1d53e87187f1a.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.