Received: (at 40267) by debbugs.gnu.org; 30 Mar 2020 02:35:38 +0000 From kuba@HIDDEN Sun Mar 29 11:32:50 2020 Received: from pat.zlotemysli.pl ([37.59.186.212]:46460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kuba@HIDDEN>) id 1jIZve-000578-5E for 40267 <at> debbugs.gnu.org; Sun, 29 Mar 2020 11:32:50 -0400 Received: (qmail 25138 invoked by uid 1009); 29 Mar 2020 17:32:48 +0200 Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat (envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25765. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.023209 secs); 29 Mar 2020 15:32:48 -0000 Received: from unknown (HELO gravity) (kuba@HIDDEN@188.123.215.55) by pat.zlotemysli.pl with SMTP; 29 Mar 2020 17:32:48 +0200 Date: Sun, 29 Mar 2020 17:32:46 +0200 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN> To: Leo Famulari <leo@HIDDEN> Cc: 40267 <at> debbugs.gnu.org Subject: Re: [bug#40267] [PATCH 2/2] gnu: Add python-pwntools. Message-ID: <20200329153246.prmtftsaburxt4tt@gravity> References: <20200328005052.22846-1-kuba@HIDDEN> <20200328005345.24506-1-kuba@HIDDEN> <20200329025615.GA16918@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sexsfyzgwa7epi6n" Content-Disposition: inline In-Reply-To: <20200329025615.GA16918@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40267 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> X-List-Received-Date: Sun, 29 Mar 2020 15:32:50 -0000 --sexsfyzgwa7epi6n Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 28, 2020 at 10:56:15PM -0400, Leo Famulari wrote: > On Sat, Mar 28, 2020 at 01:53:45AM +0100, Jakub K=C4=85dzio=C5=82ka wrote: > > * gnu/packages/cybersecurity.scm (python-pwntools): New variable. > > + (propagated-inputs >=20 > It would be nice to sort these, especially if the package might grow new > dependencies later. The current order is copied from setup.py in the package, as I felt it was easier to compare it that way, but I can sort them if that's preferred. > > + (license (list license:expat license:bsd-2 license:gpl2+)))) >=20 > I looked it up; the package is overall MIT/Expat licensed, but a few > components use other licenses. It helpful to list the files with the > other licenses, or to say where to look up the info with a comment like > "See LICENSE-pwntools.txt in the source distribution." Ok, I added your suggested comment locally. --sexsfyzgwa7epi6n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl6Av5YACgkQ4xWnWEYT FWT0FQ/+KCI7a/IX8tuJGmJh3Dy2j41V9w/WE0HyHltpYgGSBXGlfWmdeIE+j1sP 4B1DrS0DN1aZKkv8T+1dnupbuCBI65xD2xYwZejXD5QyV2ZRW4A+SpmcUtCeJykY q88x7/4jeOhvWeiham44wZEO58ZzdCTz/V73eSA9eCMLwB8zfz8N9VaWG4lE+mEl yQ7sWpYhMb/uHKwWKU3i4nXTK8KCLQe0OffG22UWHP5+5YGgRowdA6y1Zs4u3IhD IjYqltZhexKZSAiIzUFx+/mAbxfiI5vFaQ58j+zZuJrZMwLgtNg5e5x42Ja4lQHD 4gug0uXMa90uAsYhwjS3ISC32QmwpP+eFnOfPVsNTyXODpY0jiRoQm80as+GmGy9 8tR7Fh8eOhEdlHmlC50x85yLyIUxnITxAMFq/sIFbM9tdinoCirPP9X/xMQEVXp9 dgfqAPDJ+ZYhdc4wNDplwhMFo9zvqQ8eXw/D1wq7XfWANDC7rtS8KjtKHX2Yj+i9 0wLXSiqGeH+FtxOMgaPBAeT0p3IpnDRnSTVw099bQyIwlzDQjAZounLnv7M6CFlV c3TTTlJodHVkKN69JCcVChzhkyZDa6L8GG4IXIbE+JcbH2mb20IClkHHT3LA9qDW Sb+N5GwvRCySMfFLLFXHJWXXCNKH8uVMEDJteatyQwXZeKwN5xs= =87PL -----END PGP SIGNATURE----- --sexsfyzgwa7epi6n--
guix-patches@HIDDEN:bug#40267; Package guix-patches.
Full text available.
Received: (at 40267) by debbugs.gnu.org; 30 Mar 2020 02:35:37 +0000
From kuba@HIDDEN Sun Mar 29 08:43:56 2020
Received: from pat.zlotemysli.pl ([37.59.186.212]:51142)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <kuba@HIDDEN>) id 1jIXIB-0000JZ-0z
for 40267 <at> debbugs.gnu.org; Sun, 29 Mar 2020 08:43:56 -0400
Received: (qmail 537 invoked by uid 1009); 29 Mar 2020 14:43:53 +0200
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
(envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st
(clamdscan: 0.98.6/25765. spamassassin: 3.4.0. perlscan: 2.08st.
Clear:RC:1(188.123.215.55):.
Processed in 0.030789 secs); 29 Mar 2020 12:43:53 -0000
Received: from unknown (HELO gravity) (kuba@HIDDEN@188.123.215.55)
by pat.zlotemysli.pl with SMTP; 29 Mar 2020 14:43:52 +0200
Date: Sun, 29 Mar 2020 14:43:51 +0200
From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN>
To: Leo Famulari <leo@HIDDEN>
Cc: 40267 <at> debbugs.gnu.org
Subject: Re: [bug#40267] [PATCH 1/2] gnu: Add unicorn.
Message-ID: <20200329124351.dckxah33q6ajb6z2@gravity>
References: <20200328005052.22846-1-kuba@HIDDEN>
<20200329034811.GB16918@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="vzywwqkch572k4rq"
Content-Disposition: inline
In-Reply-To: <20200329034811.GB16918@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 40267
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Mar 2020 12:43:56 -0000
--vzywwqkch572k4rq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Mar 28, 2020 at 11:48:11PM -0400, Leo Famulari wrote:
> On Sat, Mar 28, 2020 at 01:50:52AM +0100, Jakub K=C4=85dzio=C5=82ka wrote:
> > If I package a -rc version, should it have a -next suffix in its name
> > even though the "stable" version isn't packaged?
>=20
> I think it's best to just call it unicorn. The version says -rc and we
> mention it in the synopsis and description. And it's useful under the
> hood for guix lint to match the upstream name.
Fair enough.
> > Maybe I should also package the non-rc unicorn? The test suite for that
> > version fails to compile, so it's not entirely trivial.
>=20
> Is the previous release useful?
As far as I am aware, the non-rc release is not useful beyond avoiding
any potential uneasyness about running -rc releases ;)
> We normally don't package betas or
> release candidates... it depends. Do you have an idea of the release
> timeline?
Sadly, I have no idea.
> Do you think upstream would mind if we packaged the RC?
I don't think so? As a datapoint, FreeBSD packages the -rc.
> > + ;; NOTE: unicorn ships a bundled QEMU, but with custom modificatio=
ns.
>=20
> Can you add more detail to this comment? Is it just a patch on a QEMU
> tarball or is this not really QEMU anymore?
The documentation suggests the changes go quite deep:
| Internally, Unicorn reuses the CPU emulation component of QEMU as its
| core (with quite a lot of changes to adapt to our design).
What do you think about a comment like this?
;; NOTE: unicorn ships a bundled QEMU, but heavily modified.
> > + (add-after 'unpack 'install-bindings-to-python-output
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + ;; python-build-system will build the bindings and instal=
l them to
> > + ;; the "out" output, so change the build-internal names o=
f the
> > + ;; outputs.
> > + (set-car! (assoc "out" outputs) "lib")
> > + (set-car! (assoc "python" outputs) "out")
> > + #t))
>=20
> I would wait for advice here. The manual requests we write everything in
> a functional style. But I don't know of another way to make
> python-build-system install things to alternate outputs without changing
> the build system or replacing the install phase. It would be nice to
> have a parameter for this somewhere...
Yeah, it's not the nicest thing. I think I'll submit a patch to c-u that
would add such a parameter (does #:python-output sound good?), and then come
back here when it lands. Would this imperative hack be ok as a temporary so=
lution?
> > + (add-before 'check 'check-library
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + ;; TODO: running the tests on non-x86 requires a cross-bi=
nutils
> > + ;; with x86 as target.
> > + ,@(if (member (%current-system) '("x86_64-linux" "i686-li=
nux"))
>=20
> I think the 'when' procedure is more clear than 'if' in cases where the
> else branch is empty.
The issue is that the else branch contains '(), and is not itself empty.
Do you happen to know how to get the value of (%current-system)
build-side?
Thanks for your review!
--vzywwqkch572k4rq
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl6AmAEACgkQ4xWnWEYT
FWSgFhAAyDaaXmj8Js9BvgjvinyLCQRrB0CVull04a2pIT7O527tsxxlUK3uRM0U
WIbLEovk/5dkWILIOkDPKc5/rSQM7tO+xjya6fJCT5Y6i6M0plurrtUKrBnAOdUq
EgvjWYfGeOOYnoM5+v86RMSdy/4fRe0pogSQ8hlhsQmfpA0d3m6FnWKExxp97ya+
/SdXp2SQcGV6zJAfa4s+PAqxrPJSEJqOdTS5yY9AGb17sSm/PmsGxaKhtnVtuRS9
Igr9VD4ljfuzRZx9qreg5nwxqZ0hwXqjRaiIPen/CHB+HSqs8p4eOvl9jHAC5XQt
oVr0NdB3Fh3Z7jLNhWpWfYENzp72baQftMopXPTM7mBMje75x+bBzr6UZXshnRzU
qFG3f+iW2PiAjPGKPrJnLNVJVP84IA09HTdRKxE/OhCwNQ8cMrK5+gCsPJZ4QSB+
+X0F6/QgCuJUcRE3nMz4vrArFw/t/KDGmBxGGEe6pN2yKZx3lC0Stk4W9L2blyrw
5IfEmkPq3pl1fDWLUKw+H2eriA9dHFaWKsl7nXGBtT7giylr0OVTNVzZp0M8AWcB
DusOLuCogkKAvs5inBaP0InDttBYN2vZNW27Dbhqz2O4AFMx6p3GD4NxXecilGVQ
5ucITT19Nf/+Y5yXd8PShcIDwEnrJ43YAsUK6RJlySjwYGDfw9Y=
=0iAC
-----END PGP SIGNATURE-----
--vzywwqkch572k4rq--
guix-patches@HIDDEN:bug#40267; Package guix-patches.
Full text available.
Received: (at 40267) by debbugs.gnu.org; 30 Mar 2020 02:35:35 +0000
From leo@HIDDEN Sat Mar 28 23:48:21 2020
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:37107)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <leo@HIDDEN>) id 1jIOvs-0001Qh-Sd
for 40267 <at> debbugs.gnu.org; Sat, 28 Mar 2020 23:48:21 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.west.internal (Postfix) with ESMTP id 93D0A5E7;
Sat, 28 Mar 2020 23:48:14 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Sat, 28 Mar 2020 23:48:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
bh=b//v4HhoTz5ydRpfTR+M2Tbm/R3gs6EF1h48TEBnM3M=; b=pt+QfEl7DI5n
hw9lJVw/toaN2jsRcOXhgjxKgEx1OZWEu5Vs0mxzBPRt52ul50V6YRB1+St7Q//K
AMTcy9S08X4XeSaLviXEyCpdNHmiS0l8A/6681WCRU0sSyx+e7mOfJfPDdkkibN6
vXtH8wsyTtvz/IOigMfngL8AwNbAcig=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=b//v4HhoTz5ydRpfTR+M2Tbm/R3gs6EF1h48TEBnM
3M=; b=Ptv9BL1yEZUocck0bqXiw8u7NXnjUm9WL9aa3zjnzbYHDAObiAqXW97YO
DomykMxVG8pBZLZZu3iy+KubvPWgTrM9SxSXjW+u+2UbEAnqZadw0+rwQuRaqD5c
H5GVxdOKGat1fLzVNiJLbKmw6H7XH8D3X1d2blpeb+9YbCeAnxChR2V26+vITldc
47lJ1Wqodt2hRFxFHIwiopooc9zIXn70RhpU9HZYeyuJydhz08uAQAkAm50nIwNv
8AtiAqZKAgPS3yrMVrVr1NBUp0GpgJ6xpqcHYcnx5rO4RTeDVvFWvpq4q+FeQuh8
6uD2gqKro/BSh4cvLBq55i1bZAY1w==
X-ME-Sender: <xms:fRqAXrnkOhS4_vDNGTdMKs90T-3nWeuX6ddX58dTo_QNPMD5kvx4hw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeivddgieegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjsehtke
ertddttdejnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl
rghrihdrnhgrmhgvqeenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvg
hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghr
ihdrnhgrmhgv
X-ME-Proxy: <xmx:fRqAXjGOQnA_ENRiNdQsgokQ0Zd3JYi-m0GX5pdJsk_b79AyecIoGw>
<xmx:fRqAXsp97exND5PqQVGkyICxEJM6ShE2LytCsowNsHmud8-339wTRg>
<xmx:fRqAXn4UWXFCpnVzrmpvGI0TvpLJYZOGqjZwjdfQG-RLB83SF44JJw>
<xmx:fhqAXqyACAecQVHmwqfksS_tn-Tx1iKeDta2NAyRM0AMxbaa-SSNlQ>
Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63])
by mail.messagingengine.com (Postfix) with ESMTPA id 7A29C3280059;
Sat, 28 Mar 2020 23:48:13 -0400 (EDT)
Date: Sat, 28 Mar 2020 23:48:11 -0400
From: Leo Famulari <leo@HIDDEN>
To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN>
Cc: 40267 <at> debbugs.gnu.org
Subject: Re: [bug#40267] [PATCH 1/2] gnu: Add unicorn.
Message-ID: <20200329034811.GB16918@HIDDEN>
References: <20200328005052.22846-1-kuba@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200328005052.22846-1-kuba@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 40267
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Mar 2020 03:48:21 -0000
On Sat, Mar 28, 2020 at 01:50:52AM +0100, Jakub Kądziołka wrote:
> * gnu/packages/emulators.scm (unicorn-next): New variable.
Sounds like a cool package!
> If I package a -rc version, should it have a -next suffix in its name
> even though the "stable" version isn't packaged?
I think it's best to just call it unicorn. The version says -rc and we
mention it in the synopsis and description. And it's useful under the
hood for guix lint to match the upstream name.
> Maybe I should also package the non-rc unicorn? The test suite for that
> version fails to compile, so it's not entirely trivial.
Is the previous release useful? We normally don't package betas or
release candidates... it depends. Do you have an idea of the release
timeline? Do you think upstream would mind if we packaged the RC?
> + ;; NOTE: unicorn ships a bundled QEMU, but with custom modifications.
Can you add more detail to this comment? Is it just a patch on a QEMU
tarball or is this not really QEMU anymore?
> + ;; The main library is not written in Python, but the build process has
> + ;; little in common with any defined build system, so we might as well
> + ;; build on top of python-build-system and make use of all
> + ;; the Python-specific phases that can be reused.
Okay
> + (add-after 'unpack 'install-bindings-to-python-output
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; python-build-system will build the bindings and install them to
> + ;; the "out" output, so change the build-internal names of the
> + ;; outputs.
> + (set-car! (assoc "out" outputs) "lib")
> + (set-car! (assoc "python" outputs) "out")
> + #t))
I would wait for advice here. The manual requests we write everything in
a functional style. But I don't know of another way to make
python-build-system install things to alternate outputs without changing
the build system or replacing the install phase. It would be nice to
have a parameter for this somewhere...
> + (add-before 'check 'check-library
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; TODO: running the tests on non-x86 requires a cross-binutils
> + ;; with x86 as target.
> + ,@(if (member (%current-system) '("x86_64-linux" "i686-linux"))
I think the 'when' procedure is more clear than 'if' in cases where the
else branch is empty.
guix-patches@HIDDEN:bug#40267; Package guix-patches.
Full text available.Received: (at 40267) by debbugs.gnu.org; 30 Mar 2020 02:35:35 +0000 From leo@HIDDEN Sat Mar 28 22:56:44 2020 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:50297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1jIO7w-0008Tg-1P for 40267 <at> debbugs.gnu.org; Sat, 28 Mar 2020 22:56:44 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id D33295C9; Sat, 28 Mar 2020 22:56:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 28 Mar 2020 22:56:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=L36G7hHr0x08EjiTmFYpDDuJQaq1TzEQa7Pc0bSfaTQ=; b=ZSvlMRGp8ye0 c3JJg/UIDekS2BN7cV3xAo5AJUu76eTFZZTLEKB5szxdLq3mqax6xMJFsipISOlU VdmqdPB0wDft370b7SDw9V/N283BtaYC5jiVivFyAg9/wv/sdok5v8A5OGrIZ48d lDzOLXjnLwD+7Wn3jtUvVC/AImae3TE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=L36G7hHr0x08EjiTmFYpDDuJQaq1TzEQa7Pc0bSfa TQ=; b=wEQcYn/GQADesEWQ054NjrTWGm+kR0CIwsihS224pax3uep+AyAj7ULu/ keFFYOT/Qx7AdBtGnmtDPpdnwSaszHdmJA+2+6eavjvECzmU2dyEa/2+zbYHQsgV ZOoltEeBufWnLrAHCAhF7g8Y7pxmjyQpHpgRd9nGIUjnJ5P64Y45izyY5jwwxFFE Z/Bk/op2I25ZPkNJrC2iTIaahCiUwHflGFX7u/n0NyWuX9cZFJJjewDsxE9iugxD 2Qbxb6a1EOS8OeiDHAISbme7tk9QIlfT+KEXrv5iQ3lIK222YnCg3LAoXMm7BSPi juLzZRDkseyX2gD/xTHlGNhquqNyg== X-ME-Sender: <xms:ZA6AXkRy4TaudF4v7lgMB8-W1gpGADlkNm0CMyaDiwE0HSI5S2r8Bg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeivddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjsehtke ertddttdejnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghr ihdrnhgrmhgv X-ME-Proxy: <xmx:ZA6AXictBsghRolY7cb4PviwyqDLsjSfA0H4V4YB21H48mSI4qbp3w> <xmx:ZA6AXgAY23BhlJkaj0ocHMZbMUfEIRv2AtrWh3cRPz_t99aUlr2_aQ> <xmx:ZA6AXsmXJldxOSfLspLSNH2sjvhl30UqaqeD1JIWgixLQ2Qo3lhicg> <xmx:ZQ6AXkZIvYHtPF5CpWAyJVjCV8N77JRwjDbDDFKhAkWeIgKEsx2YiQ> Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id CA14E306C7A7; Sat, 28 Mar 2020 22:56:36 -0400 (EDT) Date: Sat, 28 Mar 2020 22:56:15 -0400 From: Leo Famulari <leo@HIDDEN> To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN> Cc: 40267 <at> debbugs.gnu.org Subject: Re: [bug#40267] [PATCH 2/2] gnu: Add python-pwntools. Message-ID: <20200329025615.GA16918@HIDDEN> References: <20200328005052.22846-1-kuba@HIDDEN> <20200328005345.24506-1-kuba@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200328005345.24506-1-kuba@HIDDEN> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40267 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> X-List-Received-Date: Sun, 29 Mar 2020 02:56:44 -0000 On Sat, Mar 28, 2020 at 01:53:45AM +0100, Jakub Kądziołka wrote: > * gnu/packages/cybersecurity.scm (python-pwntools): New variable. > + (propagated-inputs It would be nice to sort these, especially if the package might grow new dependencies later. > + (license (list license:expat license:bsd-2 license:gpl2+)))) I looked it up; the package is overall MIT/Expat licensed, but a few components use other licenses. It helpful to list the files with the other licenses, or to say where to look up the info with a comment like "See LICENSE-pwntools.txt in the source distribution."
guix-patches@HIDDEN:bug#40267; Package guix-patches.
Full text available.
Received: (at 40267) by debbugs.gnu.org; 28 Mar 2020 00:53:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 27 20:53:50 2020
Received: from localhost ([127.0.0.1]:33546 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1jHzjS-0001bJ-1w
for submit <at> debbugs.gnu.org; Fri, 27 Mar 2020 20:53:50 -0400
Received: from pat.zlotemysli.pl ([37.59.186.212]:47442)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <kuba@HIDDEN>) id 1jHzjQ-0001bB-Az
for 40267 <at> debbugs.gnu.org; Fri, 27 Mar 2020 20:53:48 -0400
Received: (qmail 12181 invoked by uid 1009); 28 Mar 2020 01:53:46 +0100
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
(envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st
(clamdscan: 0.98.6/25763. spamassassin: 3.4.0. perlscan: 2.08st.
Clear:RC:1(188.123.215.55):.
Processed in 0.019527 secs); 28 Mar 2020 00:53:46 -0000
Received: from unknown (HELO localhost.localdomain)
(kuba@HIDDEN@188.123.215.55)
by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 28 Mar 2020 01:53:46 +0100
From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
To: 40267 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add python-pwntools.
Date: Sat, 28 Mar 2020 01:53:45 +0100
Message-Id: <20200328005345.24506-1-kuba@HIDDEN>
X-Mailer: git-send-email 2.26.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Qmailux-2.08st: added fake Content-Type header
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 40267
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* gnu/packages/cybersecurity.scm (python-pwntools): New variable.
---
This patch requires #40265.
gnu/packages/cybersecurity.scm | 51 +++++++++++++++++++++++++++++++++-
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/cybersecurity.scm b/gnu/packages/cybersecurity.scm
index aedac03b8a..cb9c33bae1 100644
--- a/gnu/packages/cybersecurity.scm
+++ b/gnu/packages/cybersecurity.scm
@@ -18,10 +18,17 @@
(define-module (gnu packages cybersecurity)
#:use-module (guix download)
+ #:use-module (guix git-download)
#:use-module (guix packages)
#:use-module ((guix licenses) #:prefix license:)
#:use-module (guix build-system python)
- #:use-module (gnu packages engineering))
+ #:use-module (gnu packages bioinformatics)
+ #:use-module (gnu packages emulators)
+ #:use-module (gnu packages engineering)
+ #:use-module (gnu packages python-crypto)
+ #:use-module (gnu packages python-web)
+ #:use-module (gnu packages python-xyz)
+ #:use-module (gnu packages time))
(define-public ropgadget
(package
@@ -44,3 +51,45 @@
gadgets in binaries. Some facilities are included for automatically generating
chains of gadgets to execute system calls.")
(license license:bsd-3)))
+
+(define-public python-pwntools
+ (package
+ (name "python-pwntools")
+ (version "4.0.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/Gallopsled/pwntools")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "14grsflkfpr7y3gg2lm86lfn6n40yip45n4gjz0hzi9sjalq1gr5"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:tests? #f)) ; Tests require networking and custom sshd configuration
+ (propagated-inputs
+ `(("paramiko" ,python-paramiko)
+ ("mako" ,python-mako)
+ ("pyelftools" ,python-pyelftools)
+ ("capstone" ,python-capstone)
+ ("ropgadget" ,ropgadget)
+ ("pyserial" ,python-pyserial)
+ ("requests" ,python-requests)
+ ("pygments" ,python-pygments)
+ ("pysocks" ,python-pysocks)
+ ("dateutil" ,python-dateutil)
+ ("packaging" ,python-packaging)
+ ("psutil" ,python-psutil)
+ ("intervaltree" ,python-intervaltree)
+ ("sortedcontainers" ,python-sortedcontainers)
+ ("unicorn" ,unicorn-next "python")))
+ (native-inputs
+ `(("tox" ,python-tox)))
+ (home-page "https://github.com/Gallopsled/pwntools")
+ (synopsis "CTF framework and exploit development library")
+ (description "Pwntools is a CTF framework and exploit development library.
+Written in Python, it is designed for rapid prototyping and development, and
+intended to make exploit writing as simple as possible.")
+ (license (list license:expat license:bsd-2 license:gpl2+))))
--
2.26.0
guix-patches@HIDDEN:bug#40267; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 28 Mar 2020 00:51:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 27 20:51:01 2020
Received: from localhost ([127.0.0.1]:33541 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1jHzgj-0001Vx-CJ
for submit <at> debbugs.gnu.org; Fri, 27 Mar 2020 20:51:01 -0400
Received: from lists.gnu.org ([209.51.188.17]:49177)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <kuba@HIDDEN>) id 1jHzgh-0001Vm-80
for submit <at> debbugs.gnu.org; Fri, 27 Mar 2020 20:50:59 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:42540)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <kuba@HIDDEN>) id 1jHzgf-0006YU-En
for guix-patches@HIDDEN; Fri, 27 Mar 2020 20:50:59 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE,
URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <kuba@HIDDEN>) id 1jHzgd-00074A-Mf
for guix-patches@HIDDEN; Fri, 27 Mar 2020 20:50:57 -0400
Received: from pat.zlotemysli.pl ([37.59.186.212]:34348)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <kuba@HIDDEN>) id 1jHzgd-000734-Dt
for guix-patches@HIDDEN; Fri, 27 Mar 2020 20:50:55 -0400
Received: (qmail 11701 invoked by uid 1009); 28 Mar 2020 01:50:53 +0100
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
(envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st
(clamdscan: 0.98.6/25763. spamassassin: 3.4.0. perlscan: 2.08st.
Clear:RC:1(188.123.215.55):.
Processed in 0.027054 secs); 28 Mar 2020 00:50:53 -0000
Received: from unknown (HELO localhost.localdomain)
(kuba@HIDDEN@188.123.215.55)
by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 28 Mar 2020 01:50:53 +0100
From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 1/2] gnu: Add unicorn.
Date: Sat, 28 Mar 2020 01:50:52 +0100
Message-Id: <20200328005052.22846-1-kuba@HIDDEN>
X-Mailer: git-send-email 2.26.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Qmailux-2.08st: added fake Content-Type header
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 37.59.186.212
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* gnu/packages/emulators.scm (unicorn-next): New variable.
---
If I package a -rc version, should it have a -next suffix in its name
even though the "stable" version isn't packaged?
Maybe I should also package the non-rc unicorn? The test suite for that
version fails to compile, so it's not entirely trivial.
I'd also like to bring these build phases to your attention - I feel
like they need a review the most.
gnu/packages/emulators.scm | 110 ++++++++++++++++++++++++++++++++++++-
1 file changed, 109 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 3591b1740c..5b5e1359e3 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -44,6 +44,7 @@
#:use-module (gnu packages boost)
#:use-module (gnu packages backup)
#:use-module (gnu packages cdrom)
+ #:use-module (gnu packages check)
#:use-module (gnu packages compression)
#:use-module (gnu packages curl)
#:use-module (gnu packages elf)
@@ -88,7 +89,8 @@
#:use-module (gnu packages web)
#:use-module (guix build-system cmake)
#:use-module (guix build-system glib-or-gtk)
- #:use-module (guix build-system gnu))
+ #:use-module (guix build-system gnu)
+ #:use-module (guix build-system python))
(define-public desmume
(package
@@ -1628,3 +1630,109 @@ derived from Gens. Project goals include clean source code, combined features
from various forks of Gens, and improved platform portability.")
(supported-systems '("i686-linux" "x86_64-linux"))
(license license:gpl2+)))
+
+;; python-pwntools requires a -rc release of unicorn
+(define-public unicorn-next
+ (package
+ (name "unicorn-next")
+ (version "1.0.2-rc2")
+ ;; NOTE: unicorn ships a bundled QEMU, but with custom modifications.
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/unicorn-engine/unicorn")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0v5sc8sniv2w0bki1f7n3pgsk17y7hggw55fvkjzk2sv8z8w4bsj"))))
+ (outputs '("out" "python"))
+ ;; The main library is not written in Python, but the build process has
+ ;; little in common with any defined build system, so we might as well
+ ;; build on top of python-build-system and make use of all
+ ;; the Python-specific phases that can be reused.
+ (build-system python-build-system)
+ (arguments
+ `(#:modules ((srfi srfi-26)
+ (guix build python-build-system)
+ (guix build utils))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'install-bindings-to-python-output
+ (lambda* (#:key outputs #:allow-other-keys)
+ ;; python-build-system will build the bindings and install them to
+ ;; the "out" output, so change the build-internal names of the
+ ;; outputs.
+ (set-car! (assoc "out" outputs) "lib")
+ (set-car! (assoc "python" outputs) "out")
+ #t))
+ (add-before 'build 'build-library
+ (lambda* (#:key inputs #:allow-other-keys)
+ (invoke "make"
+ "-j" (number->string (parallel-job-count))
+ (string-append
+ "UNICORN_QEMU_FLAGS=--python="
+ (assoc-ref inputs "python-for-qemu")
+ "/bin/python2")
+ "UNICORN_STATIC=no"
+ "CC=gcc")))
+ (add-after 'build-library 'install-library
+ (lambda* (#:key outputs #:allow-other-keys)
+ (invoke "make" "install"
+ "UNICORN_STATIC=no"
+ (string-append
+ "PREFIX="
+ (assoc-ref outputs "lib")))))
+ (add-before 'build 'prepare-bindings
+ (lambda* (#:key outputs #:allow-other-keys)
+ (chdir "bindings/python")
+ ;; Set this environment variable so that the Python bindings
+ ;; don't build their own copy of the shared object, but use
+ ;; a dummy value such that the bindings test suite uses the
+ ;; same mechanism for loading the library as any other user.
+ (setenv "LIBUNICORN_PATH" "1")
+ (substitute* "unicorn/unicorn.py"
+ (("_path_list = \\[.*")
+ (string-append
+ "_path_list = [\""
+ (assoc-ref outputs "lib")
+ ;; eat the rest of the list
+ "/lib\"] + 0*[")))
+ #t))
+ (add-before 'check 'check-library
+ (lambda* (#:key outputs #:allow-other-keys)
+ ;; TODO: running the tests on non-x86 requires a cross-binutils
+ ;; with x86 as target.
+ ,@(if (member (%current-system) '("x86_64-linux" "i686-linux"))
+ '((for-each
+ (lambda (suite)
+ (with-directory-excursion
+ (string-append "../../tests/" suite)
+ (invoke "make" "test" "CC=gcc")))
+ '("unit" "regress")))
+ '())
+ #t))
+ (add-after 'install 'install-samples
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((python-samples (find-files "." "sample_.*"))
+ (c-samples (find-files "../../samples" ".*\\.c"))
+ (python-docdir
+ (string-append (assoc-ref outputs "out")
+ "/share/doc/unicorn/samples"))
+ (c-docdir
+ (string-append (assoc-ref outputs "lib")
+ "/share/doc/unicorn/samples")))
+ (for-each (cut install-file <> c-docdir) c-samples)
+ (for-each (cut install-file <> python-docdir) python-samples)
+ #t))))))
+ (native-inputs
+ `(("cmocka" ,cmocka)
+ ("python-for-qemu" ,python-2)
+ ("hexdump-for-tests" ,util-linux)))
+ (home-page "http://www.unicorn-engine.org")
+ (synopsis "Unicorn CPU emulator framework")
+ (description
+ "Unicorn is a lightweight, multi-platform, multi-architecture CPU emulator
+framework based on QEMU.")
+ (license license:gpl2+)))
--
2.26.0
Jakub Kądziołka <kuba@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#40267; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.