GNU bug report logs - #40270
[PATCH 1/2] gnu: Add python-flask-markdown.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40270 in the body.
You can then email your comments to 40270 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pinoaffe <at> airmail.cc
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: Add python-flask-markdown.
Date: Sat, 28 Mar 2020 09:33:16 +0000

* gnu/packages/python-web.scm (python-flask-markdown, 
python2-flask-markdown): New variables.
---
 gnu/packages/python-web.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b02ffd5f58..db66f1ed4d 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -470,6 +470,36 @@ both of which are installed automatically if you 
install this library.")
 (define-public python2-flask-babel
   (package-with-python2 python-flask-babel))

+(define-public python-flask-markdown
+  (package
+    (name "python-flask-markdown")
+    (version "0.3")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "Flask-Markdown" version))
+        (sha256
+          (base32
+            "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
+    (build-system python-build-system)
+    (arguments
+       `(#:tests? #f))
+    (propagated-inputs
+      `(("python-markdown" ,python-markdown)
+        ("python-flask" ,python-flask)))
+    (native-inputs
+      `(("python-nose" ,python-nose)))
+    (home-page
+      "http://github.com/dcolish/flask-markdown")
+    (synopsis
+      "Small extension to make using markdown in flask easy")
+    (description
+      "Small extension to make using markdown in flask easy")
+    (license license:bsd-3)))
+
+(define-public python2-flask-markdown
+  (package-with-python2 python-flask-markdown))
+
 (define-public python-html5lib
   (package
     (name "python-html5lib")
-- 
2.25.2

Message #8 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: pinoaffe <at> airmail.cc
To: 40270 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add python-flask-session.
Date: Sat, 28 Mar 2020 09:36:57 +0000

* gnu/packages/python-web.scm (python-flask-session, 
python2-flask-session): New variables.
---
 gnu/packages/python-web.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index db66f1ed4d..acca981eee 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -500,6 +500,33 @@ both of which are installed automatically if you 
install this library.")
 (define-public python2-flask-markdown
   (package-with-python2 python-flask-markdown))

+(define-public python-flask-session
+  (package
+    (name "python-flask-session")
+    (version "0.3.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "Flask-Session" version))
+        (sha256
+          (base32
+            "0cd7h5c236m6smyixnyfrks4spsqp9d65ndk4p400zr8qgh2f753"))))
+    (build-system python-build-system)
+    (arguments
+       `(#:tests? #f))
+    (propagated-inputs
+      `(("python-flask" ,python-flask)))
+    (home-page
+      "https://github.com/fengsp/flask-session")
+    (synopsis
+      "Adds server-side session support to your Flask application")
+    (description
+      "Adds server-side session support to your Flask application")
+    (license license:bsd-3)))
+
+(define-public python2-flask-session
+  (package-with-python2 python-flask-session))
+
 (define-public python-html5lib
   (package
     (name "python-html5lib")
-- 
2.25.2

Message #13 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: pinoaffe <at> airmail.cc, 40270 <at> debbugs.gnu.org
Subject: Re: [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown.
Date: Sun, 29 Mar 2020 22:10:02 +0200

[Message part 1 (text/plain, inline)]

pinoaffe <at> airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-markdown, 
> python2-flask-markdown): New variables.

Note: I merged your previous bug report that adds this package (#40165)
with this bug (#40270).  The comments still stand however!  :-)

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: pinoaffe <at> airmail.cc, 40270 <at> debbugs.gnu.org
Subject: Re: [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
Date: Sun, 29 Mar 2020 22:11:40 +0200

[Message part 1 (text/plain, inline)]

pinoaffe <at> airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-session, 
> python2-flask-session): New variables.

I have the same comments on this package as the python-flask-markdown
patch.  Can you send an updated patch?

Also the python2 variants can be omitted unless you plan on using them.
Python 2 is deprecated, so we do not add new Python 2 packages unless
required by something else.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: pinoaffe <at> airmail.cc
Cc: 40270 <at> debbugs.gnu.org
Subject: Re: [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
Date: Sat, 21 Nov 2020 09:15:08 +0000

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> pinoaffe <at> airmail.cc writes:
>
>> * gnu/packages/python-web.scm (python-flask-session,
>> python2-flask-session): New variables.
>
> I have the same comments on this package as the python-flask-markdown
> patch.  Can you send an updated patch?
>
> Also the python2 variants can be omitted unless you plan on using them.
> Python 2 is deprecated, so we do not add new Python 2 packages unless
> required by something else.

It's been a few months, are these patches still relevant?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: pinoaffe <at> airmail.cc
To: Christopher Baines <mail <at> cbaines.net>
Cc: 40270 <at> debbugs.gnu.org
Subject: Re: [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
Date: Sun, 22 Nov 2020 17:49:44 +0000

thanks for the reminder,
I'd completely forgotten about these patches,
will send new ones with the changes you suggested applied in a minute

On 2020-11-21 09:15, Christopher Baines wrote:
> Marius Bakke <mbakke <at> fastmail.com> writes:
> 
>> pinoaffe <at> airmail.cc writes:
>> 
>>> * gnu/packages/python-web.scm (python-flask-session,
>>> python2-flask-session): New variables.
>> 
>> I have the same comments on this package as the python-flask-markdown
>> patch.  Can you send an updated patch?
>> 
>> Also the python2 variants can be omitted unless you plan on using 
>> them.
>> Python 2 is deprecated, so we do not add new Python 2 packages unless
>> required by something else.
> 
> It's been a few months, are these patches still relevant?
> 
> Thanks,
> 
> Chris

Message #25 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: pinoaffe <at> airmail.cc
To: 40270 <at> debbugs.gnu.org
Cc: mail <at> cbaines.net
Subject: [PATCH 1/2] gnu: Add python-flask-markdown.
Date: Sun, 22 Nov 2020 17:52:05 +0000

* gnu/packages/python-web.scm (python-flask-markdown): New variable.
---
 gnu/packages/python-web.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b02ffd5f58..baf24d3849 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -470,6 +470,34 @@ both of which are installed automatically if you 
install this library.")
 (define-public python2-flask-babel
   (package-with-python2 python-flask-babel))

+(define-public python-flask-markdown
+  (package
+    (name "python-flask-markdown")
+    (version "0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-Markdown" version))
+       (sha256
+        (base32
+         "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;tests seem to be incompatible with latest python
+    (propagated-inputs
+     `(("python-markdown" ,python-markdown)
+       ("python-flask" ,python-flask)))
+    (native-inputs
+     `(("python-nose" ,python-nose)))
+    (home-page
+     "http://github.com/dcolish/flask-markdown")
+    (synopsis
+     "Small extension to make using Markdown in Flask easy")
+    (description
+     "Small extension to make using Markdown in Flask easy.  Supports
+several extensions for Markdown and integrates into Jinja2 by 
default.")
+    (license license:bsd-3)))
+
 (define-public python-html5lib
   (package
     (name "python-html5lib")
-- 
2.29.2

Message #31 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: pinoaffe <at> airmail.cc
To: 40270 <at> debbugs.gnu.org
Cc: mail <at> cbaines.net
Subject: [PATCH 2/2] gnu: Add python-flask-session.
Date: Sun, 22 Nov 2020 19:15:13 +0000

* gnu/packages/python-web.scm (python-flask-session, 
python2-flask-session): New variables.
---
 gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index baf24d3849..4ad81ef6e5 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -498,6 +498,31 @@ both of which are installed automatically if you 
install this library.")
 several extensions for Markdown and integrates into Jinja2 by 
default.")
     (license license:bsd-3)))

+(define-public python-flask-session
+  (package
+    (name "python-flask-session")
+    (version "0.3.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-Session" version))
+       (sha256
+        (base32
+         "0cd7h5c236m6smyixnyfrks4spsqp9d65ndk4p400zr8qgh2f753"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;tests require the various storage backends to be 
present
+    (propagated-inputs
+     `(("python-flask" ,python-flask)))
+    (home-page
+     "https://github.com/fengsp/flask-session")
+    (synopsis
+     "Adds server-side session support to your Flask application")
+    (description
+     "Adds server-side support for secure sessions to your Flask 
application,
+and supports a variety of different backends for session storage.")
+    (license license:bsd-3)))
+
 (define-public python-html5lib
   (package
     (name "python-html5lib")
-- 
2.29.2

Message #34 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: pinoaffe <at> airmail.cc
Cc: 40270 <at> debbugs.gnu.org
Subject: Re: [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
Date: Sat, 28 Nov 2020 12:33:41 +0000

[Message part 1 (text/plain, inline)]

pinoaffe <at> airmail.cc writes:

> thanks for the reminder,
> I'd completely forgotten about these patches,
> will send new ones with the changes you suggested applied in a minute

Awesome, thanks, I'll have a look at the new patches momentarily.

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: pinoaffe <at> airmail.cc
Cc: 40270 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add python-flask-markdown.
Date: Sat, 28 Nov 2020 13:13:41 +0000

[Message part 1 (text/plain, inline)]

pinoaffe <at> airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-markdown): New variable.
> ---
>  gnu/packages/python-web.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index b02ffd5f58..baf24d3849 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -470,6 +470,34 @@ both of which are installed automatically if you
> install this library.")
>  (define-public python2-flask-babel
>    (package-with-python2 python-flask-babel))
>
> +(define-public python-flask-markdown
> +  (package
> +    (name "python-flask-markdown")
> +    (version "0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Flask-Markdown" version))
> +       (sha256
> +        (base32
> +         "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;tests seem to be incompatible with latest python
> +    (propagated-inputs
> +     `(("python-markdown" ,python-markdown)
> +       ("python-flask" ,python-flask)))
> +    (native-inputs
> +     `(("python-nose" ,python-nose)))
> +    (home-page
> +     "http://github.com/dcolish/flask-markdown")

I'm guessing the linter might have spotted this, but I've changed it to
https:// as that's a better default.

> +    (synopsis
> +     "Small extension to make using Markdown in Flask easy")
> +    (description
> +     "Small extension to make using Markdown in Flask easy.  Supports
> +several extensions for Markdown and integrates into Jinja2 by
> default.")

The description is just repeating the synopsis at the start, I rewrote
this to:

Flask-Markdown supports several extensions for Markdown and integrates
into Jinja2 by default.

> +    (license license:bsd-3)))
> +
>  (define-public python-html5lib
>    (package
>      (name "python-html5lib")

[signature.asc (application/pgp-signature, inline)]

Message #40 received at 40270 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: pinoaffe <at> airmail.cc
Cc: 40270 <at> debbugs.gnu.org
Subject: Re: [PATCH 2/2] gnu: Add python-flask-session.
Date: Sat, 28 Nov 2020 13:16:12 +0000

[Message part 1 (text/plain, inline)]

pinoaffe <at> airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-session,
>   python2-flask-session): New variables.
> ---
>  gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index baf24d3849..4ad81ef6e5 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -498,6 +498,31 @@ both of which are installed automatically if you
> install this library.")
>  several extensions for Markdown and integrates into Jinja2 by
>  default.")
>      (license license:bsd-3)))
>
> +(define-public python-flask-session
> +  (package
> +    (name "python-flask-session")
> +    (version "0.3.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Flask-Session" version))
> +       (sha256
> +        (base32
> +         "0cd7h5c236m6smyixnyfrks4spsqp9d65ndk4p400zr8qgh2f753"))))

0.3.2 has been released, so I updated to that.

> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;tests require the various storage backends to
> be present
> +    (propagated-inputs
> +     `(("python-flask" ,python-flask)))
> +    (home-page
> +     "https://github.com/fengsp/flask-session")
> +    (synopsis
> +     "Adds server-side session support to your Flask application")
> +    (description
> +     "Adds server-side support for secure sessions to your Flask
> application,
> +and supports a variety of different backends for session storage.")

Similar to python-flask-markdown, I tweaked the description here so it's
less repetitive.

Flask-Session is an extension for Flask that adds support for
Server-side sessions, with a variety of different backends for session
storage.

> +    (license license:bsd-3)))
> +
>  (define-public python-html5lib
>    (package
>      (name "python-html5lib")

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 40270-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: pinoaffe <at> airmail.cc
Cc: 40270-done <at> debbugs.gnu.org
Subject: Re: [PATCH 2/2] gnu: Add python-flask-session.
Date: Sat, 28 Nov 2020 13:17:17 +0000

[Message part 1 (text/plain, inline)]

I've pushed these as 9e2669690c80dc00973859edf732964f0a514d7b now, so
closing.

Thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.