GNU bug report logs - #40281
[PATCH] gnu: Add mtpaint

Previous Next

Package: guix-patches;

Reported by: R Veera Kumar <vkor <at> vkten.in>

Date: Sun, 29 Mar 2020 17:22:02 UTC

Severity: normal

Tags: patch

Done: Danny Milosavljevic <dannym <at> scratchpost.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40281 in the body.
You can then email your comments to 40281 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40281; Package guix-patches. (Sun, 29 Mar 2020 17:22:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to R Veera Kumar <vkor <at> vkten.in>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 29 Mar 2020 17:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: R Veera Kumar <vkor <at> vkten.in>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add mtpaint
Date: Sun, 29 Mar 2020 22:51:36 +0530
Mtpaint is a graphic editing program which uses the GTK+ toolkit.
Create pixel art and manipulate digital photos. It can create and
edit indexed pallete or 24bit RGB images, offers basic painting
and palette manipulation tools.

Signed-off-by: R Veera Kumar <vkor <at> vkten.in>
---
 gnu/packages/image.scm | 49 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index b665740ca2..c4b979a775 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -45,6 +45,7 @@
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages curl)
@@ -1983,3 +1984,51 @@ AOM, including with alpha.")
     (home-page "https://github.com/AOMediaCodec/libavif")
     (license (list license:bsd-2    ; libavif itself
                    license:expat)))) ; cJSON in the test suite
+
+(define-public mtpaint
+  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
+        (revision "1"))
+    (package
+      (name "mtpaint")
+      (version (git-version "3.49.25" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/wjaguar/mtPaint/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
+      (build-system gnu-build-system)
+      (native-inputs
+       `(("which" ,which)
+         ("pkg-config" ,pkg-config)
+         ("perl" ,perl)))
+      (inputs
+       `(("imlib2" ,imlib2)
+         ("libtiff" ,libtiff)
+         ("libpng" ,libpng)
+         ("libungif", libungif)
+         ("libjpeg", libjpeg)
+         ("libwebp" ,libwebp)
+         ("openjpeg" ,openjpeg)
+         ("lcms" ,lcms)
+         ("zlib", zlib)
+         ("glib" ,glib)
+         ("gtk+" ,gtk+-2)
+         ("gettext" ,gettext-minimal)))
+      (arguments
+       `(#:configure-flags
+         (list
+          "intl") ;; internationalized support
+         ;; no make check
+         #:tests? #f))
+      (home-page "http://mtpaint.sourceforge.net/")
+      (synopsis "Create pixel art and manipulate digital photos")
+      (description
+       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
+It can create and edit indexed pallete or 24bit RGB images, offers basic
+painting and palette manipulation tools.  It also handles JPEG, JPEG2000,
+GIF, TIFF, WEBP, BMP, PNG, XPM files.")
+      (license license:gpl3+))))
-- 
2.26.0





Information forwarded to guix-patches <at> gnu.org:
bug#40281; Package guix-patches. (Tue, 31 Mar 2020 09:41:02 GMT) Full text and rfc822 format available.

Message #8 received at 40281 <at> debbugs.gnu.org (full text, mbox):

From: R Veera Kumar <vkor <at> vkten.in>
To: 40281 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add mtpaint.
Date: Tue, 31 Mar 2020 15:09:56 +0530
* gnu/packages/image.scm (mtpaint): New variable.

Signed-off-by: R Veera Kumar <vkor <at> vkten.in>
---
Changes in v2:
 - Commit msg according to changelog format
 - put gettext in native-inputs
---
 gnu/packages/image.scm | 50 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index cc9cf8cd6a..4946f5a500 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2018 Alex Vong <alexvong1995 <at> gmail.com>
 ;;; Copyright © 2018 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
+;;; Copyright © 2020 R Veera Kumar <vkor <at> vkten.in>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -45,6 +46,7 @@
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages curl)
@@ -1979,3 +1981,51 @@ AOM, including with alpha.")
     (home-page "https://github.com/AOMediaCodec/libavif")
     (license (list license:bsd-2    ; libavif itself
                    license:expat)))) ; cJSON in the test suite
+
+(define-public mtpaint
+  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
+        (revision "1"))
+    (package
+      (name "mtpaint")
+      (version (git-version "3.49.25" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/wjaguar/mtPaint/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
+      (build-system gnu-build-system)
+      (native-inputs
+       `(("gettext" ,gettext-minimal)
+         ("pkg-config" ,pkg-config)
+         ("pkg-config" ,pkg-config)
+         ("which" ,which)))
+      (inputs
+       `(("imlib2" ,imlib2)
+         ("libtiff" ,libtiff)
+         ("libpng" ,libpng)
+         ("libungif", libungif)
+         ("libjpeg", libjpeg)
+         ("libwebp" ,libwebp)
+         ("openjpeg" ,openjpeg)
+         ("lcms" ,lcms)
+         ("zlib", zlib)
+         ("glib" ,glib)
+         ("gtk+" ,gtk+-2)))
+      (arguments
+       `(#:configure-flags
+         (list
+          "intl") ;; internationalized support
+         ;; no check target
+         #:tests? #f))
+      (home-page "http://mtpaint.sourceforge.net/")
+      (synopsis "Create pixel art and manipulate digital images")
+      (description
+       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
+It can create and edit indexed pallete or 24bit RGB images, offers basic
+painting and palette manipulation tools.  It also handles JPEG, JPEG2000,
+GIF, TIFF, WEBP, BMP, PNG, XPM files.")
+      (license license:gpl3+))))
-- 
2.26.0





Information forwarded to guix-patches <at> gnu.org:
bug#40281; Package guix-patches. (Fri, 03 Apr 2020 04:17:02 GMT) Full text and rfc822 format available.

Message #11 received at 40281 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: R Veera Kumar <vkor <at> vkten.in>
Cc: 40281 <at> debbugs.gnu.org
Subject: Re: [bug#40281] [PATCH v2] gnu: Add mtpaint.
Date: Fri, 03 Apr 2020 06:15:57 +0200
R Veera Kumar <vkor <at> vkten.in> writes:

> * gnu/packages/image.scm (mtpaint): New variable.

Thank you for the patch!

> +
> +(define-public mtpaint
> +  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
> +        (revision "1"))

Why is this particular commit needed?  Can’t we use the latest release?

> +    (package
> +      (name "mtpaint")
> +      (version (git-version "3.49.25" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/wjaguar/mtPaint/")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
> +      (build-system gnu-build-system)
> +      (native-inputs
> +       `(("gettext" ,gettext-minimal)
> +         ("pkg-config" ,pkg-config)
> +         ("pkg-config" ,pkg-config)

You have this line twice.

> +         ("which" ,which)))
> +      (inputs
> +       `(("imlib2" ,imlib2)
> +         ("libtiff" ,libtiff)
> +         ("libpng" ,libpng)
> +         ("libungif", libungif)
> +         ("libjpeg", libjpeg)
> +         ("libwebp" ,libwebp)
> +         ("openjpeg" ,openjpeg)
> +         ("lcms" ,lcms)
> +         ("zlib", zlib)
> +         ("glib" ,glib)
> +         ("gtk+" ,gtk+-2)))

Could you please build with gtk+ (i.e. version 3).  You probably need to
add “gtk3” to the configure flags.

> +      (arguments
> +       `(#:configure-flags
> +         (list
> +          "intl") ;; internationalized support

Please remove the line break.
For margin comments (at the end of a line) use just one semicolon please.

> +         ;; no check target
> +         #:tests? #f))
> +      (home-page "http://mtpaint.sourceforge.net/")
> +      (synopsis "Create pixel art and manipulate digital images")
> +      (description
> +       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
> +It can create and edit indexed pallete or 24bit RGB images, offers
> basic

“pallete” –> “palette”

> +painting and palette manipulation tools.

Same here.

--
Ricardo




Information forwarded to guix-patches <at> gnu.org:
bug#40281; Package guix-patches. (Fri, 03 Apr 2020 04:44:01 GMT) Full text and rfc822 format available.

Message #14 received at 40281 <at> debbugs.gnu.org (full text, mbox):

From: R Veera Kumar <vkor <at> vkten.in>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 40281 <at> debbugs.gnu.org
Subject: Re: [bug#40281] [PATCH v2] gnu: Add mtpaint.
Date: Fri, 3 Apr 2020 10:12:51 +0530
On Fri, Apr 03, 2020 at 06:15:57AM +0200, Ricardo Wurmus wrote:
> 
> R Veera Kumar <vkor <at> vkten.in> writes:
> 
> > * gnu/packages/image.scm (mtpaint): New variable.
> 
> Thank you for the patch!
> 
> > +
> > +(define-public mtpaint
> > +  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
> > +        (revision "1"))
> 
> Why is this particular commit needed?  Can’t we use the latest release?
>

The author does not make release tarballs or even make git release tags.
He only puts package version in git commit title.
 
> > +    (package
> > +      (name "mtpaint")
> > +      (version (git-version "3.49.25" revision commit))
> > +      (source
> > +       (origin
> > +         (method git-fetch)
> > +         (uri (git-reference
> > +               (url "https://github.com/wjaguar/mtPaint/")
> > +               (commit commit)))
> > +         (file-name (git-file-name name version))
> > +         (sha256
> > +          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
> > +      (build-system gnu-build-system)
> > +      (native-inputs
> > +       `(("gettext" ,gettext-minimal)
> > +         ("pkg-config" ,pkg-config)
> > +         ("pkg-config" ,pkg-config)
> 
> You have this line twice.
> 

Will correct this.

> > +         ("which" ,which)))
> > +      (inputs
> > +       `(("imlib2" ,imlib2)
> > +         ("libtiff" ,libtiff)
> > +         ("libpng" ,libpng)
> > +         ("libungif", libungif)
> > +         ("libjpeg", libjpeg)
> > +         ("libwebp" ,libwebp)
> > +         ("openjpeg" ,openjpeg)
> > +         ("lcms" ,lcms)
> > +         ("zlib", zlib)
> > +         ("glib" ,glib)
> > +         ("gtk+" ,gtk+-2)))
> 
> Could you please build with gtk+ (i.e. version 3).  You probably need to
> add “gtk3” to the configure flags.
> 

Currently gtk2 support is stable. gtk3 is testing stage.

> > +      (arguments
> > +       `(#:configure-flags
> > +         (list
> > +          "intl") ;; internationalized support
> 
> Please remove the line break.
> For margin comments (at the end of a line) use just one semicolon please.
> 

Will correct.

> > +         ;; no check target
> > +         #:tests? #f))
> > +      (home-page "http://mtpaint.sourceforge.net/")
> > +      (synopsis "Create pixel art and manipulate digital images")
> > +      (description
> > +       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
> > +It can create and edit indexed pallete or 24bit RGB images, offers
> > basic
> 
> “pallete” –> “palette”
> 

Will correct.

> > +painting and palette manipulation tools.
> 
> Same here.
> 

Will correct.

R Veera Kumar

> --
> Ricardo




Information forwarded to guix-patches <at> gnu.org:
bug#40281; Package guix-patches. (Fri, 03 Apr 2020 16:35:02 GMT) Full text and rfc822 format available.

Message #17 received at 40281 <at> debbugs.gnu.org (full text, mbox):

From: R Veera Kumar <vkor <at> vkten.in>
To: 40281 <at> debbugs.gnu.org
Cc: R Veera Kumar <vkor <at> vkten.in>
Subject: [PATCH v3] gnu: Add mtpaint.
Date: Fri,  3 Apr 2020 22:03:47 +0530
* gnu/packages/image.scm (mtpaint): New variable.
---
Changes in v3:
 - Remove duplicate native-inputs entry
 - Proper use of comments
 - add installation of man page.
 - Correct a spelling mistake in description
Changes in v2:
 - Commit msg according to changelog format
 - put gettext in native-inputs
---
 gnu/packages/image.scm | 52 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 99fa1e05e6..c3b55dd918 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2018 Alex Vong <alexvong1995 <at> gmail.com>
 ;;; Copyright © 2018 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
+;;; Copyright © 2020 R Veera Kumar <vkor <at> vkten.in>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -45,6 +46,7 @@
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages curl)
@@ -1979,3 +1981,53 @@ AOM, including with alpha.")
     (home-page "https://github.com/AOMediaCodec/libavif")
     (license (list license:bsd-2    ; libavif itself
                    license:expat)))) ; cJSON in the test suite
+
+(define-public mtpaint
+  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
+        (revision "1"))
+    (package
+      (name "mtpaint")
+      (version (git-version "3.49.25" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/wjaguar/mtPaint/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
+      (build-system gnu-build-system)
+      (native-inputs
+       `(("gettext" ,gettext-minimal)
+         ("pkg-config" ,pkg-config)
+         ("which" ,which)))
+      (inputs
+       `(("imlib2" ,imlib2)
+         ("libtiff" ,libtiff)
+         ("libpng" ,libpng)
+         ("libungif", libungif)
+         ("libjpeg", libjpeg)
+         ("libwebp" ,libwebp)
+         ("openjpeg" ,openjpeg)
+         ("lcms" ,lcms)
+         ("zlib", zlib)
+         ("glib" ,glib)
+         ("gtk+" ,gtk+-2)))
+      (arguments
+       `(#:configure-flags
+         (list
+          ;; internationalized version
+          "intl"
+          ;; install man page
+          "man")
+         ;; no check target
+         #:tests? #f))
+      (home-page "http://mtpaint.sourceforge.net/")
+      (synopsis "Create pixel art and manipulate digital images")
+      (description
+       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
+It can create and edit indexed palette or 24bit RGB images, offers basic
+painting and palette manipulation tools.  It also handles JPEG, JPEG2000,
+GIF, TIFF, WEBP, BMP, PNG, XPM formats.")
+      (license license:gpl3+))))
-- 
2.26.0





Information forwarded to guix-patches <at> gnu.org:
bug#40281; Package guix-patches. (Sat, 04 Apr 2020 17:34:01 GMT) Full text and rfc822 format available.

Message #20 received at 40281 <at> debbugs.gnu.org (full text, mbox):

From: R Veera Kumar <vkor <at> vkten.in>
To: 40281 <at> debbugs.gnu.org
Cc: R Veera Kumar <vkor <at> vkten.in>
Subject: [PATCH v4] gnu: Add mtpaint.
Date: Sat,  4 Apr 2020 23:03:25 +0530
* gnu/packages/image.scm (mtpaint): New variable.
---
Changes in v4:
 - Add comment explaining author git commit versioning
 - Add comment for using gtk2 instead of gtk3
Changes in v3:
 - Remove duplicate native-inputs entry
 - Proper use of comments
 - add installation of man page.
 - Correct a spelling mistake in description
Changes in v2:
 - Commit msg according to changelog format
 - put gettext in native-inputs
---
 gnu/packages/image.scm | 55 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 861c6cd8e7..79dee20c48 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2018 Alex Vong <alexvong1995 <at> gmail.com>
 ;;; Copyright © 2018 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
+;;; Copyright © 2020 R Veera Kumar <vkor <at> vkten.in>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -45,6 +46,7 @@
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages curl)
@@ -1979,3 +1981,56 @@ AOM, including with alpha.")
     (home-page "https://github.com/AOMediaCodec/libavif")
     (license (list license:bsd-2    ; libavif itself
                    license:expat)))) ; cJSON in the test suite
+
+(define-public mtpaint
+  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
+        (revision "1"))
+    (package
+      (name "mtpaint")
+      ;; author does not releases tarball neither uses git version tags
+      ;; instead author puts version in git commit title
+      (version (git-version "3.49.25" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/wjaguar/mtPaint/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
+      (build-system gnu-build-system)
+      (native-inputs
+       `(("gettext" ,gettext-minimal)
+         ("pkg-config" ,pkg-config)
+         ("which" ,which)))
+      (inputs
+       `(("imlib2" ,imlib2)
+         ("libtiff" ,libtiff)
+         ("libpng" ,libpng)
+         ("libungif", libungif)
+         ("libjpeg", libjpeg)
+         ("libwebp" ,libwebp)
+         ("openjpeg" ,openjpeg)
+         ("lcms" ,lcms)
+         ("zlib", zlib)
+         ("glib" ,glib)
+         ;; support for gtk3 is in testing stage
+         ("gtk+" ,gtk+-2)))
+      (arguments
+       `(#:configure-flags
+         (list
+          ;; internationalized version
+          "intl"
+          ;; install man page
+          "man")
+         ;; no check target
+         #:tests? #f))
+      (home-page "http://mtpaint.sourceforge.net/")
+      (synopsis "Create pixel art and manipulate digital images")
+      (description
+       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
+It can create and edit indexed palette or 24bit RGB images, offers basic
+painting and palette manipulation tools.  It also handles JPEG, JPEG2000,
+GIF, TIFF, WEBP, BMP, PNG, XPM formats.")
+      (license license:gpl3+))))
-- 
2.26.0





Reply sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
You have taken responsibility. (Sun, 05 Apr 2020 17:49:02 GMT) Full text and rfc822 format available.

Notification sent to R Veera Kumar <vkor <at> vkten.in>:
bug acknowledged by developer. (Sun, 05 Apr 2020 17:49:02 GMT) Full text and rfc822 format available.

Message #25 received at 40281-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: R Veera Kumar <vkor <at> vkten.in>
Cc: 40281-done <at> debbugs.gnu.org
Subject: Re: [bug#40281] [PATCH v4] gnu: Add mtpaint.
Date: Sun, 5 Apr 2020 19:48:20 +0200
[Message part 1 (text/plain, inline)]
Hi Veera,

pushed to guix master as commit 95b800e67ca9b6ca6be4f7afd74ddd70286ac852.

Thanks!
[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 04 May 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 329 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.