GNU bug report logs - #40288
[PATCH 1/1] gnu: Add lxqt-organizer.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40288 in the body.
You can then email your comments to 40288 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/1] gnu: Add lxqt-organizer.
Date: Sat, 28 Mar 2020 21:11:06 +0430

* gnu/packages/lxqt.scm (lxqt-organizer): New variable.
---
 gnu/packages/lxqt.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index a440491633..7ef6ca51ce 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1269,6 +1269,40 @@ QTermWidget.")
 easily publishing them on internet image hosting services.")
     (license license:gpl2+)))
 
+(define-public lxqt-organizer
+  (package
+    (name "lxqt-organizer")
+    (version "v0.003")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url (string-append "https://github.com/lxqt/organizer.git"))
+               (commit "5aa556aa0f0409e00fac5b63d9118ff228d2e840")
+               (recursive? #t)))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32 "1czs9gca7aqsfcnxhi7nzq97pxbmhfgbfh00j7nl8cig0yxb6apv"))))
+    (build-system cmake-build-system)
+    (inputs
+      `(("kwindowsystem" ,kwindowsystem)
+        ("liblxqt" ,liblxqt)
+        ("libqtxdg" ,libqtxdg)
+        ("qtbase" ,qtbase)
+        ("qtsvg" ,qtsvg)
+        ;;("qtlinguist" ,qttools)
+        ("qtx11extras" ,qtx11extras)))
+    (native-inputs
+      `(("pkg-config" ,pkg-config)
+        ("lxqt-build-tools" ,lxqt-build-tools)
+        ("qttools" ,qttools)))
+    (arguments
+      '(#:tests? #f))
+    (home-page "https://lxqt.org/")
+    (synopsis "LXQt Organizer is a lightweight organizer for personal information management.")
+    (description
+     "This package provides a Qt-based application for managing meetings, events and other personal information.")
+    (license license:lgpl2.1+)))
 
 (define-public lxqt-archiver
   (package
-- 
2.25.1

Message #8 received at 40288 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Hamzeh Nasajpour <h.nasajpour <at> pantherx.org>
Cc: 40288 <at> debbugs.gnu.org
Subject: Re: [bug#40288] [PATCH 1/1] gnu: Add lxqt-organizer.
Date: Mon, 30 Mar 2020 11:46:30 +0300

[Message part 1 (text/plain, inline)]

I didn't realize we had so much of lxqt packaged.

Some comments inline:

On Sat, Mar 28, 2020 at 09:11:06PM +0430, Hamzeh Nasajpour wrote:
> * gnu/packages/lxqt.scm (lxqt-organizer): New variable.
> ---
>  gnu/packages/lxqt.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index a440491633..7ef6ca51ce 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -1269,6 +1269,40 @@ QTermWidget.")
>  easily publishing them on internet image hosting services.")
>      (license license:gpl2+)))
>  
> +(define-public lxqt-organizer
> +  (package
> +    (name "lxqt-organizer")
> +    (version "v0.003")

The author seems to be using this time to do some rapid development and
has already (at the time I checked) already bumped the version to
v0.6.0. Can you update to the most recent version?

> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url (string-append "https://github.com/lxqt/organizer.git"))
> +               (commit "5aa556aa0f0409e00fac5b63d9118ff228d2e840")
> +               (recursive? #t)))

I was going to mention using the version string for the commit but it
seems they haven't pushed any tags to the repo. Can you add a comment
saying they haven't tagged any releases in git? Also, it doesn't look
like there are any submodules so you don't need 'recursive? #t'

> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32 "1czs9gca7aqsfcnxhi7nzq97pxbmhfgbfh00j7nl8cig0yxb6apv"))))
> +    (build-system cmake-build-system)
> +    (inputs
> +      `(("kwindowsystem" ,kwindowsystem)
> +        ("liblxqt" ,liblxqt)
> +        ("libqtxdg" ,libqtxdg)
> +        ("qtbase" ,qtbase)
> +        ("qtsvg" ,qtsvg)
> +        ;;("qtlinguist" ,qttools)
> +        ("qtx11extras" ,qtx11extras)))

guix gc --references /path/to/item doesn't list all the inputs, so many
of them can actually be moved to native-inputs.

> +    (native-inputs
> +      `(("pkg-config" ,pkg-config)
> +        ("lxqt-build-tools" ,lxqt-build-tools)
> +        ("qttools" ,qttools)))
> +    (arguments
> +      '(#:tests? #f))

I saw that there were no tests in the repo, please add a note.

> +    (home-page "https://lxqt.org/")

Is there a project-specific home-page? If not I'd recommend just using
the github repo as the home-page.

> +    (synopsis "LXQt Organizer is a lightweight organizer for personal information management.")
Perhaps: "LXQt desktop organizer" or "LXQt organizer for personal
information management" Actually the second sounds clunky. "LXQt
personal information management organizer"

> +    (description
> +     "This package provides a Qt-based application for managing meetings, events and other personal information.")
> +    (license license:lgpl2.1+)))
>  
>  (define-public lxqt-archiver
>    (package
> -- 
> 2.25.1
> 

In addition, in the desktop file (in %out/share/application/) there's a
second exec line which starts /usr/local/lxqt-organizer. Can you add a
phase to patch that?

Also, 'guix lint' complains about the length of two of the lines and
about the period in the synopsis.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40288 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Hamzeh Nasajpour <h.nasajpour <at> pantherx.org>
Cc: 40288 <at> debbugs.gnu.org
Subject: Re: [bug#40288] [PATCH 1/1] gnu: Add lxqt-organizer.
Date: Sat, 21 Nov 2020 09:19:49 +0000

It's been a few months, is this patch still relevant?

Thanks,

Chris

Message #16 received at 40288-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 40288-done <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: Add lxqt-organizer.
Date: Wed, 23 Oct 2024 19:58:47 +0100

[Message part 1 (text/plain, inline)]

Hi,

It looks like the project is no longer maintained: "This repository has
been archived by the owner on May 5, 2022. It is now read-only."

<https://github.com/lxqt/organizer>.

Closing the issue as no applied.

--
Thanks
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.