GNU bug report logs - #40289
[PATCH] games.scm: add "neverball" and "neverputt" (bundled together)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40289 in the body.
You can then email your comments to 40289 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] games.scm: add "neverball" and "neverputt" (bundled together)
Date: Sat, 28 Mar 2020 17:37:16 +0000

[Message part 1 (text/plain, inline)]

gnu/packages/games.scm:
  Added:
    *  a game neverball and it's "addon", neverputt.
    *  the #:use-module "copy-build-system".

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-games.scm-add-neverball-and-neverputt-bundled-togeth.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org>
Cc: 40289 <at> debbugs.gnu.org, Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
Subject: Re: [bug#40289] [PATCH] games.scm: add "neverball" and "neverputt"
 (bundled together)
Date: Mon, 30 Mar 2020 14:31:16 +0200

Hello,

Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org> writes:

> gnu/packages/games.scm:
>   Added:
>     *  a game neverball and it's "addon", neverputt.
>     *  the #:use-module "copy-build-system".

Thank you! Somme comments follow

> Subject: [PATCH] games.scm:  add "neverball" and "neverputt" (bundled
>  together).
>
> gnu/packages/games.scm:
>   Added:
>     *  a game neverball and it's "addon", neverputt.
>     *  the #:use-module "copy-build-system".

The commit message should be

    gnu: Add neverball

    * gnu/packages/games.scm (neverball): New variable.

That's it.
> +      (source (origin

Nitpick: I suggest to move `origin' on the line below `source'.

> +                 ;; Debian doesn't strip it, though.  i'm dummy
> +                 (delete-file-recursively "data/ball/octocat"))

Usually, we would delete it in a snippet so "guix build -S neverball"
returns source without the problematic part. Could you do it?

> +           (add-after 'install 'install-icons

Could this be moved within the install plan?

> +      (description
> +       "Also included is Neverputt, which is a 3D miniature golf
> game.

The first sentence should be complete.

> +In the grand tradition of Marble Madness and Super Monkey Ball,
> +Neverball has you guide a rolling ball through dangerous territory.
> +Balance on narrow bridges, navigate mazes, ride moving platforms, and
> +dodge pushers and shovers to get to the goal.  Race against the clock to
> +collect coins to earn extra balls.") ;; mouse on sway cause crash

The last comment seems out of place. This may need to be reported
upstream instead.

Also, note that end of line comments are expected to start with a single
semicolon. Double semicolon comments start at the beginning of the line
instead.

Regards,

-- 
Nicolas Goaziou

Message #14 received at 40289 <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "40289 <at> debbugs.gnu.org" <40289 <at> debbugs.gnu.org>
Subject: [PATCH] games.scm: add "neverball" and "neverputt" (bundled together)
Date: Tue, 31 Mar 2020 17:36:35 +0000

[Message part 1 (text/plain, inline)]

Hi.  Seems that all is done.  If it's good enough now?

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-neverball.patch (text/x-patch, attachment)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org>
Cc: "40289 <at> debbugs.gnu.org" <40289-done <at> debbugs.gnu.org>,
 Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
Subject: Re: [bug#40289] [PATCH] games.scm: add "neverball" and "neverputt"
 (bundled together)
Date: Tue, 31 Mar 2020 20:24:57 +0200

Hello,

Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org> writes:

> Hi.  Seems that all is done.  If it's good enough now?

It looks good. Thank you!

I added a copyright line for you, removed some comments, made sure lines
were not going past column 80, and pushed it, as
3de5b4047e010340485019170e5715deb0de21c0.

Regards,

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.