GNU bug report logs -
#40291
gnu: packages: java: Add libantlr3c
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40291 in the body.
You can then email your comments to 40291 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#40291
; Package
guix-patches
.
(Mon, 30 Mar 2020 02:36:04 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
"Raghav Gururajan" <raghavgururajan <at> disroot.org>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Mon, 30 Mar 2020 02:36:04 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Guix!
Please find the attached patch to add "libantlr3c" package.
Regards,
RG.
[libantlr3c.patch (application/octet-stream, attachment)]
Added blocking bug(s) 40307
Request was from
Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
to
control <at> debbugs.gnu.org
.
(Tue, 31 Mar 2020 02:01:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#40291
; Package
guix-patches
.
(Tue, 31 Mar 2020 04:55:01 GMT)
Full text and
rfc822 format available.
Message #10 received at 40291 <at> debbugs.gnu.org (full text, mbox):
Hello Raghav!
You'll find my review of this patch below. For other readers, this is
needed in preparation of Linphone, which requires it through its
belle-sip dependency.
"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:
> Hello Guix!
>
> Please find the attached patch to add "libantlr3c" package.
>
> Regards,
> RG.
>
> From 791e2392aaa9a3202db90c1e50340c38bd001504 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 28 Mar 2020 14:21:35 -0400
> Subject: [PATCH 6/6] gnu: packages: java: Add libantlr3c
This should be: "gnu: Add libantlr3c."
> * gnu/packages/java.scm (libantlr3c): New variable.
> ---
> gnu/packages/java.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 5154dc124e..400ef8795e 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -105,6 +105,35 @@
> ;; build framework. We then build the more recent JDKs Icedtea 2.x and
> ;; Icedtea 3.x.
>
> +(define-public libantlr3c
> + (package
> + (name "libantlr3c")
> + (version "3.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri
> + (string-append "https://www.antlr3.org/download/C/"
> + name "-" version ".tar.gz"))
> + (sha256
> + (base32 "0lpbnb4dq4azmsvlhp6khq1gy42kyqyjv8gww74g5lm2y6blm4fa"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:configure-flags
> + (list
> + "--enable-debuginfo"
> + "--enable-64bit"
Is this really required? The default is "no". If enabled, it probably
needs to be made conditional so that it is only enabled for 64 bits
architectures.
> + "--enable-abiflags"
> + "--enable-antlrdebug"
> + "--enable-shared"
> + "--enable-static"
If enabled, the static library should go to its own "static" output.
> + "--enable-fast-install")))
> + (synopsis "ANTLR C Library")
> + (description "LIBANTLR3C provides run-time C libraries for ANTLR3
> +(ANother Tool for Language Recognition v3).")
> + (home-page "https://www.antlr3.org/")
> + (license license:bsd-3)))
> +
The indentation is off. If you don't use Emacs for editing, you can run
the Emacs script provided by Guix like this:
./etc/indent-code.el gnu/packages/java.scm libantlr3c
Thanks!
Maxim
Added indication that bug 40291 blocks40264
Request was from
"Raghav Gururajan" <raghavgururajan <at> disroot.org>
to
control <at> debbugs.gnu.org
.
(Tue, 31 Mar 2020 15:53:02 GMT)
Full text and
rfc822 format available.
Reply sent
to
Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
:
You have taken responsibility.
(Wed, 01 Apr 2020 02:38:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
"Raghav Gururajan" <raghavgururajan <at> disroot.org>
:
bug acknowledged by developer.
(Wed, 01 Apr 2020 02:38:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 40291-done <at> debbugs.gnu.org (full text, mbox):
Hi Raghav,
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
> Hello Raghav!
>
> You'll find my review of this patch below. For other readers, this is
> needed in preparation of Linphone, which requires it through its
> belle-sip dependency.
>
> "Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:
>
>> Hello Guix!
>>
>> Please find the attached patch to add "libantlr3c" package.
>>
>> Regards,
>> RG.
>>
>> From 791e2392aaa9a3202db90c1e50340c38bd001504 Mon Sep 17 00:00:00 2001
>> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
>> Date: Sat, 28 Mar 2020 14:21:35 -0400
>> Subject: [PATCH 6/6] gnu: packages: java: Add libantlr3c
>
> This should be: "gnu: Add libantlr3c."
>
>> * gnu/packages/java.scm (libantlr3c): New variable.
>> ---
>> gnu/packages/java.scm | 29 +++++++++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>>
>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> index 5154dc124e..400ef8795e 100644
>> --- a/gnu/packages/java.scm
>> +++ b/gnu/packages/java.scm
>> @@ -105,6 +105,35 @@
>> ;; build framework. We then build the more recent JDKs Icedtea 2.x and
>> ;; Icedtea 3.x.
>>
>> +(define-public libantlr3c
>> + (package
>> + (name "libantlr3c")
>> + (version "3.4")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri
>> + (string-append "https://www.antlr3.org/download/C/"
>> + name "-" version ".tar.gz"))
>> + (sha256
>> + (base32 "0lpbnb4dq4azmsvlhp6khq1gy42kyqyjv8gww74g5lm2y6blm4fa"))))
>> + (build-system gnu-build-system)
>> + (arguments
>> + `(#:configure-flags
>> + (list
>> + "--enable-debuginfo"
>> + "--enable-64bit"
>
> Is this really required? The default is "no". If enabled, it probably
> needs to be made conditional so that it is only enabled for 64 bits
> architectures.
I've studied what Debian does, and they do conditionals based on the
host. I could find a way to achieve this with Guix and pushed as commit
f1cf62f5dc.
>
>> + "--enable-abiflags"
>> + "--enable-antlrdebug"
>> + "--enable-shared"
>> + "--enable-static"
>
> If enabled, the static library should go to its own "static" output.
As discussed in #guix, I've disabled static libraries for now. I've
also only used the flags which are specific to antlr3c and that need to
be changed from their default values, to keep the noise level as low as
possible.
With this, the base for Linphone is now merged and we can attack the
more interesting bits.
Thanks!
Maxim
Information forwarded
to
guix-patches <at> gnu.org
:
bug#40291
; Package
guix-patches
.
(Thu, 02 Apr 2020 04:10:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 40291 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
[libantlr3c-v2.patch (application/octet-stream, attachment)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 30 Apr 2020 11:24:07 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 359 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.