GNU bug report logs - #40300
[PATCH] gnu: Add emacs-haskell-snippets.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40300 in the body.
You can then email your comments to 40300 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-haskell-snippets.
Date: Sat, 28 Mar 2020 18:07:22 -0700

Hi Guix,

I find the haskell-snippets very helpful when writing haskell.

Thanks,

John

Message #8 received at 40300 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40300 <at> debbugs.gnu.org
Subject: Re: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Date: Mon, 30 Mar 2020 19:17:10 +0200

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> I find the haskell-snippets very helpful when writing haskell.

Thank you... but you forgot to send the patch.

Regards,

-- 
Nicolas Goaziou

Message #11 received at 40300 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40300 <at> debbugs.gnu.org
Subject: Re: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Date: Mon, 30 Mar 2020 10:38:01 -0700

[Message part 1 (text/plain, inline)]

Hi Nicolas,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Thank you... but you forgot to send the patch.

Oh, sorry. Here it is.

Thanks for the speedy review!

John

[0001-gnu-Add-emacs-haskell-snippets.patch (text/x-patch, attachment)]

Message #14 received at 40300 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40300 <at> debbugs.gnu.org
Subject: Re: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Date: Mon, 30 Mar 2020 19:52:29 +0200

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> +(define-public emacs-haskell-snippets
> +  (package
> +    (name "emacs-haskell-snippets")
> +    (version "0.1.0")

Would it make sense to package HEAD instead. I'm looking in particular
at upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/haskell/haskell-snippets")
> +         (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6"))))

Usual nitpick: please put string on the same line as `base32'.

> +    (inputs
> +     `(("emacs-yasnippet" ,emacs-yasnippet)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'install-snippets
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (snippets
> +                     (string-append
> +                      out "/share/emacs/site-lisp/snippets/haskell-mode")))
> +               (mkdir-p snippets)
> +               (copy-recursively "snippets/haskell-mode" snippets)
> +               #t))))))
> +    (build-system emacs-build-system)

Nitpick: could you move parts in this order: build-system ->
arguments -> inputs.

Regards,

-- 
Nicolas Goaziou

Message #17 received at 40300 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40300 <at> debbugs.gnu.org
Subject: Re: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Date: Mon, 30 Mar 2020 12:03:23 -0700

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> John Soo <jsoo1 <at> asu.edu> writes:
>
>> +(define-public emacs-haskell-snippets
>> +  (package
>> +    (name "emacs-haskell-snippets")
>> +    (version "0.1.0")
>
> Would it make sense to package HEAD instead. I'm looking in particular
> at upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5.

I think so. Done.

>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri
>> +        (git-reference
>> +         (url "https://github.com/haskell/haskell-snippets")
>> +         (commit version)))
>> +       (file-name (git-file-name name version))
>> +       (sha256
>> +        (base32
>> +         "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6"))))
>
> Usual nitpick: please put string on the same line as `base32'.

Done.

>> +    (inputs
>> +     `(("emacs-yasnippet" ,emacs-yasnippet)))
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'install 'install-snippets
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (snippets
>> +                     (string-append
>> +                      out "/share/emacs/site-lisp/snippets/haskell-mode")))
>> +               (mkdir-p snippets)
>> +               (copy-recursively "snippets/haskell-mode" snippets)
>> +               #t))))))
>> +    (build-system emacs-build-system)
>
> Nitpick: could you move parts in this order: build-system ->
> arguments -> inputs.

Yes I can. Done.

I also changed inputs -> propagated-inputs.

Thanks again,

John

[0001-gnu-Add-emacs-haskell-snippets.patch (text/x-patch, attachment)]

Message #22 received at 40300-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40300-done <at> debbugs.gnu.org
Subject: Re: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Date: Mon, 30 Mar 2020 22:39:23 +0200

John Soo <jsoo1 <at> asu.edu> writes:

> Subject: [PATCH] gnu: Add emacs-haskell-snippets.
>
> * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): New variable.

Applied as 1c2f6d66ecf70637d92cb984d0c60433ba3e41e8. I added a comment
explaing why we don't provide a release.

Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.