GNU bug report logs - #40301
[PATCH] gnu: Add emacs-psc-ide.

Previous Next

Package: guix-patches;

Reported by: John Soo <jsoo1 <at> asu.edu>

Date: Mon, 30 Mar 2020 02:36:11 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40301 in the body.
You can then email your comments to 40301 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40301; Package guix-patches. (Mon, 30 Mar 2020 02:36:11 GMT) Full text and rfc822 format available.

Acknowledgement sent to John Soo <jsoo1 <at> asu.edu>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 30 Mar 2020 02:36:11 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-psc-ide.
Date: Sat, 28 Mar 2020 18:11:01 -0700
[Message part 1 (text/plain, inline)]
Hi Guix,

psd-ide is an indispensable part of my PureScript workflow.

Thanks!

John

[0001-gnu-Add-emacs-psc-ide.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#40301; Package guix-patches. (Sat, 11 Apr 2020 16:22:02 GMT) Full text and rfc822 format available.

Message #8 received at 40301 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 40301 <at> debbugs.gnu.org
Subject: [PATCH] Fixed some issues with the patches.
Date: Sat, 11 Apr 2020 09:21:27 -0700
[Message part 1 (text/plain, inline)]
Hi Guix,

I rebased these commits on master, moved the build-system field up, and
put the sha string on the same line as base32. I also moved the
definition further up in the file to avoid conflicts.

Thanks!

John

[0001-gnu-Add-emacs-psc-ide.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#40301; Package guix-patches. (Sat, 11 Apr 2020 19:56:02 GMT) Full text and rfc822 format available.

Message #11 received at 40301 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40301 <at> debbugs.gnu.org
Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches.
Date: Sat, 11 Apr 2020 21:55:36 +0200
Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> I rebased these commits on master, moved the build-system field up, and
> put the sha string on the same line as base32. I also moved the
> definition further up in the file to avoid conflicts.

Thank you!

> +(define-public emacs-psc-ide
> +  (package
> +    (name "emacs-psc-ide")
> +    (version "0.0.0")

According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,
you need to add a revision number, "0", or "1" at this point.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/purescript-emacs/psc-ide-emacs")
> +         (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))

The commit should be moved in a top-level `let' at the beginning of the
package definition.

> +       (file-name (git-file-name name "0.0.0"))

This should use version, along with the revision number.
> +    (synopsis "Emacs integration for PureScript's psc-ide tool")
> +    (description
> +     "Emacs integration for PureScript's psc-ide tool. Featuring:

Description should be made of full sentences. Also, it might be useful
to explain what "psc-ide" tool is.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#40301; Package guix-patches. (Sun, 12 Apr 2020 00:46:01 GMT) Full text and rfc822 format available.

Message #14 received at 40301 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40301 <at> debbugs.gnu.org
Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches.
Date: Sat, 11 Apr 2020 17:45:47 -0700
[Message part 1 (text/plain, inline)]
Hi Nicolas,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

>> +(define-public emacs-psc-ide
>> +  (package
>> +    (name "emacs-psc-ide")
>> +    (version "0.0.0")
>
> According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,
> you need to add a revision number, "0", or "1" at this point.
> ...
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri
>> +        (git-reference
>> +         (url "https://github.com/purescript-emacs/psc-ide-emacs")
>> +         (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))
>
> The commit should be moved in a top-level `let' at the beginning of the
> package definition.
>
>> +       (file-name (git-file-name name "0.0.0"))
>
> This should use version, along with the revision number.
>> +    (synopsis "Emacs integration for PureScript's psc-ide tool")
>> +    (description
>> +     "Emacs integration for PureScript's psc-ide tool. Featuring:

Ok I added the revision and the commit and used git-version and
git-file-name. As an aside, what does the revision mean? Maybe if I
really understand it I can submit better patches in the future.

> Description should be made of full sentences. Also, it might be useful
> to explain what "psc-ide" tool is.

I think I clarified the description a little. This was an excellent
detailed review, thank you so much.

Also, I changed inputs->propagated-inputs.

Kindly,

John

[0001-gnu-Add-emacs-psc-ide.patch (text/x-patch, attachment)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sun, 12 Apr 2020 09:05:01 GMT) Full text and rfc822 format available.

Notification sent to John Soo <jsoo1 <at> asu.edu>:
bug acknowledged by developer. (Sun, 12 Apr 2020 09:05:02 GMT) Full text and rfc822 format available.

Message #19 received at 40301-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40301-done <at> debbugs.gnu.org
Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches.
Date: Sun, 12 Apr 2020 11:04:08 +0200
Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> Ok I added the revision and the commit and used git-version and
> git-file-name. As an aside, what does the revision mean? Maybe if I
> really understand it I can submit better patches in the future.

If there is no proper versioning for the package (e.g., no releases, or
version strings hidden in a source file), we have to rely on commit
hashes. But commit hashes are not monotonic. So, if you package, e.g.,
"emacs-psc-ide" with commit "bbbb", and later, update it to include
latest commit "aaaa", you have, from Guix's point of view, downgraded
the package, even though "aaaa" is more advanced than "bbbb".

The revision number solves that. Each time you update the commit
message, you increase the revision number, so you releases are
monotonic. E.g., your first package will be "emacs-psc-ide-1-bbbb", and
the other "emacs-psc-ide-2-aaaa".

> Subject: [PATCH] gnu: Add emacs-psc-ide.
>
> * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable.

Thank you. Applied as 8a00a2202ef2a0a0173e17479359370f5656ecd0.

Regards,

-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 10 May 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 323 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.