GNU bug report logs - #40304
[PATCH] gnu: Add emacs-dhall-mode.

Previous Next

Package: guix-patches;

Reported by: John Soo <jsoo1 <at> asu.edu>

Date: Mon, 30 Mar 2020 02:36:13 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40304 in the body.
You can then email your comments to 40304 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40304; Package guix-patches. (Mon, 30 Mar 2020 02:36:13 GMT) Full text and rfc822 format available.

Acknowledgement sent to John Soo <jsoo1 <at> asu.edu>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 30 Mar 2020 02:36:13 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-dhall-mode.
Date: Sat, 28 Mar 2020 18:20:44 -0700
[Message part 1 (text/plain, inline)]
Hi Guix!

dhall-mode provides language support for the dhall configuration
language.

Thanks!

John

[0001-gnu-Add-emacs-dhall-mode.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#40304; Package guix-patches. (Mon, 30 Mar 2020 17:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 40304 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40304 <at> debbugs.gnu.org
Subject: Re: [bug#40304] [PATCH] gnu: Add emacs-dhall-mode.
Date: Mon, 30 Mar 2020 19:24:34 +0200
Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> dhall-mode provides language support for the dhall configuration
> language.

Thank you.

> +(define-public emacs-dhall-mode
> +  (package
> +    (name "emacs-dhall-mode")
> +    (version "0.1.0")

This version is not accurate. The ".el" file mentions 0.1.3, but I think
we should use Github versioning, i.e., there is no versioning at all, so
we should do the commit + revision dance again, and use "0.1.3" as the
base of the version string.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/psibi/dhall-mode")
> +         (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2")))

This should go in a dedicated variable.

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384"))))

Nitpick: I usually put `base32' on the same line as the string.

> +    (inputs

Nitpick: Emacs build system uses `propagated-inputs', although this is
the same.

> +     `(("emacs-reformatter" ,emacs-reformatter)))
> +    (build-system emacs-build-system)

Nitpick: `build-system' is usually above

> +    (home-page "https://github.com/psibi/dhall-mode")
> +    (synopsis "Major mode for working with Dhall configuration language")
> +    (description
> +     "Emacs Major mode for working with Dhall configuration
> language.")

The description must be a full sentence.

> +    (license license:gpl2+)))

The license looks wrong. I see GPL3+ in this package.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#40304; Package guix-patches. (Mon, 30 Mar 2020 18:40:02 GMT) Full text and rfc822 format available.

Message #11 received at 40304 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40304 <at> debbugs.gnu.org
Subject: Re: [bug#40304] [PATCH] gnu: Add emacs-dhall-mode.
Date: Mon, 30 Mar 2020 11:39:49 -0700
[Message part 1 (text/plain, inline)]
Hi Nicolas,

Thanks again!

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> John Soo <jsoo1 <at> asu.edu> writes:
>
>> dhall-mode provides language support for the dhall configuration
>> language.
>
> Thank you.
>
>> +(define-public emacs-dhall-mode
>> +  (package
>> +    (name "emacs-dhall-mode")
>> +    (version "0.1.0")
>
> This version is not accurate. The ".el" file mentions 0.1.3, but I think
> we should use Github versioning, i.e., there is no versioning at all, so
> we should do the commit + revision dance again, and use "0.1.3" as the
> base of the version string.

Done.

>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri
>> +        (git-reference
>> +         (url "https://github.com/psibi/dhall-mode")
>> +         (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2")))
>
> This should go in a dedicated variable.

Did you mean the commit? If so that is also done.

>> +       (file-name (git-file-name name version))
>> +       (sha256
>> +        (base32
>> +         "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384"))))
>
> Nitpick: I usually put `base32' on the same line as the string.

Ok, I like that better. Done.

>> +    (inputs
>
> Nitpick: Emacs build system uses `propagated-inputs', although this is
> the same.

Oh! I think that's a bug, then. If the input is not propagated, there
will be an error when the user uses the package, right?  Fixed.

>> +     `(("emacs-reformatter" ,emacs-reformatter)))
>> +    (build-system emacs-build-system)
>
> Nitpick: `build-system' is usually above

No problem. Done.

>> +    (home-page "https://github.com/psibi/dhall-mode")
>> +    (synopsis "Major mode for working with Dhall configuration language")
>> +    (description
>> +     "Emacs Major mode for working with Dhall configuration
>> language.")
>
> The description must be a full sentence.

Fixed and added some more detail.

>> +    (license license:gpl2+)))
>
> The license looks wrong. I see GPL3+ in this package.

Ah, fixed, sorry.

> Could you send an updated patch?

Sure. Attached.

Thanks again,

John

[0001-gnu-Add-emacs-dhall-mode.patch (text/x-patch, attachment)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Mon, 30 Mar 2020 20:44:01 GMT) Full text and rfc822 format available.

Notification sent to John Soo <jsoo1 <at> asu.edu>:
bug acknowledged by developer. (Mon, 30 Mar 2020 20:44:01 GMT) Full text and rfc822 format available.

Message #16 received at 40304-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40304-done <at> debbugs.gnu.org
Subject: Re: [bug#40304] [PATCH] gnu: Add emacs-dhall-mode.
Date: Mon, 30 Mar 2020 22:43:15 +0200
John Soo <jsoo1 <at> asu.edu> writes:

> Subject: [PATCH] gnu: Add emacs-dhall-mode.
>
> * gnu/packages/emacs-xyz.scm (emacs-dhall-mode): New variable.

Applied as 47fc5229eb8cda8c97801f71eb4bdb1fd9b26123. I added a comment
about the lack of proper versioning.

Thank you!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 28 Apr 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 335 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.