GNU bug report logs - #40307
gnu: packages: telephony: Add spandsp

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40307 in the body.
You can then email your comments to 40307 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: packages: telephony: Add spandsp
Date: Sun, 29 Mar 2020 03:37:04 +0000

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch to add "spandsp" package.

Regards,
RG.

[spandsp.patch (application/octet-stream, attachment)]

Message #14 received at 40307 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40307 <at> debbugs.gnu.org
Subject: Re: [bug#40307] gnu: packages: telephony: Add spandsp
Date: Tue, 31 Mar 2020 01:21:03 -0400

Hello again :-)

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to add "spandsp" package.
>
> Regards,
> RG.
>
> From 68e093007f2c5678895a5cbe29f2b1ac2c357ba2 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 28 Mar 2020 23:32:57 -0400
> Subject: [PATCH 13/13] gnu: packages: telephony: Add spandsp

This prefix also need to be adjusted to just "gnu: Add ...".

> * gnu/packages/telephony.scm (spandsp): New variable.
> ---
>  gnu/packages/telephony.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index fe6c230693..c68f80669c 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -52,6 +52,7 @@
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gnupg)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages image)
>    #:use-module (gnu packages libcanberra)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages multiprecision)
> @@ -84,6 +85,35 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system qt))
>  
> +(define-public spandsp
> + (package
> +  (name "spandsp")
> +  (version "0.0.6")
> +  (source
> +   (origin
> +    (method url-fetch)
> +    (uri
> +     (string-append "https://www.soft-switch.org/downloads/" name "/"
> +                    name "-" version ".tar.gz"))
> +    (sha256
> +     (base32 "0rclrkyspzk575v8fslzjpgp4y2s4x7xk3r55ycvpi4agv33l1fc"))))
> + (build-system gnu-build-system)

The check phase doesn't seem to run anything; it just passes.  Perhaps
we don't start it the correct way?

> + (native-inputs
> +  `(("libtiff" ,libtiff)
> +    ("zlib" ,zlib)))
> + (synopsis "DSP library for telephony")
> + (description "SpanDSP is a library of DSP functions for telephony, in the 8000 sample
> +per second world of E1s, T1s, and higher order PCM channels.  It contains low level
> +functions, such as basic filters.  It also contains higher level functions, such as
> +cadenced supervisory tone detection, and a complete software FAX
> machine.")

This body of text is a bit too wide.  We limit our column width at 80
characters.  You can use M-q in Emacs to automatically re-flow the
paragraph.  I kind of like the concise description from Debian, because
it gives me a better idea of what the package can be used for: "SpanDSP
is a low-level signal processing library that modulate and demodulate
signals commonly used in telephony, such as the "noise" generated by a
fax modem or DTMF touchpad."

> + (home-page "https://www.soft-switch.org/index.html")
> + (license
> +  (list
> +   ;; For Library
> +   license:lgpl2.1+
> +   ;; For Test Suites and Support Programs
> +   license:gpl2+))))
> +

My preferred style for formatting the license list would be:

    (license (list license:lgpl2.1+  ;for the library
                   license:gpl2+)))) ;for the test suites and support programs


The indentation of the package is off.  Please use Emacs or the
indent-code.el script :-).

Maxim

Message #17 received at 40307 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40307 <at> debbugs.gnu.org
Subject: Re: [bug#40307] gnu: packages: telephony: Add spandsp
Date: Tue, 31 Mar 2020 01:25:17 -0400

Hi again,

I forgot to add; Debian adds the --enable-doc --enable-tests flags.  I
think it'd be nice to have a manpage, and perhaps the check phase would
actually run something with the above?

Maxim

Message #20 received at 40307 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40307 <at> debbugs.gnu.org
Subject: Alternative Source for TarBall
Date: Tue, 31 Mar 2020 16:29:59 +0000

https://disroot.org/upload/BSso1ApOLdASSoZ3/spandsp-0.0.6.tar.gz

Message #23 received at 40307 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40307 <at> debbugs.gnu.org
Subject: Re: Alternative Source for TarBall
Date: Tue, 31 Mar 2020 16:37:00 +0000

> https://disroot.org/upload/BSso1ApOLdASSoZ3/spandsp-0.0.6.tar.gz

PROPER:

https://web.archive.org/web/20180626203108/https://www.soft-switch.org/downloads/spandsp/spandsp-0.0.6.tar.gz

Message #28 received at 40307-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40307-done <at> debbugs.gnu.org
Subject: Re: [bug#40307] gnu: packages: telephony: Add spandsp
Date: Tue, 31 Mar 2020 17:03:59 -0400

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to add "spandsp" package.
>
> Regards,
> RG.

Hi Raghav!

I've modified the package to add the doc + tests and pushed as
d82539d35f.

Thank you!

Closing.

Message #31 received at 40307 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40307 <at> debbugs.gnu.org
Subject: gnu: Add spandsp (v2)
Date: Thu, 02 Apr 2020 04:00:22 +0000

[Message part 1 (text/plain, inline)]

[spandsp-v2.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.