GNU bug report logs - #40318
[PATCH] gnu: Add tuir.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40318 in the body.
You can then email your comments to 40318 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: Add tuir.
Date: Sun, 29 Mar 2020 17:23:00 +0300

* gnu/packages/syndication.scm (tuir): New variable.
---
 gnu/packages/syndication.scm | 41 +++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scm
index a84281364f..7e62636835 100644
--- a/gnu/packages/syndication.scm
+++ b/gnu/packages/syndication.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2016, 2017, 2019 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2016, 2017, 2019, 2020 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -136,3 +136,42 @@ It started life as a fork of the currently unmaintained Newsbeuter.")
      "RTV provides a text-based interface to view and interact with Reddit.")
     (license (list license:expat
                    license:gpl3+)))) ; rtv/packages/praw
+
+(define-public tuir
+  (package
+    (name "tuir")
+    (version "1.28.3")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "tuir" version))
+        (sha256
+         (base32
+          "1gpyjrl7jdfjq30m32nzh59ajv91gq19l93jjri2wsv5yrf90hdr"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (add-installed-pythonpath inputs outputs)
+             (invoke "py.test" "-v"))))))
+    (propagated-inputs
+     `(("python-beautifulsoup4" ,python-beautifulsoup4)
+       ("python-decorator" ,python-decorator)
+       ("python-kitchen" ,python-kitchen)
+       ("python-requests" ,python-requests)
+       ("python-six" ,python-six)))
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-coveralls" ,python-coveralls)
+       ("python-mock" ,python-mock)
+       ("python-pylint" ,python-pylint)
+       ("python-pytest" ,python-pytest)
+       ("python-vcrpy" ,python-vcrpy)))
+    (home-page "https://gitlab.com/ajak/tuir")
+    (synopsis "Terminal viewer for Reddit (Terminal UI for Reddit)")
+    (description
+     "Tuir provides a simple terminal viewer for Reddit (Terminal UI for Reddit).")
+    (license (list license:expat
+                   license:gpl3+))))    ; tuir/packages/praw
-- 
2.26.0

Message #8 received at 40318 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>, 40318 <at> debbugs.gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#40318] [PATCH] gnu: Add tuir.
Date: Thu, 02 Apr 2020 19:14:25 +0200

[Message part 1 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> * gnu/packages/syndication.scm (tuir): New variable.

[...]

> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (add-installed-pythonpath inputs outputs)
> +             (invoke "py.test" "-v"))))))
> +    (propagated-inputs
> +     `(("python-beautifulsoup4" ,python-beautifulsoup4)
> +       ("python-decorator" ,python-decorator)
> +       ("python-kitchen" ,python-kitchen)
> +       ("python-requests" ,python-requests)
> +       ("python-six" ,python-six)))

As this is a terminal application, I guess these inputs can be regular
inputs instead of propagated?  The 'wrap' phase should take care of
things automatically.

Also note that "py.test" is deprecated and one is supposed to use just
"pytest" nowadays IIRC.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 40318-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40318-done <at> debbugs.gnu.org
Subject: Re: [bug#40318] [PATCH] gnu: Add tuir.
Date: Sun, 5 Apr 2020 09:44:49 +0300

[Message part 1 (text/plain, inline)]

On Thu, Apr 02, 2020 at 07:14:25PM +0200, Marius Bakke wrote:
> Efraim Flashner <efraim <at> flashner.co.il> writes:
> 
> > * gnu/packages/syndication.scm (tuir): New variable.
> 
> [...]
> 
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (replace 'check
> > +           (lambda* (#:key inputs outputs #:allow-other-keys)
> > +             (add-installed-pythonpath inputs outputs)
> > +             (invoke "py.test" "-v"))))))
> > +    (propagated-inputs
> > +     `(("python-beautifulsoup4" ,python-beautifulsoup4)
> > +       ("python-decorator" ,python-decorator)
> > +       ("python-kitchen" ,python-kitchen)
> > +       ("python-requests" ,python-requests)
> > +       ("python-six" ,python-six)))
> 
> As this is a terminal application, I guess these inputs can be regular
> inputs instead of propagated?  The 'wrap' phase should take care of
> things automatically.
> 

Good call, I forgot about that one.

> Also note that "py.test" is deprecated and one is supposed to use just
> "pytest" nowadays IIRC.

TIL. I was working from their test suite command.

Patch pushed.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.