GNU bug report logs - #40321
[PATCH] Add python-tortoise-orm

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40321 in the body.
You can then email your comments to 40321 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add python-tortoise-orm
Date: Mon, 30 Mar 2020 08:43:34 +0200

[Message part 1 (text/plain, inline)]

Hi,

this patchset adds python-tortoise-orm and dependencies.

Cheers,
Lars

[0001-gnu-Add-python-aiounittest.patch (text/x-diff, attachment)]

[0002-gnu-Add-python-aiosqlite.patch (text/x-diff, attachment)]

[0003-gnu-Add-python-pypika.patch (text/x-diff, attachment)]

[0004-gnu-Add-python-ciso8601.patch (text/x-diff, attachment)]

[0005-gnu-Add-python-tortoise-orm.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 40321-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 40321-done <at> debbugs.gnu.org
Subject: Re: [bug#40321] [PATCH] Add python-tortoise-orm
Date: Mon, 30 Mar 2020 14:52:53 -0400

On Mon, Mar 30, 2020 at 08:43:34AM +0200, Lars-Dominik Braun wrote:
> this patchset adds python-tortoise-orm and dependencies.

Thanks! Pushed as 1110a421f4c9ede6ee814e678135a1dd2ac05fc9 with some
changes...

I added copyright lines for you and edited some of the descriptions to
fix typos and grammatical mistakes.

> +(define-public python-ciso8601
> +  (package
> +    (name "python-ciso8601")
> +    (version "2.1.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       ;; Pypi package lacks file tests.py
> +       (uri (git-reference
> +             (url "https://github.com/closeio/ciso8601.git")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0g1aiyc1ayh0rnibyy416m5mmck38ksgdm3jsy0z3rxgmgb24951"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("python-pytz" ,python-pytz)))

According to README.rst, this should only be required with Python 2, but
the tests fail without it. Can we amend the package to just fetch from
PyPi and remove this dependency?

Message #13 received at 40321-done <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40321-done <at> debbugs.gnu.org
Subject: Re: [bug#40321] [PATCH] Add python-tortoise-orm
Date: Tue, 31 Mar 2020 08:04:02 +0200

[Message part 1 (text/plain, inline)]

Hi,

> Thanks! Pushed as 1110a421f4c9ede6ee814e678135a1dd2ac05fc9 with some
> changes...
thank you.

> Can we amend the package to just fetch from PyPi and remove this dependency?
You mean amend tests_require in setup.py?

Lars

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 40321-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 40321-done <at> debbugs.gnu.org
Subject: Re: [bug#40321] [PATCH] Add python-tortoise-orm
Date: Tue, 31 Mar 2020 10:27:16 -0400

[Message part 1 (text/plain, inline)]

On Tue, Mar 31, 2020 at 08:04:02AM +0200, Lars-Dominik Braun wrote:
> > Can we amend the package to just fetch from PyPi and remove this dependency?
> You mean amend tests_require in setup.py?

Not sure... I noticed your comment said that the PyPi source did not
include the tests. If we built from that source, would the package still
build, or would the test phase fail somehow?

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 40321-done <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40321-done <at> debbugs.gnu.org
Subject: Re: [bug#40321] [PATCH] Add python-tortoise-orm
Date: Wed, 1 Apr 2020 08:09:39 +0200

[Message part 1 (text/plain, inline)]

Hi,

> > You mean amend tests_require in setup.py?
(that does not work by the way, because the tests really *do* require pytz)

> Not sure... I noticed your comment said that the PyPi source did not
> include the tests. If we built from that source, would the package still
> build, or would the test phase fail somehow?
Yep, the test phase fails.

---snip---
======================================================================
ERROR: tests (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: tests
Traceback (most recent call last):
  File "/gnu/store/78w7y0lxar70j512iqw8x3nimzj10yga-python-3.7.4/lib/python3.7/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
ModuleNotFoundError: No module named 'tests'
---snap---

I guess we could pass `#:tests? #f`, but is that worth it? pytz is just a
native input and not propagated.

Lars

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 40321-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 40321-done <at> debbugs.gnu.org
Subject: Re: [bug#40321] [PATCH] Add python-tortoise-orm
Date: Wed, 1 Apr 2020 12:09:11 -0400

On Wed, Apr 01, 2020 at 08:09:39AM +0200, Lars-Dominik Braun wrote:
> I guess we could pass `#:tests? #f`, but is that worth it? pytz is just a
> native input and not propagated.

Okay!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.