GNU bug report logs - #40325
make backup files for "-i" option invisible

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 30 Mar 2020 15:41:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 30 11:41:03 2020
Received: from localhost ([127.0.0.1]:34909 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jIwX8-0007my-NF
	for submit <at> debbugs.gnu.org; Mon, 30 Mar 2020 11:41:03 -0400
Received: from lists.gnu.org ([209.51.188.17]:39916)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <aon.913677709@HIDDEN>) id 1jItDg-0007ir-Sp
 for submit <at> debbugs.gnu.org; Mon, 30 Mar 2020 08:08:45 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:36495)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <aon.913677709@HIDDEN>) id 1jItDf-0004rO-R9
 for bug-sed@HIDDEN; Mon, 30 Mar 2020 08:08:44 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: **
X-Spam-Status: No, score=2.9 required=5.0 tests=BAYES_40,DATE_IN_PAST_24_48,
 FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL,
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <aon.913677709@HIDDEN>) id 1jItDe-0006Vy-Ox
 for bug-sed@HIDDEN; Mon, 30 Mar 2020 08:08:43 -0400
Received: from smtpout.aon.at ([195.3.96.115]:34371)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <aon.913677709@HIDDEN>)
 id 1jItDe-0006U2-ER
 for bug-sed@HIDDEN; Mon, 30 Mar 2020 08:08:42 -0400
Received: (qmail 20739 invoked from network); 30 Mar 2020 12:08:38 -0000
Received: from 100-69-160-118.rfc6598.a1.net (HELO golem.localdomain)
 ([100.69.160.118]) (envelope-sender <aon.913677709@HIDDEN>)
 by smarthub79.res.a1.net (qmail-ldap-1.03) with SMTP
 for <bug-sed@HIDDEN>; 30 Mar 2020 12:08:38 -0000
X-A1Mail-Track-Id: 1585570118:20599:smarthub79:100.69.160.118:1
Date: Sat, 28 Mar 2020 17:00:12 +0100
From: nokangaroo <aon.913677709@HIDDEN>
To: bug-sed@HIDDEN
Subject: make backup files for "-i" option invisible
Message-Id: <20200328170012.358bb8a78458a50f43f79267@HIDDEN>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]
X-Received-From: 195.3.96.115
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  The visible backup files create problems with file managers, 
 e. g. they show up in MATE, and I have to reload the folder to make them
 disappear. The following patch creates invisible files: --- sed/execute.c
 2020-01-01 20:38:19.000000000 +0100 +++ sed/execute.c 2020-03-26
 12:17:30.209662815 +0100 @@ -614,7 +614,7 @@ } } 
 Content analysis details:   (3.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
 blocked.  See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
 for more information. [URIs: aon.at]
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (aon.913677709[at]aon.at)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (aon.913677709[at]aon.at)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.5 DATE_IN_PAST_24_48     Date: is 24 to 48 hours before Received: date
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
 low trust [209.51.188.17 listed in list.dnswl.org]
 2.0 SPOOFED_FREEMAIL       No description available.
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Mon, 30 Mar 2020 11:41:02 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

The visible backup files create problems with file managers, e. g. they show up
in MATE, and I have to reload the folder to make them disappear. The following
patch creates invisible files:

--- sed/execute.c	2020-01-01 20:38:19.000000000 +0100
+++ sed/execute.c	2020-03-26 12:17:30.209662815 +0100
@@ -614,7 +614,7 @@
             }
         }
 
-      output_file.fp = ck_mkstemp (&input->out_file_name, tmpdir, "sed",
+      output_file.fp = ck_mkstemp (&input->out_file_name, tmpdir, ".sed",
                                    write_mode);
       register_cleanup_file (input->out_file_name);
       output_file.missing_newline = false;


This works because ck_mkstemp tests for strlen.
BTW why not use /tmp instead of '.'?

-- 
nokangaroo <aon.913677709@HIDDEN>