GNU bug report logs - #40350
[PATCH] ui: Mention that changes to package definitions can cause "upgrades".

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Tue, 31 Mar 2020 15:17:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40350 in the body.
You can then email your comments to 40350 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40350; Package guix-patches. (Tue, 31 Mar 2020 15:17:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 31 Mar 2020 15:17:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] ui: Mention that changes to package definitions can cause
 "upgrades".
Date: Tue, 31 Mar 2020 11:15:32 -0400
* guix/ui.scm (show-manifest-transaction)[upgrade-string]: Use the
package name in UI message.
---
 guix/ui.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 1e24fe5dca..20b1e79ca9 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2019 Simon Tournier <zimon.toutoune <at> gmail.com>
+;;; Copyright © 2020 Leo Famulari <leo <at> famulari.name>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1162,11 +1163,13 @@ separator between subsequent columns."
                               name
                               (string-append name ":" output)))
                         names outputs)
-                   (map (lambda (old new)
+                   (map (lambda (old new name)
                           (if (string=? old new)
-                              (G_ "(dependencies changed)")
+                              (format
+                                (G_ "(dependencies or ~a package recipe changed)")
+                                name)
                               (string-append old " " → " " new)))
-                        old-version new-version))
+                        old-version new-version names))
               #:initial-indent 3))
 
   (let-values (((remove install upgrade downgrade)
-- 
2.26.0





Information forwarded to guix-patches <at> gnu.org:
bug#40350; Package guix-patches. (Wed, 01 Apr 2020 21:04:02 GMT) Full text and rfc822 format available.

Message #8 received at 40350 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40350 <at> debbugs.gnu.org
Subject: Re: [bug#40350] [PATCH] ui: Mention that changes to package
 definitions can cause "upgrades".
Date: Wed, 01 Apr 2020 23:03:22 +0200
Hi,

Leo Famulari <leo <at> famulari.name> skribis:

> * guix/ui.scm (show-manifest-transaction)[upgrade-string]: Use the
> package name in UI message.

[...]

>                            (if (string=? old new)
> -                              (G_ "(dependencies changed)")
> +                              (format
> +                                (G_ "(dependencies or ~a package recipe changed)")

Is that not implied in a way?

If it is, how about something shorter like:

  (dependencies or package changed)

?

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#40350; Package guix-patches. (Wed, 01 Apr 2020 21:15:02 GMT) Full text and rfc822 format available.

Message #11 received at 40350 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40350 <at> debbugs.gnu.org
Subject: Re: [bug#40350] [PATCH] ui: Mention that changes to package
 definitions can cause "upgrades".
Date: Wed, 1 Apr 2020 17:13:52 -0400
On Wed, Apr 01, 2020 at 11:03:22PM +0200, Ludovic Courtès wrote:
> Is that not implied in a way?

It is, but I think we will still get some confused users asking about
it.

> If it is, how about something shorter like:
> 
>   (dependencies or package changed)

Yeah, I think that's okay.




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 02 Apr 2020 08:06:02 GMT) Full text and rfc822 format available.

Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Thu, 02 Apr 2020 08:06:02 GMT) Full text and rfc822 format available.

Message #16 received at 40350-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40350-done <at> debbugs.gnu.org
Subject: Re: [bug#40350] [PATCH] ui: Mention that changes to package
 definitions can cause "upgrades".
Date: Thu, 02 Apr 2020 10:05:05 +0200
Hi,

Leo Famulari <leo <at> famulari.name> skribis:

> On Wed, Apr 01, 2020 at 11:03:22PM +0200, Ludovic Courtès wrote:
>> Is that not implied in a way?
>
> It is, but I think we will still get some confused users asking about
> it.
>
>> If it is, how about something shorter like:
>> 
>>   (dependencies or package changed)
>
> Yeah, I think that's okay.

OK, done!

Thanks,
Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 30 Apr 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 333 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.