GNU bug report logs - #40358
Add beancount

Previous Next

Package: guix-patches;

Reported by: Christopher Lemmer Webber <cwebber <at> dustycloud.org>

Date: Tue, 31 Mar 2020 21:04:01 UTC

Severity: normal

Done: Christopher Lemmer Webber <cwebber <at> dustycloud.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40358 in the body.
You can then email your comments to 40358 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40358; Package guix-patches. (Tue, 31 Mar 2020 21:04:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christopher Lemmer Webber <cwebber <at> dustycloud.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 31 Mar 2020 21:04:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: guix-patches <at> gnu.org
Subject: Add beancount
Date: Tue, 31 Mar 2020 17:03:23 -0400
[Message part 1 (text/plain, inline)]
Yet Another Plaintext Accounting System!

[0001-gnu-Add-beancount.patch (text/x-patch, inline)]
From 27274e0075f7215693cc4a51482c68ce00167d37 Mon Sep 17 00:00:00 2001
From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Date: Tue, 31 Mar 2020 16:57:15 -0400
Subject: [PATCH] gnu: Add beancount.

* gnu/packages/finance.scm (beancount): New variable.
* gnu/packages/patches/beancount-disable-googleapis-fonts.patch: New file.
---
 gnu/packages/finance.scm                      | 42 +++++++++++++++++++
 .../beancount-disable-googleapis-fonts.patch  | 23 ++++++++++
 2 files changed, 65 insertions(+)
 create mode 100644 gnu/packages/patches/beancount-disable-googleapis-fonts.patch

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 7bf8f4fc6e..53bbbb2f84 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2019 Martin Becze <mjbecze <at> riseup.net>
 ;;; Copyright © 2019 Sebastian Schott <sschott <at> mailbox.org>
 ;;; Copyright © 2020 Kei Kebreau <kkebreau <at> posteo.net>
+;;; Copyright © 2020 Christopher Lemmer Webber <cwebber <at> dustycloud.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1398,3 +1399,44 @@ entity management.")
 electronic cash system.  This package provides a command line client and
 a Qt GUI.")
     (license license:expat)))
+
+(define-public beancount
+  (package
+    (name "beancount")
+    (version "2.2.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "beancount" version))
+       (sha256
+        (base32
+         "0pcfl2rx2ng06i4f9izdpnlnb1k0rdzsckbzzn4cn4ixfzyssm0m"))
+       (patches (search-patches "beancount-disable-googleapis-fonts.patch"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f  ; Says test is missing, not sure why
+       #:phases
+       (modify-phases %standard-phases
+         ;; Not importing the googleapis package for now
+         (add-after 'unpack 'ignore-googleapis
+           (lambda _
+             (substitute* "setup.py"
+               (("'google-api-python-client',") ""))
+             #t)))))
+    (propagated-inputs
+     `(("python-beautifulsoup4" ,python-beautifulsoup4)
+       ("python-bottle" ,python-bottle)
+       ("python-chardet" ,python-chardet)
+       ("python-dateutil" ,python-dateutil)
+       ("python-lxml" ,python-lxml)
+       ("python-magic" ,python-magic)
+       ("python-ply" ,python-ply)
+       ("python-pytest" ,python-pytest)
+       ("python-requests" ,python-requests)))
+    (home-page "http://furius.ca/beancount")
+    (synopsis "Command-line Double-Entry Accounting")
+    (description
+     "A double-entry bookkeeping computer language that lets you define
+financial transaction records in a text file, read them in memory, generate
+a variety of reports from them, and provides a web interface.")
+    (license license:gpl2)))
diff --git a/gnu/packages/patches/beancount-disable-googleapis-fonts.patch b/gnu/packages/patches/beancount-disable-googleapis-fonts.patch
new file mode 100644
index 0000000000..f3ef574ddc
--- /dev/null
+++ b/gnu/packages/patches/beancount-disable-googleapis-fonts.patch
@@ -0,0 +1,23 @@
+From: Nicolas Dandrimont <nicolas <at> dandrimont.eu>
+Date: Tue, 1 May 2018 04:49:55 +0200
+Subject: Remove fonts.googleapis.com links for the bean-web template
+
+---
+ beancount/web/web.html | 4 ----
+ 1 file changed, 4 deletions(-)
+
+diff --git a/beancount/web/web.html b/beancount/web/web.html
+index 3995ce2..ec9e707 100644
+--- a/beancount/web/web.html
++++ b/beancount/web/web.html
+@@ -3,10 +3,6 @@
+   <head>
+     <meta content="text/html; charset=utf-8" http-equiv="Content-Type" />
+ 
+-    <link href="https://fonts.googleapis.com/css?family=Roboto+Condensed:400italic,700italic,700,400" rel="stylesheet" type="text/css" />
+-    <link href="https://fonts.googleapis.com/css?family=Roboto:400italic,700italic,700,400" rel="stylesheet" type="text/css" />
+-    <link href='https://fonts.googleapis.com/css?family=Droid+Sans+Mono' rel='stylesheet' type='text/css' />
+-
+     <link href="/resources/web.css" rel="stylesheet" type="text/css" />
+     <title>{{title}}: {{pagetitle}}</title>
+ 
\ No newline at end of file
-- 
2.25.1

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#40358; Package guix-patches. (Thu, 02 Apr 2020 13:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 40358 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Cc: 40358 <at> debbugs.gnu.org
Subject: Re: [bug#40358] Add beancount
Date: Thu, 02 Apr 2020 15:44:01 +0200
Hello!

Christopher Lemmer Webber <cwebber <at> dustycloud.org> skribis:

> From 27274e0075f7215693cc4a51482c68ce00167d37 Mon Sep 17 00:00:00 2001
> From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
> Date: Tue, 31 Mar 2020 16:57:15 -0400
> Subject: [PATCH] gnu: Add beancount.
>
> * gnu/packages/finance.scm (beancount): New variable.
> * gnu/packages/patches/beancount-disable-googleapis-fonts.patch: New file.

Could you add the patch to gnu/local.mk?

> +    (home-page "http://furius.ca/beancount")
> +    (synopsis "Command-line Double-Entry Accounting")

Nitpick: please remote capitals except for the first one, and…

> +    (description
> +     "A double-entry bookkeeping computer language that lets you define
> +financial transaction records in a text file, read them in memory, generate
> +a variety of reports from them, and provides a web interface.")

… make it a full sentence.

> +++ b/gnu/packages/patches/beancount-disable-googleapis-fonts.patch
> @@ -0,0 +1,23 @@
> +From: Nicolas Dandrimont <nicolas <at> dandrimont.eu>
> +Date: Tue, 1 May 2018 04:49:55 +0200
> +Subject: Remove fonts.googleapis.com links for the bean-web template

Could you add the URL of the upstream patch or discussion, if any?

OK with these changes!

Thanks,
Ludo’.




Reply sent to Christopher Lemmer Webber <cwebber <at> dustycloud.org>:
You have taken responsibility. (Thu, 02 Apr 2020 15:21:01 GMT) Full text and rfc822 format available.

Notification sent to Christopher Lemmer Webber <cwebber <at> dustycloud.org>:
bug acknowledged by developer. (Thu, 02 Apr 2020 15:21:01 GMT) Full text and rfc822 format available.

Message #13 received at 40358-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40358-done <at> debbugs.gnu.org
Subject: Re: [bug#40358] Add beancount
Date: Thu, 02 Apr 2020 11:20:20 -0400
Ludovic Courtès writes:

> Hello!
>
> Christopher Lemmer Webber <cwebber <at> dustycloud.org> skribis:
>
>> From 27274e0075f7215693cc4a51482c68ce00167d37 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
>> Date: Tue, 31 Mar 2020 16:57:15 -0400
>> Subject: [PATCH] gnu: Add beancount.
>>
>> * gnu/packages/finance.scm (beancount): New variable.
>> * gnu/packages/patches/beancount-disable-googleapis-fonts.patch: New file.
>
> Could you add the patch to gnu/local.mk?

Good call.  Done.

>> +    (home-page "http://furius.ca/beancount")
>> +    (synopsis "Command-line Double-Entry Accounting")
>
> Nitpick: please remote capitals except for the first one, and…

Done.

>> +    (description
>> +     "A double-entry bookkeeping computer language that lets you define
>> +financial transaction records in a text file, read them in memory, generate
>> +a variety of reports from them, and provides a web interface.")
>
> … make it a full sentence.

Okay, done.

>> +++ b/gnu/packages/patches/beancount-disable-googleapis-fonts.patch
>> @@ -0,0 +1,23 @@
>> +From: Nicolas Dandrimont <nicolas <at> dandrimont.eu>
>> +Date: Tue, 1 May 2018 04:49:55 +0200
>> +Subject: Remove fonts.googleapis.com links for the bean-web template
>
> Could you add the URL of the upstream patch or discussion, if any?
>
> OK with these changes!
>
> Thanks,
> Ludo’.

Pushed!  Thanks for your review!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 01 May 2020 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 353 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.