GNU bug report logs - #40383
[PATCH 0/5] Make some inputs native.

Previous Next

Package: guix-patches;

Reported by: Vincent Legoll <vincent.legoll <at> gmail.com>

Date: Wed, 1 Apr 2020 23:21:03 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40383 in the body.
You can then email your comments to 40383 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Wed, 01 Apr 2020 23:21:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vincent Legoll <vincent.legoll <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 01 Apr 2020 23:21:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/5] Make some inputs native.
Date: Thu, 2 Apr 2020 01:20:35 +0200
This is the reworked patchset sent yesterday
to guix-devel.

I hope I did not miss any review comment.

I dropped the cgit patch, reworded the commit
messages, added perl to the native-inputs of
darktable, guix linted all (graphviz still has some
lint problems, looks like they moved to gitlab, I'll
let that for another day)

-- 
Vincent Legoll




Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Wed, 01 Apr 2020 23:23:02 GMT) Full text and rfc822 format available.

Message #8 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 40383 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 1/5] gnu: darktable: Make some inputs native.
Date: Thu,  2 Apr 2020 01:22:21 +0200
* gnu/packages/photo.scm (darktable)[inputs]: Move intltool, perl & pkg-config
from here...
[native-inputs]: ...to here.
---
 gnu/packages/photo.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index 585289daf1..7cb67dcbe6 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2020 Sebastian Schott <sschott <at> mailbox.org>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -483,6 +484,10 @@ photographic equipment.")
                      (string-append (assoc-ref inputs "ilmbase")
                                     "/include/OpenEXR:" (or (getenv "CPATH") "")))
              #t)))))
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)))
     (inputs
      `(("libxslt" ,libxslt)
        ("libxml2" ,libxml2)
@@ -502,9 +507,6 @@ photographic equipment.")
        ("ilmbase" ,ilmbase)
        ("libsoup" ,libsoup)
        ("python-jsonschema" ,python-jsonschema)
-       ("intltool" ,intltool)
-       ("perl" ,perl)
-       ("pkg-config" ,pkg-config)
        ("libwebp" ,libwebp)
        ("lensfun" ,lensfun)
        ("librsvg" ,librsvg)
-- 
2.25.2





Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Wed, 01 Apr 2020 23:23:02 GMT) Full text and rfc822 format available.

Message #11 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 40383 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 2/5] gnu: graphviz: Make some inputs native.
Date: Thu,  2 Apr 2020 01:22:22 +0200
* gnu/packages/graphviz.scm (graphviz)[inputs]: Move swig from here...
[native-inputs]: ...to here.
---
 gnu/packages/graphviz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm
index 2d2bb11130..051089881a 100644
--- a/gnu/packages/graphviz.scm
+++ b/gnu/packages/graphviz.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2017 Gábor Boskovits <boskovits <at> gmail.com>
 ;;; Copyright © 2018 Mathieu Lirzin <mthl <at> gnu.org>
 ;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -97,7 +98,6 @@
        ("gts" ,gts)
        ("gd" ,gd)                                 ; FIXME: Our GD is too old
        ("guile" ,guile-2.0)                       ;Guile bindings
-       ("swig" ,swig)
        ("pango" ,pango)
        ("fontconfig" ,fontconfig)
        ("freetype" ,freetype)
@@ -108,6 +108,7 @@
        ("libpng" ,libpng)))
     (native-inputs
      `(("bison" ,bison)
+       ("swig" ,swig)
        ("pkg-config" ,pkg-config)))
     (outputs '("out" "doc"))                      ; 5 MiB of html + pdfs
     (home-page "http://www.graphviz.org/")
-- 
2.25.2





Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Wed, 01 Apr 2020 23:23:03 GMT) Full text and rfc822 format available.

Message #14 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 40383 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 3/5] gnu: iwd: Make some inputs native.
Date: Thu,  2 Apr 2020 01:22:23 +0200
* gnu/packages/networking.scm (iwd)[inputs]: Move libtool from here...
[native-inputs]: ...to here.
---
 gnu/packages/networking.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index ec2f0b64bd..79b07e23f0 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2712,13 +2712,13 @@ protocol daemons for BGP, IS-IS, LDP, OSPF, PIM, and RIP. ")
     (build-system gnu-build-system)
     (inputs
      `(("dbus" ,dbus)
-       ("libtool" ,libtool)
        ("ell" ,ell)
        ("readline" ,readline)))
     (native-inputs
      `(("asciidoc" ,asciidoc)
        ("autoconf" ,autoconf)
        ("automake" ,automake)
+       ("libtool" ,libtool)
        ("pkgconfig" ,pkg-config)
        ("python" ,python)
        ("openssl" ,openssl)))
-- 
2.25.2





Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Wed, 01 Apr 2020 23:23:03 GMT) Full text and rfc822 format available.

Message #17 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 40383 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 4/5] gnu: mailutils: Make some inputs native.
Date: Thu,  2 Apr 2020 01:22:24 +0200
* gnu/packages/mail.scm (mailutils)[inputs]: Move dejagnu from here...
[native-inputs]: ...to here.
---
 gnu/packages/mail.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 0cb3eddf15..ed14360066 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2018 Gábor Boskovits <boskovits <at> gmail.com>
 ;;; Copyright © 2018, 2019, 2020 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -218,11 +219,11 @@
 
        #:parallel-tests? #f))
     (native-inputs
-     `(("perl" ,perl)))                           ;for 'gylwrap'
-    (inputs
-     `(("dejagnu" ,dejagnu)
-       ("m4" ,m4)
+     `(("perl" ,perl)                           ;for 'gylwrap'
        ("texinfo" ,texinfo)
+       ("dejagnu" ,dejagnu)))
+    (inputs
+     `(("m4" ,m4)
        ("guile" ,guile-2.2)
        ("gsasl" ,gsasl)
        ("gnutls" ,gnutls)
-- 
2.25.2





Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Wed, 01 Apr 2020 23:23:03 GMT) Full text and rfc822 format available.

Message #20 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 40383 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 5/5] gnu: nethack: Make some inputs native.
Date: Thu,  2 Apr 2020 01:22:25 +0200
* gnu/packages/games.scm (nethack)[inputs]: Move flex & bison from here...
[native-inputs]: ...to this new field.
---
 gnu/packages/games.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 8a24dad33d..4d4b2b0b05 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2020 Naga Malleswari <nagamalli <at> riseup.net>
 ;;; Copyright © 2020 Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1293,10 +1294,11 @@ watch your CPU playing while enjoying a cup of tea!")
                         (string-join (string-split version #\.) "") "-src.tgz"))
         (sha256
           (base32 "1liyckjp34j354qnxc1zn9730lh1p2dabrg1hap24z6xnqx0rpng"))))
+    (native-inputs
+      `(("bison" ,bison)
+        ("flex" ,flex)))
     (inputs
       `(("ncurses" ,ncurses)
-        ("bison" ,bison)
-        ("flex" ,flex)
         ("less" ,less)))
     (build-system gnu-build-system)
     (arguments
-- 
2.25.2





Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Thu, 02 Apr 2020 09:17:01 GMT) Full text and rfc822 format available.

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>, 40383 <at> debbugs.gnu.org
Subject: Re: [bug#40383] [PATCH 0/5] Make some inputs native.
Date: Thu, 02 Apr 2020 11:16:34 +0200
Hello Vincent,

> I hope I did not miss any review comment.
>
> I dropped the cgit patch, reworded the commit
> messages, added perl to the native-inputs of
> darktable, guix linted all (graphviz still has some
> lint problems, looks like they moved to gitlab, I'll
> let that for another day)

Thanks for the updated serie. Some of these patches trigger a lot of
rebuilds. If you read this page[1], point 8, you will see that there's a
limit of 300 dependencies for pushing to master.

Graphviz has 1370 dependencies, which makes it a candidate for
core-updates branch that has been frozen recently. Maybe we can start a
'core-updates-next' branch. Marius, WDYT?

Mailutils has 125 dependencies, which is under the 300 limit so I'll
push it on master.

The other patches are fine :)

Thanks,

Mathieu

[1]: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html,




Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Thu, 02 Apr 2020 09:17:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Thu, 02 Apr 2020 16:02:02 GMT) Full text and rfc822 format available.

Message #29 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 40383 <at> debbugs.gnu.org
Subject: Re: [bug#40383] [PATCH 0/5] Make some inputs native.
Date: Thu, 02 Apr 2020 18:01:32 +0200
[Message part 1 (text/plain, inline)]
Mathieu Othacehe <m.othacehe <at> gmail.com> writes:

> Graphviz has 1370 dependencies, which makes it a candidate for
> core-updates branch that has been frozen recently. Maybe we can start a
> 'core-updates-next' branch. Marius, WDYT?

I've been meaning to rework the rebuild limits from the manual as a lot
has changed since that was written.  In particular I want to keep "mesa"
on 'staging', but that has crept to almost 2000 rebuilds!

Perhaps we need another tier in between staging and core-updates, or
just aim for slower staging cycles (as has been de facto a while..).

Anyway for now I think this can go to 'staging'.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Thu, 02 Apr 2020 16:19:02 GMT) Full text and rfc822 format available.

Message #32 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40383 <at> debbugs.gnu.org
Subject: Re: [bug#40383] [PATCH 0/5] Make some inputs native.
Date: Thu, 02 Apr 2020 18:18:20 +0200
> I've been meaning to rework the rebuild limits from the manual as a lot
> has changed since that was written.  In particular I want to keep "mesa"
> on 'staging', but that has crept to almost 2000 rebuilds!

Yup, an updated documentation section would be great!

>
> Perhaps we need another tier in between staging and core-updates, or
> just aim for slower staging cycles (as has been de facto a while..).
>
> Anyway for now I think this can go to 'staging'.

Ok, pushed on staging, thanks for your help.

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Thu, 02 Apr 2020 16:21:02 GMT) Full text and rfc822 format available.

Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 40383-done <at> debbugs.gnu.org
Subject: Re: [bug#40383] [PATCH 0/5] Make some inputs native.
Date: Thu, 02 Apr 2020 18:20:07 +0200
I pushed the graphviz patch on the staging branch and the other ones on
master.

Thanks,

Mathieu




Reply sent to Mathieu Othacehe <m.othacehe <at> gmail.com>:
You have taken responsibility. (Thu, 02 Apr 2020 16:21:02 GMT) Full text and rfc822 format available.

Notification sent to Vincent Legoll <vincent.legoll <at> gmail.com>:
bug acknowledged by developer. (Thu, 02 Apr 2020 16:21:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#40383; Package guix-patches. (Thu, 02 Apr 2020 17:46:02 GMT) Full text and rfc822 format available.

Message #43 received at 40383 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 40383 <at> debbugs.gnu.org
Subject: numerous rebuilds
Date: Thu, 2 Apr 2020 19:44:59 +0200
Mathieu,

I knew about the rebuild limit, and
told about it in the other thread:

> The graphviz patch may not be for master
> as it may force 2918 packages to be rebuilt.
> The other ones should be OK.

But it has been a long thread.

I should have restated it here, in the repost...

Thanks

-- 
Vincent Legoll




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 01 May 2020 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 332 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.