GNU bug report logs - #40418
28.0.50; ERC quit server causes error in `erc-server-send-queue` timer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40418 in the body.
You can then email your comments to 40418 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Narendra Joshi <narendraj9 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; ERC quit server causes error in `erc-server-send-queue` timer
Date: Fri, 03 Apr 2020 23:00:36 +0200

Using `erc-quit-server' command causes the following error:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (error "Selecting deleted buffer")
 erc-server-send-queue(#<killed buffer>)
 apply(erc-server-send-queue #<killed buffer>)
 timer-event-handler([t 24199 41423 723955 nil 
 erc-server-send-queue (#<killed buffer>) nil 886000])
--8<---------------cut here---------------end--------------->8---

The timer responsible for sending the message should have been 
cancelled before killing the buffer that is being passed to 
`erc-server-send-queue' function.  

In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 
3.24.5, cairo version 1.16.0)
Repository revision: 1276c8e10b000b571a12227ebe9216cc6305ef7f
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 
11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Best,
-- 
Narendra Joshi

Message #8 received at 40418 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Narendra Joshi <narendraj9 <at> gmail.com>
Cc: 40418 <at> debbugs.gnu.org
Subject: Re: bug#40418: 28.0.50; ERC quit server causes error in
 `erc-server-send-queue` timer
Date: Sun, 02 Aug 2020 07:49:46 +0200

Narendra Joshi <narendraj9 <at> gmail.com> writes:

> Using `erc-quit-server' command causes the following error:
>
> Debugger entered--Lisp error: (error "Selecting deleted buffer")
>   erc-server-send-queue(#<killed buffer>)
>   apply(erc-server-send-queue #<killed buffer>)
>   timer-event-handler([t 24199 41423 723955 nil 
>   erc-server-send-queue (#<killed buffer>) nil 886000])
>
> The timer responsible for sending the message should have been 
> cancelled before killing the buffer that is being passed to 
> `erc-server-send-queue' function.  

If I'm reading the code correctly, the timer is only set in a variable
buffer-local to the killed buffer itself, so killing the timer isn't
trivial.  Instead I've made erc-server-send-queue check that the buffer
is live before trying to use it, which I think should fix this.

(Applied to Emacs 28.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.