GNU bug report logs - #40429
[PATCH] gnu: Add emacs-flymake-shellcheck.

Previous Next

Package: guix-patches;

Reported by: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>

Date: Sat, 4 Apr 2020 15:36:02 UTC

Severity: normal

Tags: patch

Merged with 51364

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40429 in the body.
You can then email your comments to 40429 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#40429; Package guix-patches. (Sat, 04 Apr 2020 15:36:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 04 Apr 2020 15:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-flymake-shellcheck.
Date: Sat, 04 Apr 2020 10:35:13 -0500

[Message part 1 (text/plain, inline)]
Patch file is attached.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-flymake-shellcheck.patch (text/x-patch, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#40429; Package guix-patches. (Sun, 05 Apr 2020 08:12:02 GMT) Full text and rfc822 format available.

Message #8 received at 40429 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 40429 <at> debbugs.gnu.org
Subject: Re: [bug#40429] [PATCH] gnu: Add emacs-flymake-shellcheck.
Date: Sun, 05 Apr 2020 10:11:41 +0200

Hello,

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> +      (inputs
> +       `(("shellcheck" ,shellcheck)))
> +      (arguments
> +       '(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'hardcode-shellcheck-path
> +             (lambda _
> +               (let ((file "flymake-shellcheck.el"))
> +                 (chmod file #o644)
> +                 (emacs-substitute-sexps file
> +                   ("(defcustom flymake-shellcheck-path"
> +                    (which "shellcheck")))))))))

You could use `emacs-substitute-variables' here.

However, I wonder if we should add "shellcheck" as an input. Of course,
the package will not work so well if "shellcheck" is not available. But,
as a user, it would not cross my mind to use "flymake-shellcheck"
without it. As another data point, "emacs-flycheck-rust" doesn't add
"rust" as an input.

WDYT?

Regards,

-- 
Nicolas Goaziou
Merged 40429 51364. Request was from Morgan Smith <Morgan.J.Smith <at> outlook.com> to control <at> debbugs.gnu.org. (Sat, 23 Oct 2021 22:25:01 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 03 Dec 2021 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 137 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.