GNU bug report logs - #40479
[PATCH] gnu: Add fdroidcl.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40479 in the body.
You can then email your comments to 40479 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH] gnu: Add fdroidcl.
Date: Tue, 7 Apr 2020 06:57:13 +0200

* gnu/packages/android (fdroidcl): New variable.
---
 gnu/packages/android.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 17f5f41fcb..4d1a591686 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2019 Andreas Enge <andreas <at> enge.fr>
 ;;; Copyright © 2019 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2020 Sergey Trofimov <sarg <at> sarg.org.ru>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system android-ndk)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module ((guix licenses) #:prefix license:)
@@ -41,6 +43,7 @@
   #:use-module (gnu packages docker)
   #:use-module (gnu packages gcc)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages java)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pcre)
@@ -946,6 +949,39 @@ publishing, or to assist in creating, testing and submitting metadata to the
 main repository.")
     (license license:agpl3+)))
 
+(define-public fdroidcl
+  (package
+    (name "fdroidcl")
+    (version "0.5.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/mvdan/fdroidcl/archive/"
+                    "v" version ".tar.gz"))
+              (sha256
+               (base32 "0ybqxklhrp23xm89l4g6ms5qxm08db00kx4g6w9vyv11jd68qajk"))))
+    (build-system go-build-system)
+
+    (inputs
+     `(("go-github-com-kr-pretty"
+        ,go-github-com-kr-pretty)
+       ;; used in tests
+       ;; ("go-github-com-rogpeppe-go-internal-testscript"
+       ;;  ,go-github-com-rogpeppe-go-internal-testscript)
+       ("go-gopkg.in-check.v1"
+        ,go-gopkg.in-check.v1)))
+    (arguments
+     `(#:import-path "mvdan.cc/fdroidcl"
+       #:tests? #f ; TODO.
+       #:install-source? #f))
+    (synopsis "F-Droid desktop client")
+    (description
+     "While the Android client integrates with the system with regular update
+checks and notifications, this is a simple command line client that talks to
+connected devicesvia ADB.")
+    (home-page "https://github.com/mvdan/fdroidcl")
+    (license license:bsd-3)))
+
 (define-public enjarify
   (package
     (name "enjarify")
-- 
2.25.1

Message #10 received at 40479 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 40479 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH]: Add fdroidcl.
Date: Mon, 20 Apr 2020 12:16:53 +0300

[Message part 1 (text/plain, inline)]

I made a couple of changes to the patch. It now downloads the source
using git-fetch and I updated the inputs a bit.

For the tests, I'm afraid you're going to need to package the
missing package.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[0001-gnu-Add-fdroidcl.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 40479 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 40479 <at> debbugs.gnu.org, Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: Re: [bug#40479] [PATCH]: Add fdroidcl.
Date: Wed, 09 Sep 2020 23:21:27 +0200

Hi,

Efraim Flashner <efraim <at> flashner.co.il> skribis:

> I made a couple of changes to the patch. It now downloads the source
> using git-fetch and I updated the inputs a bit.
>
> For the tests, I'm afraid you're going to need to package the
> missing package.

[...]

> From efd8708885f451b34cbb712ef6a7d97e8ea598c4 Mon Sep 17 00:00:00 2001
> From: Sergey Trofimov <sarg <at> sarg.org.ru>
> Date: Tue, 7 Apr 2020 06:57:13 +0200
> Subject: [PATCH] gnu: Add fdroidcl.
>
> * gnu/packages/android (fdroidcl): New variable.

[...]

> +    (native-inputs
> +     `(;; used in tests
> +       ;; ("go-github-com-rogpeppe-go-internal-testscript"
> +       ;;  ,go-github-com-rogpeppe-go-internal-testscript)

Perhaps make the comment a TODO and push?

Thanks,
Ludo’.

Message #18 received at 40479-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>, 40479-done <at> debbugs.gnu.org
Subject: Re: [bug#40479] [PATCH]: Add fdroidcl.
Date: Thu, 10 Sep 2020 10:59:31 +0300

[Message part 1 (text/plain, inline)]

On Wed, Sep 09, 2020 at 11:21:27PM +0200, Ludovic Courtès wrote:
> Hi,
> 
> Efraim Flashner <efraim <at> flashner.co.il> skribis:
> 
> > I made a couple of changes to the patch. It now downloads the source
> > using git-fetch and I updated the inputs a bit.
> >
> > For the tests, I'm afraid you're going to need to package the
> > missing package.
> 
> [...]
> 
> > From efd8708885f451b34cbb712ef6a7d97e8ea598c4 Mon Sep 17 00:00:00 2001
> > From: Sergey Trofimov <sarg <at> sarg.org.ru>
> > Date: Tue, 7 Apr 2020 06:57:13 +0200
> > Subject: [PATCH] gnu: Add fdroidcl.
> >
> > * gnu/packages/android (fdroidcl): New variable.
> 
> [...]
> 
> > +    (native-inputs
> > +     `(;; used in tests
> > +       ;; ("go-github-com-rogpeppe-go-internal-testscript"
> > +       ;;  ,go-github-com-rogpeppe-go-internal-testscript)
> 
> Perhaps make the comment a TODO and push?
> 
> Thanks,
> Ludo’.

Works for me.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.