GNU bug report logs - #40495
[PATCH] Add taisei, and spirv-cross

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40495 in the body.
You can then email your comments to 40495 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Add taisei, and spirv-cross
Date: Tue, 07 Apr 2020 19:52:31 +0000

[Message part 1 (text/plain, inline)]

Hi;  taisei is a game, it has three renderers: gl33, gles20, and gles30.  To support later two it need a SPIRV-Cross tool.

   I was told on IRC that the game wasn't playable due to graphics issues, but it worked fine on my machine;  testing and help are welcome.

Game build is "developer" build; it enables cheats, but greatly improves the diagnostics (output to console).  If configured as "debugoptimized" with "-Ddeveloper=false", then it's diagnostics are same as for "release".  I didn't notice any impact on performance with my 7-years old laptop, from those options.

SPIRV-Cross seem to have tests, but i didn't get how to start them yet.

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-taisei-and-spirv-cross.patch (text/x-patch, attachment)]

Message #8 received at 40495 <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "40495 <at> debbugs.gnu.org" <40495 <at> debbugs.gnu.org>
Subject: [PATCH] Add taisei, and spirv-cross
Date: Wed, 08 Apr 2020 06:54:23 +0000

[Message part 1 (text/plain, inline)]

UPDATE:  Game reported playable with gles30 instead of default gl33 (both work for me, so maybe we need to change the default?)
http://logs.guix.gnu.org/2020-04-07.log#163939

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org>
Cc: "40495 <at> debbugs.gnu.org" <40495 <at> debbugs.gnu.org>,
 Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
Subject: Re: [bug#40495] [PATCH] Add taisei, and spirv-cross
Date: Fri, 10 Apr 2020 19:13:20 +0200

Hello,

Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org> writes:

> UPDATE:  Game reported playable with gles30 instead of default gl33 (both work for me, so maybe we need to change the default?)
> http://logs.guix.gnu.org/2020-04-07.log#163939

FWIW gl33 works fine here. 

Some notes: you can drop quotes from descrption. They are not needed an
"..." is not a correct quoting in Texinfo.

Also, I'm not sure the last part of the description is useful. I mean,
this is the same for many arcade games, isn't it?

OOC, don't use need to add (recursive? #t) to `url'?

Regards,

-- 
Nicolas Goaziou

Message #17 received at 40495 <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "40495 <at> debbugs.gnu.org" <40495 <at> debbugs.gnu.org>
Subject: Update
Date: Sat, 11 Apr 2020 07:31:19 +0000

[Message part 1 (text/plain, inline)]

(substitute* "CMakeLists.txt" with assoc-refs of respective tools enable tests... will refine further.  Thanks for a kick.

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

Message #20 received at 40495 <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "40495 <at> debbugs.gnu.org" <40495 <at> debbugs.gnu.org>
Subject: v2, spirv tests steel fail
Date: Sat, 11 Apr 2020 11:11:08 +0000

[Message part 1 (text/plain, inline)]

>>> gl33 works
gl33: http://logs.guix.gnu.org/guix/2020-04-07.log#115246
Please also test with gles30 (it's default now).

>>> quotes, description
removed, cut.

>>> (recursive? #t)
spirv-cross:  gives nothing (to me at least).  I'd used `substitute*` to make tests work, but they're fail.
spirv-tools is a dependency for spirv-cross tests, and spirv-tools tests also fails.  Tests fails, idk how to fix them.

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-taisei-and-spirv-cross.patch (text/x-patch, attachment)]

Message #23 received at 40495 <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "40495 <at> debbugs.gnu.org" <40495 <at> debbugs.gnu.org>
Subject: v3-- fixed indentation
Date: Sat, 11 Apr 2020 12:29:10 +0000

[Message part 1 (text/plain, inline)]

i'm sorry.

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-taisei-and-spirv-cross.patch (text/x-patch, attachment)]

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org>
Cc: "40495 <at> debbugs.gnu.org" <40495 <at> debbugs.gnu.org>,
 Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
Subject: Re: [bug#40495] v3-- fixed indentation
Date: Sat, 11 Apr 2020 22:23:30 +0200

Hello,

Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add taisei, and spirv-cross
>
> * gnu/packages/games.scm  (taisei):      new variable
> * gnu/packages/vulkan.scm (spirv-cross): new variable

It works nicely, thank you.

> +     `(;;configure option developer=true enables the diagnostics
> +       ;;needed for bug reports.  it is 'true' if not "release"
> +       ;;#:build-type "release"

So, what do you suggest here? Use release or developer build?

> +    (synopsis "Fangame and libre clone of Touhou Project")

I would suggest something like

  Shoot'em up game set in a world full of Japanese folklore

> +    (description
> +     "Taisei is a shoot-em-up game: The player controls a character (one of
> +three: Good, Bad, and Dead), dodges the missiles (lots of it cover the screen,
> +but the character's hitbox is very small), and shoot at the adversaries that
> +keep appear on the screen.")


> +    (license (list license:expat      ;game
> +                   license:cc-by4.0   ;resources/00-taisei.pkgdir/bgm/
> +                                        ;atlas/portraits/
> +                   ;;miscellaneous
> +                   license:cc0
> +                   license:public-domain))))

It would be clearer to explain in a comment above the license field what
is subject to what terms.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/KhronosGroup/SPIRV-Cross")
> +             (commit (string-append version))))

You can remove the `string-append' here.

> +       (sha256
> +        (base32
> +         "0489s29kqgq20clxqg22y299yxz23p0yjh87yhka705hm9skx4sa"))
> +       (file-name (git-file-name name version))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f  ;FIXME: Tests fail.

IMO, this is not a blocker. However, if you have more information than
"Tests fail", it would be nice to add it in a comment.

> +       #:configure-flags
> +       (list "-DSPIRV_CROSS_SHARED=YES")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-tests-to-find-deps
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "CMakeLists.txt"
> +               (((string-append "PATHS "
> +                                "\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}"
> +                                "/external/glslang-build/output/bin"))

Why do you need this? What about simply writing the full string without
`string-append'?

> +             (substitute* "CMakeLists.txt"
> +               (((string-append "PATHS "
> +                                "\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}"
> +                                "/external/spirv-tools-build/output/bin"))

Ditto.

> +    (native-inputs `(("glslang" ,glslang)
> +                     ("python" ,python)
> +                     ("spirv-headers" ,spirv-headers)
> +                     ("spirv-tools" ,spirv-tools)))

Nitpick: I would move the inputs below the `native-inputs' line.

> +    (description
> +     "SPIRV-Cross tries hard to emit readable and clean output from the
> +SPIR-V.  The goal is to emit GLSL or MSL that looks like it was written by a
> +human and not awkward IR/assembly-like code.  NOTE: Individual features are

You can drop the "NOTE:" prefix. 

Actually, I think you can drop everything after "NOTE:". Is it useful
information for someone looking at the package?

> +expected to be mostly complete, but it is possible that certain obscure GLSL
> +features are not yet supported.  However, most missing features are expected
> +to be \"trivial\" improvements at this stage.")

If you disagree with my suggestion, you need to remove these double
quotes. Texinfo uses ``trivial'', but you could also write
@emph{trivial}.

Regards,

-- 
Nicolas Goaziou

Message #32 received at 40495 <at> debbugs.gnu.org (full text, mbox):

From: Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
To: "40495 <at> debbugs.gnu.org" <40495 <at> debbugs.gnu.org>
Subject: update
Date: Sun, 12 Apr 2020 04:10:49 +0000

[Message part 1 (text/plain, inline)]

### taisei ###
>>> 'release' or 'developer'?
   IDK how valuable those diagnostics is, but during testing found the 'developer' mode cheat-keys to easy to hit.  Changed to 'release'.

>>> (synopsis "Shoot'em up game set in a world full of Japanese folklore")
   I know nothing about Japan (seen this variant too).  Changed to "Shoot'em up fangame and libre clone of Touhou Project"..?

>>> comments in '(license'
done

### spirv-cross ###
>>> remove '(string-append' from '(commit'
done

>>> tests fail, more info
nckx may know (idk, sorry): http://logs.guix.gnu.org/guix/2020-04-11.log#172304
("-cross yet have a multiple failures").

>>> (substitute*
Why: 'fix-tests-to-find-deps, i can't fix tests myself, thought i'm prepare the ground.
'(string-append' is to stay < 80 cols.

>>> (native-inputs, (inputs order
seems done

>>> drop 'note:', \"
done
________

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-taisei-and-spirv-cross.patch (text/x-patch, attachment)]

Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org>
Cc: 40495-done <at> debbugs.gnu.org, Vitaliy Shatrov <D0dyBo0D0dyBo0 <at> protonmail.com>
Subject: Re: [bug#40495] update
Date: Tue, 30 Jun 2020 17:27:31 +0200

Hello,

Vitaliy Shatrov via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add taisei, and spirv-cross

Sorry for the looong delay!

spirv-cross was recently updated and added to Guix. I pushed taisei.

Thank you!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.