GNU bug report logs - #40508
26.2; shr does not make h1 tag larger if variable-pitch font is set

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40508 in the body.
You can then email your comments to 40508 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ndame <emacsuser <at> freemail.hu>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 26.2;  shr does not make h1 tag larger if variable-pitch font is set
Date: Wed,  8 Apr 2020 16:37:35 +0200 (CEST)

[Message part 1 (text/plain, inline)]

If you change the font of the default variable-pitch face

(set-face-font 'variable-pitch "Arial-15")

then shr renders h1 tags as regular size text.

This is because variable-pitch is listed first in the face  setting and
if it is set with size then it overrides the settings coming later:

(defun shr-tag-h1 (dom)
  (shr-heading dom (if shr-use-fonts
               '(variable-pitch (:height 1.3 :weight bold))
             'bold)))
 

[Message part 2 (text/html, inline)]

Message #8 received at 40508 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: ndame <emacsuser <at> freemail.hu>
Cc: 40508 <at> debbugs.gnu.org
Subject: Re: bug#40508: 26.2;  shr does not make h1 tag larger if
 variable-pitch font is set
Date: Fri, 17 Jul 2020 16:24:14 +0200

ndame <emacsuser <at> freemail.hu> writes:

> If you change the font of the default variable-pitch face
>
> (set-face-font 'variable-pitch "Arial-15")
>
> then shr renders h1 tags as regular size text.
>
> This is because variable-pitch is listed first in the face  setting and
> if it is set with size then it overrides the settings coming later:
>
> (defun shr-tag-h1 (dom)
>   (shr-heading dom (if shr-use-fonts
>                '(variable-pitch (:height 1.3 :weight bold))
>              'bold)))

Would reversing the order fix this problem?  Untested patch below.

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index d6bdb4c17e..ea74316a74 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1916,7 +1916,7 @@ shr-tag-span
 
 (defun shr-tag-h1 (dom)
   (shr-heading dom (if shr-use-fonts
-		       '(variable-pitch (:height 1.3 :weight bold))
+		       '((:height 1.3 :weight bold) variable-pitch)
 		     'bold)))
 
 (defun shr-tag-h2 (dom)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 40508 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: ndame <emacsuser <at> freemail.hu>
Cc: 40508 <at> debbugs.gnu.org
Subject: Re: bug#40508: 26.2;  shr does not make h1 tag larger if
 variable-pitch font is set
Date: Wed, 29 Jul 2020 09:49:44 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> This is because variable-pitch is listed first in the face  setting and
>> if it is set with size then it overrides the settings coming later:
>>
>> (defun shr-tag-h1 (dom)
>>   (shr-heading dom (if shr-use-fonts
>>                '(variable-pitch (:height 1.3 :weight bold))
>>              'bold)))
>
> Would reversing the order fix this problem?  Untested patch below.

Well, no, and the order isn't the problem at all -- it's that if you set
the font that way in a face, it doesn't really matter what else you add
to the spec afterwards, as far as I can see.

If what you were trying to achieve was to make the face bigger, then you
can increase the size by (for instance) 20% with this:

(set-face-attribute 'variable-pitch nil :height 120)

So this isn't an eww bug, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.