GNU logs - #40601, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#40601] [PATCH 0/5] Handle runit-based foreign distributions
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 16:05:01 +0000
Resent-Message-ID: <handler.40601.B.158679389826197 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 40601 <at> debbugs.gnu.org
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Date: Mon, 13 Apr 2020 18:04:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

And assorted small fixes around the subject.

The first 3 patches are smallish things.

Maybe the REQUIRED array could get other
missing requirements: tar (or maybe the "tr"
item is a typoed tar, I've found no use of tr),
mkdir, ln, usermod, useradd, cp, cat...

The handling of local files for guix-install.sh is to
help testing modified / locally generated binary
tarballs.

One thing that is working as-is, but that I'm not sure
is right: The runit script in the guix-binary tarball is
patched for the shebang to point to /gnu/store/...

This looks wrong even if it is working, the interpreter
for that script should be the one of the foreign distro.

But this is not specific to the runit support, the sysv
scripts also are shebang-patched.

How would I tell guix not to patch these files's shebangs ?

WDYT ?

This series has been tested on void linux i686 in qemu
kvm with:

- upload locally build guix-binary tarball & guix-install.sh
to VM
- run guix-install.sh guix-binary.i686-linux.tar.xz

1) guix search hello
2) guix show hello
3) guix build hello
4) guix gc -D/gnu/store/*hello*
5) guix build --no-substitutes hello (stopped as it was rebuilding the world)
6) guix package -u
7) guix pull
8) guix package -u
9) guix gc

So the download part is not tested, but all ran well.

-- 
Vincent Legoll

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Vincent Legoll <vincent.legoll@HIDDEN>
Subject: bug#40601: Acknowledgement ([PATCH 0/5] Handle runit-based
 foreign distributions)
Message-ID: <handler.40601.B.158679389826197.ack <at> debbugs.gnu.org>
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
X-Gnu-PR-Message: ack 40601
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 40601 <at> debbugs.gnu.org
Date: Mon, 13 Apr 2020 16:05:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 40601 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
40601: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40601
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#40601] [PATCH 2/5] guix-install.sh: Add xz to requirements.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 16:08:02 +0000
Resent-Message-ID: <handler.40601.B40601.158679408026564 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Mon, 13 Apr 2020 18:07:37 +0200
Message-Id: <20200413160740.19584-2-vincent.legoll@HIDDEN>
In-Reply-To: <20200413160740.19584-1-vincent.legoll@HIDDEN>
References: <20200413160740.19584-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* etc/guix-install.sh (REQUIRE): Add xz to requirements list.
---
 etc/guix-install.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 4909d3f162..dbc038a0ab 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -48,6 +48,7 @@ REQUIRE=(
     "groupadd"
     "tail"
     "tr"
+    "xz"
 )

 PAS=$'[ \033[32;1mPASS\033[0m ] '
-- 
2.26.0

Message sent to guix-patches@HIDDEN:

Subject: [bug#40601] [PATCH 3/5] guix-install.sh: Fix systemctl not found error message at probe.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 16:09:02 +0000
Resent-Message-ID: <handler.40601.B40601.158679408326608 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Mon, 13 Apr 2020 18:07:38 +0200
Message-Id: <20200413160740.19584-3-vincent.legoll@HIDDEN>
In-Reply-To: <20200413160740.19584-1-vincent.legoll@HIDDEN>
References: <20200413160740.19584-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* etc/guix-install.sh (chk_init_sys)[systemctl]: Redirect errors to /dev/null.
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index dbc038a0ab..4fa9664cf5 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -142,7 +142,7 @@ chk_init_sys()
         _msg "${INF}init system is: upstart"
         INIT_SYS="upstart"
         return 0
-    elif [[ $(systemctl) =~ -\.mount ]]; then
+    elif [[ $(systemctl 2>/dev/null) =~ -\.mount ]]; then
         _msg "${INF}init system is: systemd"
         INIT_SYS="systemd"
         return 0
-- 
2.26.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 4/5] guix-install.sh: Handle local binary tarball file.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 16:09:03 +0000
Resent-Message-ID: <handler.40601.B40601.158679408426617 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158679408426617
          (code B ref 40601); Mon, 13 Apr 2020 16:09:03 +0000
Received: (at 40601) by debbugs.gnu.org; 13 Apr 2020 16:08:04 +0000
Received: from localhost ([127.0.0.1]:60564 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jO1cx-0006v3-7q
	for submit <at> debbugs.gnu.org; Mon, 13 Apr 2020 12:08:03 -0400
Received: from mail-wm1-f53.google.com ([209.85.128.53]:53272)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jO1cu-0006u8-U1
 for 40601 <at> debbugs.gnu.org; Mon, 13 Apr 2020 12:08:01 -0400
Received: by mail-wm1-f53.google.com with SMTP id d77so9780258wmd.3
 for <40601 <at> debbugs.gnu.org>; Mon, 13 Apr 2020 09:08:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=wV4+1jyL8qU7WCJsvI95UQYIXcSBn6faITajzYEeedA=;
 b=cbEL3BTTH2m0IOj9v1zg7i4mrXLswIS99BrOlNJ3g7d66YVs8/77uZrfcRogXFTuSS
 An9FVVbJg7y7qBt2K0SprEazuP8j4eFJueIIEIDYMfC6skm/yH6GTciirpLlfuWIXg+Z
 ABcGbMp/FGK3uN1nzLk7QviB6nx05ggkKg0OUKj8DMHjW/H516zmPdyEKrwCBUj1IIaj
 6A4NinFqrAfTRNq6fA4fdEJWNrRCN7BoskP/bU0VFAN2s9ng/bhcFJ92YRFnCwQ22VFK
 7aZWouWdUrn3oXjoOo0iIH3dH/Dcw3+80iJ0+5kCroH3yf02tDcagUOnqn6bcNttwILA
 ldew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=wV4+1jyL8qU7WCJsvI95UQYIXcSBn6faITajzYEeedA=;
 b=G3tQUIarNaLv4bJJOy7tAvSjQnSZBiZStRDGaCagBzaYMf3l/D0G5jen1IU/z+Z2j7
 08iD92k5HKhoZlwwP9Uu/t7VH37kD1Q0qYWpMfdur0PMz/Dq8v71pBNAkISq9JWhmLN+
 tRXaShGjKzpdz2DZVmnlQWo3qx0sixqk1xR3WITfSHPShDR29O2Rg8x38kU671dOUGYp
 ewXN0OXplR+gcUA43C1b0DCYWnstvD8mO1sznhvkf/1qO1sNPVksfErdPmy843OUzOD9
 f6gJKrPUAhbA7JpNdAfaqmd+P+1QRGYlKgNW7XWLKjgYDIzG8RSrv2yWtIFfxeTnNh5V
 weuQ==
X-Gm-Message-State: AGi0PuYuHAylY08/ZdwT0hVKp+V1D2qSS/7xHCZ7vGYFTTF9nLKC3fVQ
 lvOPsJMDhGlxy0sOA7fFJD7ekvts
X-Google-Smtp-Source: APiQypJi3B321cNV7cNvgYziACQfmBAgWzJ0NXdXepUHOKcWHwsE3OSJS7v4k0C/1R50EuGTUJg0zg==
X-Received: by 2002:a1c:6787:: with SMTP id
 b129mr20203785wmc.165.1586794075046; 
 Mon, 13 Apr 2020 09:07:55 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id g74sm15248774wme.44.2020.04.13.09.07.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 13 Apr 2020 09:07:54 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Mon, 13 Apr 2020 18:07:39 +0200
Message-Id: <20200413160740.19584-4-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200413160740.19584-1-vincent.legoll@HIDDEN>
References: <20200413160740.19584-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

* etc/guix-install.sh (REQUIRE): add realpath.
(main): Handle local binary tarball file path passed as first arg.
---
 etc/guix-install.sh | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 4fa9664cf5..0d15a05cb4 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -4,6 +4,7 @@
 # Copyright © 2018 Ricardo Wurmus <rekado@HIDDEN>
 # Copyright © 2018 Efraim Flashner <efraim@HIDDEN>
 # Copyright © 2019 Tobias Geerinckx-Rice <me@HIDDEN>
+# Copyright © 2020 Vincent Legoll <vincent.legoll@HIDDEN>
 #
 # This file is part of GNU Guix.
 #
@@ -47,6 +48,7 @@ REQUIRE=(
     "uname"
     "groupadd"
     "tail"
+    "realpath"
     "tr"
     "xz"
 )
@@ -482,10 +484,14 @@ main()
     umask 0022
     tmp_path="$(mktemp -t -d guix.XXX)"
 
-    guix_get_bin_list "${GNU_URL}"
-    guix_get_bin "${GNU_URL}" "${BIN_VER}" "$tmp_path"
-
-    sys_create_store "${BIN_VER}.tar.xz" "${tmp_path}"
+    if [ -z "$1" ]; then
+        guix_get_bin_list "${GNU_URL}"
+        guix_get_bin "${GNU_URL}" "${BIN_VER}" "$tmp_path"
+        TARBALL="${BIN_VER}.tar.xz"
+    else
+        TARBALL="$(realpath $1)"
+    fi
+    sys_create_store "${TARBALL}" "${tmp_path}"
     sys_create_build_user
     sys_enable_guix_daemon
     sys_authorize_build_farms
-- 
2.26.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 1/5] nix/local.mk: Add missing comment to sysvinit section.
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 16:09:03 +0000
Resent-Message-ID: <handler.40601.B40601.158679408426623 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158679408426623
          (code B ref 40601); Mon, 13 Apr 2020 16:09:03 +0000
Received: (at 40601) by debbugs.gnu.org; 13 Apr 2020 16:08:04 +0000
Received: from localhost ([127.0.0.1]:60566 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jO1cx-0006vG-R1
	for submit <at> debbugs.gnu.org; Mon, 13 Apr 2020 12:08:04 -0400
Received: from mail-wm1-f45.google.com ([209.85.128.45]:35046)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jO1cs-0006u1-1L
 for 40601 <at> debbugs.gnu.org; Mon, 13 Apr 2020 12:08:01 -0400
Received: by mail-wm1-f45.google.com with SMTP id r26so10536361wmh.0
 for <40601 <at> debbugs.gnu.org>; Mon, 13 Apr 2020 09:07:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=sPjUeY1YzjgtcP6IGf1w7ZdV0iy1Z8k2oY14lOE1DM8=;
 b=EcSkikbEa+/D5R83P0CfjtT6AplHcDU3Qc0QlDmiJyL38Ds+rwiAYRt/05OkQZJwdq
 Wlwd+1oxV9Oh3Fs3VVU0U/93WB4pyfapA7hccfLLpJk0fMKQmJkdy5R8S9SePkS+xVbH
 r86XjgavSLmoNJveo91gSXmEFOFzJkGp0WU7F+MV7zek5Kqd1FDR/s6NpUQ6M3qDYIfS
 lwiYn+A9foayBK6QP292+15Bsy8PTToKldhRsy/sR8HuIWSXsEoicpXyBnSP7pq/khPe
 GcCtmP29HMkOmgouP5kxHkJ5rDj8R5JvBkj2FtmUaomPBx6rsKvQlGM7zMesaKIfNC48
 BlDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=sPjUeY1YzjgtcP6IGf1w7ZdV0iy1Z8k2oY14lOE1DM8=;
 b=t2eFEcaw0NQdYYf25rcWkuMwk9Lh1OEIFlAnxLz8XRvrj287iOTu8yF+MUKfnrZ4f/
 B/hb0yFJROIeXkJBENyktCTfaeTYxyU+1MnBS5M0+vB3uuvfxB+5copBmkuhDW7UcH8W
 Hh9DRbqF262E4W3gC4qmLpH51Wc8Sssvcd2iNBVsCxPx8cdDEqPTom5ACIIFmJFjdErn
 C4+jNUcJzGJ8O41fvDpNRuy5mFOeC82/3u9MOYf0mEiX1pjC8c0rpvq9zyXAwznl5NZ4
 l57XQAgY5ly9OX58MrW5f8D0s8wvaJtYtQ5spkREp+AB9ChL8esECyIA62ghXJFkkR5S
 iERA==
X-Gm-Message-State: AGi0PuZ7jFiDahxSvMUFtBiuNysjMitgjG+lhRnp3hZe2FIqUH2t7ckY
 8N33f6qHggfS/UpoX6IN1nePZY0C
X-Google-Smtp-Source: APiQypKbDWwGW4Cc691K2wLDXwCaF0iqPGe1DX8FEd+Wc/Nt2uLbsKjZm70smIyZkDbEgmjJqPslvg==
X-Received: by 2002:a1c:1bcb:: with SMTP id b194mr20188668wmb.4.1586794071897; 
 Mon, 13 Apr 2020 09:07:51 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id g74sm15248774wme.44.2020.04.13.09.07.51
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 13 Apr 2020 09:07:51 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Mon, 13 Apr 2020 18:07:36 +0200
Message-Id: <20200413160740.19584-1-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

* nix/local.mk (sysvinit): Add comment.
---
 nix/local.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nix/local.mk b/nix/local.mk
index a64bdd2137..412d89ba3d 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -164,6 +164,7 @@ etc/guix-%.service: etc/guix-%.service.in	\
 	       "$<" > "$@.tmp";		\
 	mv "$@.tmp" "$@"
 
+# The service script for sysvinit.
 sysvinitservicedir = $(sysconfdir)/init.d
 nodist_sysvinitservice_DATA = etc/init.d/guix-daemon
 
-- 
2.26.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 5/5] guix-install.sh, guix-binary tarball: Handle runit-based foreign distributions.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 16:09:03 +0000
Resent-Message-ID: <handler.40601.B40601.158679409326649 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158679409326649
          (code B ref 40601); Mon, 13 Apr 2020 16:09:03 +0000
Received: (at 40601) by debbugs.gnu.org; 13 Apr 2020 16:08:13 +0000
Received: from localhost ([127.0.0.1]:60568 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jO1d2-0006vc-4s
	for submit <at> debbugs.gnu.org; Mon, 13 Apr 2020 12:08:13 -0400
Received: from mail-wr1-f41.google.com ([209.85.221.41]:41939)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jO1cv-0006uA-WD
 for 40601 <at> debbugs.gnu.org; Mon, 13 Apr 2020 12:08:04 -0400
Received: by mail-wr1-f41.google.com with SMTP id h9so10692205wrc.8
 for <40601 <at> debbugs.gnu.org>; Mon, 13 Apr 2020 09:08:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=d7XlIXph/dC3p0sp+I8C/nuk/eRXd6pCqWVW4IA61to=;
 b=TLcgwE4T3Unju7lw1EuNb35smtcCapQA/KC3BZf1NZJUBAzjG5wlEdrvqdkPNXd18G
 4YMbFUqwr0ggEDkoT0uVW6QE7b6qbejS5ogONmja0y+OaRu5Iy8VUjZnMRzCRRFapnFv
 fOpRp/vK7BPWKiqJVClFkvNrllX68Bnn+DPEluYC/plPjeJspaq2QmISu5RJhJJDYmFG
 5fhWH6yidi2yvGysyAvbTH3PVmLMhoTleUxC3kD7xnKUsK8grimiKHP+PUgJiuNIi9Sh
 YyEjOOtoRtW6Np/VKJ1vgFU6W/okUFCVcfFxaLsDFbpgkcWwptCApDirNzCusoIf2F2H
 MQfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=d7XlIXph/dC3p0sp+I8C/nuk/eRXd6pCqWVW4IA61to=;
 b=A1uN7VNuILIC/OHZbM3TDVWxIW+BR2vUZkpvzw0ishyziHNOGpm2LYkNJLHBINCHes
 ZnwG4qia3W7tT1S22lw4FnT/UPdV4ZW6jIqsXVx4imXMxBS9XUZoKfz0TOag/GTH0vm5
 fC4NViRV1wBFqe/eCoojvzDcPhZrPhpeBcAB4KoEI0BHTWIustS8IZ++WKAA774OPQoc
 7VTB6jtcm75TCX6Xu8WZFavlQojcPW7CrHDCcCVjko65hvvGtHAPw1nr+PFTpjqxlJ03
 JsT2RLaO/X0YAnY8oWvVltIOgjuypDnqk6aKm3rn+lvVXCObEI6sAnJKA9U/40fxjtwE
 LV9g==
X-Gm-Message-State: AGi0PuZzykoIKqssWSf6w/iSHM3qAikY0Mcf6D3N3M6tP8OC8qgGSAbj
 9PTuyv5iEsf/DNNe9tZgiWFw4mEl
X-Google-Smtp-Source: APiQypJbUoz3JH0g6htS6vOQdQbDSb+/pF48Dfx7Fx3aZ9T4Nrj727JzWH22+su7hVU+qHUQUKWBbw==
X-Received: by 2002:a5d:6310:: with SMTP id i16mr6506935wru.177.1586794076101; 
 Mon, 13 Apr 2020 09:07:56 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id g74sm15248774wme.44.2020.04.13.09.07.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 13 Apr 2020 09:07:55 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Mon, 13 Apr 2020 18:07:40 +0200
Message-Id: <20200413160740.19584-5-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200413160740.19584-1-vincent.legoll@HIDDEN>
References: <20200413160740.19584-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* .gitignore: Add /etc/runit/run.
* etc/guix-install.sh (chk_init_sys): Add case to detect runit.
(sys_enable_guix_daemon): Add case to setup guix-daemon within runit.
* etc/runit/run.in: New file.
* nix/local.mk (etc/runit/run): Add target to generate etc/runit/run from
etc/runit/run.in. (nodist_runitservice_DATA): New variable... (CLEANFILES):
... add it here. (runitservicedir): New variable. (EXTRA_DIST): Add
etc/runit/run.in.
---
 .gitignore          |  1 +
 etc/guix-install.sh | 11 +++++++++++
 etc/runit/run.in    | 15 +++++++++++++++
 nix/local.mk        | 13 +++++++++++++
 4 files changed, 40 insertions(+)
 create mode 100644 etc/runit/run.in

diff --git a/.gitignore b/.gitignore
index fd2cf56098..89a2c89e1e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -72,6 +72,7 @@
 /etc/guix-publish.conf
 /etc/guix-publish.service
 /etc/init.d/guix-daemon
+/etc/runit/run
 /guix-daemon
 /guix/config.scm
 /libformat.a
diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 0d15a05cb4..06590ee97f 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -152,6 +152,10 @@ chk_init_sys()
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
+    elif [[ -d /etc/sv ]]; then
+        _msg "${INF}init system is: runit"
+        INIT_SYS="runit"
+        return 0
     else
         INIT_SYS="NA"
         _err "${ERR}Init system could not be detected."
@@ -364,6 +368,13 @@ sys_enable_guix_daemon()
                   systemctl enable guix-daemon; } &&
                 _msg "${PAS}enabled Guix daemon via systemd"
             ;;
+        runit)
+            { cp -r "${ROOT_HOME}/.config/guix/current/lib/runit/guix-daemon" \
+                 /etc/sv;
+              chmod 755 /etc/sv/guix-daemon/run;
+              ln -s /etc/sv/guix-daemon /etc/runit/runsvdir/default/; } &&
+                _msg "${PAS}enabled Guix daemon via runit"
+            ;;
         sysv-init)
             { mkdir -p /etc/init.d;
               cp "${ROOT_HOME}/.config/guix/current/etc/init.d/guix-daemon" \
diff --git a/etc/runit/run.in b/etc/runit/run.in
new file mode 100644
index 0000000000..e57ef597bc
--- /dev/null
+++ b/etc/runit/run.in
@@ -0,0 +1,15 @@
+#!/bin/sh
+
+# This is a "run script" for the runit init system to launch
+# 'guix-daemon'.  Drop it in /etc/sv/guix-daemon and add a symlink to
+# it like the following to have 'guix-daemon' automatically started.
+# ln -s /etc/sv/guix-daemon /etc/runit/runsvdir/default/
+
+GUIX_LOCPATH=@localstatedir@/guix/profiles/per-user/root/guix-profile/lib/locale
+LC_ALL=en_US.utf8
+
+export GUIX_LOCPATH LC_ALL
+
+exec @localstatedir@/guix/profiles/per-user/root/current-guix/bin/guix-daemon \
+  --build-users-group=guixbuild
+
diff --git a/nix/local.mk b/nix/local.mk
index 412d89ba3d..877ddcc281 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -175,6 +175,17 @@ etc/init.d/guix-daemon: etc/init.d/guix-daemon.in	\
 	       "$<" > "$@.tmp";		\
 	mv "$@.tmp" "$@"
 
+# The service run script for runit.
+runitservicedir = $(libdir)/runit/guix-daemon
+nodist_runitservice_DATA = etc/runit/run
+
+etc/runit/run: etc/runit/run.in		\
+			$(top_builddir)/config.status
+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";   \
+        $(SED) -e 's|@''localstatedir''@|$(localstatedir)|' <   \
+               "$<" > "$@.tmp";         \
+        mv "$@.tmp" "$@"
+
 # The '.conf' jobs for Upstart.
 upstartjobdir = $(libdir)/upstart/system
 nodist_upstartjob_DATA = etc/guix-daemon.conf etc/guix-publish.conf
@@ -189,6 +200,7 @@ etc/guix-%.conf: etc/guix-%.conf.in	\
 CLEANFILES +=					\
   $(nodist_systemdservice_DATA)			\
   $(nodist_upstartjob_DATA)			\
+  $(nodist_runitservice_DATA)			\
   $(nodist_sysvinitservice_DATA)
 
 EXTRA_DIST +=					\
@@ -198,6 +210,7 @@ EXTRA_DIST +=					\
   etc/guix-daemon.conf.in			\
   etc/guix-publish.service.in			\
   etc/guix-publish.conf.in			\
+  etc/runit/run.in				\
   etc/init.d/guix-daemon.in
 
 if CAN_RUN_TESTS
-- 
2.26.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH v2] Re: Add how to create a runit service in step 5 of binary installation manual
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 22:23:02 +0000
Resent-Message-ID: <handler.40601.B40601.158681658021015 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Foxmean <foxmean@HIDDEN>
Cc: 37624 <at> debbugs.gnu.org, 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158681658021015
          (code B ref 40601); Mon, 13 Apr 2020 22:23:02 +0000
Received: (at 40601) by debbugs.gnu.org; 13 Apr 2020 22:23:00 +0000
Received: from localhost ([127.0.0.1]:32781 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jO7To-0005Sr-KB
	for submit <at> debbugs.gnu.org; Mon, 13 Apr 2020 18:23:00 -0400
Received: from mail-wr1-f45.google.com ([209.85.221.45]:43132)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>)
 id 1jO7Tn-0005Sc-9g; Mon, 13 Apr 2020 18:22:59 -0400
Received: by mail-wr1-f45.google.com with SMTP id i10so11957726wrv.10;
 Mon, 13 Apr 2020 15:22:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=to:cc:from:subject:message-id:date:user-agent:mime-version
 :content-transfer-encoding:content-language;
 bh=EpmlTXXRHyPF7pv5lnP6rsMgs5IHmEUq2JVPbEMkCgU=;
 b=mkhyYXkZ3Q7SIWl0jq8+9vPh/J7nNRJOL/8yK/1JEcmlzt8TNq8xcCa0x00+2dMffR
 RfxdWs26SR66MxTDGrq0Scng4fCA6rCs2dxRKJl/2RoczPszNKpAMUHWtmrmIp73cqO2
 8Ewq5uXyKoIZFAhU8xf/yjfv+Slz2gPeYY0A/I7gbndSNNEneQGxGKTPDpG/ld7jBXIz
 2RvkOdTDfb5cXH2I9fCHP77cFqO3ztHas4YhnRYyzzn8pvrbrAmXCkq0dwVVPxrm4mFn
 s4aJQoAg16P7BKHp4ucfSqseLotgjtRI4ufnDrTe0PlIq6+RA+zYxIqTmmzftZX8tAtM
 IDoA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent
 :mime-version:content-transfer-encoding:content-language;
 bh=EpmlTXXRHyPF7pv5lnP6rsMgs5IHmEUq2JVPbEMkCgU=;
 b=MtsjbaB6Q0VXNrVLyGnwIt5o0et0Hhve+aruqHQkanOf+eufqB6MZTpofkYjo4LHee
 AyTqWXA9jvss07wzb5sogE7HG021j6CKtX611UoUrcxcLmEe86inKaNnPKwMw1fXB7AY
 lmGu58JpyAkTFdgPKrjIDJ7sQFDuMKWDRt0ZoyFp/omEY1iacVa6OaSNdFAdr9WtFpDm
 HTvUeUYbjeE2QEsodzImopriMgeQtFCVyGmg9IzN+ioHVrjvNKY4AIk281gNwrobHGmz
 o9LWuqZ76HGb9y76OvO918q9rQ0ynG7h97br2LmiMFr4hDs7cPRbuGNKlS05jaiqeGvl
 6GmQ==
X-Gm-Message-State: AGi0PuZcCQw2qAnD1sfeCtpYG+IeCPr1zBCFF/yb7MuMf2OldQYoaJti
 Z/HVcPkQgYaL2jeJfjhoORdveqc4ZKs=
X-Google-Smtp-Source: APiQypJSFzomZA3JQqEJKXj4H7iIUa6HqVpJUMSM3FdT18U5Ub1RZiYco0+dU84T5PgjrnGw3jv9jg==
X-Received: by 2002:a05:6000:192:: with SMTP id
 p18mr21247287wrx.398.1586816572990; 
 Mon, 13 Apr 2020 15:22:52 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id h81sm17300289wme.42.2020.04.13.15.22.51
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 13 Apr 2020 15:22:52 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <46fe93c6-6d19-fab8-8810-37f36d5f1344@HIDDEN>
Date: Tue, 14 Apr 2020 00:22:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Spam-Score: -0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

Hello,


as I recently worked on the same subject in [1],

I reviewed and amended the documentation patch [2].


[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40601

[2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37624


-- 

Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH v2] Re: Add how to create a runit service in step 5 of binary installation manual
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Apr 2020 22:30:02 +0000
Resent-Message-ID: <handler.40601.B40601.158681698521690 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Foxmean <foxmean@HIDDEN>
Cc: 37624 <at> debbugs.gnu.org, 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158681698521690
          (code B ref 40601); Mon, 13 Apr 2020 22:30:02 +0000
Received: (at 40601) by debbugs.gnu.org; 13 Apr 2020 22:29:45 +0000
Received: from localhost ([127.0.0.1]:32795 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jO7aC-0005dd-Vi
	for submit <at> debbugs.gnu.org; Mon, 13 Apr 2020 18:29:45 -0400
Received: from mail-wm1-f65.google.com ([209.85.128.65]:51858)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>)
 id 1jO7aB-0005dO-O5; Mon, 13 Apr 2020 18:29:36 -0400
Received: by mail-wm1-f65.google.com with SMTP id x4so10905269wmj.1;
 Mon, 13 Apr 2020 15:29:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:from:to:cc:references:message-id:date:user-agent
 :mime-version:in-reply-to:content-language;
 bh=yXldhWbRcuZcItUDx6vw9j0tbKn88PPDcYkWVkxQvVs=;
 b=m96yz8b6YcwtyZqOHnrWcAlN7apuU8Z+kZTeQ1+Kw71dACnJ+YOT4WMHV2Ksoa4+SP
 +ENJ5NXKMsL675f5/dZlZLdOrardM68pHyMXoJmq1omfyMuj2J5bV0v5PMLfgeW3JnIc
 /Hq06nK3M41giz8Z1DHAzFAktK4JK+JI7+wte9qJoBjz3QjpkO8nxgKdRJcSHH4Dgmr0
 H8YkinEcEeQ5tgEJokAjyvGsGHQ3kZvb26l01DBevKuMKC9ltNcwUIIzNu1xrYjQOhZl
 J0MZQhmxkmmLG9O+1wvQ5iQFawBI9RJ+AFGhclOPYinGhreDZ6Rg74ZxP1BpNOS5451R
 9CSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:from:to:cc:references:message-id:date
 :user-agent:mime-version:in-reply-to:content-language;
 bh=yXldhWbRcuZcItUDx6vw9j0tbKn88PPDcYkWVkxQvVs=;
 b=JhUsTFG/jqrHQ4XmmvB1MRx8zxpoadN6ORdXz+uu8TkmidQHvjlUgIo4CXcR4TaJqn
 +tJZfPEcpRT9Cp/PT4BOiiOvr1Sjt3V5nhN2lUSgLWhW0MFNLcumfflMiZNNHm53NHJ6
 rZxXTf5C6qICvFKWaYRS9jhvjys3GK4FTRWkE5OH/DCFiAVU7hb16P3OUjjAXGlvKVQH
 RfZHy2693rDkApJsQFX6xkchjy9EHNgHRsae2jupTLB0y/vkS1VVD0qDRw6DWakb8Qps
 GZmcbDwa6I/l+PeILG2OE3JZ3jnj04sZWg475DbFJLR7wTw2Z6Y6te5WRv6JVS35tm9+
 7VBg==
X-Gm-Message-State: AGi0PubHn4hDivQY+C3nFg+XDS6VsELUX84fqgzx3ZP7W4wuuds/il1f
 o0wBi3gcRUnmoahJDG2ruUjKheIl6Oo=
X-Google-Smtp-Source: APiQypIRmxRUwaQtL4iP6NvMHn7WYJigmCkFoop5d+zvWAYxo0vIgMPAwPsOsxSO+JMeCn2N6YSY+g==
X-Received: by 2002:a1c:b70a:: with SMTP id h10mr19473329wmf.172.1586816969734; 
 Mon, 13 Apr 2020 15:29:29 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id g186sm17272121wmg.36.2020.04.13.15.29.28
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 13 Apr 2020 15:29:28 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
References: <46fe93c6-6d19-fab8-8810-37f36d5f1344@HIDDEN>
Message-ID: <712fb208-43c4-6a30-b0c8-04198a51db8f@HIDDEN>
Date: Tue, 14 Apr 2020 00:29:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <46fe93c6-6d19-fab8-8810-37f36d5f1344@HIDDEN>
Content-Type: multipart/mixed; boundary="------------330EAE1A47531C5A4888C0A6"
Content-Language: en-US
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  On 14/04/2020 00:22, Vincent Legoll wrote: > Hello, > > >
 as I recently worked on the same subject in [1], > > I reviewed and amended
 the documentation patch [2]. > > > [1] https://debbugs.gnu.org/cgi [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
 blocked.  See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
 for more information. [URIs: gnu.org]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (vincent.legoll[at]gmail.com)
 2.0 PDS_OTHER_BAD_TLD      Untrustworthy TLDs
 [URI: ambrevar.xyz (xyz)]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.128.65 listed in list.dnswl.org]
 -0.8 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.128.65 listed in wl.mailspike.net]
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

This is a multi-part message in MIME format.
--------------330EAE1A47531C5A4888C0A6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


On 14/04/2020 00:22, Vincent Legoll wrote:
> Hello,
>
>
> as I recently worked on the same subject in [1],
>
> I reviewed and amended the documentation patch [2].
>
>
> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40601
>
> [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37624
>

And now with the patch...


--------------330EAE1A47531C5A4888C0A6
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-doc-Add-Runit-init-system-in-guix-installation.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
 filename*0="0001-doc-Add-Runit-init-system-in-guix-installation.patch"

From 6b656a54ef7a17fdbd5f82ceaeb98198e2c241af Mon Sep 17 00:00:00 2001
From: Pathompong Kwangtong <foxmean@HIDDEN>
Date: Sun, 13 Oct 2019 01:24:48 +0700
Subject: [PATCH] doc: Add Runit init system in guix installation.

* doc/guix.texi (Binary Installation): Add runit section.
* .mailmap: Add author email adress.

Co-authored-by: Vincent Legoll <vincent.legoll@HIDDEN>
---
 .mailmap      |  1 +
 doc/guix.texi | 30 ++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/.mailmap b/.mailmap
index 97018775f6..aa5227b91d 100644
--- a/.mailmap
+++ b/.mailmap
@@ -62,6 +62,7 @@ ng0 <ng0@HIDDEN> <ngillmann@HIDDEN>
 ng0 <ng0@HIDDEN> <niasterisk@HIDDEN>
 ng0 <ng0@HIDDEN> <ng@HIDDEN>
 ng0 <ng0@HIDDEN> <ng0@HIDDEN>
+Pathompong Kwangtong <foxmean@HIDDEN>
 Pierre Neidhardt <mail@HIDDEN>
 Pierre-Antoine Rouby <pierre-antoine.rouby@HIDDEN>
 Pjotr Prins <pjotr.guix@HIDDEN> <pjotr.public01@HIDDEN>
diff --git a/doc/guix.texi b/doc/guix.texi
index 8bf4ef9b74..94cb89eddf 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -71,6 +71,7 @@ Copyright @copyright{} 2019 Alex Griffin@*
 Copyright @copyright{} 2019 Guillaume Le Vaillant@*
 Copyright @copyright{} 2020 Leo Prikler@*
 Copyright @copyright{} 2019, 2020 Simon Tournier@*
+Copyright @copyright{} 2019 Pathompong Kwangtong@*
 Copyright @copyright{} 2020 Wiktor Żelazny@*
 Copyright @copyright{} 2020 Damien Cassou@*
 Copyright @copyright{} 2020 Jakub Kądziołka@*
@@ -664,6 +665,35 @@ If your host distro uses the Upstart init system:
 # start guix-daemon
 @end example
 
+If your host distro use the Runit init system:
+
+@example
+# mkdir /etc/sv/guix-daemon
+@end example
+
+Then create the guix-daemon runit launch script:
+
+@example
+# cat > /etc/sv/guix-daemon/run <<EOF
+#!/bin/sh
+
+GUIX_LOCPATH=/var/guix/profiles/per-user/root/guix-profile/lib/locale
+LC_ALL=en_US.utf8
+
+export GUIX_LOCPATH LC_ALL
+
+exec /var/guix/profiles/per-user/root/current-guix/bin/guix-daemon \
+  --build-users-group=guixbuild
+EOF
+@end example
+
+Now, you can enable and start the guix-daemon service with:
+
+@example
+# ln -s /etc/sv/guix-daemon /etc/runit/runsvdir/default/
+# sv up guix-daemon
+@end example
+
 Otherwise, you can still start the daemon manually with:
 
 @example
-- 
2.20.1


--------------330EAE1A47531C5A4888C0A6--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [bug#39329] [PATCH v4 0/2] Start guix-daemon on SysV.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 14 Apr 2020 10:41:02 +0000
Resent-Message-ID: <handler.40601.B40601.15868608242842 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Leo Famulari <leo@HIDDEN>, Danny Milosavljevic <dannym@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org, 39329 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.15868608242842
          (code B ref 40601); Tue, 14 Apr 2020 10:41:02 +0000
Received: (at 40601) by debbugs.gnu.org; 14 Apr 2020 10:40:24 +0000
Received: from localhost ([127.0.0.1]:33323 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jOIzP-0000jl-Ls
	for submit <at> debbugs.gnu.org; Tue, 14 Apr 2020 06:40:23 -0400
Received: from mail-wm1-f66.google.com ([209.85.128.66]:33954)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>)
 id 1jOIzO-0000jT-53; Tue, 14 Apr 2020 06:40:22 -0400
Received: by mail-wm1-f66.google.com with SMTP id c195so12188919wme.1;
 Tue, 14 Apr 2020 03:40:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-transfer-encoding:content-language;
 bh=3tJRNoPNkxWmtV3spxOiU1Nsk1MG+us20NpV6Z9Gpz8=;
 b=t5URDlswLJEirXetPZK+ER++go+Do0x8hyoAuuaoHpb6l+m9ixpIa+3a56prrNrArv
 udeMSDEHzSYOnl9D+OCYGZTxqgTx8KGrZVHR5xA2r9u1eo+2xAqcZT6L77kc4QSV017p
 glVO2SIskfLtLRNXSYYE7P/EBP9zeWK3TcrPRQjyl8UUGorF4i6jIdhjdmBVUkCl8kuz
 KJlgruKIoQaLufbZN+bovlhY/o4nAbMWXXO4hE4vRe3m+rwAySp85Ft2n1xWepjIx0m2
 3wuV2EHARE2V0vwlKYqiV/QwhZI+T4nsvK9nNfbTZIB2KWOaSgYg7nco+ovHBQXoA6vZ
 8wmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding
 :content-language;
 bh=3tJRNoPNkxWmtV3spxOiU1Nsk1MG+us20NpV6Z9Gpz8=;
 b=HkbBkcLJxkU5axWbnc/ssBZKEIju5G/O0se0ARyeAX0VJE6KtATSQ5Y8KlfY++QZCa
 c5mpIM2MrYrJBujzQJfUcXsDOja9Cj2qsv/Rew9adGTk6A34GAijFvFdcNHuwQmRuQhQ
 h5mm5a6Etya+MQF7EzqnKX6IUWzk6To0gasFDmRk92EO6Gv7nhLj6KaBCSIY6h6A+X+9
 X2/gbNjqljSzJ7XOQYoekiCiFL2km8QXiW3CvvESdQna8snMev/3Duj+xSurNZ8ljlZj
 6fNru2+4WUnyM/3zBvfITY6bNhEvD7JPCcVZ0XTYLwUyrx5idrhjIpb3jXMO5RExQ9AG
 HJug==
X-Gm-Message-State: AGi0PubghPkiMUck8HLJadqGTLGdix/0UV+FB4hBA8/nB4R85P/2t478
 +J1dlEL8WXEx0GLGjZts36PvhbKd+Ss=
X-Google-Smtp-Source: APiQypKnBeR8bQ7fV1qZigK73LhANlNvsBJ1/TWqs0hNBg8rD6FrOsedSC452/MHQuiOdoiYjcXeWw==
X-Received: by 2002:a7b:cf27:: with SMTP id m7mr2375997wmg.183.1586860815862; 
 Tue, 14 Apr 2020 03:40:15 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id o28sm3885470wra.84.2020.04.14.03.40.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 14 Apr 2020 03:40:15 -0700 (PDT)
References: <57afed60-5bca-8776-102f-6126396d481c@HIDDEN>
 <20200413200829.7ceb3c7e@HIDDEN>
 <20200413182145.GA24906@HIDDEN>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <4d13d72e-16ab-a25d-f7a9-263d35cca1a9@HIDDEN>
Date: Tue, 14 Apr 2020 12:40:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200413182145.GA24906@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Spam-Score: -0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

Hello,


I now have tested the patch series in #40601

also on latest devuan-sysvinit x86_64.


On 13/04/2020 20:21, Leo Famulari wrote:
> On Mon, Apr 13, 2020 at 08:08:29PM +0200, Danny Milosavljevic wrote:
>> I don't know whether it actually works.
>>
>> I don't feel great just closing this because of that.
> Okay, feel free to reopen if you want [0]
>
>> I mean SysV is kinda outdated, so I wouldn't even know how to test it myself.
>> Would Devuan work?
>> Or Redhat 6/CentOS 6?
> I'm sure we will get some bug reports if it doesn't work for them.


Here's the first one: ;-)

the sysvinit init.d script relies on "daemonize" which is not

installed by default on devuan.


Would fixing it by checking a second round of REQUIRED_BY_INIT

after checking the init type be the right way ?


Or should I report an issue about that ?


But if daemonize is installed, the sysvinit support works

as expected, and I can run guix commands as for the

other tests I did.


Thanks


-- 

Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] bug#39023: binary installation manual doesn't work on Alpine Linux
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 23 Apr 2020 11:57:02 +0000
Resent-Message-ID: <handler.40601.B40601.15876429665193 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 39023 <at> debbugs.gnu.org
Cc: symphonia@HIDDEN, boskovits@HIDDEN, me@HIDDEN, 40601 <at> debbugs.gnu.org, zimon.toutoune@HIDDEN
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.15876429665193
          (code B ref 40601); Thu, 23 Apr 2020 11:57:02 +0000
Received: (at 40601) by debbugs.gnu.org; 23 Apr 2020 11:56:06 +0000
Received: from localhost ([127.0.0.1]:54175 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jRaSb-0001Lg-UY
	for submit <at> debbugs.gnu.org; Thu, 23 Apr 2020 07:56:06 -0400
Received: from mail-wr1-f65.google.com ([209.85.221.65]:44771)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>)
 id 1jRaSa-0001L8-CN; Thu, 23 Apr 2020 07:56:04 -0400
Received: by mail-wr1-f65.google.com with SMTP id d17so6482558wrg.11;
 Thu, 23 Apr 2020 04:56:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=to:cc:from:subject:message-id:date:user-agent:mime-version
 :content-language:content-transfer-encoding;
 bh=sV3rDxOhCk3LEST0Av5E0hjVvPrW0mXSBQmbZ/AJD+E=;
 b=OpadnVLdzmwPSAV8VpASvncB/bWIcQllI+1vc36aU/RoGNkxBbGbYjXLg7He0s9AQO
 12lq4Nc9R1bldRy6NR1Hu+BcwphVAht3mJIr6hV9ZFq5XpuepJtLv/DFgDzcDVMqykdK
 cwt7rfc7NuyH6pJ6JEissuLTmpyy98TyY9JJSNQyhlQTU15lL6xZLdQUuw7uOsEzszzA
 xyDnVvfTvjzJEGNy/0mNngFt17ODea+doZCNsN+rJf98Vgtf3SK1mBLyF+gZp16FfxfS
 pjKz2ezPoKzN2WrGSjp7vCq+KHbGd87LMvNopIGPOZKFV970E0LdMrciXLqa7P9+8+rt
 Q0uA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent
 :mime-version:content-language:content-transfer-encoding;
 bh=sV3rDxOhCk3LEST0Av5E0hjVvPrW0mXSBQmbZ/AJD+E=;
 b=Shk0GT00/CmV5o8631qOIsKRhre7C4A5wiKpMpVaz0sOaJKu39la2UQFY/io2wRio4
 lMdEiFmTHXovfm02GkM3JRXc+rv+4sJ119lzn23YexgnZ2ByeTaP2JjaeBb8SnzKAIJT
 o/eDfrkk23tz5qTOFyQG0DtKvycmy/fuOthyaz1pYo4Q308r3XNXEJ07McI3DEc+ZvAB
 jy+xoEmI9cCHPnmjuxA4b3CDzh/FbaDU+OxuC+6g8LKzbLWb+iVa3eM/sKuJErbvVPtG
 HUoqg4a1GqEFKpyjsRoFPlXxOioeiZZB1vTiUN8EqnSfDT2iK4VyLHudrrbXMkx7dAfJ
 klZA==
X-Gm-Message-State: AGi0PuY+60F3C9jvEEgcxhncrNelOLk4VcUQ3IWRA0og65/JjdYOZLZn
 CEYOvAsiBiCyKYCKrHG4QRy2MLyB
X-Google-Smtp-Source: APiQypLdbM+hcrFXvBA92XhxzD4Ao/O5kZtBr0ohZ2efQfx0sQcdYAqVhFeZYUN21VrR1tk8zb6FBw==
X-Received: by 2002:adf:f282:: with SMTP id k2mr4352822wro.133.1587642958155; 
 Thu, 23 Apr 2020 04:55:58 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id r20sm3188101wmh.26.2020.04.23.04.55.56
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 23 Apr 2020 04:55:57 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <b041d4ae-0457-02f4-3f31-9a1a1a111e0e@HIDDEN>
Date: Thu, 23 Apr 2020 13:55:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

as I had been working on the installer lately [1],
I tried to tackle this bug also, I have it mostly
working.

I added support for openrc-based init systems.

I opted to support both adduser & useradd, changed
some tool calls to work on busybox, etc... Then
sprinkled a bit of cleanup & polish over the top.

It's not finished, because I could not test it. I
have a problem building the binary-tarball since I
switched to the 1.1.0 release and I've yet to try
to build on an earlier version.

Stay tuned, patches incoming for review.

[1] https://issues.guix.gnu.org/40601

-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] bug#39023: binary installation manual doesn't work on Alpine Linux
Resent-From: zimoun <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 23 Apr 2020 13:31:02 +0000
Resent-Message-ID: <handler.40601.B40601.158764861422500 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: symphonia@HIDDEN, 39023 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me@HIDDEN>, 40601 <at> debbugs.gnu.org, =?UTF-8?Q?G=C3=A1bor?= Boskovits <boskovits@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158764861422500
          (code B ref 40601); Thu, 23 Apr 2020 13:31:02 +0000
Received: (at 40601) by debbugs.gnu.org; 23 Apr 2020 13:30:14 +0000
Received: from localhost ([127.0.0.1]:54258 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jRbvi-0005ql-Cf
	for submit <at> debbugs.gnu.org; Thu, 23 Apr 2020 09:30:14 -0400
Received: from mail-qk1-f176.google.com ([209.85.222.176]:46004)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>)
 id 1jRbvg-0005pT-1h; Thu, 23 Apr 2020 09:30:12 -0400
Received: by mail-qk1-f176.google.com with SMTP id m67so6268065qke.12;
 Thu, 23 Apr 2020 06:30:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=6hrgbBuSYno1In41rLp2sX/+O5FmS0LdKIO0LkB7zEU=;
 b=b+fh3u0TSgQJk28asfMOzsy6zAwRS6sa+BT4ItxRxTJsTIUCaQfvtMc2kU/zRrvxqH
 KzYJpNAsCJLL1FAxShJqspFpUBPLCnyvfY5iAT5Vx1E/nkCCuXr1XGoan7yMNvOJ3nVy
 26hn7213WbHNeb8OBipsrEvQ+iKt8Oow47z3A/dqhW6mMasqey1P+aY5TMy0HFQVpSUj
 PCUwZGd6Mb4t9ZDdM9/JGi63R8gorWyjVPW5UTGb61wvjwy5tM9dsNmmcQEKGREPUIAA
 LpG5CvGRMqGsc+y+zRt603OlfTzScVpk1Vx5EGTzqHYvEZ1vLc35vd3S/VfqgyjlePkU
 n2VA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=6hrgbBuSYno1In41rLp2sX/+O5FmS0LdKIO0LkB7zEU=;
 b=tWcJ+3+2zoa5KbOQf7sst7zE3he1LzuOHOi1OakHfySsfFXnAFWSyfwHziOxOlCPQC
 rDmyhHnvrOdZLSGDqpm3hFyK6LLAYAo3YPf57H/UerI1Z+T8lpgxvg6gaFDd/3krqtSb
 Ehc2aSUpy392oZaYpItJd/uKoFCUa+dt6ZkRlGYGqvcJ1BUnJ5xfHqTxvpuiTbUmrkI/
 eFqT9ACVfbCr3nCO19NOHSXBlT+mbYXe0IpXnnsYYEcJmhKifSegSzgyr7mfFoY0D81z
 6rNiWPMSQnIr7m/INt7QS86J7XDIdAoiUnOnxbzFo2cYQ0WHPN1LD2DjXgFObvgAc8a7
 +hLw==
X-Gm-Message-State: AGi0PuZQiJwWnEOP8oDLAg+KisZTxuWiOyA+++zLYv2IhBVLn2ZD9vJ/
 /M5QBt2QfZ7FP4mZ6R9ppGW2YQSbO0xkMSxMpvY=
X-Google-Smtp-Source: APiQypLcNPY2oS2UBff0qBRT/F2nXhQT6TbuZHwHc6S7fMEP0iRQK+lqX31SGbHlw9f4nQs21mnOm2LbkD1g9qiLir8=
X-Received: by 2002:a37:a6d4:: with SMTP id p203mr3263306qke.201.1587648606466; 
 Thu, 23 Apr 2020 06:30:06 -0700 (PDT)
MIME-Version: 1.0
References: <b041d4ae-0457-02f4-3f31-9a1a1a111e0e@HIDDEN>
In-Reply-To: <b041d4ae-0457-02f4-3f31-9a1a1a111e0e@HIDDEN>
From: zimoun <zimon.toutoune@HIDDEN>
Date: Thu, 23 Apr 2020 15:29:53 +0200
Message-ID: <CAJ3okZ25BEr5vHRgFqjjP6fz4v-kOWiYVxCgyRZE+=+czhR0og@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Vincent,

On Thu, 23 Apr 2020 at 13:55, Vincent Legoll <vincent.legoll@HIDDEN> wrote:

> as I had been working on the installer lately [1],
> I tried to tackle this bug also, I have it mostly
> working.
>
> I added support for openrc-based init systems.
>
> I opted to support both adduser & useradd, changed
> some tool calls to work on busybox, etc... Then
> sprinkled a bit of cleanup & polish over the top.
>
> It's not finished, because I could not test it. I
> have a problem building the binary-tarball since I
> switched to the 1.1.0 release and I've yet to try
> to build on an earlier version.
>
> Stay tuned, patches incoming for review.
>
> [1] https://issues.guix.gnu.org/40601

Do you mean that the incoming patches will include an explanation in
the manual about adduser/useradd?
Do you mean that guix-install.sh will now include a conditional test
on the kind of foreign distibution to use adduser or useradd?


Thank you for working on that.

Cheers,
simon

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 17 May 2020 16:55:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 12:55:12 2020
Received: from localhost ([127.0.0.1]:44501 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMZE-0002Cw-Ds
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 12:55:12 -0400
Received: from mail-wm1-f43.google.com ([209.85.128.43]:40304)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMZD-0002Ci-1q
 for control <at> debbugs.gnu.org; Sun, 17 May 2020 12:55:11 -0400
Received: by mail-wm1-f43.google.com with SMTP id n18so3453841wmj.5
 for <control <at> debbugs.gnu.org>; Sun, 17 May 2020 09:55:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=to:from:subject:message-id:date:user-agent:mime-version
 :content-language:content-transfer-encoding;
 bh=cG6sP+VnN4oBtpiYSUC+N6lB983HnXlTWifIFGC/q/g=;
 b=LsMJev0mAlcINWl25TM0COgKG3PZdNm/dTOMPOrdweP/Q0OmmadKC8hgsPxPdGJRLl
 dF55LVQE59NL6VerNRY5O5g/pk7TiIbG50Wylq4yyzdgns4EPpATrhmhnZk02vRiqCft
 eUCZsdgM9Pv5YXRor4J7mAVhNoM3WdviN56n5Cwaog9VT6Uf2vtaD7wopyAr6axfymoe
 bGNVSJpTx1sj9LVKhemX8CxzFjg0xv9xfmx8BFLd4VQXfGvQojVBZLr8QIJd//cRWyH0
 KiclXErtc74xpnC9iAIkwyVGfcEJAeQ+T8L8Ym06jxLDMvPI5fwlPoLC765VfC/1rcv3
 HwFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:to:from:subject:message-id:date:user-agent
 :mime-version:content-language:content-transfer-encoding;
 bh=cG6sP+VnN4oBtpiYSUC+N6lB983HnXlTWifIFGC/q/g=;
 b=PXcYDvgY+oaW/HOOpPK38U6nE5XjouVTvIjDPZ/3eJx5KF8vXdEklodkhif4kigN0e
 Fwwwn9YLRA6zrvEz60uicNxy/PXxkYmwOm5hlslN/Hev00fWGHerHCwC2sujtTrFvbtk
 ArvgJlEOXUocysGXbf7rlMFDqMt3QOOt5tTbGL7CtyA6dEt6g2iHEdgEF/m0DaWdtLai
 9XWpMY9GeNeWNWLPpjECm/q7h8me9Xlp+8NBp09uEnXgEQXS+B8lCn1WPl/hOYrRznkx
 2KfURhCxzYxzYzEyJEzLavhE/I45zplCikJB3SNnfgCAb8pbOWqwjPFmC+08M05S/rpy
 5q6w==
X-Gm-Message-State: AOAM530TBERkweqIe1GNiewEL7hK3vBHQ35gZJbPyPdz+UA0M5u3Rdyl
 FX5HlSHiWYki2DabCtBxlwHvGAeA
X-Google-Smtp-Source: ABdhPJwrOAV/cIzyjnn+JQ5zs61es0IRfYLc1lde6LDx2lFQW9k5xv46hZtaGXdmQn+qdcifpKS0NA==
X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr13984833wmk.99.1589734504675; 
 Sun, 17 May 2020 09:55:04 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id z3sm13349793wrm.81.2020.05.17.09.55.03
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 May 2020 09:55:04 -0700 (PDT)
To: control <at> debbugs.gnu.org
From: Vincent Legoll <vincent.legoll@HIDDEN>
Subject: retitle: guix-install.sh port to other distros
Message-ID: <59180167-87d6-ee82-2ae8-4d29d7977e5f@HIDDEN>
Date: Sun, 17 May 2020 18:55:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

retitle 40601 guix-install.sh: port to other distros & init systems

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [RFC, PATCH 0/28] guix-install.sh: port to other distros & init systems
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:16:02 +0000
Resent-Message-ID: <handler.40601.B40601.158973575722019 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973575722019
          (code B ref 40601); Sun, 17 May 2020 17:16:02 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:15:57 +0000
Received: from localhost ([127.0.0.1]:44532 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMtJ-0005im-53
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:15:57 -0400
Received: from mail-wr1-f51.google.com ([209.85.221.51]:45341)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMtG-0005bI-Gs
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:15:54 -0400
Received: by mail-wr1-f51.google.com with SMTP id v12so9031597wrp.12
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:15:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=to:from:subject:message-id:date:user-agent:mime-version
 :content-language:content-transfer-encoding;
 bh=AJPa3u0cTH97iNj5B2ib9uwf2SGkiIiIyXFz98I9US0=;
 b=oba/hJmxRFLkluUmsaC+yxD8lxJS284q4+OLPNWyxnPJlRmnF/dykIpB4S7YmUYs5B
 MS09kR1o40eEuoYvuzuAshqi1P9g2tkHEPQGCKhmqCqo+oHwwUfqetBII5WSWz+y0AH7
 YBW+nyRqjAXLUNEQ7V7AJcXZFV5/aRAXrbULUX3AkgmDryi8jz591gaND2G4MoF2JLhl
 mImmBa3nYwIFF4dJ+z1ih7IriKzT1yYg1772/gMsDDgdgSUthcE3kS6Q6SMy+NE4wbOD
 zYZpd6wb5eFhXvFotNBGZmb9MmlJk8PyJ7AeHJ+r8uKpCBc2kIYvbdRLCbWY74e2jDdZ
 fV+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:to:from:subject:message-id:date:user-agent
 :mime-version:content-language:content-transfer-encoding;
 bh=AJPa3u0cTH97iNj5B2ib9uwf2SGkiIiIyXFz98I9US0=;
 b=eiWy/GvxsDqurNmqF3DH6qK8MdRVjp595Q8nqQ53WF3EPAADMrhzv8gAgTTJsrj6kd
 E38YbSkLk6rCrOgXfh0/x+Fh4zjkkEyAlBCv8DuOqmZQOoUevDwBXw/3B1ZP17p1tLX0
 O038FI1IRqMg8G8HQuhn+As1edMSr9X2f+69fmp9HbwgC33bmnjMk9gB9BaGfC8d7qKY
 DnefY0PIaBVbQx16Ulbc73Y+4Yjnc+K7Q6AvNcNn7bmvQwEl22l/LHDMpx23UXu59qUy
 a7Y83yIctQOjg8UloJgBrRg3SarY/5LNNiciQbsVLCJ+CfDQKLx6gQKyN5JzwI0vU9hY
 JwVQ==
X-Gm-Message-State: AOAM533SDYdT3qlwa7ugTebDnkNqQBNIf8WDmXEFu6t6kLHv2QmAGZxr
 yfyQsZsGMmrjCh+dUOIpjsAsb7GV
X-Google-Smtp-Source: ABdhPJzAre8iyawyW1G5pH9llY/X8yr/c6QDfD6b6h2YKdOOJGZ6rGfJmuR9PDwdEzB/DERLZFiyYQ==
X-Received: by 2002:a5d:6085:: with SMTP id w5mr15020643wrt.322.1589735748324; 
 Sun, 17 May 2020 10:15:48 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id d9sm12831328wmd.10.2020.05.17.10.15.47
 for <40601 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 May 2020 10:15:47 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <12af851d-73b6-5865-8950-857c2158d41e@HIDDEN>
Date: Sun, 17 May 2020 19:15:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

Here is a RFC series of patches that add a few things:

- small fixes & cleanups
- removing some (not all) bashisms
- non-interactive mode (useful for (semi-) automated
   testing)
- openrc init system support
- runit init system support
- busybox compatibility (for alpine support)
- handle local guix-binary.${ARCH}.tar.xz file (useful
   for (semi-) automated testing)
- requirements fixes

It currently has been tested on a range of distros/arches
but the latest patches are still not polished (missing
proper commit messages)

The series is RFC as a few questions remain for me:

- Do we want to support alien (aka foreign++) distros
   (different shells, different init systems, etc...)
- To what extent
- Are the patches too fine-grained (I personally like
   them smallish)

Future, additionnal work items:
- s6 (adelie / obarun) init support
- handle GPG downloading in non-interactive mode
- being able to cross-build & test them on other
   arches again (dunno why it broke)
- documentation
- add missing guix-publish services
- add missing RO remounting the store on other distros
- removing allremaining bashisms (being shellcheck clean
   maybe ?)

This is to gather input before investing too much time.

For example, do we want to commit part of this now, with
the rest coming later ?

Any feedback ?
On individual patch(es) or on the whole series goal...

Thanks for reading this far.

-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 02/28] guix-install.sh: Add xz to requirements.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:18:02 +0000
Resent-Message-ID: <handler.40601.B40601.158973587127005 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973587127005
          (code B ref 40601); Sun, 17 May 2020 17:18:02 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:17:51 +0000
Received: from localhost ([127.0.0.1]:44539 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMv8-00071T-Px
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:51 -0400
Received: from mail-wr1-f53.google.com ([209.85.221.53]:40090)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMv6-000718-SP
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:49 -0400
Received: by mail-wr1-f53.google.com with SMTP id e16so9075630wra.7
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=TxfIgW/Ayf/9NgxHeZNBfOjwvzM/BDfSzmCc+ynI1gs=;
 b=jbnq1gToAE5S8NgtBbnF3f23GEjUFYWUavKSM2ujYBK/39i0Wkqaryf4XyxQXtkz1a
 FRfyprTYj79YnM4phGM7kYwVDklmGlNMZt1JJK3vb9r6UCybQ8v/iO8xRtw8EdQSO+BP
 JA8F3CQvydT6wziTf8Fbxe3qSfmPwqjYlssynn0wup9jo15eZGn+ss/M4EWeBBtAa25/
 MJmZt/gVwWkIPz3chAp0Ddo4hJbV4eLjrtfb+5zg+aJJk2STZRSuhwUDKTFusbp6RIeb
 GoM5skGhBZd8Dt6ggjsKYJBhT+5gHtqoJ7o7PnJijEc8B2V8Idgbzpk8YEstCeGVQm9u
 Aanw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=TxfIgW/Ayf/9NgxHeZNBfOjwvzM/BDfSzmCc+ynI1gs=;
 b=pYJ25GVftMl713z/z1FEH0WZjvGLzO3Ekk2hFEe/3J+tqd0nQoW1T0/V7iHBidjpQD
 A0UMr1wxn8xNoLWkzko6ZEMPwFH03KNDgnYc8DOFLEdl5KniFyUzJrKqVtsz+aSRUPYb
 HclpQ4nKA5jiqVKPhohRcQs6GzNd9MN+aP2qrlfLeuds1azJRYJIeaVoKXefTZqpK+7G
 e136Cu/CyKzj5AvF5vL4Ysq7wC5yd3zMT7R2npk9LDQEOgGoSA5aC9P3QNTXOdcyXMXF
 svzba6DRms0dhwLlRu5/UXIKNZe+tacmMSTNnx/ciFSZIMPrXgIl3BX7pacG/bfgPIk7
 JW7g==
X-Gm-Message-State: AOAM532mVZioFPgqKx1LfHyILiXEXiG2toIeAzZgvCdPQsMPKI2QytmI
 gStH9Wia1UUMFMceyqh38msICNyT
X-Google-Smtp-Source: ABdhPJxyipOofqZQNwSsUR1z5dNqD6cqZDxLoG7LAVqxY4QikclaJvl4W6cx+4zdWxb/6DNCdlWajA==
X-Received: by 2002:adf:dc86:: with SMTP id r6mr14605615wrj.45.1589735863169; 
 Sun, 17 May 2020 10:17:43 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:42 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:16:59 +0200
Message-Id: <20200517171725.732-2-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (REQUIRE): Add xz to requirements list.
---
 etc/guix-install.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 4909d3f162..dbc038a0ab 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -48,6 +48,7 @@ REQUIRE=(
     "groupadd"
     "tail"
     "tr"
+    "xz"
 )
 
 PAS=$'[ \033[32;1mPASS\033[0m ] '
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 03/28] guix-install.sh: Fix systemctl not found error message at probe.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:18:03 +0000
Resent-Message-ID: <handler.40601.B40601.158973587527055 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973587527055
          (code B ref 40601); Sun, 17 May 2020 17:18:03 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:17:55 +0000
Received: from localhost ([127.0.0.1]:44546 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvD-00072F-3c
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:55 -0400
Received: from mail-wm1-f41.google.com ([209.85.128.41]:38504)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMv7-00071A-Qy
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:51 -0400
Received: by mail-wm1-f41.google.com with SMTP id m185so2874861wme.3
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=YG1WXT/2/G3bXWxE0kriE/ZG3kP024EQQJnXT1rELdI=;
 b=vTgjmfvBZYYcFBwE9+oSbbDrR+dtO2L1N4vi0TTNpPD3HxoNuY7NjSvNXjmOq7/EyB
 XwAUV28/6kJIqsglwkR66J8VbVkf0gX70RwzflorkV2kXRa6hSku3Yk2ZY5W0h0pWJop
 IBdcsQADFPMtpl9sUCWARfHyqrhTECTwNVqe2pwuK4rQuQSNIY2e19icHZH9AmPlSY+y
 ehNyCB459YxQT+wYzeDX67quUQ1cttPEHsD1ZdtLbIuZSTLZuJqvJeTviqhv8Z5RaYJ3
 YA8wfqYY7FeBRXK7gXoIBX9t54gT8A+KDm3oqM+J/plTBEy8UplBu0zddqy/BX7JUlPR
 VP/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=YG1WXT/2/G3bXWxE0kriE/ZG3kP024EQQJnXT1rELdI=;
 b=kcCbnJXX42pHRlbCNDrxOpa6RcBdZOMdK1wpO4cOeZyAtGIRU8tXV/ZDjbJol1QtlH
 toQWbIYM0KOHcGGqeI1jGvq2OC+7smyjZOqdi+fA1FlaJPwGlyWKnejqZfh4Ttk8Xto5
 k7QgTD8BJ9MPOJPHhacU+gP/TyNmanWG6J3BNrMHlXIq1IbjsvI5KIvIrBB4M9NSbURL
 /8ZQUl99yR/fmZU5/KcNPnfUnyGPhhZf3yGnwUpZGERJ4uZOZnx7Q65dRv5ti+Gf3Hkj
 ooPPvZ10dfiO3thXJ8qQQMCLMadYbIS2dCgy0GSWzzcYMWB6/9fzOEvtTrH7qgdrEpZE
 B31A==
X-Gm-Message-State: AOAM531syHqQWq5q6Py997xncSFvRDDOPeVWhhfsy1SfRwcQYSmHEnGB
 RWRHCvXDAp5UcUuV8oIMS8Y3ZK8E
X-Google-Smtp-Source: ABdhPJxKkYSJHF2dB20E8vjnfIhIY/B8DawCzWyMU3jwdPOlUOcftZAJRYNoCZiHMWq6Uqz0NadRKA==
X-Received: by 2002:a1c:6204:: with SMTP id w4mr14947035wmb.55.1589735864036; 
 Sun, 17 May 2020 10:17:44 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:43 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:00 +0200
Message-Id: <20200517171725.732-3-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (chk_init_sys)[systemctl]: Redirect errors to /dev/null.
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index dbc038a0ab..4fa9664cf5 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -142,7 +142,7 @@ chk_init_sys()
         _msg "${INF}init system is: upstart"
         INIT_SYS="upstart"
         return 0
-    elif [[ $(systemctl) =~ -\.mount ]]; then
+    elif [[ $(systemctl 2>/dev/null) =~ -\.mount ]]; then
         _msg "${INF}init system is: systemd"
         INIT_SYS="systemd"
         return 0
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 04/28] guix-install.sh: Handle local binary tarball file.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:18:03 +0000
Resent-Message-ID: <handler.40601.B40601.158973587927086 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973587927086
          (code B ref 40601); Sun, 17 May 2020 17:18:03 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:17:59 +0000
Received: from localhost ([127.0.0.1]:44548 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvD-00072K-DM
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:58 -0400
Received: from mail-wm1-f42.google.com ([209.85.128.42]:56110)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMv8-00071D-Q9
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:51 -0400
Received: by mail-wm1-f42.google.com with SMTP id f13so6973508wmc.5
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=lwoOyC+nbnUDSu6+nfoEADl5SzsOrZnhHg5VEX6FKmk=;
 b=hKyfCJGxR2jp7VnSP1JyLOcEOjp8gy+QfaFk0DTdgnrlUCHpdr6g1vmD2hHEb6NxNM
 QPl1oLN1IGZCHb7gXDiaM2qecvsJWZpy6HENZWCICz26VHUinoORqqyASZrfCg7lwbXu
 xYszoauB5E50dVSO5ZrJ7sAgr8AApPZw3uGrEvunMkDiCJqWB4Zkj6bf4ynchUcbUprD
 DIRn5VjGej4hj7l6vQatRdZM+s2RQ6evuIBMc5BbhhRRVOl54zED4PWrYd+wE1iBQ8yn
 xnovGL/lePaJjvJR3Vbk6nj4yZT4oFwCtjl2TigXXptNjlcDlT9bKkTQ+BLxpVIJl4iD
 3jhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=lwoOyC+nbnUDSu6+nfoEADl5SzsOrZnhHg5VEX6FKmk=;
 b=AvUc0OVxJ9k74j+E/HCu2DrvseA9/Fd44bq4L0zSZDfa0YButxg1HWAtAae19pnkZe
 QyTM+rs09o0PYyMCedXbRqgTuzYGxfeYmySOmppO7n0ANJmJTq+AedkMctjKTDHepr4o
 mcgAgMyZzRONSrfDZoG09NtPOnT9tICW0xSi+5vKm2HnStrOSZ+jENvcqNJ4XXUEevWj
 tKA3GgkVVTOVA1i01yA7cBSNZKv1ocls1vopoJiv+rXt0cFU+q8Y2CEXgQBkIoZQamNG
 JCQGVP5CV0yzu2DEpReR+33oJ3MZZexNift2moVm+Fn2losVOeWsL+VtIw9ChR2kGdIO
 j01w==
X-Gm-Message-State: AOAM532U2ErT2eMSmtojSmBTTV+ka2eJ9xRhrOUzZKkuyHV+aqMxF4sb
 Q7u2Ob6KwCUYykZFfzvwXaj4jS9L
X-Google-Smtp-Source: ABdhPJyzWOhPgIYh2s5c2ABzMTgZQ6Zgh5mjEljC1JIxaA1yEBcTOJEF8fOzaKTscc43US7DuMP0AA==
X-Received: by 2002:a1c:2dc7:: with SMTP id
 t190mr14234318wmt.129.1589735864988; 
 Sun, 17 May 2020 10:17:44 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:44 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:01 +0200
Message-Id: <20200517171725.732-4-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (REQUIRE): add realpath.
(main): Handle local binary tarball file path passed as first arg.
---
 etc/guix-install.sh | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 4fa9664cf5..7b9a729570 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -4,6 +4,7 @@
 # Copyright © 2018 Ricardo Wurmus <rekado@HIDDEN>
 # Copyright © 2018 Efraim Flashner <efraim@HIDDEN>
 # Copyright © 2019 Tobias Geerinckx-Rice <me@HIDDEN>
+# Copyright © 2020 Vincent Legoll <vincent.legoll@HIDDEN>
 #
 # This file is part of GNU Guix.
 #
@@ -47,6 +48,7 @@ REQUIRE=(
     "uname"
     "groupadd"
     "tail"
+    "realpath"
     "tr"
     "xz"
 )
@@ -482,10 +484,14 @@ main()
     umask 0022
     tmp_path="$(mktemp -t -d guix.XXX)"
 
-    guix_get_bin_list "${GNU_URL}"
-    guix_get_bin "${GNU_URL}" "${BIN_VER}" "$tmp_path"
-
-    sys_create_store "${BIN_VER}.tar.xz" "${tmp_path}"
+    if [ -z "$1" ]; then
+        guix_get_bin_list "${GNU_URL}"
+        guix_get_bin "${GNU_URL}" "${BIN_VER}" "${tmp_path}"
+        TARBALL="${BIN_VER}.tar.xz"
+    else
+        TARBALL="$(realpath $1)"
+    fi
+    sys_create_store "${TARBALL}" "${tmp_path}"
     sys_create_build_user
     sys_enable_guix_daemon
     sys_authorize_build_farms
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 01/28] nix/local.mk: Add missing comment to sysvinit section.
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:18:05 +0000
Resent-Message-ID: <handler.40601.B40601.158973588327137 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973588327137
          (code B ref 40601); Sun, 17 May 2020 17:18:05 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:03 +0000
Received: from localhost ([127.0.0.1]:44554 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvG-00072p-Su
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:03 -0400
Received: from mail-wm1-f52.google.com ([209.85.128.52]:39466)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMv6-000716-5y
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:52 -0400
Received: by mail-wm1-f52.google.com with SMTP id w64so7743101wmg.4
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=oUYo9T/+Q7VaUq8k85t2wMuKj0cuREfH0mo0SNmNsWs=;
 b=l4tVdl+oiar6F5DzR9bi8p8tcE8JBybLZzDQAUP7OJQ4yhZwrUiSnQpqM0yoxpM8Pp
 JP3Lyia9a7mF3PUfKMXDeHOFuK5J7iCSegjBQwrGPTLQ+IJQCctmmQ8NKFLXFbBEquql
 um84AK6sMM+W6FMzweSXHqCLXS07C3abmzEfTEELRtW5xu/9e0lTYvVIBRcil6WtExmJ
 wmsjtAZQiYxACDuA+JPHAXNZl2sMasypjvvO9lxmRbN5cL2p7gcN3+TtZNNSDNAHOkSX
 8GmFlINaQTPh+9A106Wxi4iww9zHIRzGerBjOEHOgzdrJR57vT/yw6HG4nw2TNMCVuH+
 MXkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=oUYo9T/+Q7VaUq8k85t2wMuKj0cuREfH0mo0SNmNsWs=;
 b=oII2XtOc6D3KAB0047QQEj3HfAeP03ChjNBq4C1+TGBdM/1tWzKBt9oSzJDDDj9sEK
 EgAdHG9nU2+oOsfcQ5O/kKKIQO5vQPH2li6ZydmbFz0IKLYSrtloVS+K53hUXHPVnCo9
 6xUR/VcLWzS5SrcUuCWqNuwJLbJ9dhELGhunTmL14Q1JHRHmHrdtRpde72Vcac8wa7gO
 /8F2KjY4YUgR1rgltgoPlX8beuVjlsytSf3QoibPsOruTU5uOrLcTu/Ys0W6ewkg3jYy
 DGEruQjidtHOEK1yBf4dIX8NWDppty+aZV1TSHgtl0fyC2ccVngAK3rfH/I0PDuiQLZ3
 RhMw==
X-Gm-Message-State: AOAM530Y99U6uDS5AaClwC+6oUhbR5mL/VrPjA/5jfl0jBhYR49e39iI
 +kt4z/tYmVkWtR0hHXb8hpPFm4vq
X-Google-Smtp-Source: ABdhPJw3/do73iAcEJYEd2LxdcSHYl1AoKFKlGR67D9LOyESKUwxSs5q/XLoPWu9b+sj4use6zO2nA==
X-Received: by 2002:a1c:3585:: with SMTP id c127mr218206wma.34.1589735862201; 
 Sun, 17 May 2020 10:17:42 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:41 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:16:58 +0200
Message-Id: <20200517171725.732-1-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* nix/local.mk (sysvinit): Add comment.
---
 nix/local.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nix/local.mk b/nix/local.mk
index a64bdd2137..412d89ba3d 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -164,6 +164,7 @@ etc/guix-%.service: etc/guix-%.service.in	\
 	       "$<" > "$@.tmp";		\
 	mv "$@.tmp" "$@"
 
+# The service script for sysvinit.
 sysvinitservicedir = $(sysconfdir)/init.d
 nodist_sysvinitservice_DATA = etc/init.d/guix-daemon
 
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 06/28] guix-install.sh: trivial whitespace fix.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:18:06 +0000
Resent-Message-ID: <handler.40601.B40601.158973588427160 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973588427160
          (code B ref 40601); Sun, 17 May 2020 17:18:06 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:04 +0000
Received: from localhost ([127.0.0.1]:44563 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvL-00073e-HU
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:04 -0400
Received: from mail-wm1-f48.google.com ([209.85.128.48]:38513)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvA-00071G-I0
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:53 -0400
Received: by mail-wm1-f48.google.com with SMTP id m185so2875061wme.3
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=UKovMz2T8MmeYnmWNRGA1O8pU4zP7TixW5aI7Dq8KYU=;
 b=kNqMPGHE5yXUGCp8RKzh0tYer7ZAntvhohPAhsRjGTMQdyYCbGflpCqbWctxAaSsXM
 LjgYpjm4C5cKoryyfWKs+LJ0lEM3r4QHCQiX6n+x0ZieM1ErJNt+hC2rRibwRAqylTUK
 4HG4oOQ97G/O/uj0+lq6ap8BO2V/qL+z20SyVMPmgVCv/xGA0jcyJzrMYAQfbK2TODb0
 ywM4L/P/zVZlVL643Q3Qab/GUpu/8jUvq16m6zIEpw6eYQLqIYzaNCikdoD72/o9inQ9
 AK/a80Of0+EIzbThqsub+uAl1uSrKUgqHoBlEFVFpYj1K3wJ9LCjx/1x9bMii4unRKte
 Dw5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=UKovMz2T8MmeYnmWNRGA1O8pU4zP7TixW5aI7Dq8KYU=;
 b=PQhBhzwnUPxmMQD3cF1aiEg0vWWLEXI7fDsvdUnFpvzjsAZVnPwiWjws6pCR4gs3PL
 Km5HkloL3EaR1xdY4qMFtQCq7YS61jbDnmif2MqTxP1EX5XlDwyLNrL+yui0w95y2eFJ
 J9gidlmAFxK88741kxykPXvcr+c4wDlznkO7Tccgqws7F5dlWpa24oslbDmvjwc8TmYL
 gZtJgC5YV6G+H67aVQBHpWaV0oy24LR90N4DO2uJGGM+HaWkj/CoMcWxmLgJxGc05kgA
 4hUeR2c3Arn44lQX0LUhaTYHM65vGqNNJl/KdHbBLld8AkAAXb/cYi5Rs21LKgydR5FP
 KtNA==
X-Gm-Message-State: AOAM532VmvRSNwgA5FKiyL5k13Ebi10lI/dVGFVILIqyesUR6aVu4yh/
 hdMjqRwlRAXoXyUIFGhY56i1vTHa
X-Google-Smtp-Source: ABdhPJzI1tPmIJWEEtWxPzUY2idnjV9yYYLCwUDJJzpgJIHJlAilcu+t3hGEWT/nWjlMANlWM5fgmA==
X-Received: by 2002:a1c:68c2:: with SMTP id
 d185mr14316823wmc.145.1589735866751; 
 Sun, 17 May 2020 10:17:46 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:46 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:03 +0200
Message-Id: <20200517171725.732-6-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Almost the entire file is indented with spaces, a few tabs slipped in, clean
them up.

Checked triviality with git diff -b.

* etc/guix-install.sh(chk_sys_arch): Replace tabs with spaces.
(sys_enable_guix_daemon): Likewise.
---
 etc/guix-install.sh | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 6eff82c444..078aa4a781 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -180,9 +180,9 @@ chk_sys_arch()
         aarch64)
             local arch=aarch64
             ;;
-	armv7l)
-	    local arch=armhf
-	    ;;
+        armv7l)
+            local arch=armhf
+            ;;
         *)
             _err "${ERR}Unsupported CPU type: ${arch}"
             exit 1
@@ -353,15 +353,15 @@ sys_enable_guix_daemon()
                  /etc/systemd/system/;
               chmod 664 /etc/systemd/system/guix-daemon.service;
 
-	      # Work around <https://bugs.gnu.org/36074>, present in 1.0.1.
-	      sed -i /etc/systemd/system/guix-daemon.service \
-	          -e "s/GUIX_LOCPATH='/'GUIX_LOCPATH=/";
+              # Work around <https://bugs.gnu.org/36074>, present in 1.0.1.
+              sed -i /etc/systemd/system/guix-daemon.service \
+                  -e "s/GUIX_LOCPATH='/'GUIX_LOCPATH=/";
 
-	      # Work around <https://bugs.gnu.org/35671>, present in 1.0.1.
-	      if ! grep en_US /etc/systemd/system/guix-daemon.service >/dev/null;
-	      then sed -i /etc/systemd/system/guix-daemon.service \
-		       -e 's/^Environment=\(.*\)$/Environment=\1 LC_ALL=en_US.UTF-8';
-	      fi;
+              # Work around <https://bugs.gnu.org/35671>, present in 1.0.1.
+              if ! grep en_US /etc/systemd/system/guix-daemon.service >/dev/null;
+              then sed -i /etc/systemd/system/guix-daemon.service \
+                  -e 's/^Environment=\(.*\)$/Environment=\1 LC_ALL=en_US.UTF-8';
+              fi;
 
               systemctl daemon-reload &&
                   systemctl start guix-daemon &&
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 07/28] guix-install.sh: Move code in a new function.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:18:06 +0000
Resent-Message-ID: <handler.40601.B40601.158973588527189 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973588527189
          (code B ref 40601); Sun, 17 May 2020 17:18:06 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:05 +0000
Received: from localhost ([127.0.0.1]:44568 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvM-000740-If
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:05 -0400
Received: from mail-wm1-f67.google.com ([209.85.128.67]:35934)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvB-00071I-ER
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:53 -0400
Received: by mail-wm1-f67.google.com with SMTP id u188so7755990wmu.1
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=8gNStNg88YD5Kn8bnefVqMYHDyPrfA+9fsyDVjiARFA=;
 b=C9YkW51Cskar2pyN6kkgL8rsJpvhVC2xtRP2hyQWy3GndJNemAQZE1uCerb0NXwWw8
 kjWzgHElIe4MMWn6vgXD/FsgSCbC2nIyMMQVgjPKZQkFjrVFN4lmMyHaVrzPzYcLDot/
 02UWiCrxkMyaKqoZdasDAHUhtOGxJprrMtF0E2rXaUy+ZKWRkUsSxviuGN+t9JAPBLaF
 dxHjSFOzYeIZA1fo9Q4/9Jav1kKdjjNab5J/5D0sPy4/IooaQeo6ZPpZ7W+wHcWZ+Kmg
 EQVA/rqrAR7jIZRUfocm1PmlYsjaFuLT6W3MFws+3sF2rgZlRAJOtJCKsio4JJYa8Dql
 HXJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=8gNStNg88YD5Kn8bnefVqMYHDyPrfA+9fsyDVjiARFA=;
 b=XgjWeNXPqrK1bqiDSLwR+ItGkJRp8PhSoa5urBWF6hb30+eJq2TFWJVS4eHmc1ggeA
 IsomMiqPBmqxWaPCQRW9xzxJ0JsQiPDPBHa4bC9VUmRCYuratFqL7oaVL5rf8g12/g8S
 Zhc3lhAQ+yqSp1g9UcB4CwT11ymuDUkvgOLWb8w7n8VDzwBp8Q9fCq+DJ+dZLmEp7Kzg
 IGpuUIhqZAkfGzhBi0GNPLSY2t+UXG9uTbqekUUJ50uFsP0aONXbZIL5YU6LsX/NQpR9
 clVjbm6Q9gvFeiwktzhApCTBA9MKDAEim0x07fuailBCMlIFBn/zS7dUX7RM+7/v5uS5
 /buA==
X-Gm-Message-State: AOAM531imJ4yDw7aXfMUqCiNNKeIIAft1TmEJQrV7SEqmp0a0Nqvy7zs
 l0+0L3tjlVhR6TcyQyquGflqGKRA
X-Google-Smtp-Source: ABdhPJx4YtphdmZnHmVF3DiEC4wiDpWUNeMPJEYZ4q9aONx0DU9hitIRXQczdN29TkGRzo/Kzrbg7A==
X-Received: by 2002:a1c:2c0b:: with SMTP id s11mr11309060wms.97.1589735867600; 
 Sun, 17 May 2020 10:17:47 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:47 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:04 +0200
Message-Id: <20200517171725.732-7-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (sys_enable_guix_daemon): Move code from here...
(sys_make_guix_available): ...to this new function, fixing whitespace...
(main): ...and call it here.
---
 etc/guix-install.sh | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 078aa4a781..225cf532b8 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -330,16 +330,8 @@ sys_create_build_user()
 sys_enable_guix_daemon()
 { # Run the daemon, and set it to automatically start on boot.
 
-    local info_path
-    local local_bin
-    local var_guix
-
     _debug "--- [ $FUNCNAME ] ---"
 
-    info_path="/usr/local/share/info"
-    local_bin="/usr/local/bin"
-    var_guix="/var/guix/profiles/per-user/root/current-guix"
-
     case "$INIT_SYS" in
         upstart)
             { initctl reload-configuration;
@@ -391,11 +383,25 @@ sys_enable_guix_daemon()
             echo "  ${ROOT_HOME}/.config/guix/current/bin/guix-daemon --build-users-group=guixbuild"
             ;;
     esac
+}
+
+sys_make_guix_available()
+{ # add guix into PATH
+
+    local info_path
+    local local_bin
+    local var_guix
+
+    _debug "--- [ $FUNCNAME ] ---"
+
+    info_path="/usr/local/share/info"
+    local_bin="/usr/local/bin"
+    var_guix="/var/guix/profiles/per-user/root/current-guix"
 
     _msg "${INF}making the guix command available to other users"
 
     [ -e "$local_bin" ] || mkdir -p "$local_bin"
-    ln -sf "${var_guix}/bin/guix"  "$local_bin"
+    ln -sf "${var_guix}/bin/guix" "$local_bin"
 
     [ -e "$info_path" ] || mkdir -p "$info_path"
     for i in ${var_guix}/share/info/*; do
@@ -505,6 +511,7 @@ main()
     sys_create_store "${TARBALL}" "${tmp_path}"
     sys_create_build_user
     sys_enable_guix_daemon
+    sys_make_guix_available
     sys_authorize_build_farms
     sys_create_init_profile
 
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 08/28] guix-install.sh: Use getent for both user & group presence checking.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:02 +0000
Resent-Message-ID: <handler.40601.B40601.158973588827249 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973588827249
          (code B ref 40601); Sun, 17 May 2020 17:19:02 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:08 +0000
Received: from localhost ([127.0.0.1]:44576 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvP-00075Q-MG
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:07 -0400
Received: from mail-wm1-f51.google.com ([209.85.128.51]:35887)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvC-00071K-G0
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:54 -0400
Received: by mail-wm1-f51.google.com with SMTP id u188so7756015wmu.1
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=0G9W/TT/cnOdqEzDp8jxk8cyBTHuyph0EULP52acRck=;
 b=EhaRD1Wfk5m4PyEzMS29brIb3OKASeJkJa6ZOPDFrxBTAfkkeCugeQHMC7BHYZvdk3
 Ul8T4jH+mkG3BPSbim9Q71rb2AhLuHcAe6OMWnXVfDvVJxma3v5nRBh6q+mMhoOlfIS5
 TeMqkLATETF3Qc1LdtQaRE1jeRb2+WChR0Zrb9YwJ7JbOWp5TROwgQezb7BT0Gu+YJSa
 UqpEy6LdFhTMv/FrGBnND1VakvWSgGebPZ18+rmXL1fn20pBZthUuhjgbwc6uG6nz1p0
 0n5Zj5rEN3Mrnt+dhdbJI1sZyJRORHVgxIU1vMcFXXzlMe9o76TxfDPd976HQGoPwL22
 W4Vg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=0G9W/TT/cnOdqEzDp8jxk8cyBTHuyph0EULP52acRck=;
 b=HFI7/PQ2lwhizr9duzZLIGjSkZh+A0NfWddqtgEIuGfFv5V559DSTPZohxS2ZsJmp9
 dggP88JHNCSf0UE5hqy9txJDRbO1KIH4ZxQFbI91JmRj4wkSDgLaoR+GBVe4eW3wGYGg
 xO3bDlhXGuHPqM3YAtym5mIGfPyhtD2K3UghmFHwPj9cnLZnFRjZ5DSNLKam3QqW2UBI
 u/AomEyZ+lqe0F8WAcRixtA92zB0va+ShehXTMC7ht61f51GyK6a1bZKhmNz0/eiPMRw
 RlVEfU0TASsscMwwTuUWiMzDnRenq/73kNaEFqhCGjH5/zDossC2tOgjMqe/eVNePSBH
 ZvHw==
X-Gm-Message-State: AOAM532hjksU868B1magQ1dTZCSV4c6lavKCfaYEPco3OIDK7r0rJuVu
 qf1hqWwAoNVj1gGeGsy+Jt35lk9z
X-Google-Smtp-Source: ABdhPJyrdwf071sp6gLrimvJKfJUGyUe08h4w1gPgbgu9n47HMQpwJCwK8SphbBNnxu2Pdw0jKSn8A==
X-Received: by 2002:a05:600c:2109:: with SMTP id
 u9mr14469226wml.75.1589735868765; 
 Sun, 17 May 2020 10:17:48 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:48 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:05 +0200
Message-Id: <20200517171725.732-8-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (sys_create_build_user): Use getent instead of id to check
presence of users, use bare getent call with output redirection for group check.
---
 etc/guix-install.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 225cf532b8..a56e0ec7b2 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -303,7 +303,7 @@ sys_create_build_user()
 
     _debug "--- [ $FUNCNAME ] ---"
 
-    if [ $(getent group guixbuild) ]; then
+    if getent group guixbuild >/dev/null 2>&1; then
         _msg "${INF}group guixbuild exists"
     else
         groupadd --system guixbuild
@@ -311,7 +311,7 @@ sys_create_build_user()
     fi
 
     for i in $(seq -w 1 10); do
-        if id "guixbuilder${i}" &>/dev/null; then
+        if getent passwd "guixbuilder${i}" >/dev/null 2>&1; then
             _msg "${INF}user is already in the system, reset"
             usermod -g guixbuild -G guixbuild           \
                     -d /var/empty -s "$(which nologin)" \
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 05/28] guix-install.sh, guix-binary tarball: Handle runit-based foreign distributions.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:04 +0000
Resent-Message-ID: <handler.40601.B40601.158973589527301 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973589527301
          (code B ref 40601); Sun, 17 May 2020 17:19:04 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:15 +0000
Received: from localhost ([127.0.0.1]:44578 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvP-00075S-VV
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:15 -0400
Received: from mail-wm1-f41.google.com ([209.85.128.41]:36983)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMv9-00071F-MA
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:55 -0400
Received: by mail-wm1-f41.google.com with SMTP id z72so7778509wmc.2
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=5LmrIZmiQZyJ7CLoCVkmbsukOTFLZwrdqX3s7kCsRxU=;
 b=RKHj8dgrpMXQhF5CMmNruInoUpdObaGy7lktryJUiXoo4Ahwh0sv7U5ghrFmmwaZYT
 jtzm1SXt9D4Wn604oIqJtSs/Y6GqCEFk5Iag3rUSQhXSSPqXLG49JiG40/TSoVGsWu+w
 yeuhx2bSrfPt58vO4KDBDOsV8Em4FwjpkDPxe8OcHBtHa8k8pu2f4v9TJe6DcaZQDypz
 RsbuKO1L/1l5/YZYXB1+g3mnP02jZqexP+zM9GWqoTL3kvXc5aKG3vGdIlMigcQfApqC
 JZbHbGN+DIrPpz2akw0Q/4PvQZTDRNKTpMtHwFAe9oHfEfk6DT/dkPaJwy31V7JeJZkC
 ueIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=5LmrIZmiQZyJ7CLoCVkmbsukOTFLZwrdqX3s7kCsRxU=;
 b=mpiDT2Xdl8JCpINkpUTXniNKZQguTAGHGulNf0msFGs2fhcbmKWuI7dXQpzcWhCZL3
 iEtO+sDoCmHtjjsMa3Acu/FDg+oTpXnpqF1f+vWZQEv8sWhOsWzQ3dJYQ22GsyOIg6SW
 NGLlRMcXhk+wqpS39+9dodJcgcTiMgzcBfP+C30ySKK7w1VYitgyXJhx6AtLFhwUaZGv
 4H+yy11jVBqwj/TdHJ7VhhcDBeSyAMhX9pAaGZhUpR/yRWUWrrVoshfuivyCmuzhfkyG
 AqloVOvk5gRase7tMNuqmu0waYPw/o7UwU7hZM3oroJ0FsIcrmjNkhow9nQpN9OeLou3
 WKmQ==
X-Gm-Message-State: AOAM532mJI+fmuOpGL/nL8uina/Mj/brJTSIiwRN+Ztn0z2f8ApAxg0b
 nKGfIRmXHLMVeDXbkqcTs/rZLvKs
X-Google-Smtp-Source: ABdhPJzGrpfZ9lg1YejuATRhIkHSj10p8uQHVetGjS5VTJMdc9E/ViYdSdmMIFqDcKpTByBd/6oS5Q==
X-Received: by 2002:a7b:c21a:: with SMTP id x26mr14722739wmi.82.1589735865917; 
 Sun, 17 May 2020 10:17:45 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:45 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:02 +0200
Message-Id: <20200517171725.732-5-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* .gitignore: Add /etc/runit/run.
* etc/guix-install.sh (chk_init_sys): Add case to detect runit.
(sys_enable_guix_daemon): Add case to setup guix-daemon within runit.
* etc/runit/run.in: New file.
* nix/local.mk (etc/runit/run): Add target to generate etc/runit/run from
etc/runit/run.in. (nodist_runitservice_DATA): New variable... (CLEANFILES):
... add it here. (runitservicedir): New variable. (EXTRA_DIST): Add
etc/runit/run.in.
---
 .gitignore          |  1 +
 etc/guix-install.sh | 11 +++++++++++
 etc/runit/run.in    | 15 +++++++++++++++
 nix/local.mk        | 14 ++++++++++++++
 4 files changed, 41 insertions(+)
 create mode 100644 etc/runit/run.in

diff --git a/.gitignore b/.gitignore
index fd2cf56098..89a2c89e1e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -72,6 +72,7 @@
 /etc/guix-publish.conf
 /etc/guix-publish.service
 /etc/init.d/guix-daemon
+/etc/runit/run
 /guix-daemon
 /guix/config.scm
 /libformat.a
diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 7b9a729570..6eff82c444 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -152,6 +152,10 @@ chk_init_sys()
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
+    elif [[ -d /etc/sv ]]; then
+        _msg "${INF}init system is: runit"
+        INIT_SYS="runit"
+        return 0
     else
         INIT_SYS="NA"
         _err "${ERR}Init system could not be detected."
@@ -364,6 +368,13 @@ sys_enable_guix_daemon()
                   systemctl enable guix-daemon; } &&
                 _msg "${PAS}enabled Guix daemon via systemd"
             ;;
+        runit)
+            { cp -r "${ROOT_HOME}/.config/guix/current/lib/runit/guix-daemon" \
+                 /etc/sv;
+              chmod 755 /etc/sv/guix-daemon/run;
+              ln -s /etc/sv/guix-daemon /etc/runit/runsvdir/default/; } &&
+                _msg "${PAS}enabled Guix daemon via runit"
+            ;;
         sysv-init)
             { mkdir -p /etc/init.d;
               cp "${ROOT_HOME}/.config/guix/current/etc/init.d/guix-daemon" \
diff --git a/etc/runit/run.in b/etc/runit/run.in
new file mode 100644
index 0000000000..e57ef597bc
--- /dev/null
+++ b/etc/runit/run.in
@@ -0,0 +1,15 @@
+#!/bin/sh
+
+# This is a "run script" for the runit init system to launch
+# 'guix-daemon'.  Drop it in /etc/sv/guix-daemon and add a symlink to
+# it like the following to have 'guix-daemon' automatically started.
+# ln -s /etc/sv/guix-daemon /etc/runit/runsvdir/default/
+
+GUIX_LOCPATH=@localstatedir@/guix/profiles/per-user/root/guix-profile/lib/locale
+LC_ALL=en_US.utf8
+
+export GUIX_LOCPATH LC_ALL
+
+exec @localstatedir@/guix/profiles/per-user/root/current-guix/bin/guix-daemon \
+  --build-users-group=guixbuild
+
diff --git a/nix/local.mk b/nix/local.mk
index 412d89ba3d..582ff16168 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -1,6 +1,7 @@
 # GNU Guix --- Functional package management for GNU
 # Copyright © 2012, 2013, 2014, 2015, 2016, 2018, 2019 Ludovic Courtès <ludo@HIDDEN>
 # Copyright © 2016 Mathieu Lirzin <mthl@HIDDEN>
+# Copyright © 2020 Vincent Legoll <vincent.legoll@HIDDEN>
 #
 # This file is part of GNU Guix.
 #
@@ -175,6 +176,17 @@ etc/init.d/guix-daemon: etc/init.d/guix-daemon.in	\
 	       "$<" > "$@.tmp";		\
 	mv "$@.tmp" "$@"
 
+# The service run script for runit.
+runitservicedir = $(libdir)/runit/guix-daemon
+nodist_runitservice_DATA = etc/runit/run
+
+etc/runit/run: etc/runit/run.in		\
+			$(top_builddir)/config.status
+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";   \
+        $(SED) -e 's|@''localstatedir''@|$(localstatedir)|' <   \
+               "$<" > "$@.tmp";         \
+        mv "$@.tmp" "$@"
+
 # The '.conf' jobs for Upstart.
 upstartjobdir = $(libdir)/upstart/system
 nodist_upstartjob_DATA = etc/guix-daemon.conf etc/guix-publish.conf
@@ -189,6 +201,7 @@ etc/guix-%.conf: etc/guix-%.conf.in	\
 CLEANFILES +=					\
   $(nodist_systemdservice_DATA)			\
   $(nodist_upstartjob_DATA)			\
+  $(nodist_runitservice_DATA)			\
   $(nodist_sysvinitservice_DATA)
 
 EXTRA_DIST +=					\
@@ -198,6 +211,7 @@ EXTRA_DIST +=					\
   etc/guix-daemon.conf.in			\
   etc/guix-publish.service.in			\
   etc/guix-publish.conf.in			\
+  etc/runit/run.in				\
   etc/init.d/guix-daemon.in
 
 if CAN_RUN_TESTS
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 10/28] guix-install.sh: Replace subshell-inducing command grouping.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:05 +0000
Resent-Message-ID: <handler.40601.B40601.158973589627308 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973589627308
          (code B ref 40601); Sun, 17 May 2020 17:19:05 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:16 +0000
Received: from localhost ([127.0.0.1]:44586 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvX-00076I-Lu
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:15 -0400
Received: from mail-wm1-f43.google.com ([209.85.128.43]:40671)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvE-00071V-9x
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:56 -0400
Received: by mail-wm1-f43.google.com with SMTP id n18so3495194wmj.5
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=ytrjZ5+hfsUd6CTscL8Kv2fvv7PYXRhpj9ozR1tFr04=;
 b=HssHqkVS1hmOddimWSPF0LXzEoonwULQoXtAQx9uWnEyEM36ay7F3At3OY42149EYF
 /SxsxB6KvXqwSROvS87en3lHOmnsn4zzQQsXaf618B0BF0wEXIAWOSocUcQU/SxVRtng
 OxMfJz3CHNU6RwRvXCRfWsCvwC/74vpyja9KxJjTWKlfy2gd2LMxIwiRTbvO7xb4PNUq
 /7cOOoPT59L7dPmVPF0vhcGlW1ZQts0OPXmaEtDktJO5bnNASzMsVXhmILqDnPvHyInQ
 1gLyHnahgqKbGsM/ZG9f/slmQwybqLuovTMgDVIlmAeD7/Ms1cvgr6VC8N+rO08vknHB
 EefA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ytrjZ5+hfsUd6CTscL8Kv2fvv7PYXRhpj9ozR1tFr04=;
 b=FKJEV1ty5/UA4l7Mmx4KUcW6PEA/kH6qcOEq0Xcmor9gvW3kHExVA670FgAWIYXHw2
 5XSU1YS+vbpLG6m9dhjRYJiRj1zOgh5gmR09hqqS+UamytMOPeeIRrdkXLgWFQ9wwjdC
 2yEItMknKllx94+nfao1gPv7VmJr1FJNxn9WyxeU7dfXkDHvqc0zSQpwQZcLa5rs+C1H
 LNjv/O7ou0jhnacWfu29OJnzTci02FogKzG90KleWtguDLMpsxQmBzAG7zDLiXEmc8zo
 ACF4cu8425gJbUtpP3cVKFx7DvRPT+UaZ7lPKsROSGWkq8UFWUWGNdHoWEtp3E4ubNHC
 JZxQ==
X-Gm-Message-State: AOAM530aHx+kBtrtXu4LTCRo3iKUFS7Ro+FyxYvBZnF2HtpZdgZmAqVO
 rhaEqISjH2l4YSrtFcrI0gc6Xlm5
X-Google-Smtp-Source: ABdhPJzVd14f1pAUkMDnjrQpi+CJw6a3W+/Sq0VrFTKkOViVsJEPqpXTF7VQfkSbCf/rHvQjIis+IA==
X-Received: by 2002:a1c:19c1:: with SMTP id 184mr14086263wmz.29.1589735870462; 
 Sun, 17 May 2020 10:17:50 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:50 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:07 +0200
Message-Id: <20200517171725.732-10-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (chk_gpg_keyring): Replace () command grouping by {}.
---
 etc/guix-install.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 19883b89ae..d2e44e98b2 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -110,11 +110,11 @@ chk_gpg_keyring()
 
     # Without --dry-run this command will create a ~/.gnupg owned by root on
     # systems where gpg has never been used, causing errors and confusion.
-    gpg --dry-run --list-keys ${OPENPGP_SIGNING_KEY_ID} >/dev/null 2>&1 || (
-        _err "${ERR}Missing OpenPGP public key.  Fetch it with this command:"
-        echo "  wget https://sv.gnu.org/people/viewgpg.php?user_id=15145 -qO - | gpg --import -"
-        exit 1
-    )
+    gpg --dry-run --list-keys ${OPENPGP_SIGNING_KEY_ID} >/dev/null 2>&1 || {
+        _err "${ERR}Missing OpenPGP public key.  Fetch it with this command:";
+        echo "  wget https://sv.gnu.org/people/viewgpg.php?user_id=15145 -qO - | gpg --import -";
+        exit 1;
+    }
 }
 
 chk_term()
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 12/28] guix-install.sh: Rework user & group handling, adding busybox support.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:07 +0000
Resent-Message-ID: <handler.40601.B40601.158973591027337 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591027337
          (code B ref 40601); Sun, 17 May 2020 17:19:07 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:30 +0000
Received: from localhost ([127.0.0.1]:44588 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvY-00076P-0z
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:29 -0400
Received: from mail-wr1-f65.google.com ([209.85.221.65]:43464)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvG-00071p-1M
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:58 -0400
Received: by mail-wr1-f65.google.com with SMTP id i15so9040165wrx.10
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=2izcnBu2ZDWO/kGThBJBoui+0alVNDMev/sMWrvHluo=;
 b=rpoS9d14/uNkiHssIHLUvxZEe9yr+96zfeABbw6rBxzqOdfVa5z39ObLnj0j4/J2GT
 ChQCFLWbAq/gzQRzpL7JZPDvUcJHxEl2iieIzV11dqb5JD92MnkbJp+qwhRwIJP8fAFu
 xQguwJzrlwMXhHxrph15hMc83BFTK7ath9/+dH3QNRMakTNO7CAlj365mBCXeznOBC7R
 eKROmRQrpq2dr1F4rN+3d9K7Ar+3x07CJoORqd9JX4UD9UrN0lIVETk/A6IKbZwhRorC
 B9cKLhUVZ+v5Ixawl0+UBTqE6LgwU5sfjQxStehvfR/2sIqBkU88LVGGPOj23XDQSbXQ
 I8kw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=2izcnBu2ZDWO/kGThBJBoui+0alVNDMev/sMWrvHluo=;
 b=SWlAYi8fQu/TyiTziCQtj5GMcGaQwfwg4mSxCW2D1zajecHgoLxRq+KdGTB8U6e4MS
 IlXf2Sp7Rc9SU8rmjp/vcLp+191QpMVspizvjwLjYlGA/EKDt4U9d06UwzbFcfyCdRRn
 joJFBKjg9eLYtvTXCqfcJVNywhLff7p5MPF+dGNRc1eGVIDg+Esu4hHoemEQ10f6fGPk
 nhG+nFC9kvG9lcAECP4hLSqVOyLiYBpxDiYjZ76Ke/KI2jeVAPV6RjTzIZ5nmw1fryIR
 PrzCwRuA+1NL0bDZWAKfzHKHMh4Q54j22UuahUr9BQFaxd92Ws8r/QoYRu/H/gL6nDp8
 s6oA==
X-Gm-Message-State: AOAM5305uxndsS2ONQuT0vrDWMSSmY1jghMmLtbYJZvLKHWh3+UBnlA2
 TplshbEzM8gP30T56EJctNAtrV7k
X-Google-Smtp-Source: ABdhPJz9TUyc+hP2IDG+tzFqnIjparv0j7nKds9p45nuY96kyc1WUTuN+FHiNlRspURNrSEcAqXo5w==
X-Received: by 2002:adf:fdd0:: with SMTP id i16mr15156444wrs.389.1589735872187; 
 Sun, 17 May 2020 10:17:52 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.51
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:51 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:09 +0200
Message-Id: <20200517171725.732-12-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (REQUIRE): Remove groupadd, add comment.
(sys_create_build_user): Add adduser handling.
(sys_create_build_group): New function, add addgroup handling...
(main): ...call it here.
---
 etc/guix-install.sh | 57 +++++++++++++++++++++++++++++++++------------
 1 file changed, 42 insertions(+), 15 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 043357d9c4..d6966f851a 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -32,6 +32,8 @@ set -e
 
 [ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
 
+# groupadd, useradd, usermod, adduser, addgroup are handled in:
+# sys_create_build_user & sys_create_build_group functions.
 REQUIRE=(
     "wget"
     "gpg"
@@ -45,7 +47,6 @@ REQUIRE=(
     "rm"
     "chmod"
     "uname"
-    "groupadd"
     "tail"
     "realpath"
     "tar"
@@ -298,31 +299,56 @@ sys_create_store()
     _msg "${PAS}activated root profile at ${ROOT_HOME}/.config/guix/current"
 }
 
-sys_create_build_user()
-{ # Create the group and user accounts for build users.
+sys_create_build_group()
+{ # Create the group for build users.
 
     _debug "--- [ $FUNCNAME ] ---"
 
     if getent group guixbuild >/dev/null 2>&1; then
-        _msg "${INF}group guixbuild exists"
-    else
+        _msg "${INF}group guixbuild already exists"
+    elif command -v groupadd &>/dev/null; then
         groupadd --system guixbuild
         _msg "${PAS}group <guixbuild> created"
+    elif command -v addgroup &>/dev/null; then
+        addgroup -S guixbuild
+        _msg "${PAS}group <guixbuild> created"
+    else
+        _err "${ERR}cannot add group for guix build users"
+        exit 1
     fi
+}
+
+sys_create_build_user()
+{ # Create the user accounts for build users.
+
+    _debug "--- [ $FUNCNAME ] ---"
 
     for i in $(seq -w 1 10); do
         if getent passwd "guixbuilder${i}" >/dev/null 2>&1; then
-            _msg "${INF}user is already in the system, reset"
-            usermod -g guixbuild -G guixbuild           \
-                    -d /var/empty -s "$(which nologin)" \
-                    -c "Guix build user $i"             \
-                    "guixbuilder${i}";
+            if command -v usermod &>/dev/null; then
+                _msg "${INF}user is already in the system, resetting"
+                usermod -g guixbuild -G guixbuild           \
+                        -d /var/empty -s "$(which nologin)" \
+                        -c "Guix build user $i"             \
+                        "guixbuilder${i}"
+            else
+                _msg "${ERR}cannot reset user environment, doing nothing"
+            fi
         else
-            useradd -g guixbuild -G guixbuild           \
-                    -d /var/empty -s "$(which nologin)" \
-                    -c "Guix build user $i" --system    \
-                    "guixbuilder${i}";
-            _msg "${PAS}user added <guixbuilder${i}>"
+            if command -v useradd &>/dev/null; then
+                useradd -g guixbuild -G guixbuild           \
+                        -d /var/empty -s "$(which nologin)" \
+                        -c "Guix build user $i" --system    \
+                        "guixbuilder${i}"
+                _msg "${PAS}user added <guixbuilder${i}>"
+            elif command -v adduser &>/dev/null; then
+                adduser -G guixbuild -h /var/empty -s "$(which nologin)" \
+                        -H -S "guixbuilder${i}"
+                _msg "${PAS}user added <guixbuilder${i}>"
+            else
+                _msg "${ERR}cannot add user: <guixbuilder${i}>"
+                exit 1
+            fi
         fi
     done
 }
@@ -509,6 +535,7 @@ main()
         TARBALL="$(realpath $1)"
     fi
     sys_create_store "${TARBALL}" "${tmp_path}"
+    sys_create_build_group
     sys_create_build_user
     sys_enable_guix_daemon
     sys_make_guix_available
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 09/28] guix-install.sh: Fix requirements.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:07 +0000
Resent-Message-ID: <handler.40601.B40601.158973591027344 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591027344
          (code B ref 40601); Sun, 17 May 2020 17:19:07 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:30 +0000
Received: from localhost ([127.0.0.1]:44590 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvl-00076s-Qq
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:30 -0400
Received: from mail-wr1-f66.google.com ([209.85.221.66]:46497)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvD-00071S-Al
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:59 -0400
Received: by mail-wr1-f66.google.com with SMTP id w7so9031734wre.13
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=9CHbortN79gv+m/bvbe15uO/DPrgxWvRSsdF8Un18A4=;
 b=uF+uPL2ZKRlHoHI1aMOWC2yHdvO3GNVGSOnp+tOSwFe3WeWU0KgjhFjSalha+PvXuA
 1gAhfXz3UHiia36DnRmhA7tL5H5QRUID6q67eTOLHLj30MBtBQ0xyEjFadpZ7B4Ol/SY
 seBvARqPz9yTpkRV01mrzPtxxqfUK0MDNftYaSUGoS+I13cB4ilDHu5wLkd8NBUwldTY
 boqrRfE2Lxh5Lk1RPCmYP5Mg90G3A+TUcoNewvCFq+gaD36h2yRUc5ljCgRGBOhDAGdx
 IpjEmcbW6EofmD4BffHnfrwVY5EPmfA/Rzq5NgA+qLa05MJkaB7qPmXN22Xlqg8chPoE
 ep5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=9CHbortN79gv+m/bvbe15uO/DPrgxWvRSsdF8Un18A4=;
 b=nwqZdtWYl+zOjj7/cYEMn/xhkk2mVULQzFW6TIXnt4PG+n2pYmL0tFLZX28YAxT9A+
 0j0UdOb8fTBexaZfK0ySzsoobKXNKnpGvMSv0//JjcCgBQ2Ds/yzijVdr5MeY0+pLwYe
 mDwpCQ64TW9lUe9kFd9AA1ZFakUcVCO+7IapOUz9AFAHMSlizuRFxSDABju8PprQRPIT
 N9f4VauVCG7UPRgq6AoZGPncIGlyEmkYp4xE6xABKr8kOrjkVz2p4Fj/vmWtC8GlDBuR
 LNTwCTs+3SfXMoTTQmozWCLHxgPyRbpN4kC3g+WGplFoluNwSupcm7RPuHgWg5WTjhXA
 p5xg==
X-Gm-Message-State: AOAM531xa5hArCEsf/InbTelYHk/9zFm2lv+RaSHneEsU/zxl7q/UsBi
 syS4EvrZkL8tSLcBw1wh6BoYEumt
X-Google-Smtp-Source: ABdhPJxXhjP6hhQfIbjIVzdXxfZgoVOLnTHvoVYPf/0/7HtKr67NDHtRnNBckBlCoaoNGtcdJz2C7w==
X-Received: by 2002:adf:e449:: with SMTP id t9mr15182719wrm.108.1589735869608; 
 Sun, 17 May 2020 10:17:49 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:49 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:06 +0200
Message-Id: <20200517171725.732-9-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

There's no usage of "tr" in the script, whereas tar is used.

* etc/guix-install.sh (REQUIRE): Change tr to tar, add ln, remove
readlink & dirname.
---
 etc/guix-install.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index a56e0ec7b2..19883b89ae 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -33,8 +33,6 @@ set -e
 [ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
 
 REQUIRE=(
-    "dirname"
-    "readlink"
     "wget"
     "gpg"
     "grep"
@@ -42,6 +40,7 @@ REQUIRE=(
     "sed"
     "sort"
     "getent"
+    "ln"
     "mktemp"
     "rm"
     "chmod"
@@ -49,7 +48,7 @@ REQUIRE=(
     "groupadd"
     "tail"
     "realpath"
-    "tr"
+    "tar"
     "xz"
 )
 
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 13/28] guix-install.sh: Make grep & mktemp usage compatible with busybox.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:08 +0000
Resent-Message-ID: <handler.40601.B40601.158973591027351 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591027351
          (code B ref 40601); Sun, 17 May 2020 17:19:08 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:30 +0000
Received: from localhost ([127.0.0.1]:44592 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvm-00076z-68
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:30 -0400
Received: from mail-wm1-f65.google.com ([209.85.128.65]:53584)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvH-000723-2L
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:17:59 -0400
Received: by mail-wm1-f65.google.com with SMTP id k12so6989319wmj.3
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=nWn9a80F9xiVLG4JDHlaVfqkELF/9LuYMmVWNagKe3s=;
 b=hoBjQzv5JouYHgfDvVwd+s1Sr44F7vjNGOz0jOL+MJQ1dwqB49DVE7XToxL3gaH6AW
 pcrP5oRWNFH0AwP/eJmxfOZ3BbxD0t9FU/zlRL4j1ZMMNxjs37m8d3aoXqVF80/IjzjP
 zDRuuVN45NGcByASeJsZ8xE/uupWVlr/YUEUbm3qF5PPVgFebkffwt/bj/JT0jqQXQjv
 uB9jZ1zfA64x3m6a+UKIGCADtL+7qKA3xwnYXhfN+llrBDm0oHxO8eDPrg67wesajAK5
 RRJdSgPG8XAX7w4H/gyZfdyOR7X/hrE1IHf9rjmkAqnnWIW2lPPI2ujTRqKflVrw20PO
 o9DQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=nWn9a80F9xiVLG4JDHlaVfqkELF/9LuYMmVWNagKe3s=;
 b=QKHiqT3r8RLBa62x7WlO3o/PQygq53I7nSzaFCeCoNZtEvcdgJ2/MoUWBuPvsZSsWp
 sscr+iR9Bzt5UyF1fM+y57Od9IqGe4fLEUrBypVIRNpg5wBRL/OPU3U7fC5mAE2Udo+f
 XBPKRQ42dnHB06DZM7akhhiYx0DzLWEVfGg/RW3x8an8YwkGxIV01TKS3q2+JaT5qiun
 IkjP+2/NJ+SxmGRh5OdIwrRWKW7she0x5VH6+ZSFRBC7sdkxtDnNrYBEMW9puk2T1pKb
 yPEWF2HuZm+kzBcwgdJAC0pxN2l3nSJVw77PBpLkUC1VFZ6To2dWPLTDWsPHbvKaIgNv
 7mwg==
X-Gm-Message-State: AOAM532CmFeAQkbj1Y3B20cda5S27Xlk03usrmKyvh7ETCz9WswQoPMQ
 2++ucQ6TAmGCdrYpgbmlzK45vvlZ
X-Google-Smtp-Source: ABdhPJzLQsqQcwN0htKc+frKeRxIb8uUn/IM7v+b0I6KDzF/nIiVqcw2ZEjvjWRWGAWIs+r2EA+64g==
X-Received: by 2002:a05:600c:2c0c:: with SMTP id
 q12mr14556977wmg.36.1589735873148; 
 Sun, 17 May 2020 10:17:53 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:52 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:10 +0200
Message-Id: <20200517171725.732-13-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

The regex is not using pcre-specific syntax.
Busybox requires the mktemp template to end with 6 "X".  The longer template is
harmless for other systems.

* etc/guix-install.sh (guix_get_bin_list): Use grep -E instead of pcre.
(main): Use template that is accepted by busybox mktemp.
---
 etc/guix-install.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index d6966f851a..770ecfaf3f 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -219,7 +219,7 @@ guix_get_bin_list()
         | sort -Vu)")
 
     latest_ver="$(echo "$bin_ver_ls" \
-                       | grep -oP "([0-9]{1,2}\.){2}[0-9]{1,2}" \
+                       | grep -oE "([0-9]{1,2}\.){2}[0-9]{1,2}" \
                        | tail -n1)"
 
     default_ver="guix-binary-${latest_ver}.${ARCH_OS}"
@@ -525,7 +525,7 @@ main()
     _msg "${INF}system is ${ARCH_OS}"
 
     umask 0022
-    tmp_path="$(mktemp -t -d guix.XXX)"
+    tmp_path="$(mktemp -t -d guix.XXXXXX)"
 
     if [ -z "$1" ]; then
         guix_get_bin_list "${GNU_URL}"
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 14/28] guix-install.sh: Make tar usage compatible with busybox.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:08 +0000
Resent-Message-ID: <handler.40601.B40601.158973591127358 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591127358
          (code B ref 40601); Sun, 17 May 2020 17:19:08 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:31 +0000
Received: from localhost ([127.0.0.1]:44594 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvm-000776-Gk
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:30 -0400
Received: from mail-wr1-f48.google.com ([209.85.221.48]:45473)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvI-000729-0R
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:00 -0400
Received: by mail-wr1-f48.google.com with SMTP id v12so9035719wrp.12
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=ygICNL6IhoFFWHUOcX9V5HZ4FO6scN2R4lCW8bvbziE=;
 b=ZUObr8/9Kco5MlwqgtI4JJeVnArneMQnH5rtoF4XZYaSsCco0p85O+ijKJOxUwbjho
 8c2ryUgr604dR4q64ZNI7Aey1+MISO+9Hsetc0pfmBZlLDAMH5ty5Id+jQYsUQPYVTDQ
 pRoVHWhowSFCRLK96ARrQZZyHvLiJ+uZJj1AjqSUgDv7Vo0DOJqOwsW+J/2kjudGfHUc
 hTgfQyBzpgGuvZFF5x0/AlYDUiWkbF9nDeJ5NjsmnL5zOkb4Q7TprjTHlFmUcoIyWlco
 cgob0DPGMQjX3fOWoszOUjkrXnfn04lZk1snLnDeuNyxJD6JE6A8hm9/qdg0cATQ1k6z
 iORw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ygICNL6IhoFFWHUOcX9V5HZ4FO6scN2R4lCW8bvbziE=;
 b=SWdNmOvvrGNfh7luAFd4At4gl+MUAx/2CXEaQX7iOWeYq2mAGfERKpO3KtBYzdU2SK
 qy17L8AqL0nRmw/PSIFdvGXvvEL/q5UB5fN23VYKO6oA/IXIj9lK+BosRdA7Z2TQqk0m
 5v+a+0XHWy/9j0vYmJXsZnR2GUhbqWJL2W1dN9liZJ5x74+OwcRjZPGPJdoAp6mB2R9Z
 AyJ8/+Vf/MRsDuZNwQU+qiShDkqGyoYuH0pisKW2KL07CcVAuw7S//alinDTVpc6NNDo
 gj7lYfUj9dO/hSjE1uD37NOUu/Ia+3Bb1RRpcGSWDttS7QKCQ4zolXGyGCEEO5IVbohX
 toHA==
X-Gm-Message-State: AOAM533Jvi0xnbWZ9JXA6miRYNK/ij+IkqYwywRMfa4vJ8uPlKot23fZ
 qocwgPo5rHkZfY+OkH23XSLFMMp+
X-Google-Smtp-Source: ABdhPJxJLljX6Crsfs7icX4ZgJ87waC4jNdnIJifLvXay58e4sbU/403dA2/snB2gjFQrbyi4lf9xQ==
X-Received: by 2002:adf:9264:: with SMTP id 91mr15068684wrj.362.1589735874176; 
 Sun, 17 May 2020 10:17:54 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:53 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:11 +0200
Message-Id: <20200517171725.732-14-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

The --warning option is not suported by busybox tar, but it does not emit missing
timestamps warnings anyways.

* etc/guix-install.sh (sys_create_store): Add --warning tar option only when
supported.
---
 etc/guix-install.sh | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 770ecfaf3f..b5e8416610 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -274,10 +274,13 @@ sys_create_store()
 
     _debug "--- [ $FUNCNAME ] ---"
 
-    cd "$tmp_path"
-    tar --warning=no-timestamp \
-        --extract \
-        --file "$pkg" &&
+    # Do not use the --warning option with busybox tar
+    TAROPTS=("-C" "${tmp_path}")
+    if tar c --warning=no-timestamp -f /dev/null /dev/null >&/dev/null; then
+        TAROPTS+=("--warning=no-timestamp")
+    fi
+
+    tar x -f "${pkg}" "${TAROPTS[@]}" &&
     _msg "${PAS}unpacked archive"
 
     if [[ -e "/var/guix" || -e "/gnu" ]]; then
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 17/28] fix variable quoting in sys_make_guix_available
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:08 +0000
Resent-Message-ID: <handler.40601.B40601.158973591127366 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591127366
          (code B ref 40601); Sun, 17 May 2020 17:19:08 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:31 +0000
Received: from localhost ([127.0.0.1]:44596 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvm-00077D-RZ
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:31 -0400
Received: from mail-wr1-f45.google.com ([209.85.221.45]:44204)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvK-00072e-K9
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:03 -0400
Received: by mail-wr1-f45.google.com with SMTP id 50so9042867wrc.11
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=YIeeuzeHBqh6HaKfeecEoKvu2DDlvFZVuIVUcHX+Aes=;
 b=csgZUdSgBm+ednuEXIPicdqKej2xrYcDKBrxU8YhxMG89EMvFE9gpdOj4ISBjRTAb4
 oQn37qdmrxVb0pBjcuunOgCpKH66QECRyjUia/BXLVIDSzS2qub6h6iUbqLg6EKBKz37
 1/eGkIP5e2A9/gS/aDq9ymKqKEI0WSKUEOZb0R2/sutwof8KzbbO2Y5TxA56GuM6p5cV
 YVNA4EMTnxkC4/n3M6a9DAxcpNNU/LY9QDPh+zQlxOrUOofcZNMLBPzIfsKAScBV7KIM
 tyK2am6ouD6EC6dKEPPqdEAD+ED503xWhUFDCSvZcTlP8NkVLj34w44zGzH5Vt4Es9oO
 /60w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=YIeeuzeHBqh6HaKfeecEoKvu2DDlvFZVuIVUcHX+Aes=;
 b=BToLZVDx+odlrFWKy5Kx+pXnsvtoHZyJkTEFj3Bnvh6Ny6pOwHM5rlsLoaMNLS4Zau
 QGDtX4oYGki8XUz5obbombkazs2tvCc25zm2SHnAboY8vNAzEtcdVpzfof3AuUG+fmWK
 5CixxTpILFxjB1lD3ehhaJYJ7xZqeqJxxUmms3iWjuMtJDcYgaRAk2qGfyUDKAvK/M8h
 RILXbk1k7DYz/dJGJYHzhTAKnxdboCPJuSGQ6HnXIiPHFmMNgixksEpfQ4ubiJazjzGB
 SbVNGf4KSbs/YRwnz9mcIJF+knjVrFv1TliXqNfGwjDlb9OFwLEzDT+PSMH1gpB25+IB
 I8Mw==
X-Gm-Message-State: AOAM532B4fZncT0ZZ2Gq2YP9b7nUmaPoLpojhkHuyLiZ6JVzrJTWRfbn
 OcnrPcQdyN8wnFFhLdr8aRkm5QRy
X-Google-Smtp-Source: ABdhPJz7rfC3zH8S7prNiKOiYgEDzfVgZCWVNcAWtiIUPB3lbs9N+Xf8TEKnnQKao6HeH/Q+Hmk5zg==
X-Received: by 2002:a5d:4447:: with SMTP id x7mr14616457wrr.424.1589735876845; 
 Sun, 17 May 2020 10:17:56 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:56 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:14 +0200
Message-Id: <20200517171725.732-17-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 7fb9332e97..e350fdb052 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -446,7 +446,7 @@ sys_make_guix_available()
     ln -sf "${var_guix}/bin/guix" "$local_bin"
 
     [ -e "$info_path" ] || mkdir -p "$info_path"
-    for i in ${var_guix}/share/info/*; do
+    for i in "${var_guix}"/share/info/*; do
         ln -sf "$i" "$info_path"
     done
 }
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 18/28] Replace the use of "which" by "command -v"
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:09 +0000
Resent-Message-ID: <handler.40601.B40601.158973591127373 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591127373
          (code B ref 40601); Sun, 17 May 2020 17:19:09 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:31 +0000
Received: from localhost ([127.0.0.1]:44598 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvn-00077L-4G
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:31 -0400
Received: from mail-wm1-f65.google.com ([209.85.128.65]:40492)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvL-00072h-G6
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:04 -0400
Received: by mail-wm1-f65.google.com with SMTP id n18so3495404wmj.5
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=b8zuj8hs6ax7Gia8U2Nzy4X9a4KV7XYNtedTtT7AcKo=;
 b=Pel3bGEOvi4vyg5yvQdwOc+BBpo6G1MAcKiJLNhg6vb80sMi/vJOwwtMS1gZpY1KNI
 wGURtZNlaCjMmnA7YMMswLL9GJSgjy5C3HZpm2F+8HpLAGXpngqNUmZJAQL8729E8L3W
 bJ2l5capPam/tZgorPEV3sVmfKPQyBJXinASJarMHjmxVHsoFkIFFyVkldVYtofD/SOs
 93a31V6wO1QI2Wt+Zw+EU6MmnOOK+kC1JEMXJXUjcggYY4UZvE3p3eCAfBP/WnesU+r3
 nmrbPlnz8vzQLOVghM+Ttk2EfiV70B5WRGBw21N+8uNgJzd14E6teCgORFU2blaYreHz
 PyNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=b8zuj8hs6ax7Gia8U2Nzy4X9a4KV7XYNtedTtT7AcKo=;
 b=NCAXNdamZkaGyvkaMyZx7eM+RL4J9DE+IbEr3A96PCe8vAbYKxfC+4hAL+v8HcXB9+
 lytDwUmO6PogLAM5ctIPGsqy5ikxQuBbjJdyCai7JPKD2RkS76tcE3j29HDNRyAN+0If
 uDZtcexQrNMM03kxfBHYv/gjZf7r4YgkGGg4VW/frV/3zrlyNXqhjc5yelnCPsrdztYJ
 gZSTkvfShFw+Zvc0yY51SN+yMtybm1tp133eRCKEzvDJHQSda9xL5G1UACPoBSi6IJbw
 rLH6Pmo7lK4wUyLGZeoY3pVrsxPjAmc3BTEXRjiLWVyqJx+BCRC3Bm5DUZXkz2e8PPr7
 90+Q==
X-Gm-Message-State: AOAM533o2YEMw1clp8/4xvNmgPH9a4aS5+AFrdD5hkBkSVfClNyrMmQo
 AVRPTgHSb2NLgy38k8ISs6aDmesI
X-Google-Smtp-Source: ABdhPJz4lQPUDBYeJBrb8Pq+y1MK0eF9LIzL+hCi7OBrzgknyJJ3iA/fvUVW2KvnU+IVqGx1hVrU9Q==
X-Received: by 2002:a1c:1b4d:: with SMTP id b74mr14814438wmb.123.1589735877744; 
 Sun, 17 May 2020 10:17:57 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:57 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:15 +0200
Message-Id: <20200517171725.732-18-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index e350fdb052..596ceb5b39 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -38,7 +38,6 @@ REQUIRE=(
     "wget"
     "gpg"
     "grep"
-    "which"
     "sed"
     "sort"
     "getent"
@@ -329,12 +328,13 @@ sys_create_build_user()
 
     _debug "--- [ $FUNCNAME ] ---"
 
+    NOLOGIN_SHELL="$(command -v nologin)"
     for i in $(seq -w 1 10); do
         if getent passwd "guixbuilder${i}" >/dev/null 2>&1; then
             if command -v usermod &>/dev/null; then
                 _msg "${INF}user is already in the system, resetting"
                 usermod -g guixbuild -G guixbuild           \
-                        -d /var/empty -s "$(which nologin)" \
+                        -d /var/empty -s "${NOLOGIN_SHELL}" \
                         -c "Guix build user $i"             \
                         "guixbuilder${i}"
             else
@@ -343,12 +343,12 @@ sys_create_build_user()
         else
             if command -v useradd &>/dev/null; then
                 useradd -g guixbuild -G guixbuild           \
-                        -d /var/empty -s "$(which nologin)" \
+                        -d /var/empty -s "${NOLOGIN_SHELL}" \
                         -c "Guix build user $i" --system    \
                         "guixbuilder${i}"
                 _msg "${PAS}user added <guixbuilder${i}>"
             elif command -v adduser &>/dev/null; then
-                adduser -G guixbuild -h /var/empty -s "$(which nologin)" \
+                adduser -G guixbuild -h /var/empty -s "${NOLOGIN_SHELL}" \
                         -H -S "guixbuilder${i}"
                 _msg "${PAS}user added <guixbuilder${i}>"
             else
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 15/28] guix-install.sh, guix-binary tarball: Handle openrc-based foreign distributions.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:09 +0000
Resent-Message-ID: <handler.40601.B40601.158973591527383 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591527383
          (code B ref 40601); Sun, 17 May 2020 17:19:09 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:35 +0000
Received: from localhost ([127.0.0.1]:44600 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvn-00077S-FY
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:34 -0400
Received: from mail-wr1-f46.google.com ([209.85.221.46]:42478)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvJ-00072W-01
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:04 -0400
Received: by mail-wr1-f46.google.com with SMTP id s8so9077952wrt.9
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jWLsQQ8zfmfjTduylNRYeuxozIg+Z/8jJJII15/YMRk=;
 b=EIpOXRpNQVYQPjfG2J+icjtaGPCHQVREgqUT+oxJgWFxA7roNGsEvN6QHG2Jhjd7Y4
 OMQJK/lY5doX7PyAX3ZswMgccBJS7KOglFDa21ND6icifkpVR9wte8LTkTHtg5Rgsj5B
 vQp1YlrzDmaSVrD5fCEUHjAI4EskoCQgJXmr9tEd62TlE2Aiq0pXpK6u3lGzqzGWHw/A
 H/Kj5P2JdTG2TZX7NbtioCrIjCgn4XBp0bJgPDKBXD6pSP1QCJm6f+haA8ACslOLPHCC
 WE/Q6hNYYahejrfE9TEEIhD1C+e9/pVeCNI4/l6Z6ohGSawdTTmrXKP8mWyyRGgmU2mA
 rI8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jWLsQQ8zfmfjTduylNRYeuxozIg+Z/8jJJII15/YMRk=;
 b=rg8FMfVTF8LSKhm/9awq7eyuhHdWwEKKiP+U9sVvKKceOsJX0lLkOLPIA8LA/p8NtQ
 Knf5GzBNt/WkPMTz7cOLN2SIGaNG23OxYYQk1/z5TyDwygCdfBllhA3A4VxoKVNvfQE4
 wkGgvX827vel85nD2AIkgChLNpOrFMWzWgSIzG0rehkrCX1pnY3DclqscomabbfwGj6a
 VqOLZ+4pLQig2uP5IYzUgG3Fa9bI8bVyOeXoUy8mGPdUPRVSGzUniu2KqT4QqB54tNMW
 KkZ6rxTe2dY5FWKv+YZYNfsr5QyTJNVzfG1q85zyFGV89TURzdaB8gxXL2pEVikZfVis
 nXkA==
X-Gm-Message-State: AOAM5303gACsh6xd2uPY7VuYNGXoH5w6fP3h7LqnUxJBvioXUoI9Fb2Z
 PT9eUdQmeAjhfF+DhX0ILj9akRtO
X-Google-Smtp-Source: ABdhPJyt6HUe8hZLhwv9kJBTC/RjtDHSoD2L+FtkiwCM9+xnX/5siuj1ZcXgRNH1H7WN3iUa06VaTQ==
X-Received: by 2002:a5d:55c5:: with SMTP id i5mr15050518wrw.402.1589735875094; 
 Sun, 17 May 2020 10:17:55 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:54 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:12 +0200
Message-Id: <20200517171725.732-15-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* .gitignore: Add etc/openrc/guix-daemon.in.
* etc/guix-install.sh (chk_init_sys): Add case to detect openrc.
(sys_enable_guix_daemon): Add case to setup guix-daemon within openrc.
* etc/openrc/guix-daemon.in: New file...
* nix/local.mk (etc/openrc/guix-daemon): Add target to generate
etc/openrc/guix-daemon from etc/openrc/guix-daemon.in.
(CLEANFILES): ...add it here. (nodist_openrcservice_DATA): New variable...
(openrcservicedir): New variable. (EXTRA_DIST): Add etc/openrc/guix-daemon.in.
---
 .gitignore                |  1 +
 etc/guix-install.sh       | 14 ++++++++++++++
 etc/openrc/guix-daemon.in | 14 ++++++++++++++
 nix/local.mk              | 13 +++++++++++++
 4 files changed, 42 insertions(+)
 create mode 100644 etc/openrc/guix-daemon.in

diff --git a/.gitignore b/.gitignore
index 89a2c89e1e..6cd9fb4f17 100644
--- a/.gitignore
+++ b/.gitignore
@@ -72,6 +72,7 @@
 /etc/guix-publish.conf
 /etc/guix-publish.service
 /etc/init.d/guix-daemon
+/etc/openrc/guix-daemon
 /etc/runit/run
 /guix-daemon
 /guix/config.scm
diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index b5e8416610..1c22ae95ee 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -149,6 +149,10 @@ chk_init_sys()
         _msg "${INF}init system is: systemd"
         INIT_SYS="systemd"
         return 0
+    elif [[ $(rc -V 2>/dev/null) =~ OpenRC ]]; then
+        _msg "${INF}init system is: openrc"
+        INIT_SYS="openrc"
+        return 0
     elif [[ -f /etc/init.d/cron && ! -h /etc/init.d/cron ]]; then
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
@@ -396,6 +400,16 @@ sys_enable_guix_daemon()
               ln -s /etc/sv/guix-daemon /etc/runit/runsvdir/default/; } &&
                 _msg "${PAS}enabled Guix daemon via runit"
             ;;
+        openrc)
+            { mkdir -p /etc/init.d;
+              cp "${ROOT_HOME}/.config/guix/current/lib/openrc/guix-daemon/guix-daemon" \
+                 /etc/init.d/guix-daemon;
+              chmod 755 /etc/init.d/guix-daemon;
+
+              rc-update add guix-daemon default &&
+              rc-service guix-daemon start; } &&
+                _msg "${PAS}enabled Guix daemon via openrc"
+            ;;
         sysv-init)
             { mkdir -p /etc/init.d;
               cp "${ROOT_HOME}/.config/guix/current/etc/init.d/guix-daemon" \
diff --git a/etc/openrc/guix-daemon.in b/etc/openrc/guix-daemon.in
new file mode 100644
index 0000000000..9641dcfad6
--- /dev/null
+++ b/etc/openrc/guix-daemon.in
@@ -0,0 +1,14 @@
+#!/sbin/openrc-run
+
+# This is a service script file for the openrc init system to launch
+# 'guix-daemon'.  Copy it as /etc/init.d/guix-daemon to have 'guix-daemon'
+# automatically started.
+
+command=@localstatedir@/guix/profiles/per-user/root/current-guix/bin/guix-daemon
+command_args=--build-users-group=guixbuild
+command_background=true
+pidfile=/run/guix-daemon.pid
+
+GUIX_LOCPATH=@localstatedir@/guix/profiles/per-user/root/guix-profile/lib/locale
+LC_ALL=en_US.utf8
+
diff --git a/nix/local.mk b/nix/local.mk
index 582ff16168..9d6f92ebc8 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -187,6 +187,17 @@ etc/runit/run: etc/runit/run.in		\
                "$<" > "$@.tmp";         \
         mv "$@.tmp" "$@"
 
+# The service script for openrc.
+openrcservicedir = $(libdir)/openrc/guix-daemon
+nodist_openrcservice_DATA = etc/openrc/guix-daemon
+
+etc/openrc/guix-daemon: etc/openrc/guix-daemon.in		\
+			$(top_builddir)/config.status
+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";   \
+        $(SED) -e 's|@''localstatedir''@|$(localstatedir)|' <   \
+               "$<" > "$@.tmp";         \
+        mv "$@.tmp" "$@"
+
 # The '.conf' jobs for Upstart.
 upstartjobdir = $(libdir)/upstart/system
 nodist_upstartjob_DATA = etc/guix-daemon.conf etc/guix-publish.conf
@@ -202,6 +213,7 @@ CLEANFILES +=					\
   $(nodist_systemdservice_DATA)			\
   $(nodist_upstartjob_DATA)			\
   $(nodist_runitservice_DATA)			\
+  $(nodist_openrcservice_DATA)			\
   $(nodist_sysvinitservice_DATA)
 
 EXTRA_DIST +=					\
@@ -212,6 +224,7 @@ EXTRA_DIST +=					\
   etc/guix-publish.service.in			\
   etc/guix-publish.conf.in			\
   etc/runit/run.in				\
+  etc/openrc/guix-daemon.in			\
   etc/init.d/guix-daemon.in
 
 if CAN_RUN_TESTS
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 19/28] Remove &> and >& bashisms
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:10 +0000
Resent-Message-ID: <handler.40601.B40601.158973591527391 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591527391
          (code B ref 40601); Sun, 17 May 2020 17:19:10 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:35 +0000
Received: from localhost ([127.0.0.1]:44602 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvq-00077c-W6
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:35 -0400
Received: from mail-wm1-f42.google.com ([209.85.128.42]:36994)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvM-000730-C7
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:05 -0400
Received: by mail-wm1-f42.google.com with SMTP id z72so7778902wmc.2
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=XTQjn/u1Dj4qvtKAyvQ2uzDjIbzG36TwD5X4BAnRlc4=;
 b=r/GshNepw0+WN5DO2PyU68iqQkapj6kyyyCJLiuNX9VfvUdhZfKnr8voK8I86t9/bw
 SeFRo8PpBQ2BikOiOs01YHqRWmw7hoA1KrWqLxq5PO4kXgCsOyni9AJ8Sb3/8/iL94Dv
 mczhiCujtA1DA/2KBMkZ/i5uNCysh0edVhyCJwX7y5HlAuo0kZbzdgaq5kezfE9ICE0+
 98lrHksB+kuLc6Mk5UyWm3mlzAYnyaNW+ARXtnG95ZJNE/QdGh5zEmoMShyst8sU1Z4d
 hGYIJYnYmVYTdZhzf7rbPI2DblWEniSu6vXohrq3jVM60WnFN+G0DHkXQyzqkbgmktL5
 zHVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=XTQjn/u1Dj4qvtKAyvQ2uzDjIbzG36TwD5X4BAnRlc4=;
 b=W6hAsq/YEDlDLayI/UoAZ5JR92GfvIN1WtJSAlgJKNDxnx6nmn21pd08asFLO+Lxky
 eOCR1HXs9bpWpwUS/K0qTXNsI+CzPT/f++PPkRJv/gFhkMzeeJr1Spe2/1RbhHXCE8h3
 pfCnW9FKQEzwOcoRunAtijOAvG0xKV7Dt77AF3Qho7ZCcCcf1mKmYlqXpRImVP476IQl
 qgvNlYSIzcpF4IEj3ZkBwgN0+9lJ6+7RXnebdaLVwDFo/fBn7LekNGeENz//gRPmq74V
 ESEigscSUIFJE64DpggQZffGxkYT8EQhahVz9Q28UYIeR2CgAwuI7CzS+FOLvUrVDitL
 yVVw==
X-Gm-Message-State: AOAM530cbH9Pmymy3NRdPHmYp/5ogzU1/+UJ7e+Nvvsd1HMTjyXOeyOK
 3Il8EPpf6slKjBsQuDX3Z3JGIny2
X-Google-Smtp-Source: ABdhPJwOcj3xb40jndrEhjINQAgeizLdPgEbAsd0/bJ48+mXtoMINLKobnbmdvSsAMw5bPfIOoK8Pw==
X-Received: by 2002:a1c:b141:: with SMTP id a62mr14449589wmf.7.1589735878671; 
 Sun, 17 May 2020 10:17:58 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.57
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:58 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:16 +0200
Message-Id: <20200517171725.732-19-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 596ceb5b39..5b82999bc5 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -94,7 +94,7 @@ chk_require()
     _debug "--- [ $FUNCNAME ] ---"
 
     for c in "$@"; do
-        command -v "$c" &>/dev/null || warn+=("$c")
+        command -v "$c" >/dev/null 2>&1 || warn+=("$c")
     done
 
     [ "${#warn}" -ne 0 ] &&
@@ -278,7 +278,7 @@ sys_create_store()
 
     # Do not use the --warning option with busybox tar
     TAROPTS=("-C" "${tmp_path}")
-    if tar c --warning=no-timestamp -f /dev/null /dev/null >&/dev/null; then
+    if tar c --warning=no-timestamp -f /dev/null /dev/null >/dev/null 2>&1; then
         TAROPTS+=("--warning=no-timestamp")
     fi
 
@@ -311,10 +311,10 @@ sys_create_build_group()
 
     if getent group guixbuild >/dev/null 2>&1; then
         _msg "${INF}group guixbuild already exists"
-    elif command -v groupadd &>/dev/null; then
+    elif command -v groupadd >/dev/null 2>&1; then
         groupadd --system guixbuild
         _msg "${PAS}group <guixbuild> created"
-    elif command -v addgroup &>/dev/null; then
+    elif command -v addgroup >/dev/null 2>&1; then
         addgroup -S guixbuild
         _msg "${PAS}group <guixbuild> created"
     else
@@ -331,7 +331,7 @@ sys_create_build_user()
     NOLOGIN_SHELL="$(command -v nologin)"
     for i in $(seq -w 1 10); do
         if getent passwd "guixbuilder${i}" >/dev/null 2>&1; then
-            if command -v usermod &>/dev/null; then
+            if command -v usermod >/dev/null 2>&1; then
                 _msg "${INF}user is already in the system, resetting"
                 usermod -g guixbuild -G guixbuild           \
                         -d /var/empty -s "${NOLOGIN_SHELL}" \
@@ -341,13 +341,13 @@ sys_create_build_user()
                 _msg "${ERR}cannot reset user environment, doing nothing"
             fi
         else
-            if command -v useradd &>/dev/null; then
+            if command -v useradd >/dev/null 2>&1; then
                 useradd -g guixbuild -G guixbuild           \
                         -d /var/empty -s "${NOLOGIN_SHELL}" \
                         -c "Guix build user $i" --system    \
                         "guixbuilder${i}"
                 _msg "${PAS}user added <guixbuilder${i}>"
-            elif command -v adduser &>/dev/null; then
+            elif command -v adduser >/dev/null 2>&1; then
                 adduser -G guixbuild -h /var/empty -s "${NOLOGIN_SHELL}" \
                         -H -S "guixbuilder${i}"
                 _msg "${PAS}user added <guixbuilder${i}>"
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 20/28] Add missing variable quoting & curly-bracketing for dl_path
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:10 +0000
Resent-Message-ID: <handler.40601.B40601.158973591527398 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591527398
          (code B ref 40601); Sun, 17 May 2020 17:19:10 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:35 +0000
Received: from localhost ([127.0.0.1]:44604 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvr-00077j-9N
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:35 -0400
Received: from mail-wm1-f53.google.com ([209.85.128.53]:37005)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvN-000737-Ax
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:05 -0400
Received: by mail-wm1-f53.google.com with SMTP id z72so7778929wmc.2
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=I6rrWMWrhkA14xG8uiQgHxSzvxgpDLgg7Ymy3JSCyEI=;
 b=vfei2oJJgQ6z86KgcjYiJStywVQqmQTBu/1JwB3BhPKuooPzBq5NAEUUFMUVUrRPrC
 zTcUOGYOItolutgN+Xu23iiv/7AFoCTwXyOvz5mYzrnkEHcbHXLaatzaCqWS0d6dgk8n
 MWK1WHkXV7RGEu3+spW29jMwr6WtvGCHfoz/gA3r1yNMW6rqSHAwTSxvbldm+l/FQ5l0
 6qRPaNoD4l+cVxQrIHdPwd3YtXOSqLlQrWFOvUBgIbbNjtOn9LEp4TolKp3e8xCv6WGT
 /dTdLbw4hqcjoyxzyyQ48YIoQz1GxuPtxkPCZVi0XnjttXsofnA2M3vuiNYhfifdaeVP
 6yKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=I6rrWMWrhkA14xG8uiQgHxSzvxgpDLgg7Ymy3JSCyEI=;
 b=ScY4PZDwqc8GiaLMP2LBJb6/7/7r4/nxqjfsdb0BsPS9iYgVXhTjvB1FbXjSZZLUFb
 UOahjlSZ8XPzae2uGAx/PDZ4JtjoNoheJVSf//10IKvfwjLtwSXFIwe/A6/WdDuCQqgw
 QVHToMJktPMib+Y+365YXCpeikHEH0LPsOaY9fUUnuPclEgNiYnqHSysOy3LfzJxB0Mo
 +oTv1iqEHpAAdK7/u4OsocbmgeSMgdpiuAQNiOHWi/zEg42EmBmzMn0ssa+dIDU6sr2r
 SajvL84mNghd7TObK2A7xj2CV2Dh4XuXK2EAyiok+ifmklI5mGMsveELylvwhMCVUNEp
 gMiA==
X-Gm-Message-State: AOAM5335I6tn0FyAQ1LpgF5p3sXajLSGsmVNJosIxbiM205irrXkGe5c
 tgRmMHcBWPtt8X0A0iUqUbgR4uPn
X-Google-Smtp-Source: ABdhPJyJeCF9BsMjj0hlkAgxB+yl674tJu9tIkBz4VrADXi9RGPDggUDiC0S5kytU4rPboxr0Bwplg==
X-Received: by 2002:a1c:9d17:: with SMTP id g23mr14360473wme.38.1589735879561; 
 Sun, 17 May 2020 10:17:59 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:59 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:17 +0200
Message-Id: <20200517171725.732-20-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 5b82999bc5..7616f3b82f 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -249,7 +249,7 @@ guix_get_bin()
 
     wget --help | grep -q '\--show-progress' && \
         _PROGRESS_OPT="-q --show-progress" || _PROGRESS_OPT=""
-    wget $_PROGRESS_OPT -P "$dl_path" "${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig"
+    wget $_PROGRESS_OPT -P "${dl_path}" "${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig"
 
     if [[ "$?" -eq 0 ]]; then
        _msg "${PAS}download completed."
@@ -258,7 +258,7 @@ guix_get_bin()
         exit 1
     fi
 
-    pushd $dl_path >/dev/null
+    pushd "${dl_path}" >/dev/null
     gpg --verify "${bin_ver}.tar.xz.sig" >/dev/null 2>&1
     if [[ "$?" -eq 0 ]]; then
         _msg "${PAS}Signature is valid."
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 16/28] non-interactive mode, usage
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:10 +0000
Resent-Message-ID: <handler.40601.B40601.158973591927410 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591927410
          (code B ref 40601); Sun, 17 May 2020 17:19:10 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:39 +0000
Received: from localhost ([127.0.0.1]:44606 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvr-00077r-JN
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:39 -0400
Received: from mail-wr1-f46.google.com ([209.85.221.46]:35199)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvJ-00072Y-PJ
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:05 -0400
Received: by mail-wr1-f46.google.com with SMTP id j5so9128665wrq.2
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=hGqMRxJgM9E7ODx4XyXJlimNdJa81h/EIXwr4O4wHa0=;
 b=kn4uuBTsWCnlIMVYhMWnG9zUUMBaiyKghqnwoqvvDFciuJY4QRQAIrqt0RZh5+KaNE
 519PGfBdwoANpMwOH5/0PYwM7GCNuiz34WCOTYcYC10KX2iketN+36DrlwyKUAAjvUCB
 fU/FoTTtnNGy6cd8vLKzKzXpa8Sf8RHnTBqp/GULnzN+g4yiSZ+1kGmV0/KkNOudOvF9
 W7708Z1yRCqTjgyj38E6GrBj2VVvIj9Lz1JAT9gtOvmWqpFzZhX4Dp5lIUIoGVLLWyTS
 k5TczXUB3wzuf/Hk013Rc2QxdBehU6C1rW4foSa/Mg/F3aAfGHjYGlJhn/yKLSxBr6RT
 G1nw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=hGqMRxJgM9E7ODx4XyXJlimNdJa81h/EIXwr4O4wHa0=;
 b=Ju79RIkjXyXMqWOyELEYuqYtBq/qnrAb2ITKFH7gXMYjCfDPscXiK9gzS7uHSqIk66
 Rt1oqwpST2JcuPn/GKb4k7f08o2o5ePd7Ql+GX0oDaIRFqXsg/QBD9w8zSNMwEtfs5al
 FnFqlAJG5H3HuQUuX+lIe8ayUPSjkIR+HZdt01fDGlKc2WGaHgTBpsBoVHoncJ/gFKgW
 IxEE2qGgcc1pbb1HR/SmNEb3QH6dEeT3WkVJGMuonM8oOowq9YHHiQl4xRwaN/OSA8XV
 eOWHPVFTS24sBzeTmmU3pqL4pzj9CuZ1Cgnj0xZKlDOutqDdnUZQ02PJcAykQBPEsn6N
 3+bA==
X-Gm-Message-State: AOAM532f6s5oSDe2RMWLkLfq4PM/ZJUoP+x4Df4NAyd6yuFAo51AH0UE
 NzlzkPviDfAqgnkjoWVqHl9lM4EI
X-Google-Smtp-Source: ABdhPJx80GNLLXfvtmPypcGUdxVGp2ge4d4zqISqPOn2p/C/ppCy1Y8zg3/ddYRLRoBkSkIF64iQ+Q==
X-Received: by 2002:a5d:40c2:: with SMTP id b2mr14624294wrq.13.1589735875983; 
 Sun, 17 May 2020 10:17:55 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:55 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:13 +0200
Message-Id: <20200517171725.732-16-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 68 +++++++++++++++++++++++++++++++++------------
 1 file changed, 51 insertions(+), 17 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 1c22ae95ee..7fb9332e97 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -48,7 +48,6 @@ REQUIRE=(
     "chmod"
     "uname"
     "tail"
-    "realpath"
     "tar"
     "xz"
 )
@@ -454,17 +453,23 @@ sys_make_guix_available()
 
 sys_authorize_build_farms()
 { # authorize the public key of the build farm
-    while true; do
-        read -p "Permit downloading pre-built package binaries from the project's build farm? (yes/no) " yn
-        case $yn in
-            [Yy]*) guix archive --authorize < "${ROOT_HOME}/.config/guix/current/share/guix/ci.guix.gnu.org.pub" &&
-                       _msg "${PAS}Authorized public key for ci.guix.gnu.org";
-                   break;;
-            [Nn]*) _msg "${INF}Skipped authorizing build farm public keys"
-                   break;;
-            *) _msg "Please answer yes or no.";
-        esac
-    done
+    _AUTHORIZE_BUILD_FARM=1
+    if [ "$1" -eq 1 ]; then
+        while true; do
+            read -p "Permit downloading pre-built package binaries from the project's build farm? (yes/no) " yn
+            case "$yn" in
+                [Yy]*) _AUTHORIZE_BUILD_FARM=1; break;;
+                [Nn]*) _AUTHORIZE_BUILD_FARM=0; break;;
+                *) _msg "Please answer yes or no.";;
+            esac
+        done
+    fi
+    if [ "$_AUTHORIZE_BUILD_FARM" -eq 1 ]; then
+        guix archive --authorize < "${ROOT_HOME}/.config/guix/current/share/guix/ci.guix.gnu.org.pub" &&
+            _msg "${PAS}Authorized public key for ci.guix.gnu.org";
+    else
+        _msg "${INF}Skipped authorizing build farm public keys"
+    fi
 }
 
 sys_create_init_profile()
@@ -526,10 +531,41 @@ EOF
     read -r  ANSWER
 }
 
+# Do not change the tabs in the HERE-DOCUMENT
+usage()
+{
+    cat <<-EOF
+	$0: Wrong arguments:
+	$0 [-h|--help] [-n|--non-interactive] [LOCAL_GUIX_BIN_TARBALL]
+
+	-h|--help            Show this help
+	-n|--non-interactive Avoid asing interactive question, run unattended
+	                     automatically allow substitutes from guix build farm
+
+	LOCAL_GUIX_BIN_TARBALL Use the given guix binary tarball file instead of
+	                       downloading latest released one
+EOF
+}
+
+handle_args()
+{
+    _INTERACTIVE=1
+    while [ "$#" -gt 0 ]; do
+        case "$1" in
+            -h|--help) usage; exit 0;;
+            -n|--non-interactive) _INTERACTIVE=0; shift 1;;
+
+            -*) echo "unknown option: $1" >&2; echo; usage; exit 1;;
+            *) TARBALL="$1"; shift 1;;
+        esac
+    done
+}
+
 main()
 {
     local tmp_path
-    welcome
+    handle_args "$@"
+    [ "${_INTERACTIVE}" -eq 1 ] && welcome
 
     _msg "Starting installation ($(date))"
 
@@ -544,19 +580,17 @@ main()
     umask 0022
     tmp_path="$(mktemp -t -d guix.XXXXXX)"
 
-    if [ -z "$1" ]; then
+    if [ -z "${TARBALL}" ]; then
         guix_get_bin_list "${GNU_URL}"
         guix_get_bin "${GNU_URL}" "${BIN_VER}" "${tmp_path}"
         TARBALL="${BIN_VER}.tar.xz"
-    else
-        TARBALL="$(realpath $1)"
     fi
     sys_create_store "${TARBALL}" "${tmp_path}"
     sys_create_build_group
     sys_create_build_user
     sys_enable_guix_daemon
     sys_make_guix_available
-    sys_authorize_build_farms
+    sys_authorize_build_farms "${_INTERACTIVE}"
     sys_create_init_profile
 
     _msg "${INF}cleaning up ${tmp_path}"
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 21/28] Remove unused variable
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:11 +0000
Resent-Message-ID: <handler.40601.B40601.158973591927417 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973591927417
          (code B ref 40601); Sun, 17 May 2020 17:19:11 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:39 +0000
Received: from localhost ([127.0.0.1]:44608 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvv-000783-7m
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:39 -0400
Received: from mail-wm1-f41.google.com ([209.85.128.41]:38523)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvO-00073E-4V
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:06 -0400
Received: by mail-wm1-f41.google.com with SMTP id m185so2875539wme.3
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=DTNh6FM9U68VKmP6Y8g9TZ3g85BSg5XzG75Lcjw3CiM=;
 b=HFPbu+iB7/omrXGbwUWoxbJ54yDQxrYSihKCTQPuL04LfpYWomiWrBhhfkYdrZIvPJ
 3qwYru8kizoWTYAnq0Lun8GEcUDD++SThS3T/mtvoaVcjqlridmZ9N/rxo3ulbR1yJOV
 QFi5/D6jt+uLGPyblNSdISnexi+MOW4K1zdtpk8jZWZPOTODJa6IQWGHu4C+KWr09woT
 pOEjIcnu+qYjGTxoLqw6WR5DfGFOsO/x8d/eKotkn0ruERo5CdWIKYONgB8606cdi2d1
 rxZklyUryHya7dQMZ9PwfcrWrHt18HalkW9qJs1BBtSH1M3pkQH1SHf6gqfU0Y5OXzV/
 VnCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=DTNh6FM9U68VKmP6Y8g9TZ3g85BSg5XzG75Lcjw3CiM=;
 b=X0nDhYnUNw5qe9Ub6bLptwvOYEWByAXmkFM+/lR/5Q21EdQ8jcTGznXx3/TxTsd/em
 JlfMllpjx98/tc43NfkBwGBLslY4Vj9SJ2bwrXLwp9hI19Ugf67c0aC6+F8mgXmJvwBz
 fjk+oR8HSsb1K7tuLjjTA0/QqBbbP11TjUuj/ISYprcBWzk99zbAe4DR4HbbqVjEc0dw
 VcUWCjWB0mo+m+LIpNQh3dN0WktqH1bBDBzVYs3cGSZR4hHrx6bx6Hgmltiyn4jXxxTC
 Nq/14K/ggWFJ5onklfHwaCGK62O+Yd/bijtj2/KJ4/jcfz0fk/t4mEBHkYlmksmIJnhq
 0s5g==
X-Gm-Message-State: AOAM53157n/rCfJzg/ntf3OuAlRVOP94Wt1gjw38qZ8oYj0GMoQTnhRB
 0fDnyeReZp0xQVI4MWqOpzW/DytS
X-Google-Smtp-Source: ABdhPJxzLVsv2t35C5yWd174HSbhRHKF65GhHM/nenrOuCKXZlFoEuP6GUt+QOIsD6RWhXVmMAhj4w==
X-Received: by 2002:a1c:de05:: with SMTP id v5mr14354446wmg.1.1589735880475;
 Sun, 17 May 2020 10:18:00 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:00 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:18 +0200
Message-Id: <20200517171725.732-21-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 7616f3b82f..078081c08a 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -119,16 +119,12 @@ chk_gpg_keyring()
 
 chk_term()
 { # Check for ANSI terminal for color printing.
-    local ansi_term
-
     if [ -t 2 ]; then
         if [ "${TERM+set}" = 'set' ]; then
             case "$TERM" in
                 xterm*|rxvt*|urxvt*|linux*|vt*|eterm*|screen*)
-                    ansi_term=true
                     ;;
                 *)
-                    ansi_term=false
                     ERR="[ FAIL ] "
                     PAS="[ PASS ] "
                     ;;
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 22/28] Remove local bashisms
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:11 +0000
Resent-Message-ID: <handler.40601.B40601.158973592027425 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592027425
          (code B ref 40601); Sun, 17 May 2020 17:19:11 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:40 +0000
Received: from localhost ([127.0.0.1]:44610 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvv-00078A-IX
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:39 -0400
Received: from mail-wm1-f43.google.com ([209.85.128.43]:52218)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvP-00073G-3l
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:07 -0400
Received: by mail-wm1-f43.google.com with SMTP id f134so6997815wmf.1
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=+SEZi/2QEkG9kD0HWIabf4tSJMC684gTnEP6nOKmweI=;
 b=mSviWSh+cdI5PENu7P97JnQqj6Thd6XNMEs7wc0+k0Wf4IJQisDS7HILdcuj2LTY31
 UhaygSEXdhf+klYXVF/E6mP6c0uQ9bmSLqV9FepgFPfjuEnps48vYfz+ov99++jcy8+e
 i45JVcKuSVPlRR/vmFuVxBUNwhDoGwVDRoPQcoQnO6ARQvfK4ZeSpx77UHaYv1Za8Cdr
 /bMMhtVw8yPHAhqxjYWRL2bSpPYb0aBa8bILhfHCsYnS365FLhwkslPVDNcKTQFzRP/s
 6xu4W21X2N/jximmFaTkazlo2CipLCAcmynHNRe13zVvqUVXxhT2U1r6VmpJKcMsL13s
 TFQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=+SEZi/2QEkG9kD0HWIabf4tSJMC684gTnEP6nOKmweI=;
 b=MCF8eODhK40hJYgBY+54p6R5qA+Ev7q0/IHIh1sCSJTnOoGIyRGFop66isysaeYtxZ
 SyC+l/TfNQGYfKdr18C8zSY+9/VHtaSoLyVcfeXcorSSoNBJxkykHKgYZ9ErVTyodA0C
 oDm399Q5tui9aPELDHUPw+s3w2AAFMTczQqFvaEv1KIWbHAvqqWbz+8RSBIETTsakzWD
 KzpST/kT7chS2oL+XXZjNPWo4OwaIBaVwieWr+xIoOHS5gyFuQHva95R69KUq3rAeaiE
 0zwxeKjO7vMUDNuK8HnVz6CnzwSOFZWukHXyx+zMT+nPu3YFd/zwbmXS86Y5YBTXt3gG
 DCkA==
X-Gm-Message-State: AOAM531ygy/6cuZnAck5OnG3ELA1nKfZCjkAwqLQ9Dct4Igd03LVdfo/
 9dB0KkVmPLLDodJHHKeQUMFyulLx
X-Google-Smtp-Source: ABdhPJwDfvYmrfToYGT22EK6QDAIlk17W+dcBQzdkXm3YJAWGhkTgi+VgWXvozWTZjmgUXmQYgF2OA==
X-Received: by 2002:a1c:29c2:: with SMTP id p185mr14206208wmp.7.1589735881338; 
 Sun, 17 May 2020 10:18:01 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.18.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:00 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:19 +0200
Message-Id: <20200517171725.732-22-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 33 +++++++++++----------------------
 1 file changed, 11 insertions(+), 22 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 078081c08a..c7144288c9 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -89,7 +89,6 @@ _debug()
 chk_require()
 { # Check that every required command is available.
     declare -a warn
-    local c
 
     _debug "--- [ $FUNCNAME ] ---"
 
@@ -163,24 +162,22 @@ chk_init_sys()
 
 chk_sys_arch()
 { # Check for operating system and architecture type.
-    local os
-    local arch
 
     os="$(uname -s)"
     arch="$(uname -m)"
 
     case "$arch" in
         i386 | i486 | i686 | i786 | x86)
-            local arch=i686
+            arch=i686
             ;;
         x86_64 | x86-64 | x64 | amd64)
-            local arch=x86_64
+            arch=x86_64
             ;;
         aarch64)
-            local arch=aarch64
+            arch=aarch64
             ;;
         armv7l)
-            local arch=armhf
+            arch=armhf
             ;;
         *)
             _err "${ERR}Unsupported CPU type: ${arch}"
@@ -189,7 +186,7 @@ chk_sys_arch()
 
     case "$os" in
         Linux | linux)
-            local os=linux
+            os=linux
             ;;
         *)
             _err "${ERR}Your operation system (${os}) is not supported."
@@ -204,10 +201,7 @@ chk_sys_arch()
 
 guix_get_bin_list()
 { # Scan GNU archive and save list of binaries
-    local gnu_url="$1"
-    local -a bin_ver_ls
-    local latest_ver
-    local default_ver
+    gnu_url="$1"
 
     _debug "--- [ $FUNCNAME ] ---"
 
@@ -235,9 +229,9 @@ guix_get_bin_list()
 
 guix_get_bin()
 { # Download and verify binary package.
-    local url="$1"
-    local bin_ver="$2"
-    local dl_path="$3"
+    url="$1"
+    bin_ver="$2"
+    dl_path="$3"
 
     _debug "--- [ $FUNCNAME ] ---"
 
@@ -267,8 +261,8 @@ guix_get_bin()
 
 sys_create_store()
 { # Unpack and install /gnu/store and /var/guix
-    local pkg="$1"
-    local tmp_path="$2"
+    pkg="$1"
+    tmp_path="$2"
 
     _debug "--- [ $FUNCNAME ] ---"
 
@@ -426,10 +420,6 @@ sys_enable_guix_daemon()
 sys_make_guix_available()
 { # add guix into PATH
 
-    local info_path
-    local local_bin
-    local var_guix
-
     _debug "--- [ $FUNCNAME ] ---"
 
     info_path="/usr/local/share/info"
@@ -559,7 +549,6 @@ handle_args()
 
 main()
 {
-    local tmp_path
     handle_args "$@"
     [ "${_INTERACTIVE}" -eq 1 ] && welcome
 
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 24/28] Remove some "[[" bashisms
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:12 +0000
Resent-Message-ID: <handler.40601.B40601.158973592027432 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592027432
          (code B ref 40601); Sun, 17 May 2020 17:19:12 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:40 +0000
Received: from localhost ([127.0.0.1]:44612 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvv-00078K-VN
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:40 -0400
Received: from mail-wm1-f43.google.com ([209.85.128.43]:53046)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvQ-00073l-VM
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:09 -0400
Received: by mail-wm1-f43.google.com with SMTP id z4so5823455wmi.2
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=RYGsN7xu4LEGoWIENg2PawVTrW0jh9Ndo0EeHej1i9k=;
 b=JG7jBtpuTx14fZLnO1I88pULHLffW6b0gl6pt/gn4VBO4pD+OqzGapERuy5wLAPkIk
 381bD5RGTBz5KKS9uAeffga0RKRqnQrM3AUKT25CnU2sHssiFORtl4uhedWtBT1O4sl2
 nv0ubMIIkB6ifu1+xRrSMAm91sPcLkI/ocXUjjWosXT2vVmFLnDeXZYo3iPsPZShzjFe
 i9LYuQd181UWvsy1rzTdDsKROvV4i/zHjn96qCejocaZuY7BD2YRVeafJZFXqIXF0fKm
 Y3AQ/wxcd8J5TPzFL7CyApvzZ6bGq0N1Om7z5/N0JW0OzEHDRRK64ZXhvvtKKkhPI6av
 /iFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=RYGsN7xu4LEGoWIENg2PawVTrW0jh9Ndo0EeHej1i9k=;
 b=qgDBSE1jwwsOnNbcff+Xt1G3HQ2c8CJOBS5EfVcjmlcMDtMDy03nZjxSe6tqg8ksI1
 KBkeLP5SGrqYwbT8A/ByZT2E4Xd/ERaHDti78pN9sAYY88lHCin69Kwa0Z0cC6C3Nzu/
 R/696mTX71Cnqr4Fqe+G8u/6OQY14bvbQfrM+NgyDcsxbDNznMZydqLDWSATzuHDmPZu
 N1ioXs5NGwNTn04fa/9k339/HeKE/CZggDv2WhMQLJitORgoTOIAboTWuQL2H2zfWeud
 Jco5koDHgHfrXVmLxCLHJzFJo8qcJufJ/69JLxybd9qyLClvxHrS933R5I8xkFq+atrD
 MhRA==
X-Gm-Message-State: AOAM530CmxklYiriiKOreJZmm8x2O5UYZwRIgSJNSnH0PpH6YpC2GeC4
 CU0F0RPWJKmZ5sFmwjFdnjYXWelS
X-Google-Smtp-Source: ABdhPJza04motzzYFoYOu66zetOQ2ZWpJViO09fnTuidcgjcJ5D1RzR4kvbg9bLKVGQ9u5ZYNTIoGQ==
X-Received: by 2002:a7b:c21a:: with SMTP id x26mr14723589wmi.82.1589735883195; 
 Sun, 17 May 2020 10:18:03 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.18.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:02 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:21 +0200
Message-Id: <20200517171725.732-24-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 431790709a..cd33bf55bf 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -216,7 +216,7 @@ guix_get_bin_list()
 
     default_ver="guix-binary-${latest_ver}.${ARCH_OS}"
 
-    if [[ "${#bin_ver_ls}" -ne "0" ]]; then
+    if [ "${#bin_ver_ls}" -ne 0 ]; then
         _msg "${PAS}Release for your system: ${default_ver}"
     else
         _err "${ERR}Could not obtain list of Guix releases."
@@ -241,7 +241,7 @@ guix_get_bin()
         _PROGRESS_OPT="-q --show-progress" || _PROGRESS_OPT=""
     wget $_PROGRESS_OPT -P "${dl_path}" "${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig"
 
-    if [[ "$?" -eq 0 ]]; then
+    if [ "$?" -eq 0 ]; then
        _msg "${PAS}download completed."
     else
         _err "${ERR}could not download ${url}/${bin_ver}.tar.xz."
@@ -250,7 +250,7 @@ guix_get_bin()
 
     pushd "${dl_path}" >/dev/null
     gpg --verify "${bin_ver}.tar.xz.sig" >/dev/null 2>&1
-    if [[ "$?" -eq 0 ]]; then
+    if [ "$?" -eq 0 ]; then
         _msg "${PAS}Signature is valid."
         popd >/dev/null
     else
@@ -275,7 +275,7 @@ sys_create_store()
     tar x -f "${pkg}" "${TAROPTS[@]}" &&
     _msg "${PAS}unpacked archive"
 
-    if [[ -e "/var/guix" || -e "/gnu" ]]; then
+    if [ -e "/var/guix" ] || [ -e "/gnu" ]; then
         _err "${ERR}A previous Guix installation was found.  Refusing to overwrite."
         exit 1
     else
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 25/28] Remove unused variable set by "read"
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:12 +0000
Resent-Message-ID: <handler.40601.B40601.158973592027439 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592027439
          (code B ref 40601); Sun, 17 May 2020 17:19:12 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:40 +0000
Received: from localhost ([127.0.0.1]:44614 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvw-00078P-8l
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:40 -0400
Received: from mail-wr1-f51.google.com ([209.85.221.51]:46718)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvR-000742-Rd
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:10 -0400
Received: by mail-wr1-f51.google.com with SMTP id w7so9032220wre.13
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=EAzDVhVod1ErbrL1tlrLaAfDXkL+g52Ru2oeH2B1pQA=;
 b=O7Nr8XvIlvF6ZD8FS+zCb+aRdxnZESv2Po2rTT4dytrI61zz3B/Z1/corqD6HnmlP3
 Bg7fty/vp2p67C4dXsw/klMiw7D/7rKqLZtuviZRn8A/CHF57CPH+f0AaxunPN+Ub7uO
 /mkOrTeZygehnyFfSMMgEaNkxrZhzJaVyq4URb+tF/cic1TBk001T9DRW08rFNEyV7gW
 IsW0NokeP1rbfJYfxlBR8xXjyLLKOcpGKlKwzPMSPtMZp0fDPq0i80cHMYbsBrSpVTf0
 KELPhT1CZgjtH6xGOwLPDx9q075bXzHw9HCba0CoMcRE8iz9wPgf4sKWW6nQsjeDW0hW
 Sk6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=EAzDVhVod1ErbrL1tlrLaAfDXkL+g52Ru2oeH2B1pQA=;
 b=XWml/uv5XoKKVcqJwPfr5WSM+/wDQQkss479UPd2pzq1iW7T5nX1veU6suVCWuwv4k
 RYSHZkxEitBiycpiaeb3p4E00Z4ofq6Osg1TIAr5fFWggEGQmZFu2B4vEjRXVmS9pvhr
 tAeBhWuAf6h1EZLuEPQxhG5XXdlEnnaDwB+eXJgZn37zShzpZWTuxpw8EEWSukVf83wO
 MGYaqWEAo7c5yEPwxQ3u88XLcqrz8L45mZV5jChEgCFpRodmiy20fVSgN1v0m3jckIAC
 2ruxzX2nVJo57BB4nQwe7szGNsfArWTxBwxBhmjibKTEal9b7HeuokhChTcsfpNpiOU2
 U42A==
X-Gm-Message-State: AOAM530BDi6Hhb/zLs3QTp8DlQBxwIk3G2TlctNw9SoY7Ud1oEirYa+V
 YgUPpAe+Li5d2uZL6ZvGPfwjY3Ma
X-Google-Smtp-Source: ABdhPJy0z2C1snbouhe3fvNzt+xTF6xBNOCFyQ9Vv+8VOrNKZ2P8mbQhG91VrmbpFR+bK0yTVxFoYQ==
X-Received: by 2002:a5d:530b:: with SMTP id e11mr9662721wrv.85.1589735884135; 
 Sun, 17 May 2020 10:18:04 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.18.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:03 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:22 +0200
Message-Id: <20200517171725.732-25-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index cd33bf55bf..38f61de2f7 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -514,7 +514,7 @@ This script installs GNU Guix on your system
 https://www.gnu.org/software/guix/
 EOF
     echo -n "Press return to continue..."
-    read -r  ANSWER
+    read -r
 }
 
 # Do not change the tabs in the HERE-DOCUMENT
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 11/28] guix-install.sh: Use a variable for GPG key URL.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:12 +0000
Resent-Message-ID: <handler.40601.B40601.158973592127446 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592127446
          (code B ref 40601); Sun, 17 May 2020 17:19:12 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:41 +0000
Received: from localhost ([127.0.0.1]:44616 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvw-00078W-JJ
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:40 -0400
Received: from mail-wm1-f67.google.com ([209.85.128.67]:35187)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvE-00071n-Vo
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:11 -0400
Received: by mail-wm1-f67.google.com with SMTP id n5so7786936wmd.0
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:17:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=QzlDsQONmLEKuCM6RMBYCmP6K47406rcRFrwfkpDmdI=;
 b=XDW9zAVvreEZN8U3syTDnHOHnN6JmUsRdLX0twZYgScaPpVMwy1WIZW7gsCzzmWref
 nToc4VeiGXwE9zcxg+aKfB8dwOgx8kw/bZRGKR0JbJkCn6VUs6kCbhvxJOdWGhRq/tRL
 I78zwDvkqieH6YnhKoxp8oRhNmeaws72CfdWsqKxxJrVamPO1w15M630gMJJCXzpekuX
 gY4RP0rERGETBGXx9FmZqTDkEbD/NqxV9LbjbQzLdjtzJwNhxdeiOQF0fS9RT1FBB9kJ
 B3LmE3We9Wg1DFz7Qi1ldHddcw+f+P3f4uXdDReMcawBOdifayPiS/dMG2Blvv2UmST8
 S0ag==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=QzlDsQONmLEKuCM6RMBYCmP6K47406rcRFrwfkpDmdI=;
 b=tF0JVJDyrEdFKzQdsYN1ZmM4yGc02YhOaanzRTD+Mbp+PwPaLxCJkNhhQFDqKmolf+
 voMJriV4jthw7LzthnC+f/ju8cYSB9ptjbGtyHqII0+mz3Rizw96v9FkXOQ80YPzCPjP
 jf7B2BuY5f+m6szf6wCnUpzv0vlzYQEGz24rEWWdeRYfhPpt37NoSHsbDWxuyvTg+sTg
 K5Iz1mOh87YPq23ILkFohYDURlqGJOJcX176AUkzOHQg2MVO9mDhv2QxB+S/M+g6/lps
 lwUkAeN5SFKoNycHYXitTdUbd6kx+l31+pN7aTN0uVuANfJoJlviCTGKDGjumhs+gXBW
 /IJQ==
X-Gm-Message-State: AOAM531+WtWnV11+83e9LAM/Ho8bN8d6w39RRj2AVZNmaqds4z3R1JlQ
 trx3LCpp2zehdi/gog1fvcrcnmHI
X-Google-Smtp-Source: ABdhPJyMFvKH3oTeCPilPfF9VFOFtkbjm7N9uuYgG2BbofP+MjyrUABy444Udfr61/oemLdlXd7TFA==
X-Received: by 2002:a1c:80d0:: with SMTP id b199mr14663359wmd.93.1589735871316; 
 Sun, 17 May 2020 10:17:51 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.17.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:17:50 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:08 +0200
Message-Id: <20200517171725.732-11-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (OPENPGP_SIGNING_KEY_URL): Add new variable.
(chk_gpg_keyring): Use it here.
---
 etc/guix-install.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index d2e44e98b2..043357d9c4 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -59,6 +59,7 @@ INF="[ INFO ] "
 DEBUG=0
 GNU_URL="https://ftp.gnu.org/gnu/guix/"
 OPENPGP_SIGNING_KEY_ID="3CE464558A84FDC69DB40CFB090B11993D9AEBB5"
+OPENPGP_SIGNING_KEY_URL="https://sv.gnu.org/people/viewgpg.php?user_id=15145"
 
 # This script needs to know where root's home directory is.  However, we
 # cannot simply use the HOME environment variable, since there is no guarantee
@@ -112,7 +113,7 @@ chk_gpg_keyring()
     # systems where gpg has never been used, causing errors and confusion.
     gpg --dry-run --list-keys ${OPENPGP_SIGNING_KEY_ID} >/dev/null 2>&1 || {
         _err "${ERR}Missing OpenPGP public key.  Fetch it with this command:";
-        echo "  wget https://sv.gnu.org/people/viewgpg.php?user_id=15145 -qO - | gpg --import -";
+        echo "  wget ${OPENPGP_SIGNING_KEY_URL} -qO - | gpg --import -";
         exit 1;
     }
 }
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 23/28] Remove $UID bashism
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:13 +0000
Resent-Message-ID: <handler.40601.B40601.158973592327456 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592327456
          (code B ref 40601); Sun, 17 May 2020 17:19:13 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:43 +0000
Received: from localhost ([127.0.0.1]:44618 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvy-00078k-Tf
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:43 -0400
Received: from mail-wr1-f50.google.com ([209.85.221.50]:41187)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvQ-00073P-34
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:08 -0400
Received: by mail-wr1-f50.google.com with SMTP id h17so9066392wrc.8
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=RyxDZBU1WmOsP3F8XEyL3f93+gRXFiQ4O1C3yn3UdlE=;
 b=ohjG28yTHHFQI0FitsIOeM0fEsXlWw39IGSG8b/u4xA/awvVpUF24209cd9bDCUbrH
 9IcamPAMGqESXx1C8GU6GPGiESMzXys0l95JJZifw+fkWOS095cPYWIyjy5nJ68b02U4
 NfGzntuM/MNenYMEBW+akyVgy8HsmMQ2aDkt5ufFNBnO9WPmwb8wY2tCebRPWaQVfyen
 3Mh2bh1res7TOHWBCbeQhoBkkLwWQILyUMjKcB21uS463x9L0HtmwnO07Ivz/tG62frb
 JmPstYA9KsP8W/emOaPnadrH8G8kRujbi8BwaEDvo+leMgp6/vJ5Ee6cZrwkhUnTFNun
 cZSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=RyxDZBU1WmOsP3F8XEyL3f93+gRXFiQ4O1C3yn3UdlE=;
 b=jQbezNKQvdMLMmU1moE+jVRnxp1bUnQ7es3COUiZ610zCuLkqGQaK5reQhe6dARKK+
 gjN5rAV8eqFgZRBfW+H8wC+2Eak9RoWHHBbApATodHszqATrDSjIhw+GazV2hfQJMRxb
 Bo0AnfLs9x3YxLcznij+ygmyYMykDLR5BiQGN8qtIGvCLCpEnuhnEnrLyXpVvI3AyvFV
 FEn1wP6H3OL5tI9IJgTaj918wv6xx5MHLEMEy6ChzYJbIvTLkIQ/IsSKKWmJQKwRbDSB
 UkgYB2cOr4mU1vKRmsZMyxW3FrOBgGstk3F435JT54D6LUkPAM6QHbgJzdp/k8ZIqAbn
 UOjw==
X-Gm-Message-State: AOAM533xvBG0C+SW/9rp8hpff741wAUbmghD63YWQlMBBp9L6DXcGBgF
 y0I5JpjUmYwU2J7G36MD1uJgaXpy
X-Google-Smtp-Source: ABdhPJyhLey+sPZJYSN7Qp0nlAubhT50kP7KSX+8lPuSvbRm7Y92iBCcRNfQP12kMD+fkBaN+Fx1JQ==
X-Received: by 2002:adf:e388:: with SMTP id e8mr14978947wrm.174.1589735882305; 
 Sun, 17 May 2020 10:18:02 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.18.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:01 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:20 +0200
Message-Id: <20200517171725.732-23-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index c7144288c9..431790709a 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -30,7 +30,7 @@ fi
 
 set -e
 
-[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
+[ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
 
 # groupadd, useradd, usermod, adduser, addgroup are handled in:
 # sys_create_build_user & sys_create_build_group functions.
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 26/28] Add _debug_func() helper function
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:13 +0000
Resent-Message-ID: <handler.40601.B40601.158973592327463 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592327463
          (code B ref 40601); Sun, 17 May 2020 17:19:13 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:43 +0000
Received: from localhost ([127.0.0.1]:44620 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvz-00078n-6R
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:43 -0400
Received: from mail-wm1-f66.google.com ([209.85.128.66]:38489)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvT-00074n-HX
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:12 -0400
Received: by mail-wm1-f66.google.com with SMTP id m185so2875717wme.3
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jag/TTrlmDKE19yEhetNbRYZiC8DGMGy2oHhJkzWPI8=;
 b=uDk/jivmp55AQEm5zns/eOmKfQzCFaz/Ci8WI4bZUio6UDujmBvvrVL8POPXvK8AdB
 Jg0ZeFvoEipIMx9GtHvqViz7z6+ESXFHFB9cU2xNiFccpSTOPfnxvvewxrM8O1tyJIY3
 HtZ8MNrFnQakhRXZJtYrk3GKqk4Ueu6WsZkgVRQoswHm2LzVXKpN2ejzmHFlyaDhYe72
 M6A8c9Qj72YH+WJjKIl3tokqml90tpip2zj/8kna4ACjQIzlsxC/fUnIphbRDvUOfuKi
 4Cx7+JCyhDIcTfnzLV1cInxf9qhoLmpDOigFim6HyhwDG/+K6fPHCslaBHvl+0ZM7227
 XRzA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jag/TTrlmDKE19yEhetNbRYZiC8DGMGy2oHhJkzWPI8=;
 b=s171sRXKT92WRkWgF1pJCAq/j3hDuI3mynSbfx/Nao5KoCpOBHTVgAQEed6ZrkrTfp
 buIXZPMiZrUTncVwPcD+NWNdxR2RLTwkhuKHW7IFjK2YvNA216Tx16X76O5X2jlQHzLE
 XsNc2mo8ntvr5S3F/un4yE1P1rELfCb8WvV6xxFMuD+FTIeQqNvgrhFZlRLmK7A0UCA+
 Re51lEios8+8zbpKL5zYsz3botPzhltKpYrd/CK1+/sUrD+AQ3sHb/w0scdC2z5feVNn
 Yz8ihSvb+lsF+XBv8sBcX7o4vNKg1cOSSVifsZO721PrUhrFDMZYrGWXHqS4/aHjTL1z
 2djw==
X-Gm-Message-State: AOAM533r3PI5msB6EXUrl/DDifWVVkGf1vWJCILrdpFdT4bCJuW3Keo+
 AxNxU1sHi+9hxtECNLWQqNkkMByb
X-Google-Smtp-Source: ABdhPJytff3K/bOs6vlDdlBMOSc1E0khWUNT+BYiuk6+qdazINlCh5Xly+igZ5WGU20WISado7jtYg==
X-Received: by 2002:a1c:2c0b:: with SMTP id s11mr11309882wms.97.1589735885015; 
 Sun, 17 May 2020 10:18:05 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.18.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:04 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:23 +0200
Message-Id: <20200517171725.732-26-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 38f61de2f7..4ee350a155 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -85,12 +85,17 @@ _debug()
     fi
 }
 
+_debug_func()
+{
+    # Display _debug_func() caller's function name
+    _debug "--- [ ${FUNCNAME[1]} ] ---"
+}
 
 chk_require()
 { # Check that every required command is available.
     declare -a warn
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     for c in "$@"; do
         command -v "$c" >/dev/null 2>&1 || warn+=("$c")
@@ -105,7 +110,7 @@ chk_require()
 
 chk_gpg_keyring()
 { # Check whether the Guix release signing public key is present.
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     # Without --dry-run this command will create a ~/.gnupg owned by root on
     # systems where gpg has never been used, causing errors and confusion.
@@ -203,7 +208,7 @@ guix_get_bin_list()
 { # Scan GNU archive and save list of binaries
     gnu_url="$1"
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     # Filter only version and architecture
     bin_ver_ls=("$(wget -qO- "$gnu_url" \
@@ -233,7 +238,7 @@ guix_get_bin()
     bin_ver="$2"
     dl_path="$3"
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     _msg "${INF}Downloading Guix release archive"
 
@@ -264,7 +269,7 @@ sys_create_store()
     pkg="$1"
     tmp_path="$2"
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     # Do not use the --warning option with busybox tar
     TAROPTS=("-C" "${tmp_path}")
@@ -297,7 +302,7 @@ sys_create_store()
 sys_create_build_group()
 { # Create the group for build users.
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     if getent group guixbuild >/dev/null 2>&1; then
         _msg "${INF}group guixbuild already exists"
@@ -316,7 +321,7 @@ sys_create_build_group()
 sys_create_build_user()
 { # Create the user accounts for build users.
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     NOLOGIN_SHELL="$(command -v nologin)"
     for i in $(seq -w 1 10); do
@@ -352,7 +357,7 @@ sys_create_build_user()
 sys_enable_guix_daemon()
 { # Run the daemon, and set it to automatically start on boot.
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     case "$INIT_SYS" in
         upstart)
@@ -420,7 +425,7 @@ sys_enable_guix_daemon()
 sys_make_guix_available()
 { # add guix into PATH
 
-    _debug "--- [ $FUNCNAME ] ---"
+    _debug_func
 
     info_path="/usr/local/share/info"
     local_bin="/usr/local/bin"
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 27/28] Fix variable use in guix_get_bin_list()
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:14 +0000
Resent-Message-ID: <handler.40601.B40601.158973592427470 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592427470
          (code B ref 40601); Sun, 17 May 2020 17:19:14 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:44 +0000
Received: from localhost ([127.0.0.1]:44622 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvz-00078u-Iq
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:43 -0400
Received: from mail-wm1-f66.google.com ([209.85.128.66]:39085)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvT-00074s-I3
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:11 -0400
Received: by mail-wm1-f66.google.com with SMTP id w64so7743929wmg.4
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=aA+/4qneJv1BAegkxsojfBI+0JOCq6Mdfkm6K8sE+Xg=;
 b=I/T84K78y/r44hi6P3J9FcdNDN/cLr8n8BSIwCNJClGgrHP0YytPE6jmEcEAI1XaJh
 J7YS+r8W/yyyiPDN0Morzji5+ZXlr602WbkQWP7otcldNY+mpywLXDCvpry88NZrokHG
 pz9mLC1fA+MzoXoRQyoHQLtMNeJbeuox5nzldyUpnB3lL0SJGU4haLNAuyfnrwEiWFGt
 rQL0/b5XbeRY+vtzIJpYSBBkPJgO5COhy9V12mTz4Uf80af67LeqcbDTk9ASRyv0INMw
 mCm+i6pfek9EKTshugmJYYQVHf5f4MXl576xHTX9RVCSydgUn6Rd49xuWOTKPubNCSRo
 ArVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=aA+/4qneJv1BAegkxsojfBI+0JOCq6Mdfkm6K8sE+Xg=;
 b=iFfWAiX/r0I3lAw56GY82tcGV/jfArFdiot7Ho4WDaFoNqKXJ3eTVa5MwZ/Wjuo8Lm
 OnKw1zgzCXnFziUwV9+SmA9rKpFdsk1zz2mQH5xAQ4QdR6n9XwvMMVSI2WeO6iWg2zwk
 7LDW6vriPIhOosGpVxX8xF0qpdCC09HRPljY038lywYl6ax4c1cVJCilOt0w6G/8hl8K
 t6yW6QMZEIj8uqbcuKC80x0cY0QPcNw2htFo5J0YzXUCo0zE15E5QaM35MxtIGNLHOqO
 r3/Pqt7Iva2w09Xpt8aU89lCdXMDR9BT1q+K1jNZWbusVV/tkjKij7sKOleSi7W5I7q/
 DZ9w==
X-Gm-Message-State: AOAM533TEa3NzN637kmVZ9r8IDRh6XxfTjQ/K863C9f4lFMsEHsYMTQb
 JWevVrlUB+D2QAlkN0UAniMVHQoB
X-Google-Smtp-Source: ABdhPJzZ6WvXbitAP+37sW97tDQhVjasmO71bBep1qu9mZWQo2d0XZJjyRHEl7CseYRenP3/rBIqbg==
X-Received: by 2002:a05:600c:14c6:: with SMTP id
 i6mr14660165wmh.58.1589735885874; 
 Sun, 17 May 2020 10:18:05 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.18.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:05 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:24 +0200
Message-Id: <20200517171725.732-27-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

- Add missing curly-brackets
- Add implicit array zero-indexing
---
 etc/guix-install.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 4ee350a155..be2fd74905 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -215,7 +215,7 @@ guix_get_bin_list()
         | sed -n -e 's/.*guix-binary-\([0-9.]*\)\..*.tar.xz.*/\1/p' \
         | sort -Vu)")
 
-    latest_ver="$(echo "$bin_ver_ls" \
+    latest_ver="$(echo "${bin_ver_ls[0]}" \
                        | grep -oE "([0-9]{1,2}\.){2}[0-9]{1,2}" \
                        | tail -n1)"
 
@@ -229,7 +229,7 @@ guix_get_bin_list()
     fi
 
     # Use default to download according to the list and local ARCH_OS.
-    BIN_VER="$default_ver"
+    BIN_VER="${default_ver}"
 }
 
 guix_get_bin()
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 28/28] Remove "[[" bashisms in chk_init_sys()
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 17:19:14 +0000
Resent-Message-ID: <handler.40601.B40601.158973592427477 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.158973592427477
          (code B ref 40601); Sun, 17 May 2020 17:19:14 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 17:18:44 +0000
Received: from localhost ([127.0.0.1]:44624 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaMvz-000791-Su
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:44 -0400
Received: from mail-wm1-f65.google.com ([209.85.128.65]:51746)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaMvU-00075J-Dh
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 13:18:12 -0400
Received: by mail-wm1-f65.google.com with SMTP id f134so6997914wmf.1
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 10:18:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=ubhbQCy/xKyaGnm6shHlPKr+jGTj6oKsxoPaRxJZUsU=;
 b=VVsrQB6LXbP3Xc4gsAjeuVwyt82gnqtys3YoCP1xr2oG7SHPIAudJdXnOgffuuTdJv
 CT1xMFWEprs/Cahczh/v4Sum08A+DLp64Mpj1DjwS5wMu+GJNHmvPXY2CUPA6AbFanVI
 oeurzJjniU8Gb31RPZ33gWDD8pKjNULq5JorpQkodpM/sxhVY3vH0zsMdgFr9r9IeWAX
 GtVWP4yMdY9BJPeVPYt74fv1o38viNQv0nXP0Z1vkRxma5FyAcmvZGuFWVifXdHh2F3G
 0tDMTohVqFCWaU+Yr3wU7lgOJNdfDKQNF+u1O/Z72T1xyt1WpPCJc6sYJRx13OWwh9YA
 MecA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ubhbQCy/xKyaGnm6shHlPKr+jGTj6oKsxoPaRxJZUsU=;
 b=rDaRHfR7b9cObTf8I4D6BhwcgoBnhcRdBGQ6sO6dmEwQoir6deCzwwKa/TE/uEXD5w
 vVwWsHAK2Wax45zLykUWawI3VnWwI7SKPUii8FAFa3sgTqSaH1X7tHcmIZREricUnFnc
 nnCRF4UDsjf//7wWXzem+bOYRk1ykb/Jhau5Tf9WRyqMJuf9qleL4REa+ZnJ6Pr0JeXf
 OfFYcfbe7i+XnsJbAP51oKbTgaFLgSFueXeaodMzq8rmTOwLETuOjZbvqoN9VtvJzrCE
 APZXJ6p1pVdg5VJ5zn8zwEg/83SoNkw/pqwTVkaZR7vEhbpbjZ2JJQFmWMIl05NqMi4s
 n20w==
X-Gm-Message-State: AOAM530r09QOyiLtFnL+o3sB3dbE3A7a5ZOciVPP0TBoFeaowiDweZ6a
 nKhoeT6p2rUzbC5oXLyFw3+Gfrqq
X-Google-Smtp-Source: ABdhPJzd/AkBjKDtWj8AsFCBYBC/U3ITC9umoW5J72heQGrQXQn/1NNq6rMlS+PaY+DRpMnCUEeEWA==
X-Received: by 2002:a1c:19c1:: with SMTP id 184mr14087017wmz.29.1589735886742; 
 Sun, 17 May 2020 10:18:06 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id v126sm13305048wma.9.2020.05.17.10.18.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 May 2020 10:18:06 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 17 May 2020 19:17:25 +0200
Message-Id: <20200517171725.732-28-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200517171725.732-1-vincent.legoll@HIDDEN>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

---
 etc/guix-install.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index be2fd74905..45b4c4b720 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -139,23 +139,23 @@ chk_term()
 
 chk_init_sys()
 { # Return init system type name.
-    if [[ $(/sbin/init --version 2>/dev/null) =~ upstart ]]; then
+    if /sbin/init --version 2>/dev/null | grep -q upstart; then
         _msg "${INF}init system is: upstart"
         INIT_SYS="upstart"
         return 0
-    elif [[ $(systemctl 2>/dev/null) =~ -\.mount ]]; then
+    elif systemctl 2>/dev/null | grep -q -- -\.mount; then
         _msg "${INF}init system is: systemd"
         INIT_SYS="systemd"
         return 0
-    elif [[ $(rc -V 2>/dev/null) =~ OpenRC ]]; then
+    elif rc -V 2>/dev/null | grep -q OpenRC; then
         _msg "${INF}init system is: openrc"
         INIT_SYS="openrc"
         return 0
-    elif [[ -f /etc/init.d/cron && ! -h /etc/init.d/cron ]]; then
+    elif [ -f /etc/init.d/cron ] && [ ! -h /etc/init.d/cron ]; then
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
-    elif [[ -d /etc/sv ]]; then
+    elif [ -d /etc/sv ]; then
         _msg "${INF}init system is: runit"
         INIT_SYS="runit"
         return 0
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [RFC, PATCH 0/28] guix-install.sh: port to other distros & init systems
Resent-From: Julien Lepiller <julien@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 19:28:01 +0000
Resent-Message-ID: <handler.40601.B40601.15897436347124 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>,40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.15897436347124
          (code B ref 40601); Sun, 17 May 2020 19:28:01 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 19:27:14 +0000
Received: from localhost ([127.0.0.1]:44794 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaOwL-0001qp-L9
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 15:27:13 -0400
Received: from lepiller.eu ([89.234.186.109]:33304)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1jaOwJ-0001qh-RY
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 15:27:12 -0400
Received: from lepiller.eu (localhost [127.0.0.1])
 by lepiller.eu (OpenSMTPD) with ESMTP id b7a1e08c;
 Sun, 17 May 2020 19:27:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date
 :in-reply-to:references:mime-version:content-type
 :content-transfer-encoding:subject:to:from:message-id; s=dkim;
 bh=FVNHybxbyi1pZIg26SvYfknCGjB9VZ/KbKBelFJYUHc=; b=lTulEPwxBnD2
 73zrEC/NrAhHsYRxas8Rq+KcVUaMImAFXnCZPPD/qiVNsl9L8FfbX3QEeTfXPLVG
 krZYaKYSZwKISW79urA3VQ5/pAiZ/DzZpprf00btDKPPigWx+oKE/ucGAx1Zf5pB
 r0z/aO+7cj3TlGKTBFSLpsRqgFsb35d7tbn1fnynoTss0liWFVaWC5VL5wvY/LLu
 NA+MUzDTUgyhQmqxrfMfoUQo9mhejJLHVGDvsMZ37jFANYlw3LbgLaZzdWpcUTVN
 ljNQqT2DeumH4Fbjkv9lLZDU0lKKERQWYZjcLiDLuWIbRlQNF+IHLjI2UhIIGBm3
 G24y+U9UTg==
Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 15d98221
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sun, 17 May 2020 19:27:10 +0000 (UTC)
Date: Sun, 17 May 2020 15:26:50 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <12af851d-73b6-5865-8950-857c2158d41e@HIDDEN>
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <12af851d-73b6-5865-8950-857c2158d41e@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Julien Lepiller <julien@HIDDEN>
Message-ID: <9B55C53F-93C3-41E1-B092-72EA616D2536@HIDDEN>
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Le 17 mai 2020 13:15:46 GMT-04:00, Vincent Legoll <vincent=2Elegoll@gmail=
=2Ecom> a =C3=A9crit :
>Hello,
>
>Here is a RFC series of patches that add a few things:
>
>- small fixes & cleanups
>- removing some (not all) bashisms
>- non-interactive mode (useful for (semi-) automated
>   testing)
>- openrc init system support
>- runit init system support
>- busybox compatibility (for alpine support)
>- handle local guix-binary=2E${ARCH}=2Etar=2Exz file (useful
>   for (semi-) automated testing)
>- requirements fixes
>
>It currently has been tested on a range of distros/arches
>but the latest patches are still not polished (missing
>proper commit messages)
>
>The series is RFC as a few questions remain for me:
>
>- Do we want to support alien (aka foreign++) distros
>   (different shells, different init systems, etc=2E=2E=2E)
>- To what extent
>- Are the patches too fine-grained (I personally like
>   them smallish)
>
>Future, additionnal work items:
>- s6 (adelie / obarun) init support
>- handle GPG downloading in non-interactive mode
>- being able to cross-build & test them on other
>   arches again (dunno why it broke)
>- documentation
>- add missing guix-publish services
>- add missing RO remounting the store on other distros
>- removing allremaining bashisms (being shellcheck clean
>   maybe ?)
>
>This is to gather input before investing too much time=2E
>
>For example, do we want to commit part of this now, with
>the rest coming later ?
>
>Any feedback ?
>On individual patch(es) or on the whole series goal=2E=2E=2E
>
>Thanks for reading this far=2E

Nice series! I think we want to support as many foreign (init, shell, =E2=
=80=A6) distros as possible=2E

You might want to consider fixing bug #41266=2E I also found out that daem=
onize is required on sysv systems=2E

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [RFC, PATCH 0/28] guix-install.sh: port to other distros & init systems
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 May 2020 19:38:01 +0000
Resent-Message-ID: <handler.40601.B40601.15897442348037 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Julien Lepiller <julien@HIDDEN>, 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.15897442348037
          (code B ref 40601); Sun, 17 May 2020 19:38:01 +0000
Received: (at 40601) by debbugs.gnu.org; 17 May 2020 19:37:14 +0000
Received: from localhost ([127.0.0.1]:44800 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaP61-00025Y-N1
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 15:37:13 -0400
Received: from mail-wr1-f65.google.com ([209.85.221.65]:41507)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jaP60-00025L-0O
 for 40601 <at> debbugs.gnu.org; Sun, 17 May 2020 15:37:12 -0400
Received: by mail-wr1-f65.google.com with SMTP id h17so9331892wrc.8
 for <40601 <at> debbugs.gnu.org>; Sun, 17 May 2020 12:37:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:references:from:message-id:date:user-agent:mime-version
 :in-reply-to:content-language:content-transfer-encoding;
 bh=OQLh0smPhbkRn98ln8HmtUUNp3ucEYZJmI2ioGpPVG4=;
 b=seqCoS3Kiy7PsYNzWR+eJLHLE4JZAYVXSwwaglOOQlE0bIiiXr+UOBhWY/Ztup1kuc
 m1kaGgXciE+tixC48KmDuVJbVfF6mXAtsyusTQaYLqEdzUfQJjPQCzKyu0hqX1mLqD1D
 GKmIPTPPsOVhnnBHNWGDaQ5JlYJuZX2aH3/TIXsj7JBtxogh+qPdZP9pJ+/EAsCF3LM8
 hJHTOQl8wzENy0fi1v1RXUECTJZcGKi1yli2QeNJbjfpRm93x3vxH34XZlTfIof8IhFs
 IRmvhuj5hRH9XZQ+Kl/brvDgMJS2Iks61D5GjHb7+SABlPolfe6Yg5TGblC/HJRH/ngZ
 nEwA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=OQLh0smPhbkRn98ln8HmtUUNp3ucEYZJmI2ioGpPVG4=;
 b=fw2+m2jdLCSqUSTQaUWJ6+ST351sCx8n/QdixqUEclOEB3fHQkBI4WDN4waMBKCgr2
 +VFL+uRZUGMOJ++++3jp4vJF6OugjuRzjO78FUAGdf4QVEMJ3Z1fHbImTQevc+3bPT29
 tUDlx5kbbfBZkQc29rYqF5nsLuhyyevjs+sGmcZU5bBroGcFYxkxZCmWXvKYknmpToLG
 YAaK28idwqX7XHziis1m1SEr6isZTJhmfDOR67DXwpQf5NpvDiIhQbpT5bu1fxuGhJZB
 UhNyXMXVLfFZ2kjEIDR+ioyo2vm6s8/MHq62vdT/BLvqYXP6TVOuQOyKE4Bh/OylH9k4
 S7YQ==
X-Gm-Message-State: AOAM531AbXE6HAdrYQWs43Rk9CZghfpu+Jh9St6iKAOkgppCy/mntgnM
 jyBOrB1zJ6QmPsbMNvdvOCdJnKP2
X-Google-Smtp-Source: ABdhPJxD9eY0myxtdo6xCBuqQvWajueoEmxeTiIeVqNGvnLPPxPeN3PAKl1uU8XeeW2Ek2fj3XPj/w==
X-Received: by 2002:adf:f5cb:: with SMTP id k11mr15706262wrp.300.1589744225808; 
 Sun, 17 May 2020 12:37:05 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id 81sm14427243wme.16.2020.05.17.12.37.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 May 2020 12:37:05 -0700 (PDT)
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <12af851d-73b6-5865-8950-857c2158d41e@HIDDEN>
 <9B55C53F-93C3-41E1-B092-72EA616D2536@HIDDEN>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <16ce2d5b-e12b-ba6e-758c-fb02d689fe81@HIDDEN>
Date: Sun, 17 May 2020 21:37:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <9B55C53F-93C3-41E1-B092-72EA616D2536@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> Nice series! I think we want to support as many foreign
> (init, shell, …) distros as possible.

OK that makes at least 3 of us

> You might want to consider fixing bug #41266.

Ah, nice, that shows that my testing rig is still missing
cases, I only run everything directly as root (for which
I pre-import the key), so the problem slipped through.

Another one for the TODO list.

> I also found out that daemonize is required on sysv systems.

Yep, I've seen it, but forgot to add it to the TODO list, it's
now.

Thanks, this will end in a ~50-patches series ;-)

-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [guix-daemon now working on parabola with openrc]
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: jgart@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 22 May 2020 14:35:02 +0000
Resent-Message-ID: <handler.40601.B40601.15901580746564 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.15901580746564
          (code B ref 40601); Fri, 22 May 2020 14:35:02 +0000
Received: (at 40601) by debbugs.gnu.org; 22 May 2020 14:34:34 +0000
Received: from localhost ([127.0.0.1]:59965 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jc8ks-0001ho-8C
	for submit <at> debbugs.gnu.org; Fri, 22 May 2020 10:34:34 -0400
Received: from mx1.dismail.de ([78.46.223.134]:30653)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1jc7yi-00008E-5g
 for 40601 <at> debbugs.gnu.org; Fri, 22 May 2020 09:44:49 -0400
Received: from mx1.dismail.de (localhost [127.0.0.1])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id d2665e37
 for <40601 <at> debbugs.gnu.org>; Fri, 22 May 2020 15:44:40 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=
 mime-version:date:content-type:content-transfer-encoding:from
 :message-id:subject:to; s=20190914; bh=mqvzBQ7FOJA5xJFuqOpemWyrO
 02C6hnPq0dE8KOQwc4=; b=TxuVW5LEb33jyvzi4Yq/F/40wAR8gVs8fKDlSzCUD
 VSv7KnvGdNsMWloPFbZhMGUO44QRQM90y1N3fAkfd4N8FgsW67aLVLnM5oSSAd5L
 RcfBQO0j+xxWZZ7+Sgidt3d+CHBnE5ihJAgPkS3gEJNq6Wz+Zjh8j9lnUO1HXgWE
 ohGniE2RZtzaKCFkOzHTTGK5RDJfNgPBC6xD1XGBiYnbM7VRkxYmhwtPBdxpi1XI
 AmppkzTIMNZWHLOQcdwE5D/goVpcne6D4J1CiweBQh8IGxWD3NhvcIYkXY5QyLzD
 t6wrGU+UBJZSOp05Ew+mXaTLjUyJbqbxtxJUWv1AF4afg==
Received: from smtp2.dismail.de (<unknown> [10.240.26.12])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id a3c8e07c
 for <40601 <at> debbugs.gnu.org>; Fri, 22 May 2020 15:44:40 +0200 (CEST)
Received: from smtp2.dismail.de (localhost [127.0.0.1])
 by smtp2.dismail.de (OpenSMTPD) with ESMTP id 2fa39573
 for <40601 <at> debbugs.gnu.org>; Fri, 22 May 2020 15:44:40 +0200 (CEST)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id 9cc06a45
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
 for <40601 <at> debbugs.gnu.org>; Fri, 22 May 2020 15:44:40 +0200 (CEST)
MIME-Version: 1.0
Date: Fri, 22 May 2020 13:44:39 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: RainLoop/1.14.0a
From: jgart@HIDDEN
Message-ID: <103a2055e6e16e307b0d5f3112fa23dc@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Mailman-Approved-At: Fri, 22 May 2020 10:34:33 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

I have openrc working on parabola with guix-daemon. It successfully regis=
ters the following service.=0A=0A#! /sbin/openrc-run=0A=0Adescription=3D"=
guix build daemon" =0Acommand=3D"/var/guix/profiles/per-user/root/current=
-guix/bin/guix-daemon" =0Acommand_args=3D"--build-users-group=3Dguixbuild=
" =0Acommand_background=3Dtrue=0Apidfile=3D"/run/guix-daemon.pid"=0A=0ATh=
e above is a modification of Vincent's code in order to make it run for m=
e without using the @localstatedir@ variable.=0A=0AIf anybody has suggest=
ions, corrections, and incites about this it would be greatly appreciated=
.=0A=0AI would like to get this working with the packaged version of guix=
 in parabola https://www.parabola.nu/packages/?q=3Dguix=0A=0Asince that P=
KGBUILD does not support openrc currently.=0A=0AIt also needs to be updat=
ed.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [guix-daemon now working on parabola with openrc]
Resent-From: Leo Famulari <leo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 22 May 2020 18:41:02 +0000
Resent-Message-ID: <handler.40601.B.159017281813993 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-To: jgart--- via Guix-patches via <guix-patches@HIDDEN>
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org
Received: via spool by submit <at> debbugs.gnu.org id=B.159017281813993
          (code B ref -1); Fri, 22 May 2020 18:41:02 +0000
Received: (at submit) by debbugs.gnu.org; 22 May 2020 18:40:18 +0000
Received: from localhost ([127.0.0.1]:60389 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcCad-0003da-5j
	for submit <at> debbugs.gnu.org; Fri, 22 May 2020 14:40:18 -0400
Received: from lists.gnu.org ([209.51.188.17]:43560)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1jcCab-0003dS-Ap
 for submit <at> debbugs.gnu.org; Fri, 22 May 2020 14:40:13 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55468)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1jcCab-00051t-2a
 for guix-patches@HIDDEN; Fri, 22 May 2020 14:40:13 -0400
Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:49991)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1jcCaZ-00085n-5N
 for guix-patches@HIDDEN; Fri, 22 May 2020 14:40:12 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 94B1EC73;
 Fri, 22 May 2020 14:40:09 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Fri, 22 May 2020 14:40:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=XHuhTdCoY6f4IEw5aokyxSzf
 Ai7uvHJ6Kg5ptcE7UFM=; b=ijXwF8W2cf542hOFBVWwfiuQHDpxghTXn6rV7DCo
 EmidCQ6kdSU0NFwKvAvyS20ldMt2IcA3sxNHkHc+X7HHL3VKQxglaase7FkUCBff
 hh6umzv+2d92zbEeBT2RIwKpfM20KNFAz0MLtt+jP5BWUSEDDVIWm2KnsHucbEBI
 E4w=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XHuhTd
 CoY6f4IEw5aokyxSzfAi7uvHJ6Kg5ptcE7UFM=; b=kkqXuAJ4ztWByiJ2bGmPRU
 MuPVXpx4O3wzRvmnqoJZP9jexGHf37w3+wKu+s8iDdyTcxUwyCKSfKSJqq+NyWSQ
 UriSz5UAvEnhNDu9h1RM/XmL623cdYEeue5QZJeNUHFW9FudamiPwxyitebxXduA
 VSi7sdgfLp603ioJxqbHUM4DtIl6VjNqw+y2gZcCoLIAU2QUY7VezI4tLg0KxdTc
 M7RBDOGRum37dNumqCe0O5l7K/EKgeF7JUGMOfuygmwJY5h9boPeSM2/ndZjBdBf
 yUpJu1Fu9DVb9xAVxBnRUycOTN50f62RM83e7qIkMsFfsmcuJR+wEMK2eNwRkaVA
 ==
X-ME-Sender: <xms:iBzIXnfKGoKl8LstqCmXvUEbS68WevSESX7YkuaSEgTyd2t_cIXIwQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddufedguddviecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu
 hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth
 htvghrnhepieffhedtiefhhedvkeehtdegtedvkeefleejhfelteeghfelveefjeehgeet
 veeunecuffhomhgrihhnpehprghrrggsohhlrgdrnhhunecukfhppeejiedruddvgedrud
 efkedrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho
 mheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:iBzIXtM6-ZYj-k9mYhnO6CC1VGbzzHRoqrRtooZXdO7JybG2ouF0pg>
 <xmx:iBzIXgj2216Umy3zFA4wktRXD4IltvfjNCIfDKREU_fgzk9zEQnFWg>
 <xmx:iBzIXo9d9gbebMmuYyMao9MdvYJiP-W_T1qUYPJVIN340tjZZEe_cg>
 <xmx:iRzIXh5ttyFkUyd_pyhK1iDCkuTn_zF2EMUmOFgWjINMgsUiZNmxNA>
Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63])
 by mail.messagingengine.com (Postfix) with ESMTPA id BBACB3066411;
 Fri, 22 May 2020 14:40:08 -0400 (EDT)
Date: Fri, 22 May 2020 14:40:06 -0400
From: Leo Famulari <leo@HIDDEN>
Message-ID: <20200522184006.GB11419@HIDDEN>
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <103a2055e6e16e307b0d5f3112fa23dc@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <103a2055e6e16e307b0d5f3112fa23dc@HIDDEN>
Received-SPF: pass client-ip=64.147.123.24; envelope-from=leo@HIDDEN;
 helo=wout1-smtp.messagingengine.com
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/22 14:26:11
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic] [fuzzy]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

On Fri, May 22, 2020 at 01:44:39PM +0000, jgart--- via Guix-patches via wrote:
> I have openrc working on parabola with guix-daemon. It successfully registers the following service.
> 
> #! /sbin/openrc-run
> 
> description="guix build daemon" 
> command="/var/guix/profiles/per-user/root/current-guix/bin/guix-daemon" 
> command_args="--build-users-group=guixbuild" 
> command_background=true
> pidfile="/run/guix-daemon.pid"

Great!

> The above is a modification of Vincent's code in order to make it run for me without using the @localstatedir@ variable.

Does it still use the "correct" local state directory? Normally that's
'/var/guix' but I'm not sure what Parabola does.

> I would like to get this working with the packaged version of guix in parabola https://www.parabola.nu/packages/?q=guix

Is it not working now? What remains to be done, aside from updating the
packages?

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [guix-daemon now working on parabola with openrc]
Resent-From: Leo Famulari <leo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 22 May 2020 18:41:02 +0000
Resent-Message-ID: <handler.40601.B40601.159017283214021 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-To: jgart--- via Guix-patches via <guix-patches@HIDDEN>
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159017283214021
          (code B ref 40601); Fri, 22 May 2020 18:41:02 +0000
Received: (at 40601) by debbugs.gnu.org; 22 May 2020 18:40:32 +0000
Received: from localhost ([127.0.0.1]:60393 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcCat-0003e4-MQ
	for submit <at> debbugs.gnu.org; Fri, 22 May 2020 14:40:31 -0400
Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:34831)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1jcCad-0003dN-AZ
 for 40601 <at> debbugs.gnu.org; Fri, 22 May 2020 14:40:30 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 94B1EC73;
 Fri, 22 May 2020 14:40:09 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Fri, 22 May 2020 14:40:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=XHuhTdCoY6f4IEw5aokyxSzf
 Ai7uvHJ6Kg5ptcE7UFM=; b=ijXwF8W2cf542hOFBVWwfiuQHDpxghTXn6rV7DCo
 EmidCQ6kdSU0NFwKvAvyS20ldMt2IcA3sxNHkHc+X7HHL3VKQxglaase7FkUCBff
 hh6umzv+2d92zbEeBT2RIwKpfM20KNFAz0MLtt+jP5BWUSEDDVIWm2KnsHucbEBI
 E4w=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XHuhTd
 CoY6f4IEw5aokyxSzfAi7uvHJ6Kg5ptcE7UFM=; b=kkqXuAJ4ztWByiJ2bGmPRU
 MuPVXpx4O3wzRvmnqoJZP9jexGHf37w3+wKu+s8iDdyTcxUwyCKSfKSJqq+NyWSQ
 UriSz5UAvEnhNDu9h1RM/XmL623cdYEeue5QZJeNUHFW9FudamiPwxyitebxXduA
 VSi7sdgfLp603ioJxqbHUM4DtIl6VjNqw+y2gZcCoLIAU2QUY7VezI4tLg0KxdTc
 M7RBDOGRum37dNumqCe0O5l7K/EKgeF7JUGMOfuygmwJY5h9boPeSM2/ndZjBdBf
 yUpJu1Fu9DVb9xAVxBnRUycOTN50f62RM83e7qIkMsFfsmcuJR+wEMK2eNwRkaVA
 ==
X-ME-Sender: <xms:iBzIXnfKGoKl8LstqCmXvUEbS68WevSESX7YkuaSEgTyd2t_cIXIwQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddufedguddviecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu
 hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth
 htvghrnhepieffhedtiefhhedvkeehtdegtedvkeefleejhfelteeghfelveefjeehgeet
 veeunecuffhomhgrihhnpehprghrrggsohhlrgdrnhhunecukfhppeejiedruddvgedrud
 efkedrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho
 mheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:iBzIXtM6-ZYj-k9mYhnO6CC1VGbzzHRoqrRtooZXdO7JybG2ouF0pg>
 <xmx:iBzIXgj2216Umy3zFA4wktRXD4IltvfjNCIfDKREU_fgzk9zEQnFWg>
 <xmx:iBzIXo9d9gbebMmuYyMao9MdvYJiP-W_T1qUYPJVIN340tjZZEe_cg>
 <xmx:iRzIXh5ttyFkUyd_pyhK1iDCkuTn_zF2EMUmOFgWjINMgsUiZNmxNA>
Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63])
 by mail.messagingengine.com (Postfix) with ESMTPA id BBACB3066411;
 Fri, 22 May 2020 14:40:08 -0400 (EDT)
Date: Fri, 22 May 2020 14:40:06 -0400
From: Leo Famulari <leo@HIDDEN>
Message-ID: <20200522184006.GB11419@HIDDEN>
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <103a2055e6e16e307b0d5f3112fa23dc@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <103a2055e6e16e307b0d5f3112fa23dc@HIDDEN>
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Fri, May 22, 2020 at 01:44:39PM +0000, jgart--- via Guix-patches via wrote:
> I have openrc working on parabola with guix-daemon. It successfully registers the following service.
> 
> #! /sbin/openrc-run
> 
> description="guix build daemon" 
> command="/var/guix/profiles/per-user/root/current-guix/bin/guix-daemon" 
> command_args="--build-users-group=guixbuild" 
> command_background=true
> pidfile="/run/guix-daemon.pid"

Great!

> The above is a modification of Vincent's code in order to make it run for me without using the @localstatedir@ variable.

Does it still use the "correct" local state directory? Normally that's
'/var/guix' but I'm not sure what Parabola does.

> I would like to get this working with the packaged version of guix in parabola https://www.parabola.nu/packages/?q=guix

Is it not working now? What remains to be done, aside from updating the
packages?

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 01/28] nix/local.mk: Add missing comment to sysvinit section.
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 23 May 2020 12:38:02 +0000
Resent-Message-ID: <handler.40601.B.159023743919875 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.159023743919875
          (code B ref -1); Sat, 23 May 2020 12:38:02 +0000
Received: (at submit) by debbugs.gnu.org; 23 May 2020 12:37:19 +0000
Received: from localhost ([127.0.0.1]:33627 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcTOu-0005AT-S8
	for submit <at> debbugs.gnu.org; Sat, 23 May 2020 08:37:19 -0400
Received: from lists.gnu.org ([209.51.188.17]:58158)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jcTOp-0005AB-1o
 for submit <at> debbugs.gnu.org; Sat, 23 May 2020 08:37:15 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53222)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jcTOo-0005Pb-RA
 for guix-patches@HIDDEN; Sat, 23 May 2020 08:37:10 -0400
Received: from tobias.gr ([2a02:c205:2020:6054::1]:58566)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jcTOj-0006r1-DM
 for guix-patches@HIDDEN; Sat, 23 May 2020 08:37:10 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id e80e6272;
 Sat, 23 May 2020 12:37:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=DAGnb1MugpwtJGajSw0l8E
 rHo4o5b5EYsKEneLgRRUw=; b=gtFQRegGkNahF08wrnSIBD+uSkAjbkOFxY5DRz
 TeRun6Ft0g4buyxNkeSynKk1xJlufHuf95mexI6pcDlTiJDrFfYV1DVulTp0/s0o
 COegQs9hGHz68Xuu9IgOFRdDmlbVBuPIXBYRaoUsuA7wHlcdyO3Jn5rg5nFh7ctF
 kCKYPYL+P0SgYd25WyS0RmnPHC9JUxdmo+VBmw6DeY0BM9Oxwb26lNA3/u0ZwECH
 r5RzpXQqwcmxIjMVpIMrK1hmp5Rr8rr8eEofxNf8LVXJMBmEOA6wEK5BBmWmw0XU
 EP4gQo1UvS+dRBt1FtDm0FDT72qPdBKjI/kOTz5xwSkDFI+w==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 96318764
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 23 May 2020 12:37:00 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <20200517171725.732-1-vincent.legoll@HIDDEN>
In-reply-to: <20200517171725.732-1-vincent.legoll@HIDDEN>
Date: Sat, 23 May 2020 14:36:59 +0200
Message-ID: <874ks6x1xw.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Vincent Legoll =E5=86=99=E9=81=93=EF=BC=9A
> * nix/local.mk (sysvinit): Add comment.

LGTM.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXskY6wAKCRANsP+IT1Vt
eSlVAQDzCE8QDvCiBo5NUlRIo7XYfsKZKGKMWddIzrLJlNgwOgD/TUQL+Q4X9y7p
VGvvHGRGdUCj8GlogqccnJmLVBmDyQQ=
=58iO
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 01/28] nix/local.mk: Add missing comment to sysvinit section.
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 23 May 2020 12:38:02 +0000
Resent-Message-ID: <handler.40601.B40601.159023743219857 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159023743219857
          (code B ref 40601); Sat, 23 May 2020 12:38:02 +0000
Received: (at 40601) by debbugs.gnu.org; 23 May 2020 12:37:12 +0000
Received: from localhost ([127.0.0.1]:33623 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcTOm-0005A8-Ca
	for submit <at> debbugs.gnu.org; Sat, 23 May 2020 08:37:12 -0400
Received: from tobias.gr ([80.241.217.52]:34362)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jcTOg-00059d-Md
 for 40601 <at> debbugs.gnu.org; Sat, 23 May 2020 08:37:07 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id e80e6272;
 Sat, 23 May 2020 12:37:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=DAGnb1MugpwtJGajSw0l8E
 rHo4o5b5EYsKEneLgRRUw=; b=gtFQRegGkNahF08wrnSIBD+uSkAjbkOFxY5DRz
 TeRun6Ft0g4buyxNkeSynKk1xJlufHuf95mexI6pcDlTiJDrFfYV1DVulTp0/s0o
 COegQs9hGHz68Xuu9IgOFRdDmlbVBuPIXBYRaoUsuA7wHlcdyO3Jn5rg5nFh7ctF
 kCKYPYL+P0SgYd25WyS0RmnPHC9JUxdmo+VBmw6DeY0BM9Oxwb26lNA3/u0ZwECH
 r5RzpXQqwcmxIjMVpIMrK1hmp5Rr8rr8eEofxNf8LVXJMBmEOA6wEK5BBmWmw0XU
 EP4gQo1UvS+dRBt1FtDm0FDT72qPdBKjI/kOTz5xwSkDFI+w==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 96318764
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 23 May 2020 12:37:00 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <20200517171725.732-1-vincent.legoll@HIDDEN>
In-reply-to: <20200517171725.732-1-vincent.legoll@HIDDEN>
Date: Sat, 23 May 2020 14:36:59 +0200
Message-ID: <874ks6x1xw.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Vincent Legoll =E5=86=99=E9=81=93=EF=BC=9A
> * nix/local.mk (sysvinit): Add comment.

LGTM.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXskY6wAKCRANsP+IT1Vt
eSlVAQDzCE8QDvCiBo5NUlRIo7XYfsKZKGKMWddIzrLJlNgwOgD/TUQL+Q4X9y7p
VGvvHGRGdUCj8GlogqccnJmLVBmDyQQ=
=58iO
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 04/28] guix-install.sh: Handle local binary tarball file.
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 23 May 2020 13:43:02 +0000
Resent-Message-ID: <handler.40601.B.159024133126024 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.159024133126024
          (code B ref -1); Sat, 23 May 2020 13:43:02 +0000
Received: (at submit) by debbugs.gnu.org; 23 May 2020 13:42:11 +0000
Received: from localhost ([127.0.0.1]:33727 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcUPi-0006le-P7
	for submit <at> debbugs.gnu.org; Sat, 23 May 2020 09:42:10 -0400
Received: from lists.gnu.org ([209.51.188.17]:44830)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jcUPh-0006lY-Vv
 for submit <at> debbugs.gnu.org; Sat, 23 May 2020 09:42:10 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:57722)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jcUPh-0007q5-OV
 for guix-patches@HIDDEN; Sat, 23 May 2020 09:42:09 -0400
Received: from tobias.gr ([2a02:c205:2020:6054::1]:59886)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jcUPg-0000o8-IJ
 for guix-patches@HIDDEN; Sat, 23 May 2020 09:42:09 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id fb3e81e5;
 Sat, 23 May 2020 13:42:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:message-id:references:in-reply-to:date:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=NnimctCCTpwOeR+Wis3my9
 +mRPjRUynRtFK3qTXEq9o=; b=SCcWGGXJ++JVmsqK5fXKjFmyZw9Wg7i6A4CpOw
 0MKF5etjBH1iv+HIjBr44jQ74m4VrQ9Et/hRC5xeQwTiqP5EDYsg3xEFhXd0LsU9
 yJPGa50f1UuADcJa47KNwpxrAfL6Uyl/oxYMRpySwFtm3vhSEuLN82/M7QvWOati
 EC5VMWj2UPHfC1CcBr8h3zXWIYHOsXjZJJA6QGNqUd557ljHE4AkCREOih255oll
 1wj/bakGOa+auN/sj3LQfyaxylD8SFrBOeAeQSs8vm+asmxcm7/Mmi4Fl8wDHo4p
 HSox3rvBRZW7ISs6Q3d7JqGNQnE4zUIjP24H3j3c9eAK1edg==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 876f6059
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 23 May 2020 13:42:05 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
Message-ID: <87zh9yvkz1.fsf@nckx>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
 <20200517171725.732-4-vincent.legoll@HIDDEN>
In-reply-to: <20200517171725.732-4-vincent.legoll@HIDDEN>
Date: Sat, 23 May 2020 15:42:04 +0200
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Vincent,

I've pushed the first three patches with some commit message=20
tweaks.

Vincent Legoll =E5=86=99=E9=81=93=EF=BC=9A
> * etc/guix-install.sh (REQUIRE): add realpath.
> (main): Handle local binary tarball file path passed as first=20
> arg.

=E2=80=98file name=E2=80=99, =E2=80=98argument=E2=80=99.

I'm OK with this change in general but it needs to be documented=20
*somewhere*: in (guix)Binary Installation and/or a (new) --help=20
message and/or an =E2=80=98Invocation:=E2=80=99 comment at the top of the s=
cript.

I notice you ran out of commit message energy halfway through the=20
series :-)  While I've come to love Guix's discipline, I=20
sympathise, but what's the plan?

Thanks,

T G-R


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXskoLAAKCRANsP+IT1Vt
efgiAQD9JmkZKXK80464HeoqC+xwOoT8jtlbQ70s9hZgyH9grQD/VOcg/HI1WsMn
qjz5g7JD78SXuyb76z6m5ibGbqlPxAU=
=QAHd
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 04/28] guix-install.sh: Handle local binary tarball file.
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 23 May 2020 13:43:02 +0000
Resent-Message-ID: <handler.40601.B40601.159024133826044 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159024133826044
          (code B ref 40601); Sat, 23 May 2020 13:43:02 +0000
Received: (at 40601) by debbugs.gnu.org; 23 May 2020 13:42:18 +0000
Received: from localhost ([127.0.0.1]:33729 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcUPn-0006lw-0r
	for submit <at> debbugs.gnu.org; Sat, 23 May 2020 09:42:18 -0400
Received: from tobias.gr ([80.241.217.52]:35682)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jcUPf-0006lT-8D
 for 40601 <at> debbugs.gnu.org; Sat, 23 May 2020 09:42:12 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id fb3e81e5;
 Sat, 23 May 2020 13:42:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:message-id:references:in-reply-to:date:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=NnimctCCTpwOeR+Wis3my9
 +mRPjRUynRtFK3qTXEq9o=; b=SCcWGGXJ++JVmsqK5fXKjFmyZw9Wg7i6A4CpOw
 0MKF5etjBH1iv+HIjBr44jQ74m4VrQ9Et/hRC5xeQwTiqP5EDYsg3xEFhXd0LsU9
 yJPGa50f1UuADcJa47KNwpxrAfL6Uyl/oxYMRpySwFtm3vhSEuLN82/M7QvWOati
 EC5VMWj2UPHfC1CcBr8h3zXWIYHOsXjZJJA6QGNqUd557ljHE4AkCREOih255oll
 1wj/bakGOa+auN/sj3LQfyaxylD8SFrBOeAeQSs8vm+asmxcm7/Mmi4Fl8wDHo4p
 HSox3rvBRZW7ISs6Q3d7JqGNQnE4zUIjP24H3j3c9eAK1edg==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 876f6059
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 23 May 2020 13:42:05 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
Message-ID: <87zh9yvkz1.fsf@nckx>
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
 <20200517171725.732-4-vincent.legoll@HIDDEN>
In-reply-to: <20200517171725.732-4-vincent.legoll@HIDDEN>
Date: Sat, 23 May 2020 15:42:04 +0200
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Vincent,

I've pushed the first three patches with some commit message=20
tweaks.

Vincent Legoll =E5=86=99=E9=81=93=EF=BC=9A
> * etc/guix-install.sh (REQUIRE): add realpath.
> (main): Handle local binary tarball file path passed as first=20
> arg.

=E2=80=98file name=E2=80=99, =E2=80=98argument=E2=80=99.

I'm OK with this change in general but it needs to be documented=20
*somewhere*: in (guix)Binary Installation and/or a (new) --help=20
message and/or an =E2=80=98Invocation:=E2=80=99 comment at the top of the s=
cript.

I notice you ran out of commit message energy halfway through the=20
series :-)  While I've come to love Guix's discipline, I=20
sympathise, but what's the plan?

Thanks,

T G-R


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXskoLAAKCRANsP+IT1Vt
efgiAQD9JmkZKXK80464HeoqC+xwOoT8jtlbQ70s9hZgyH9grQD/VOcg/HI1WsMn
qjz5g7JD78SXuyb76z6m5ibGbqlPxAU=
=QAHd
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 04/28] guix-install.sh: Handle local binary tarball file.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 23 May 2020 21:38:02 +0000
Resent-Message-ID: <handler.40601.B.159026983624005 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tobias Geerinckx-Rice <me@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.159026983624005
          (code B ref -1); Sat, 23 May 2020 21:38:02 +0000
Received: (at submit) by debbugs.gnu.org; 23 May 2020 21:37:16 +0000
Received: from localhost ([127.0.0.1]:35882 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcbpU-0006F6-4q
	for submit <at> debbugs.gnu.org; Sat, 23 May 2020 17:37:16 -0400
Received: from lists.gnu.org ([209.51.188.17]:42874)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jcbpS-0006Ex-LY
 for submit <at> debbugs.gnu.org; Sat, 23 May 2020 17:37:15 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:36974)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <vincent.legoll@HIDDEN>)
 id 1jcbpS-00079V-Dr
 for guix-patches@HIDDEN; Sat, 23 May 2020 17:37:14 -0400
Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:46418)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <vincent.legoll@HIDDEN>)
 id 1jcbpR-0008CQ-Go
 for guix-patches@HIDDEN; Sat, 23 May 2020 17:37:14 -0400
Received: by mail-wr1-x441.google.com with SMTP id x6so111273wrm.13
 for <guix-patches@HIDDEN>; Sat, 23 May 2020 14:37:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=JDjMyiiGZXX2gIL5WY1pMu2iq/YT0mEb0yys4tJHvxw=;
 b=X5sP21NFaif3G312bi7ddxE6Duxs2EyZScktsxw+hv1RtEDxiBZY/G3QIw5u448VMM
 bJhbiDMcKxnjbUx6PBCBgee8K0d8jTR7meNyYp9/ev0MCmsGrrDC24LBezLm8P0VycF4
 c9YgsAy8fC8fXumo9w2hEiHQuqp7iT94fBFLhx99OnsGHZDBGVpN4t5LwwclCTPz9NqN
 1LhcK7Ga0P2cn8nNqXWohUsZsdv3TJOOeFTC2x5cb7TYhD8mFbO3Dy3FWgkFDQnw1p41
 wcwO3VIk/o45g+6znod0ulQt5r7lzqKmVL6HoiRc0xOUOBPZI7IEpWzjw0HhNj7uFXMR
 j4dg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=JDjMyiiGZXX2gIL5WY1pMu2iq/YT0mEb0yys4tJHvxw=;
 b=SpPBUGvrGZvu6xlKdEY8ro3vh/wxCjZJZscrM8MSUpD7EsnesKPEiC0nJdmq6ro/Z2
 ttH+BdLCTsLwjexMVYqyIUd6crdTbTN8/MvGyB+eVJPYdahVnEEa6JyuQ3UIhIDlB39A
 ASBIRZHBrkaVQePOcjxzAO4icsBzzKRFyHeC6PsxpA8rWTQk6AsA3VzkA83AU+Lcxc59
 rfIZx7KshyeDlGcjwipUCW8X9ToSTBuSy5WfmoervVU/HPM9v8TDY47UGIc4zIhsEwri
 CxDk+MXM+Yzo7tI34mEyNyDhwseoGGjyxi7ukuL0O+o+F0cWT2zW/pT2AKCuedhjoj68
 +f1A==
X-Gm-Message-State: AOAM533D7UvhCDlV+zYJ/30UuihC4EuBLY7jhTd0fUge5aNncEIt5tM/
 +Dh78xtiZVRv0T94S6N1CZRW7F01
X-Google-Smtp-Source: ABdhPJwlu5fiIkAfVHkxBn4FC2bSazmjnWrm7U8Y2iBllMAsYQp+y8D7CM71muBliaxe73nk8pQCOA==
X-Received: by 2002:a5d:6145:: with SMTP id y5mr8031146wrt.195.1590269831522; 
 Sat, 23 May 2020 14:37:11 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id n4sm12711553wmc.31.2020.05.23.14.37.09
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 May 2020 14:37:10 -0700 (PDT)
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
 <20200517171725.732-4-vincent.legoll@HIDDEN> <87zh9yvkz1.fsf@nckx>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <5c082fbc-c436-a415-03ea-4f45aa41b861@HIDDEN>
Date: Sat, 23 May 2020 23:37:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <87zh9yvkz1.fsf@nckx>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::441;
 envelope-from=vincent.legoll@HIDDEN; helo=mail-wr1-x441.google.com
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001,
 URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

On 23/05/2020 15:42, Tobias Geerinckx-Rice wrote:
> Vincent,
> 
> I've pushed the first three patches with some commit message tweaks.

Thanks & thanks

> Vincent Legoll 写道：
>> * etc/guix-install.sh (REQUIRE): add realpath.
>> (main): Handle local binary tarball file path passed as first arg.
> 
> ‘file name’, ‘argument’.
> 
> I'm OK with this change in general but it needs to be documented 
> *somewhere*: in (guix)Binary Installation and/or a (new) --help message 
> and/or an ‘Invocation:’ comment at the top of the script.
> 
> I notice you ran out of commit message energy halfway through the series 
> :-)  While I've come to love Guix's discipline, I sympathise, but what's 
> the plan?

I was off duty at dayjob cause of covid partial unemployment last week,
that's why I got more time to work on guix. I have resumed work this
week so it explains the slowdown ;-)

The plan is that I'll continue working on this series to polish the
commit messages that need to be. I just wanted to send the series to
have the ACKs that it will not be lost work, before continuing.

I've got ACKs, so I'll work on finishing the pending patches, before
embarking on more TODO items. And doc is one item from that TODO list.
I'll put it on top.

But even if dev speed is lower, I'm committed to finish this.

-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 04/28] guix-install.sh: Handle local binary tarball file.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 23 May 2020 21:38:02 +0000
Resent-Message-ID: <handler.40601.B40601.159026984124023 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tobias Geerinckx-Rice <me@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 40601 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159026984124023
          (code B ref 40601); Sat, 23 May 2020 21:38:02 +0000
Received: (at 40601) by debbugs.gnu.org; 23 May 2020 21:37:21 +0000
Received: from localhost ([127.0.0.1]:35885 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jcbpZ-0006FP-EC
	for submit <at> debbugs.gnu.org; Sat, 23 May 2020 17:37:21 -0400
Received: from mail-wr1-f68.google.com ([209.85.221.68]:41854)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jcbpV-0006Et-DZ
 for 40601 <at> debbugs.gnu.org; Sat, 23 May 2020 17:37:17 -0400
Received: by mail-wr1-f68.google.com with SMTP id h17so13694454wrc.8
 for <40601 <at> debbugs.gnu.org>; Sat, 23 May 2020 14:37:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=JDjMyiiGZXX2gIL5WY1pMu2iq/YT0mEb0yys4tJHvxw=;
 b=X5sP21NFaif3G312bi7ddxE6Duxs2EyZScktsxw+hv1RtEDxiBZY/G3QIw5u448VMM
 bJhbiDMcKxnjbUx6PBCBgee8K0d8jTR7meNyYp9/ev0MCmsGrrDC24LBezLm8P0VycF4
 c9YgsAy8fC8fXumo9w2hEiHQuqp7iT94fBFLhx99OnsGHZDBGVpN4t5LwwclCTPz9NqN
 1LhcK7Ga0P2cn8nNqXWohUsZsdv3TJOOeFTC2x5cb7TYhD8mFbO3Dy3FWgkFDQnw1p41
 wcwO3VIk/o45g+6znod0ulQt5r7lzqKmVL6HoiRc0xOUOBPZI7IEpWzjw0HhNj7uFXMR
 j4dg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=JDjMyiiGZXX2gIL5WY1pMu2iq/YT0mEb0yys4tJHvxw=;
 b=adWwJ9VtTzT3uKcbRRmMpBw9WpUUXYfZwXWKWj/KNKszwclbcQk++wQjSMi5MecBXL
 a29ICxQ0fSbzxl0iJySkmr05+j3+ciPmMH/bIfUTa0R/bpEoFit83zkIw8awiL13Nejm
 EKQlXn8lKbHor0YLAvSTVXwklueq3rHywkt+hSIdmcWe8GdkNp7qaNMZWlqD6s/rkm+y
 VVmuJj1TQrCg+/WysgPdzkVW68D3e/shg6WtSk8EZk0k/nBBg53u9Xd8QglPa3KCOxSE
 s46TlkV5kuQGrGnSjg5QMNUOkFdl0XzNzPykVQBcfCDKJf74STa73CHKz/P8Xvqe8g7g
 I1jg==
X-Gm-Message-State: AOAM530ykVK+EMk8qr4pyYeBQb5SOwxU9xKrjkH1xq6GPvuMWXBKRLl+
 YScJ4tFHZPXNu9m1Beye+mo=
X-Google-Smtp-Source: ABdhPJwlu5fiIkAfVHkxBn4FC2bSazmjnWrm7U8Y2iBllMAsYQp+y8D7CM71muBliaxe73nk8pQCOA==
X-Received: by 2002:a5d:6145:: with SMTP id y5mr8031146wrt.195.1590269831522; 
 Sat, 23 May 2020 14:37:11 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id n4sm12711553wmc.31.2020.05.23.14.37.09
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 May 2020 14:37:10 -0700 (PDT)
References: <20200517171725.732-1-vincent.legoll@HIDDEN>
 <20200517171725.732-4-vincent.legoll@HIDDEN> <87zh9yvkz1.fsf@nckx>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <5c082fbc-c436-a415-03ea-4f45aa41b861@HIDDEN>
Date: Sat, 23 May 2020 23:37:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <87zh9yvkz1.fsf@nckx>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 23/05/2020 15:42, Tobias Geerinckx-Rice wrote:
> Vincent,
> 
> I've pushed the first three patches with some commit message tweaks.

Thanks & thanks

> Vincent Legoll 写道：
>> * etc/guix-install.sh (REQUIRE): add realpath.
>> (main): Handle local binary tarball file path passed as first arg.
> 
> ‘file name’, ‘argument’.
> 
> I'm OK with this change in general but it needs to be documented 
> *somewhere*: in (guix)Binary Installation and/or a (new) --help message 
> and/or an ‘Invocation:’ comment at the top of the script.
> 
> I notice you ran out of commit message energy halfway through the series 
> :-)  While I've come to love Guix's discipline, I sympathise, but what's 
> the plan?

I was off duty at dayjob cause of covid partial unemployment last week,
that's why I got more time to work on guix. I have resumed work this
week so it explains the slowdown ;-)

The plan is that I'll continue working on this series to polish the
commit messages that need to be. I just wanted to send the series to
have the ACKs that it will not be lost work, before continuing.

I've got ACKs, so I'll work on finishing the pending patches, before
embarking on more TODO items. And doc is one item from that TODO list.
I'll put it on top.

But even if dev speed is lower, I'm committed to finish this.

-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] New reduced patchset, the easy bits first
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:42:01 +0000
Resent-Message-ID: <handler.40601.B40601.159095770927837 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095770927837
          (code B ref 40601); Sun, 31 May 2020 20:42:01 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:41:49 +0000
Received: from localhost ([127.0.0.1]:33922 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUmC-0007Eu-Vp
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:41:49 -0400
Received: from mail-wr1-f53.google.com ([209.85.221.53]:35111)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUmB-0007Ej-AG
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:41:47 -0400
Received: by mail-wr1-f53.google.com with SMTP id x14so9516831wrp.2
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:41:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=to:from:subject:message-id:date:user-agent:mime-version
 :content-language:content-transfer-encoding;
 bh=5lsUWNnchBATOToUTujnpUafpNivmzBMu+kWxBmp3wo=;
 b=d2LIYt3dxk9Oh7YujEsn9HFS+WYLDbJe6nDZ7sgX9CwpbqO8fIWMcBzG321UJEnh/I
 0Px4Xkr8RZa4oGEyEQrWo8XWjalJFayR0Bs8mqm5edIf+jRl7bey1mb+2NFKML9wWEUA
 iEXB+mrmpaw2OnrZIJCAZaw0Xfg+JjkPR1bR8RICh7kQdKeHJbRk9nFyzDIGHGG3Hk29
 Hc0v82DLWIXXwRwx3iBOKBXfDj295dC8OEZxzDGR2Ja0mVZ3vw1b73xqho2N0Kf0vqRk
 Cm6n5qsZK7CVN6+W96WgXCMi/LDLrfFIIsLYQAOVp957H1QF85Qb/Xy/OoNpIwtG0Vn5
 YSdg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:to:from:subject:message-id:date:user-agent
 :mime-version:content-language:content-transfer-encoding;
 bh=5lsUWNnchBATOToUTujnpUafpNivmzBMu+kWxBmp3wo=;
 b=GGVIabmNCPQAg5r18pNde4No1W3qHOGhNXqxZEpklatY6wgiJGAV0SlvUdbZ4vCHMx
 QSlR06h+TH9Kb3276dY32K5wS7u1vMmTl1UddK09MDX7h+SmaxAA/pAEbsJrRtBNFQKG
 ZGq0bAFXPb5lAEzHswg7wLFWJYD0VzVv3aNfuY1GEM8Nz5n5yS4vu8CM2g+ODRwseGgy
 SGjn6pMCOKzoBugdsHnyINBm6f/YDPLewV99x5OW0V3ngvKrjKnhRmQjzwp/q+6ke6vW
 pZgwtPU41hc1YDDG/z8OG1SYnfXXceYnGFGS+NYIfe5QhkfSatTmg4dmxqpmxW5/yZS7
 CDSQ==
X-Gm-Message-State: AOAM53262YcF9MXHImZ9HMuuDx9Ro+y6emGLZ5qG5wFbeSABhnkM6TOV
 t0Cd1Cf8LreXBNG4NU3hbmI=
X-Google-Smtp-Source: ABdhPJwPqzTqIrRIFwaLrjWded2FGe6BvDBWd3Y+nVmsXpWceMBdLr7P2dcfIwFx7uQMAK3Pcmk2OA==
X-Received: by 2002:adf:f990:: with SMTP id f16mr18254832wrr.311.1590957701337; 
 Sun, 31 May 2020 13:41:41 -0700 (PDT)
Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id s2sm8343817wmh.11.2020.05.31.13.41.40
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 31 May 2020 13:41:40 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Message-ID: <00b505a4-0c1a-2f6c-7242-57d7b5eb7d4f@HIDDEN>
Date: Sun, 31 May 2020 22:41:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

The patch series is becoming long. So here is a batch of fairly easy
ones, to lighten it a bit.

-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 1/7] guix-install.sh: Remove "[[" bashisms in chk_init_sys().
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:44:02 +0000
Resent-Message-ID: <handler.40601.B40601.159095781028003 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095781028003
          (code B ref 40601); Sun, 31 May 2020 20:44:02 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:30 +0000
Received: from localhost ([127.0.0.1]:33927 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUnq-0007Ha-AQ
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:30 -0400
Received: from mail-wm1-f66.google.com ([209.85.128.66]:55926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUno-0007HI-RD
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:29 -0400
Received: by mail-wm1-f66.google.com with SMTP id c71so8818321wmd.5
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:43:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=VUi2SsoAaClYlftOEEn4+ZZHwioAk5gIhNv99Z/xAq0=;
 b=lz4jDi4PgkVXEunwZe5/L0FqdbBzb29qV7tb4rOqmVVtAcUxY+a9uSIHPvJa384Qe8
 FQqTmNr4TMHMIYSPx/1dZhFJkZSIo6jp4SYqEUkmZOX/kgmKSkcRouG/8gdAs3lgW5I5
 ohjKHUQ8C8mdapt7d68RS6wOrrOq9sCH1MQNVjpAUvI4GnFejJVTJnriYznQGCZ65Wjs
 K0q4dMk8R3K7FqlpHvIjdenM9x8YhhdE5TWFXMjZeq5SSn5jlPIbNl0ZcFslrZuWahlX
 PPHlyUyPSmHsRUP45pqfbGITEqPalT5748XI+3G+gZCshqkFYLpB1/XZg6nXGpfuS4so
 j4sw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=VUi2SsoAaClYlftOEEn4+ZZHwioAk5gIhNv99Z/xAq0=;
 b=I0O0DLPRhr1mqtTER1hAngeNNk+9GuIHWd30GCe+05v0G/fMCyo/zi2ZSiwRjzLRq/
 3aP3AK0Pfwzhpo85xn7klU5bzQA4Bz0OqLNNsrxvYuPHXN+PNOyxXstYZgoxJaQp/uic
 h52fyqscwzEqtj/SxtkagfnYFIinwJLPrPkzdhOA5D1bPNlyaoJ2iQK7eeni9rfoXsA8
 vgbPt1siwgZVlXYCBbCp6PrjLG0zAsv6qjOTti7uV0WqcICYXLF3TeazroShb1q2aluU
 ILHPN/CaRkuRW3lFiZo03QDIUsJWyfYIXLAbNGdkTzX2hIBl4kh7R8hulDkWtwMVMMa1
 V+mg==
X-Gm-Message-State: AOAM531bj3n0oaTWJYzA2e/aPjoro8tCpadG3tS8BKVUurkQl+RUUHqE
 cQNkIogPQ6wsP1y3vt5zcqE43z4G
X-Google-Smtp-Source: ABdhPJyztxevd+eNeK949jqIBb+zv1IZ+ZmuUQHQN8PkLxiCVXeKaqSpzeNanKV7gXw+tf0B/pOdhQ==
X-Received: by 2002:a1c:3281:: with SMTP id y123mr18385728wmy.30.1590957802838; 
 Sun, 31 May 2020 13:43:22 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 May 2020 13:43:22 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 31 May 2020 22:42:51 +0200
Message-Id: <20200531204257.18725-1-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (chk_init_sys): Use `if something | grep' instead of "[["
pattern matching.
---
 etc/guix-install.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index bf15aede21..455e021684 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -138,11 +138,11 @@ chk_term()
 
 chk_init_sys()
 { # Return init system type name.
-    if [[ $(/sbin/init --version 2>/dev/null) =~ upstart ]]; then
+    if /sbin/init --version 2>/dev/null | grep -q upstart; then
         _msg "${INF}init system is: upstart"
         INIT_SYS="upstart"
         return 0
-    elif [[ $(systemctl 2>/dev/null) =~ -\.mount ]]; then
+    elif systemctl 2>/dev/null | grep -q -- -\.mount; then
         _msg "${INF}init system is: systemd"
         INIT_SYS="systemd"
         return 0
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 3/7] guix-install.sh: Fix requirements.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:44:02 +0000
Resent-Message-ID: <handler.40601.B40601.159095781428036 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095781428036
          (code B ref 40601); Sun, 31 May 2020 20:44:02 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:34 +0000
Received: from localhost ([127.0.0.1]:33933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUnt-0007I0-Jh
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:33 -0400
Received: from mail-wr1-f49.google.com ([209.85.221.49]:40888)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUnq-0007HM-HQ
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:30 -0400
Received: by mail-wr1-f49.google.com with SMTP id h5so3530683wrc.7
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:43:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=GJJzgbrgLVaptOy2PM7dKVjOxXb+kggJzpf/j2QH2c4=;
 b=OZf7FDVIWDW/9ePukfR8zbfYu79EONj4xiEux96VmBNwr3p59GdkwTApjdo40GmMIq
 nsq7PhkCxNPVkimEDK8hoJLtW9GxtylfGfbLXVgS1Q/Q6D741UYIK5Rgt3gI3GId/1v4
 xf2VYRjhWKdnNJKXc2fA0TykNJubxMeL0EpJ0dXOS+Vl02i9udO/YA3CrwEvaMANMToQ
 1wqsAzuakCw2GGEFtN2H10LuJyRAUn4UO5V8ZqB4vBOW3wpGgIJXDwz24x9xZEYvNTwC
 /NRhiehf0aA0x1W7a00Sp5wiPnhskKydVJVnq3rmhKnrEmZDJApkwdYZVXdxykkQhqVC
 AckQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=GJJzgbrgLVaptOy2PM7dKVjOxXb+kggJzpf/j2QH2c4=;
 b=SqjSSzAdIDQZqHs+z3BQETnYvhJhuKD3W2Vnvm2immWMWniY6Lp5pMExYeK5G5Rkny
 o33bY7Z4e+ZtpXi/Os25X3YxbKyypD6EFV2HYtFwQY/ibdeTTnwpbLqDJoBvNl4tzeW3
 rwbvJvLGo2NdKAazfOW3v7XiTFbFrYg1GGwxGaUwrVclONzr8KB0VFYbUBI52zXnwSwH
 lL4Cw7B+gCLPMbcUcuFzr538pzUHRH+KBmZih/k/PouJKPuhLVdXPjvENkOgb0u9i2OK
 sASkLrWSmD2qE7GtcMBFtIzQNyXjJU+BhJJlP/+HB/mjm9jSkWI3e1derWa7+tQBq87M
 GzbA==
X-Gm-Message-State: AOAM532WFqGxo01LR9/nR79fA2boPrqTuDC/rhOU15rElTMEsdrCaX8P
 HhHURvoOGL2wQHcucGlffdovkokN
X-Google-Smtp-Source: ABdhPJwHJMpVEBpH9uaLXN6S0JhctFbj4t2gg/2og9vLQC7rWqEliX/7oo3lyvhGCUjN8Z5ThY3ryg==
X-Received: by 2002:a05:6000:104f:: with SMTP id
 c15mr11922351wrx.391.1590957804726; 
 Sun, 31 May 2020 13:43:24 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.23
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 May 2020 13:43:24 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 31 May 2020 22:42:53 +0200
Message-Id: <20200531204257.18725-3-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200531204257.18725-1-vincent.legoll@HIDDEN>
References: <20200531204257.18725-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

There's no usage of "tr" in the script, whereas tar is used.

* etc/guix-install.sh (REQUIRE): Change tr to tar, add ln, remove
readlink & dirname.
---
 etc/guix-install.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 0d7a8c8d44..28fcf831c5 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -32,8 +32,6 @@ set -e
 [ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
 
 REQUIRE=(
-    "dirname"
-    "readlink"
     "wget"
     "gpg"
     "grep"
@@ -41,13 +39,14 @@ REQUIRE=(
     "sed"
     "sort"
     "getent"
+    "ln"
     "mktemp"
     "rm"
     "chmod"
     "uname"
     "groupadd"
     "tail"
-    "tr"
+    "tar"
     "xz"
 )
 
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 4/7] guix-install.sh: trivial whitespace fix.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:44:03 +0000
Resent-Message-ID: <handler.40601.B40601.159095781428043 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095781428043
          (code B ref 40601); Sun, 31 May 2020 20:44:03 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:34 +0000
Received: from localhost ([127.0.0.1]:33935 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUnt-0007I9-Su
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:34 -0400
Received: from mail-wr1-f67.google.com ([209.85.221.67]:46391)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUnr-0007HO-H8
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:31 -0400
Received: by mail-wr1-f67.google.com with SMTP id x6so9377749wrm.13
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:43:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=2/qLmiMk4MM5dHyyygZ79L/cRmb1Z9Gsz1obqa2+FXc=;
 b=euysIlUFMSwNwZKXSx69yZSt51lNzlK2WisyKbquZiVVEC++lYepwq/fukNkUVslp7
 XtKZ6OvG2QkOJf8ERcpjlujvvIZLpM5Dr0B6QXgE2SGfz2MJAyGDVSk1HJijM5ZHO7CX
 n0nSd+bJ/TokHJF5Z5MJmQSbD+oooJrFRmMZeUkV8h2DbZyuqbTjv1++KqCGkJxEixLV
 wKEGSweWAgt44iVN2aZ1sKsMdZWZbO6DwVWDAGA2O6DOli+sSSNM38jeXubTeL++vBPa
 hpi12SATAgXt1jV9Rr4j5KIH14rs9Y4OkEn5jMMFX2VCRtrrhqm2N9MbMirI6hmFs9Zr
 hAgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=2/qLmiMk4MM5dHyyygZ79L/cRmb1Z9Gsz1obqa2+FXc=;
 b=r2zHQjo73IfmXOkah6QeRCDo7HuVqIi0wOgbhPZu+UMJKodTKKT/+Lb9j540FNnvt8
 c03R5eTZ/GkIrDQjyDaz2sNwqLILqScx1ZDft1K3NilwjdS+pdw5CqokCFHYiip9Nqvm
 JHPx7IuXUHSC7ojlcwy+CJ6YKw5I5j7W4ZeYppfXeV4AanA3JZ8qxv7T9YWxgAb34dTM
 E0VX9vL36yGQ4BGJz/a1YZ4RL4oV5w/JExtOnd3/ej4bvRLo/xTSEGM1c+geJExO71FE
 omHyCUQRT0QB+p8i7GC5vqn57MmKZI/0UzMTkFusyvF1H55CfbmeOrLLFSuhCunU17Pd
 y2ew==
X-Gm-Message-State: AOAM5324z3Wq3ZHAoQUdwOhXElKqMOb2H2Z8O73EQCdElg/A1E4PQ5Uv
 Y0Nd/iHMYz3ZGsdOh/RWiGN2uKRk
X-Google-Smtp-Source: ABdhPJwTGli9gD4UUNPUBKnItVhYroOM1YtOE4U7M23vGpXwQiAXXOvW/JtDmJC0KW2pBqxDnGegGw==
X-Received: by 2002:adf:e908:: with SMTP id f8mr18582718wrm.184.1590957805650; 
 Sun, 31 May 2020 13:43:25 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 May 2020 13:43:25 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 31 May 2020 22:42:54 +0200
Message-Id: <20200531204257.18725-4-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200531204257.18725-1-vincent.legoll@HIDDEN>
References: <20200531204257.18725-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Almost the entire file is indented with spaces, a few tabs slipped in, clean
them up.

Checked triviality with git diff -b.

* etc/guix-install.sh(chk_sys_arch): Replace tabs with spaces.
(sys_enable_guix_daemon): Likewise.
---
 etc/guix-install.sh | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 28fcf831c5..14616f790b 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -173,9 +173,9 @@ chk_sys_arch()
         aarch64)
             local arch=aarch64
             ;;
-	armv7l)
-	    local arch=armhf
-	    ;;
+        armv7l)
+            local arch=armhf
+            ;;
         *)
             _err "${ERR}Unsupported CPU type: ${arch}"
             exit 1
@@ -355,15 +355,15 @@ sys_enable_guix_daemon()
                  /etc/systemd/system/;
               chmod 664 /etc/systemd/system/guix-daemon.service;
 
-	      # Work around <https://bugs.gnu.org/36074>, present in 1.0.1.
-	      sed -i /etc/systemd/system/guix-daemon.service \
-	          -e "s/GUIX_LOCPATH='/'GUIX_LOCPATH=/";
+              # Work around <https://bugs.gnu.org/36074>, present in 1.0.1.
+              sed -i /etc/systemd/system/guix-daemon.service \
+                  -e "s/GUIX_LOCPATH='/'GUIX_LOCPATH=/";
 
-	      # Work around <https://bugs.gnu.org/35671>, present in 1.0.1.
-	      if ! grep en_US /etc/systemd/system/guix-daemon.service >/dev/null;
-	      then sed -i /etc/systemd/system/guix-daemon.service \
-		       -e 's/^Environment=\(.*\)$/Environment=\1 LC_ALL=en_US.UTF-8';
-	      fi;
+              # Work around <https://bugs.gnu.org/35671>, present in 1.0.1.
+              if ! grep en_US /etc/systemd/system/guix-daemon.service >/dev/null;
+              then sed -i /etc/systemd/system/guix-daemon.service \
+                  -e 's/^Environment=\(.*\)$/Environment=\1 LC_ALL=en_US.UTF-8';
+              fi;
 
               systemctl daemon-reload &&
                   systemctl start  gnu-store.mount guix-daemon &&
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 5/7] guix-install.sh: Add variable quoting in sys_make_guix_available.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:44:03 +0000
Resent-Message-ID: <handler.40601.B40601.159095781428050 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095781428050
          (code B ref 40601); Sun, 31 May 2020 20:44:03 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:34 +0000
Received: from localhost ([127.0.0.1]:33937 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUnu-0007IG-BP
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:34 -0400
Received: from mail-wm1-f48.google.com ([209.85.128.48]:50998)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUns-0007HQ-F5
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:32 -0400
Received: by mail-wm1-f48.google.com with SMTP id v19so8874267wmj.0
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:43:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=dL9ifNk6TuOaLGM005YpVnEuBAyXtpnon6mFwAi1oUY=;
 b=QwKf+sUxLEJ1dHDdbRD4tktL5frvxt5cqxjfTutXXQ4FV0XCMCzqu66U+rjc7zCkmO
 YdkrSnoI6RIOj2gyeA3ZhsjVSJjkmDTrZUU5fwwo15CMaAD893qu9CwLzij6s1LLHA9s
 +CXxhnOEJk5RfjL1StEt+ySwM44avGTaBqfssGnckxAwcBU6tqlZh1tjaIYzQjUsPAvq
 9CRwPHH0w/F8qp/ow56g3QXZa5jYGy/dhdEUZAlPfhTD/ejBb5/YYJvs+sWXRWqxtQsj
 HFbWbOrhgyjnwVhFP59wmRiTe2DkNRquWTZHO+zI+6CnWD8QB7Omol6p6CAH6kbgl6xW
 PKuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=dL9ifNk6TuOaLGM005YpVnEuBAyXtpnon6mFwAi1oUY=;
 b=rTE61HJ+QIIaeSyGjZr1LBjPXkqHsDzHfD3YB8nS6W/tb72kkXGdWtdYTMfITI4mD8
 2ovjekPphq+7VnziEFyb7abao09joZ9oof/YsFU5SYL3g0wjvqX7RvrIf3k368JhrSa9
 1HwxIxL4a7h+uBVsTn6veA0uEClPv9k65QyThS9N2Ne2hlLhouuOUMNlW7CaqrjT9NK+
 N9Th/mRCvGSVwMI/rpuu5srJKtqA+eY9gEKERI7vuBnxd5RwvxYYzu0pryjn1SunxXrb
 5uVMNJEO2n3GyOcSYOMd0xMGBL3gnLmUPnUR9V5rWbjns0IV1yaiXTipFZLwLEG2d5jI
 aFJw==
X-Gm-Message-State: AOAM531SaoerxXgDH/VpqhVKayYjt5Ctt/vau7eWhHDN2BhHmse5jyTn
 2OzMfmZXN9/UtawYR13Quq5OkeBe
X-Google-Smtp-Source: ABdhPJw/n9Ah3Dgs4bw+tutXjVkq57FL4Lhi+Te7qBYs9EDy8K7zlebIJGusTu7M7dwC4aGvgA9e2A==
X-Received: by 2002:a1c:80d4:: with SMTP id
 b203mr18569734wmd.138.1590957806631; 
 Sun, 31 May 2020 13:43:26 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 May 2020 13:43:26 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 31 May 2020 22:42:55 +0200
Message-Id: <20200531204257.18725-5-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200531204257.18725-1-vincent.legoll@HIDDEN>
References: <20200531204257.18725-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (sys_make_guix_available): Add variable quoting.
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 14616f790b..0e6e6842a1 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -393,7 +393,7 @@ sys_enable_guix_daemon()
     ln -sf "${var_guix}/bin/guix"  "$local_bin"
 
     [ -e "$info_path" ] || mkdir -p "$info_path"
-    for i in ${var_guix}/share/info/*; do
+    for i in "${var_guix}"/share/info/*; do
         ln -sf "$i" "$info_path"
     done
 }
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 6/7] guix-install.sh: Fix variable uses in guix_get_bin_list().
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:44:03 +0000
Resent-Message-ID: <handler.40601.B40601.159095783728091 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095783728091
          (code B ref 40601); Sun, 31 May 2020 20:44:03 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:57 +0000
Received: from localhost ([127.0.0.1]:33940 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUo3-0007In-Mx
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:57 -0400
Received: from mail-wr1-f67.google.com ([209.85.221.67]:37694)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUnt-0007HS-AY
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:33 -0400
Received: by mail-wr1-f67.google.com with SMTP id x13so9483465wrv.4
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:43:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=FNGy2kJNz0Llgz+YOnMLJPjsIHRK/neaz0idapHB0GA=;
 b=owt16Bm4xZZf+A+OvIRPqaspPIY/K7AXseb7pSYTDxsxz/WoynNSphjbYkeo4FwuFk
 1ynCKfSkE19AOJ0q28F29IcqEBhEPDager6tUIjZZr4ts8Ifo3tABk2RsHnSMtAgx0iI
 Qm0nhvR2QUr8x6yOs4d2XNWgrfu2chG01Mg8UodZhz3VCSMr6tDFUjJrYk9SDa+nw0dX
 SNS0p/GvugWcB307ENgfSPo3iUveepTZyZ68/cuWRLcugW/ybL7HMyNAYk2Eefsyaxte
 kc2IzSrvFxYZu4YPwAgQ3bVEwHAjsYOhqypZM8lrtUoC1kKqF5l49Vcc1HI/U/GmsOVs
 d2Vg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=FNGy2kJNz0Llgz+YOnMLJPjsIHRK/neaz0idapHB0GA=;
 b=VeaS/nEzSBicoxUb77PC3HwpvGO5ha9MOV2H65SQecMMsj7Gk26Bb7zk7VtxzdyyDk
 B3/Y7FSdE6x+0cKZLmJY0CG7rrtXlZE/GUkrYqKSn/LdNNjGy9uxCrjcCkRUhzqV05HA
 ZaPa89IvkjBaKtLlfSeXg5hMj0jB4pQlgFtFdSlpG+R5jT9DH/SoMyNL8xT9jiQb0s77
 T92egoPQ4HZD1AkqclOA1/4rKxpS3vbOaORVBXHIfDdZqcxBh0D/ZSQXDWlOrx6PHzs2
 CVA972kPrIHgMmr3tXhBSULSe8CjTDXbbYd7cOT6HcQSH9nmPLJ5Du2ScRAuQ3kkw60j
 XfEA==
X-Gm-Message-State: AOAM531Bio+RqldRaJviiTC/fS1KEozPKTsxrMMgWN4Yd46LBGOQQHE4
 2etsWe5Z5N8e7B3cyXlFG6zGq1AC
X-Google-Smtp-Source: ABdhPJym6jnROHFUb80UD4Yba3FcbjuJNaeXDOwIDiDUcP9kpjuhv2rHLeXNMNC2DKNhLAKlv7v6WA==
X-Received: by 2002:adf:f8cc:: with SMTP id f12mr18395714wrq.418.1590957807590; 
 Sun, 31 May 2020 13:43:27 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 May 2020 13:43:27 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 31 May 2020 22:42:56 +0200
Message-Id: <20200531204257.18725-6-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200531204257.18725-1-vincent.legoll@HIDDEN>
References: <20200531204257.18725-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (guix_get_bin_list)[BIN_VER]: Add missing curly-brackets,
[latest_ver]: Likewise & add explicit array zero-indexing.
---
 etc/guix-install.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 0e6e6842a1..7d635c2c38 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -210,7 +210,7 @@ guix_get_bin_list()
         | sed -n -e 's/.*guix-binary-\([0-9.]*\)\..*.tar.xz.*/\1/p' \
         | sort -Vu)")
 
-    latest_ver="$(echo "$bin_ver_ls" \
+    latest_ver="$(echo "${bin_ver_ls[0]}" \
                        | grep -oP "([0-9]{1,2}\.){2}[0-9]{1,2}" \
                        | tail -n1)"
 
@@ -224,7 +224,7 @@ guix_get_bin_list()
     fi
 
     # Use default to download according to the list and local ARCH_OS.
-    BIN_VER="$default_ver"
+    BIN_VER="${default_ver}"
 }
 
 guix_get_bin()
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 7/7] guix-install.sh: Add missing variable quoting & curly-bracketing in guix_get_bin().
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:44:04 +0000
Resent-Message-ID: <handler.40601.B40601.159095783728098 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095783728098
          (code B ref 40601); Sun, 31 May 2020 20:44:04 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:57 +0000
Received: from localhost ([127.0.0.1]:33942 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUoH-0007J2-FR
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:57 -0400
Received: from mail-wr1-f53.google.com ([209.85.221.53]:42793)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUnu-0007HT-8j
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:34 -0400
Received: by mail-wr1-f53.google.com with SMTP id p5so3536544wrw.9
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:43:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=hv+8YqkYTmG+yORQcwLz2eKJ/Qn3YqvC6SvnvPCUMFg=;
 b=IYh1p5s5xPD+xvlyusvFOm3e7sXr+fXOyFZHX0eQVWg+Ib5A9RlHURoVKcmaRZHgBF
 16qM8rGQbRxqzpP8e0gnjJTIUgKD9YQTIQKcjG+SRD2LV6brvCmTXvni9VHP5b6jXbNU
 VsJNfM3vHbfx+j8jpZvOn/MiroH2dnwhscU56ZGGVCz3WBNO42F3OJpB3M7TApBS7jVp
 YBRZ1dMkjTNMQ5VpNlzM82mr3IWNR5v9vmTzJHRCoEoRjiR5OiFt6B8qCOX63hyN3iRC
 z0Kc+gBQe9tSu/kLOS9gt2uuN0gbbxpc+1hxCjT8ssnUS1ZJmDLGn/GTXfK5M4I7aG4g
 NJ/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=hv+8YqkYTmG+yORQcwLz2eKJ/Qn3YqvC6SvnvPCUMFg=;
 b=iRc0voX3RNcszswfEyZ8Ng0qkA5J8OHmYB9lXA0+QsJB3n/mDp7D1WADqnYUTSKuKi
 NnJ0GP4kkZKkfL+DsaG8Xb1CA/8NxqQ2a4TXYRL8IGIiJvB3Iv1xvbvZNA7UUKHyH+bG
 Nsyvez239ZGqP2N6ht9s39CWsxFIbux4yZyU1S+3TawJDEDQv4tc4w/1miVknn884u1E
 pC8P/94MzmvifRweCpKs+qUu5Yf8Da5aftj3Ofxx5KWiIjqKXi/EfSr4+INGDiTCnvZn
 0uytBlQtS4EGfMzPaSvv4qP5BesP1Gs9yhoiRSAaYwGlFOF2fyErdS9uP/BNAWWoREUX
 E7vA==
X-Gm-Message-State: AOAM531h+MPsgomebOwF7HNGJzi2UQzQ7MfUphwroJrMkab61JUOA1H3
 lP0D0FxuUvdXFO2sK7fn7jGAG9o1
X-Google-Smtp-Source: ABdhPJxWBg56N5V3YMxPvgUHwKTdsetH4aq4i6bz7gFttyewgsweK2nAEjdZ+pnDF0lyq8wJnTs7bA==
X-Received: by 2002:adf:a50e:: with SMTP id i14mr6932528wrb.21.1590957808521; 
 Sun, 31 May 2020 13:43:28 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.27
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 May 2020 13:43:28 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 31 May 2020 22:42:57 +0200
Message-Id: <20200531204257.18725-7-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200531204257.18725-1-vincent.legoll@HIDDEN>
References: <20200531204257.18725-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (guix_get_bin)[dl_path]: Add missing variable quoting and
curly-bracketing, [_PROGRESS_OPT]: Likewise.
---
 etc/guix-install.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 7d635c2c38..f0d4a38838 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -239,7 +239,8 @@ guix_get_bin()
 
     wget --help | grep -q '\--show-progress' && \
         _PROGRESS_OPT="-q --show-progress" || _PROGRESS_OPT=""
-    wget $_PROGRESS_OPT -P "$dl_path" "${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig"
+    wget "${_PROGRESS_OPT}" -P "${dl_path}" "${url}/${bin_ver}.tar.xz" \
+        "${url}/${bin_ver}.tar.xz.sig"
 
     if [[ "$?" -eq 0 ]]; then
        _msg "${PAS}download completed."
@@ -248,7 +249,7 @@ guix_get_bin()
         exit 1
     fi
 
-    pushd $dl_path >/dev/null
+    pushd "${dl_path}" >/dev/null
     gpg --verify "${bin_ver}.tar.xz.sig" >/dev/null 2>&1
     if [[ "$?" -eq 0 ]]; then
         _msg "${PAS}Signature is valid."
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 2/7] guix-install.sh: Remove $UID bashism.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 May 2020 20:44:04 +0000
Resent-Message-ID: <handler.40601.B40601.159095783828104 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.159095783828104
          (code B ref 40601); Sun, 31 May 2020 20:44:04 +0000
Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:58 +0000
Received: from localhost ([127.0.0.1]:33944 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jfUoH-0007J9-OB
	for submit <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:57 -0400
Received: from mail-wr1-f53.google.com ([209.85.221.53]:45271)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1jfUnp-0007HK-HR
 for 40601 <at> debbugs.gnu.org; Sun, 31 May 2020 16:43:43 -0400
Received: by mail-wr1-f53.google.com with SMTP id c3so9400756wru.12
 for <40601 <at> debbugs.gnu.org>; Sun, 31 May 2020 13:43:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Cit8EcF1+Ohubp5rixRkhSB2/owXcE6ymR0td3o8k78=;
 b=Neu7GjzQ+jFC61zBuN2f5tOAi23gx1dpmKlBqI9hBSeht8LEFzFlGjAqmEo9xlU8IP
 qE0T9662kXUzplNqglX/dFI/bbTXGj9OHEFhF6PNP0lpeTX/BOc0rIE0BfMa9CeJ+Osr
 Edj23Vr4xTa4CfyYqnyIlMkkIc9Y7LFE901NHGCsTFoT41tYV8jdLSz8xfxTH58IN/sr
 RcD4ZAowgTYSwOIkD3Wt5xU6K6E/tqhU2u0jVo1KZ9BQmwAsyzxDxL0VAfDdvazyfQIG
 zDGeoekh6G8F01M8d8ZSEsa8vBEU4tcoIrf1eYBBSO35wW1DgM7UdF3cL0HOVczluBbe
 zosg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Cit8EcF1+Ohubp5rixRkhSB2/owXcE6ymR0td3o8k78=;
 b=i7ogUZKXStpFe8M1P46xNaVNmWrENQOB8ER075HYcurtR9sdx/2Hl6VigxpFM3YZ1k
 8oYOq7PjJbuKpIpb6Fh8TtG5x6RqECDWyUwJYVPze0qHV/wFOfpkwQzasFFseKkaLEA8
 RVHbLhHC4hUiZKS3fyHjw6hIuAoXFUht5FFPDSYdW2k2+vOZOx2QpJD2VaBPw4xq3Es5
 aL0ExTSjowT0oE8uN7kk908TEUi6vJp1as4TYSwrAQYViDKeCEf/cYDnO6sFuq61gq3n
 SBAq+aip8JI1dZMMnLOWPMU4wha8vv4vGm+Bu/eXAHt1YEIRSs3kXzC9BGGjdl8xdlKJ
 DADA==
X-Gm-Message-State: AOAM5322CU+mWezND6Mh6pArIRzV8DUHFfAgcrJRiQQYRCAntF/DKtHu
 0ABdBawFNA2bI+XulPhiScCVv6fT
X-Google-Smtp-Source: ABdhPJySkrkjJraROlN8rsxhbPYrJ+dYBKtrmdNBMlN9CX0hquhS//xiWMFa2BHo18IOusaOyclnyA==
X-Received: by 2002:a05:6000:1083:: with SMTP id
 y3mr18075202wrw.425.1590957803805; 
 Sun, 31 May 2020 13:43:23 -0700 (PDT)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 May 2020 13:43:23 -0700 (PDT)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 31 May 2020 22:42:52 +0200
Message-Id: <20200531204257.18725-2-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200531204257.18725-1-vincent.legoll@HIDDEN>
References: <20200531204257.18725-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh: Use `id -u' instead of $UID.
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 455e021684..0d7a8c8d44 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -29,7 +29,7 @@ fi
 
 set -e
 
-[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
+[ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
 
 REQUIRE=(
     "dirname"
-- 
2.26.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 0/5] Handle runit-based foreign distributions
Resent-From: zimoun <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 07 Oct 2020 16:10:01 +0000
Resent-Message-ID: <handler.40601.B40601.160208696629289 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.160208696629289
          (code B ref 40601); Wed, 07 Oct 2020 16:10:01 +0000
Received: (at 40601) by debbugs.gnu.org; 7 Oct 2020 16:09:26 +0000
Received: from localhost ([127.0.0.1]:57801 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kQC0H-0007cG-BX
	for submit <at> debbugs.gnu.org; Wed, 07 Oct 2020 12:09:26 -0400
Received: from mail-wr1-f65.google.com ([209.85.221.65]:33536)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1kQC0F-0007c3-CN
 for 40601 <at> debbugs.gnu.org; Wed, 07 Oct 2020 12:09:19 -0400
Received: by mail-wr1-f65.google.com with SMTP id m6so2869498wrn.0
 for <40601 <at> debbugs.gnu.org>; Wed, 07 Oct 2020 09:09:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=45sKyswJ2bGvuGn7h/AN0r9mA2O8ADFWmCBN0/uAyzw=;
 b=AESnnHE9nXsa2bYxnIZPMXG4XU6upTkGsVsFnlbre31m3uX/ppAwjWmkbTs1AQ4k84
 MgpLlEwd3KaBesCico+Y9oqNnFH++oZmK3AGvoK59EtMImfPfiMGsAn3TQFCYI750UeT
 8Fawuxct6vXrL4+h48loKut4ZODQt3ggRZjeE4TrHiT9lkOEvlNCGz0n72zecTWhlQKu
 Z6X1Tpn4QY3PXQC66jFrnh7SXHbc5hJZ4BeScPuL3qCMgh9EmukvIAoP8deub0WE3tYK
 jw4YjicBsm2uCzaZXaipX0wnJCO1YIBDp1gKmqWRf5eZAuwmbuFKXbKqn9RAYRhmy3mK
 PIsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=45sKyswJ2bGvuGn7h/AN0r9mA2O8ADFWmCBN0/uAyzw=;
 b=CXjwelElRCun3AStAK6Vtt123VpAHd/r6CKxBA7pp8SZiRz8fXB8gf73mAGV9gBcRx
 HwLAhGk9whZVEB0RR0IFqNqxgU7tImag0D8z/jVMrURPWa1uuXCzKFjTU7TCZH7yAYnc
 dgWXY5RGhcHd3AZrArDid1Xrps0qrDXYvm1Tz8GhaWaPZhw6p7d3BdQBDTtqlP5nX3JY
 z3LzGcEt0ODrhAKWtjLJgBx+C6GW8vQqvfYDEQK0AYXf9ucBI6GvXjHVfUsTk5EP2iTO
 4IJIirYtvHPIgAwi9ftIXwkkxGoMffXh7LmhNEILU30BygGTYk9kOOg+AEOHTsYyIVB3
 ab8Q==
X-Gm-Message-State: AOAM5307QBbqaOS+ODFYi+tjvXSA6TC9B3JNQvMLsdm+JeUur1iRE2kv
 tZU3ZbjATrFYFAdV5ZjhWzy0wIzI0ksFKw==
X-Google-Smtp-Source: ABdhPJz3pzdxd9B++cZdndwLgMrufWcbkLMz95GXgFwVn2peLz/d34i//WQm3Ca+5QNDIfck3MeQZg==
X-Received: by 2002:adf:e989:: with SMTP id h9mr4634296wrm.38.1602086953095;
 Wed, 07 Oct 2020 09:09:13 -0700 (PDT)
Received: from pfiuh02 ([193.48.40.241])
 by smtp.gmail.com with ESMTPSA id z191sm3220889wme.40.2020.10.07.09.09.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 07 Oct 2020 09:09:12 -0700 (PDT)
From: zimoun <zimon.toutoune@HIDDEN>
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Date: Wed, 07 Oct 2020 18:09:11 +0200
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN> (Vincent
 Legoll's message of "Mon, 13 Apr 2020 18:04:49 +0200")
Message-ID: <87d01u81co.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Dear Vincent,

I am working on Bug #43744 and Path #43769 and I hit these patches set.

  <http://issues.guix.gnu.org/43744>
  <http://issues.guix.gnu.org/43769>

Well, I am a bit lost with the different series and I do not know which
are still valid and which are now obsolete.

Could you rebase and resent the patch set?  And reroll with v5?

Thank you in advance.

All the best,
simon

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 7/7] guix-install.sh: Add missing variable quoting & curly-bracketing in guix_get_bin().
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 18 Dec 2020 11:39:02 +0000
Resent-Message-ID: <handler.40601.B40601.16082914911662 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16082914911662
          (code B ref 40601); Fri, 18 Dec 2020 11:39:02 +0000
Received: (at 40601) by debbugs.gnu.org; 18 Dec 2020 11:38:11 +0000
Received: from localhost ([127.0.0.1]:37859 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kqE5G-0000Qf-2r
	for submit <at> debbugs.gnu.org; Fri, 18 Dec 2020 06:38:10 -0500
Received: from mira.cbaines.net ([212.71.252.8]:56862)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1kqE5E-0000QX-5C
 for 40601 <at> debbugs.gnu.org; Fri, 18 Dec 2020 06:38:04 -0500
Received: from localhost (188.30.130.172.threembb.co.uk [188.30.130.172])
 by mira.cbaines.net (Postfix) with ESMTPSA id 408FA27BC05;
 Fri, 18 Dec 2020 11:38:03 +0000 (GMT)
Received: from capella (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 2ac9e710;
 Fri, 18 Dec 2020 11:38:00 +0000 (UTC)
References: <20200531204257.18725-1-vincent.legoll@HIDDEN>
 <20200531204257.18725-7-vincent.legoll@HIDDEN>
User-agent: mu4e 1.4.13; emacs 27.1
From: Christopher Baines <mail@HIDDEN>
In-reply-to: <20200531204257.18725-7-vincent.legoll@HIDDEN>
Date: Fri, 18 Dec 2020 11:37:58 +0000
Message-ID: <87y2hv1h0p.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vincent Legoll <vincent.legoll@HIDDEN> writes:

> * etc/guix-install.sh (guix_get_bin)[dl_path]: Add missing variable quoti=
ng and
> curly-bracketing, [_PROGRESS_OPT]: Likewise.
> ---
>  etc/guix-install.sh | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index 7d635c2c38..f0d4a38838 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -239,7 +239,8 @@ guix_get_bin()
>=20=20
>      wget --help | grep -q '\--show-progress' && \
>          _PROGRESS_OPT=3D"-q --show-progress" || _PROGRESS_OPT=3D""
> -    wget $_PROGRESS_OPT -P "$dl_path" "${url}/${bin_ver}.tar.xz" "${url}=
/${bin_ver}.tar.xz.sig"
> +    wget "${_PROGRESS_OPT}" -P "${dl_path}" "${url}/${bin_ver}.tar.xz" \
> +        "${url}/${bin_ver}.tar.xz.sig"

I believe the variable quoting here will break the wget command in the
case where _PROGRESS_OPT=3D"-q --show-progress"

  =E2=86=92 wget "-q --show-progress" https://guix.gnu.org/
  wget: invalid option -- ' '
  wget: invalid option -- '-'
  wget: invalid option -- '-'
  wget: invalid option -- 's'
  Usage: wget [OPTION]... [URL]...

  Try `wget --help' for more options.

>      if [[ "$?" -eq 0 ]]; then
>         _msg "${PAS}download completed."
> @@ -248,7 +249,7 @@ guix_get_bin()
>          exit 1
>      fi
>=20=20
> -    pushd $dl_path >/dev/null
> +    pushd "${dl_path}" >/dev/null
>      gpg --verify "${bin_ver}.tar.xz.sig" >/dev/null 2>&1
>      if [[ "$?" -eq 0 ]]; then
>          _msg "${PAS}Signature is valid."


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/clJZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xe4TQ//Srwr7acXBMAxOAFzJNYuemblqUfvzB81
/zuJidLQ/LSc2Usx8icn5l4CUKnLpY8d1jSWSVQ+kQJykSdAsB7kTbz5/bAzeFpx
r6TYCtxqQZgSIPMIlEsb4H2WKCllQpxXhRkSwSn7/Gp2zGIi8z/GHnqyatgnWMqG
i66lLshZv+3b1v5T6ppNPezkcDQ71sRykNwjanU2LJcizMgIwjfjVnCP/HHMAuxZ
xlYcWsHUoAo9BReZyOewE3eri+Gp/mmF3xyHCUyN0fDJWTZOwFmKZkrpoUelc0dP
mmBXaWZrEFGf7+1t6Hg1Gmf6xZusbDZkVErVg1kh+mnxaAwnoSXzquVa6CiUKo9H
RpQX9ZjtLZXzvF1zR6gnwu3HCzAKAYakz/+rCXjWoZKzLaF5tDKdg05Z1gFFLzB5
aRZaqoXgURX1W+mZ+RO/xw+pST4JmNg5GquWu2Dhe3+eHUxvBf9mkztfsEs1d+HV
nR0rtYQCAfvkc3Kj6RzqWukOAyCX2848yt3Oop0X/frwnExJOOk5qvRmSvHtKyst
yS3bT9tAkGN2sW4npnTn5MdFvOOOpBnBDaDGsRoPoj9jeGCkokMo6+8nHIFVYZLt
8uoLgYhVRtSjjzQUHMHXpOwfRitijGLAq1JGoA3WoGlZtetBj6gAjBlQaObseOnK
4xdb+ZcFX/M=
=afVT
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] New reduced patchset, the easy bits first
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 18 Dec 2020 12:29:01 +0000
Resent-Message-ID: <handler.40601.B40601.16082945316694 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16082945316694
          (code B ref 40601); Fri, 18 Dec 2020 12:29:01 +0000
Received: (at 40601) by debbugs.gnu.org; 18 Dec 2020 12:28:51 +0000
Received: from localhost ([127.0.0.1]:37991 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kqEsN-0001ju-BK
	for submit <at> debbugs.gnu.org; Fri, 18 Dec 2020 07:28:51 -0500
Received: from mira.cbaines.net ([212.71.252.8]:58896)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1kqEsK-0001jl-MW
 for 40601 <at> debbugs.gnu.org; Fri, 18 Dec 2020 07:28:49 -0500
Received: from localhost (188.30.130.172.threembb.co.uk [188.30.130.172])
 by mira.cbaines.net (Postfix) with ESMTPSA id C4A3B27BC05;
 Fri, 18 Dec 2020 12:28:47 +0000 (GMT)
Received: from capella (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 5a481ddf;
 Fri, 18 Dec 2020 12:28:45 +0000 (UTC)
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <00b505a4-0c1a-2f6c-7242-57d7b5eb7d4f@HIDDEN>
User-agent: mu4e 1.4.13; emacs 27.1
From: Christopher Baines <mail@HIDDEN>
In-reply-to: <00b505a4-0c1a-2f6c-7242-57d7b5eb7d4f@HIDDEN>
Date: Fri, 18 Dec 2020 12:28:42 +0000
Message-ID: <87v9cz1eo5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain


Vincent Legoll <vincent.legoll@HIDDEN> writes:

> Hello,
>
> The patch series is becoming long. So here is a batch of fairly easy
> ones, to lighten it a bit.

Hi,

Sorry for the delays in reviewing this.

Thanks for sending a smaller set of patches, that makes reviewing
easier. I made some tweaks, and pushed 4 commits to master as
d2532317d136ac063a24baeec6688ea0e0ebe37b.

I'm not sure about the bashisms stuff, given the script seems to depend
on bash (see the exec bash bit at the start), I think using bash
functionality is reasonable. What was your motivation behind these
changes? (sorry if I've missed this earlier in the thread).

Maybe once we've talked about the bashisms stuff, would you be able to
send another set of patches for review?

Thanks,

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/coHpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdYvA//VgwtxneB9ha1QCHSf3luCm3eVT0Q6SAG
atPytqgeRI5kuMB2dAM6PsTWlaXXE9L1LVhgfOfRCaFYFReJBckG9j8gsLtEMh2C
FMoY3662nXOthIHdgrAMfLSF05sXAlvwsDb1ddLxbfW+edeVFsYlr9FRLcS28m64
VCz6Aikcj8H2RuyJNLZgYZm6XBmU6CA8DFFmBX5E5FmWKMPJJ7wxX2L9J6Wvwk7k
WVUfPt7ACsurISKs1IycLmNA/jbNrkP7YlPmmc1qPpQBEMJPiIjt9mB04FXB/SqK
4LcFVNRpbTlkKCYA3pm6PV4z9caHxDes7fuFdnYJNXKQ88kN4XWSA7WZ4Frw/acQ
riLa3tNNKcxe+/9fo80Me3G6U1mdfHKeZ4xWxSmjddcH7ShPdcswIqdWRm1m1JK1
d06Ap0+c/83uE3gLnN8N9jcx2VQh4Alc3kVkgqw7lefUSRZEq61MesaUxLqiPAg+
LWPeptRxHfyVQWd5nNOq/kEcfcOBs84sYF6EfKN3s6LwOwxLG4+yH7gh4PX/jdrZ
hC6KGi0z6590Grw7DioqXTNsA6yJv+KLtwYw79SooohpgETS1B3dTlSNgz9nNKcy
w4/rmKH5x6ZSPsHzKu3c9q56hVckVMGvMgI8qA3fxImLF8s52YBWDvQIAZL30v0a
IkAtVMGGbNM=
=kk2+
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] New reduced patchset, the easy bits first
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 18 Dec 2020 19:36:01 +0000
Resent-Message-ID: <handler.40601.B40601.16083201318496 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Christopher Baines <mail@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16083201318496
          (code B ref 40601); Fri, 18 Dec 2020 19:36:01 +0000
Received: (at 40601) by debbugs.gnu.org; 18 Dec 2020 19:35:31 +0000
Received: from localhost ([127.0.0.1]:39954 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kqLXG-0002Cy-Pz
	for submit <at> debbugs.gnu.org; Fri, 18 Dec 2020 14:35:31 -0500
Received: from mail-lf1-f49.google.com ([209.85.167.49]:46720)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1kqLXF-0002Ca-EK
 for 40601 <at> debbugs.gnu.org; Fri, 18 Dec 2020 14:35:29 -0500
Received: by mail-lf1-f49.google.com with SMTP id y19so8168649lfa.13
 for <40601 <at> debbugs.gnu.org>; Fri, 18 Dec 2020 11:35:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=tsqsKyo94UFRnnAKIhR+qKXky7mj/VglJnHXab4trmI=;
 b=EluTjntAOXahRBLfmphj8P+nNj8ElC9gN8My6DKAW3eOxI8ELeSMOA8vyJB1ywb2BV
 /Rs1t6/YthUZ5j1pso5Ybuj2KLfDq5XY0dcFESrZeqUqz5mcOPYSDe6/UXEVQqU2/+XY
 uDZAWkPWjFZ7LzQAkrhIx8EaM1VKVDocfrKgtmwoUsem6kWEuQHje4YNAa/+0lupVs8Y
 InSxQRIvJzcNaq4+8/fuCRTUdoC0rejdJ3lu+Hp4NV9VibBBTmxxpLwKsaX14ZuLR/x9
 QFm3alvDgic/94ry8V9psX8gzSQfJyLNwBxbMi1XzqWbsz7zBWm7OL2iX0Vh1YpuynNA
 CCTg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=tsqsKyo94UFRnnAKIhR+qKXky7mj/VglJnHXab4trmI=;
 b=sttJMxqNd3qpAu6RblZWTlj307/oOCM81m4Nm+Wi/6eqY7aSsCsrbH9mAQAUdGh5T+
 9+coN+NRemIIJN39WuLV2dV18dHNPEcVdya6mrYPxC3UBWjb2w6h9ff0hW7ZBDHZgBMX
 ydOd5RnqKC+gCmF9WvCWkKPgYH0GELsZZyVmCseftumGTgOidMefHy7Wl0jIX0QKNDJG
 6Zb/zX+gd9FvWcyZTw/UCoaXDnj+0BrDygATRoboELIdzYz1b01PE5ipHjWUnopaNfrC
 DZrIqg+H1RpCXjgw08Ed5uILgUdR7CvaymU0rhNeTTB9/u4diD01pnY0tcU/Q6Vg/fSv
 OmuA==
X-Gm-Message-State: AOAM531HPFWbd5DHQpcie7d3TMYLV45K+ffdnoWAWHQw5UrqrJPgIN9B
 tmj0Cm4xK2NkFMvCf+UqbVb3s5XeOEiYojPooTA=
X-Google-Smtp-Source: ABdhPJzAKqarSCI3NBAwX1emaMzFDm/agaquk5aJ085C//bM5iQG+6JwipXwQ6Pd3QmrxKrTtLXjviTYTaUVLY08H/s=
X-Received: by 2002:a2e:9916:: with SMTP id v22mr2402683lji.221.1608320122881; 
 Fri, 18 Dec 2020 11:35:22 -0800 (PST)
MIME-Version: 1.0
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <00b505a4-0c1a-2f6c-7242-57d7b5eb7d4f@HIDDEN> <87v9cz1eo5.fsf@HIDDEN>
In-Reply-To: <87v9cz1eo5.fsf@HIDDEN>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Fri, 18 Dec 2020 20:35:11 +0100
Message-ID: <CAEwRq=pUX4v4_OBA=THq7JYk+ef15HDFpPkD-6HmtZkx854KJA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

> Thanks for sending a smaller set of patches, that makes reviewing
> easier. I made some tweaks, and pushed 4 commits to master as
> d2532317d136ac063a24baeec6688ea0e0ebe37b.

Thanks for taking care of this, I'll have a look.

> I'm not sure about the bashisms stuff, given the script seems to depend
> on bash (see the exec bash bit at the start), I think using bash
> functionality is reasonable. What was your motivation behind these
> changes? (sorry if I've missed this earlier in the thread).

Some distributions that I intended to add support for don't default to bash
(nor have it installed by default). I think this script should aim for
the broadest
possible support, but that is only my opinion.

And the patch set was not finished, I wanted to tackle the low hanging fruits
first (also to test the interest from the guix team before doing too much).

> Maybe once we've talked about the bashisms stuff, would you be able to
> send another set of patches for review?

I'll try to revive the patch set, and submit other portions I should have lying
somewhere.

Tchuss

-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 1/5] guix-install.sh: Remove "[[" bashisms in chk_init_sys().
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
In-Reply-To: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Dec 2020 17:29:01 +0000
Resent-Message-ID: <handler.40601.B40601.16084853387158 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16084853387158
          (code B ref 40601); Sun, 20 Dec 2020 17:29:01 +0000
Received: (at 40601) by debbugs.gnu.org; 20 Dec 2020 17:28:58 +0000
Received: from localhost ([127.0.0.1]:45491 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kr2Vu-0001rO-DY
	for submit <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:28:58 -0500
Received: from mail-wr1-f49.google.com ([209.85.221.49]:38692)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1kr2Vs-0001r7-Qf
 for 40601 <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:28:57 -0500
Received: by mail-wr1-f49.google.com with SMTP id r7so8376087wrc.5
 for <40601 <at> debbugs.gnu.org>; Sun, 20 Dec 2020 09:28:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=rQAs9bMQieejJaGxFztBBnsnSvkWUUEcichMyaqhEmo=;
 b=imvNhxFvKtIvqX/G2j0rD4KTzTiXPualLHKF0jCQjTWUrZ7OjE6xFO7rqukCERAd4Q
 B5ssFj9jxgQZyK9neNUKd1TchNdFx+JoTk8usSlMz1aOAolkoERdxAA1BlyByZ1UEGCO
 DuVE90/DfVRyAOnxrUbZoH1GJMkZrWL4F9NKRNx2wY5TeVO2wFixbiqaPem2qSJNyMLd
 CCoUk5IVyWH2GB3Nz0jFihd6lP+aZm4jAxswnM9Sgs4XiVH9vzBJjA6xIgPZvhq5rjYp
 59q/GGjCdYWE3Td2e2i6CcD1L6ADZ2GjRKBmwBQwRALxZUmeYymFZhQUq7RSGZ3wxTjG
 QiPg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=rQAs9bMQieejJaGxFztBBnsnSvkWUUEcichMyaqhEmo=;
 b=BAlIQpleg+vTZhLczluwRGaAPvKFnzAg1TsuNs5z1xioXDVve5w9v4mLWGVcAq/Zds
 52lF9AP+wyQ5ZpWzkZUZG+1zTMd4G6rVBXq92igZSZI7C8BWpktcbUk/6+O8UKdeTNj+
 cr6TsOID7FrEpUobycNs/31+/tY6AI2e/jMDV5rYrUvCwLjJbEEMYlNFnEORX/UoSqlM
 Ypj1UTiA2WG2R4vnJejuGrZPPk0hq8GEr3l+SCqWPhvZ9Hkoa0xYrw0nn6GshPXQ635/
 zzwmneefBb9p0IUCOL5rHvXqDS3+N2SvgVMhVV59+UhvbOFqLwQ9dsUZwG9Oz6AQ6yI4
 MijQ==
X-Gm-Message-State: AOAM531PVcJxFt8XdgCIStUaqDHZt/P+3rezysNXditeMaAdnz0ce8+n
 fr1RWEOnSlHUTclJr7xEAIY0myjBq7M=
X-Google-Smtp-Source: ABdhPJxMbYJ2Oj0zPVOQDG5mUey8rhLVWZxhLrIfmN3P/kBV2hmACdZ34uJyEiWWw03EbMGu6G6nGA==
X-Received: by 2002:adf:ec8c:: with SMTP id z12mr14551171wrn.208.1608485330814; 
 Sun, 20 Dec 2020 09:28:50 -0800 (PST)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id h3sm20783535wmm.4.2020.12.20.09.28.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 20 Dec 2020 09:28:49 -0800 (PST)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 20 Dec 2020 18:28:35 +0100
Message-Id: <20201220172839.3059-1-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.29.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (chk_init_sys): Use `if something | grep' instead of "[["
pattern matching.
---
 etc/guix-install.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 9015f40bb6..26c8622855 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -143,11 +143,11 @@ chk_term()
 
 chk_init_sys()
 { # Return init system type name.
-    if [[ $(/sbin/init --version 2>/dev/null) =~ upstart ]]; then
+    if /sbin/init --version 2>/dev/null | grep -q upstart; then
         _msg "${INF}init system is: upstart"
         INIT_SYS="upstart"
         return 0
-    elif [[ $(systemctl 2>/dev/null) =~ -\.mount ]]; then
+    elif systemctl 2>/dev/null | grep -q -- -\.mount; then
         _msg "${INF}init system is: systemd"
         INIT_SYS="systemd"
         return 0
-- 
2.29.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 2/5] guix-install.sh: Remove $UID bashism.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Dec 2020 17:30:01 +0000
Resent-Message-ID: <handler.40601.B40601.16084853427182 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16084853427182
          (code B ref 40601); Sun, 20 Dec 2020 17:30:01 +0000
Received: (at 40601) by debbugs.gnu.org; 20 Dec 2020 17:29:02 +0000
Received: from localhost ([127.0.0.1]:45494 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kr2Vx-0001rj-LN
	for submit <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:01 -0500
Received: from mail-wr1-f48.google.com ([209.85.221.48]:36929)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1kr2Vw-0001rC-CR
 for 40601 <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:00 -0500
Received: by mail-wr1-f48.google.com with SMTP id i9so8394240wrc.4
 for <40601 <at> debbugs.gnu.org>; Sun, 20 Dec 2020 09:29:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=L+KBkTp2HvXNPAEyFjt66eMogKo2wb8EXaRz0yVOr8o=;
 b=ffLRO/M4iFVsrzQKQjNOXLw3RgSExYVeooGbzDQPYBeqfzzWxzETqoFl089GD10u7w
 +QbXRmptoN4QcNlfCq0H8v2ZZIsZ/NOgQuTn3qe6TIu8ksS5zsIb+ZQkXgoqhysioj44
 lW9tX4Q+HChOWg4jI8XmB6MSz6tkH8XPJoYh0HhiRjC3iCKfWhMIbKTfGGXvKT1Ho9UV
 RV8as+P/tW0/n9vEfVWNVm+wksYUhi5bTdfT9zDBxIrMpZhX0hxiMaPZ139piXDJd7O5
 b+7I9Z9g2E/aP2m3ibS8lsj5/DRRC2Ly0QKdug9yP2GwstOkbngK3Dh/W0hBMLzJcxFQ
 eZZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=L+KBkTp2HvXNPAEyFjt66eMogKo2wb8EXaRz0yVOr8o=;
 b=ONAqMh3cf2uh7HFd7OaGC6OC4L1SI7N4lFrr9plE4RsQqeJwbilXdmEC1z/+KrkwD3
 eNow9NNP++ePX0G6B2NlcsbhaRhFFGnLrfXnKLzJKJjHv1PQAmTVlqZH5Ub66rfn2w/3
 lWp2vieIxMjyIZcbUTFN09F2HqgjwQB9HJpog7c8N2p07pyKXLmbMiW084CmqdLFLMeE
 Eq9tC68qCF9f+wAIWhqpxUn1aS93beoftiJN3C8+mH86UFDpj/Pe3Bw/I0DJxdCPzP6r
 KxA1i04VoXk1usRD7bkjh9Q+zIqUB5tXqtayjaML58fgGtd0FKjeqbAAWCNRxCAz8qxU
 Ntkg==
X-Gm-Message-State: AOAM533zms8cEZM9VnfK3NUH9K27KLVpcCpwo6soS8MG8SYB8lk+5sE1
 sbKUvjL6Kt5DEqEe+w7qUKF40HbGbeI=
X-Google-Smtp-Source: ABdhPJwG9O6V5Rdr+ckGthSp0oY0xsSgpUBcDH+VzzgJPZ0n03KArW+IL1m8l3KuSLJQUdlihJMKOA==
X-Received: by 2002:adf:d84e:: with SMTP id k14mr14653060wrl.104.1608485334861; 
 Sun, 20 Dec 2020 09:28:54 -0800 (PST)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id h3sm20783535wmm.4.2020.12.20.09.28.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 20 Dec 2020 09:28:54 -0800 (PST)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 20 Dec 2020 18:28:36 +0100
Message-Id: <20201220172839.3059-2-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20201220172839.3059-1-vincent.legoll@HIDDEN>
References: <20201220172839.3059-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh: Use `id -u' instead of $UID.
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 26c8622855..0102901010 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -32,7 +32,7 @@ fi
 
 set -e
 
-[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
+[ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
 
 REQUIRE=(
     "dirname"
-- 
2.29.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 3/5] guix-install.sh: Fix requirements.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Dec 2020 17:30:02 +0000
Resent-Message-ID: <handler.40601.B40601.16084853457223 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16084853457223
          (code B ref 40601); Sun, 20 Dec 2020 17:30:02 +0000
Received: (at 40601) by debbugs.gnu.org; 20 Dec 2020 17:29:05 +0000
Received: from localhost ([127.0.0.1]:45500 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kr2W0-0001sQ-Va
	for submit <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:05 -0500
Received: from mail-wm1-f50.google.com ([209.85.128.50]:56289)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1kr2Vx-0001rE-Ju
 for 40601 <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:02 -0500
Received: by mail-wm1-f50.google.com with SMTP id x22so7525742wmc.5
 for <40601 <at> debbugs.gnu.org>; Sun, 20 Dec 2020 09:29:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=mGDzRfe1IEAdzowg+aYjIyEJqa1QSXgcwtEmZvj5eZs=;
 b=ushFXCsE2pj+0onvesPai4G9vA7bLajEyibEHMWUuxClbd1a41NsI4aoUCGJuotBhB
 I2DiSSVrjX+WiWNg3xQxO5t5M9WxLKWEjIbeX8y/KbiLKtn/B91orCzcYi/3Ea/Ndvvh
 whOItaJg5gz2zuJgn+fpifE+R/Xu0dhZoBHaEZEYCb3tSLsNjg8iNqgr0C5ZB9bPnBJz
 oFbvqaurpw+/wQ3CQFH44b33b781Nt51LA+cfK4qiPjpuxq0Y6PqA72w9xMVAO/96Qtd
 jIZoe5Z3ViBkRJcEfuScoFi/eMsVvbwB63UU5IolOZiysaQtKbThvmFo4j79FCvKk+sH
 RQNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=mGDzRfe1IEAdzowg+aYjIyEJqa1QSXgcwtEmZvj5eZs=;
 b=ktm5qukL9/FtMiCIioRvHragMjJaWBl1/WQobyogNuOlb0X3LK4BvPZSGMH4Ui1zKY
 HGWDRua8kagSt2Law8gWVZ9cQrQK1ukwZ9dFVQemYffNpaVy7InFMloAcBY3rNiz6VAs
 VNtc+CWdA2mFcPyFulBVyEZtUM19AbiUmNI8Uu+sES5VILBEuN+6t+BCL27gtsQihL8p
 nlh04RM8/UKvkJhI1/zi9kNUzBEJTm2VScomjOvewRlC/A/eyrf8y+zioqWkUgaUaTEN
 QRPAIFtIyJfZ5hK7SoHW/owPoUR9Z5YYlVivjGvsm6uSZwxytz8DSNpkzm2eiyjvPRgG
 R5ng==
X-Gm-Message-State: AOAM531MgTRJFqb5ZVu4o8HUF9nbuhCd7XeRkM5IM+CSyAf2xs2GdXO+
 HL9AIHrV/yeBxHJfStx3l+hJ+cVy/aE=
X-Google-Smtp-Source: ABdhPJy8b/QWStS6Hp8hkmu68lNHhZU2yk5XaToKScGGE5UAsfQYJZ0VGQSyq2c+zfVkMfjqJgFr7g==
X-Received: by 2002:a1c:4904:: with SMTP id w4mr12584741wma.140.1608485335757; 
 Sun, 20 Dec 2020 09:28:55 -0800 (PST)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id h3sm20783535wmm.4.2020.12.20.09.28.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 20 Dec 2020 09:28:55 -0800 (PST)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 20 Dec 2020 18:28:37 +0100
Message-Id: <20201220172839.3059-3-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20201220172839.3059-1-vincent.legoll@HIDDEN>
References: <20201220172839.3059-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

There's no usage of "tr" in the script, whereas tar is used.

* etc/guix-install.sh (REQUIRE): Change tr to tar, add ln, remove
readlink & dirname.
---
 etc/guix-install.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 0102901010..d40d90b377 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -35,8 +35,6 @@ set -e
 [ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
 
 REQUIRE=(
-    "dirname"
-    "readlink"
     "wget"
     "gpg"
     "grep"
@@ -44,13 +42,14 @@ REQUIRE=(
     "sed"
     "sort"
     "getent"
+    "ln"
     "mktemp"
     "rm"
     "chmod"
     "uname"
     "groupadd"
     "tail"
-    "tr"
+    "tar"
     "xz"
 )
 
-- 
2.29.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 4/5] guix-install.sh: Fix detection of SysV init system.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Dec 2020 17:30:03 +0000
Resent-Message-ID: <handler.40601.B40601.16084853457230 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16084853457230
          (code B ref 40601); Sun, 20 Dec 2020 17:30:03 +0000
Received: (at 40601) by debbugs.gnu.org; 20 Dec 2020 17:29:05 +0000
Received: from localhost ([127.0.0.1]:45502 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kr2W1-0001sS-72
	for submit <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:05 -0500
Received: from mail-wm1-f53.google.com ([209.85.128.53]:37178)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1kr2Vy-0001rG-7C
 for 40601 <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:02 -0500
Received: by mail-wm1-f53.google.com with SMTP id q75so8433105wme.2
 for <40601 <at> debbugs.gnu.org>; Sun, 20 Dec 2020 09:29:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=2VzI7wwzB0sun3AZD8tfCNLfrsTYlw4PkdKK/WMzhh8=;
 b=uLQy1gCAu2JYuH0LEcX4VSGomA500UEEyI+i48RB5m21SBaVMJ3Irro3pMloqJSwrg
 RcPjhpbVHkJeacbdGGlOmMZLLAtmCL6OVuQHve9/DH83MHb1HHptb5r0BTQMwEtzW7K/
 WqLXXWvjB6jGloMDUpE5RyLutYkqP7Uqop7w2SPB7h+tQs90vW8DboBHVO7J3sEEyNLl
 03MlhU/7g+wddrZbdNJDmTLomhKysx5VC4bNSURov4y/BbC1wlpuWRr4vjUO3i6lNLME
 XKy+z73amvcRiXAbvfLkUUE3gBFAALfbQX86xLlV+L5DIzTbuta1Hl3fFfq94a5HGrs5
 Xo6A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=2VzI7wwzB0sun3AZD8tfCNLfrsTYlw4PkdKK/WMzhh8=;
 b=divP9dHHYP1m50FI9IA7dQwYM+gizELjYCYalwpTNIPFCcZzXjdIS2JL1cefxcodtt
 5rHqxGeSDONy9kAWC+2KNglgAuwcwrcc/2HBgRIDG0wIyRr6CxOf7v25xkJ8s8BzG5T1
 v5Kta3AEZKfYR6UDT56OVLHfuZ3BJYTfFyG/GEKfSt7CXptlPuN7PvZZQPUATMCUCDCj
 QH/enZnK5AWUCoirnLStGj7fz4X/TrVMBA+vTcSQSPEB96qLsfGmw7Cyo0HqXaALfXqD
 /bO7vlrUuCHaVC6ozRptZ97yc1jWpYBtONlItpI+l9HMTW+H/Gqvw34ZsxvELH5aHj1I
 7ATA==
X-Gm-Message-State: AOAM533PlIcAxBHdbHPXUEEWdozrO7w8fkKpDGcsWBl9/FFCDjvsXQAP
 ziQJMHY3SsUJzXP/hm1bZoIHkss67h4=
X-Google-Smtp-Source: ABdhPJyQuKzJuKZA1MOWW5W+rmSX6rf8FoWYcpZcSTZ2dzmULB5s7+jFljoVGW3Zr9WLVtmxa8wZ6w==
X-Received: by 2002:a05:600c:2042:: with SMTP id
 p2mr13116276wmg.152.1608485336638; 
 Sun, 20 Dec 2020 09:28:56 -0800 (PST)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id h3sm20783535wmm.4.2020.12.20.09.28.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 20 Dec 2020 09:28:56 -0800 (PST)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 20 Dec 2020 18:28:38 +0100
Message-Id: <20201220172839.3059-4-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20201220172839.3059-1-vincent.legoll@HIDDEN>
References: <20201220172839.3059-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Checking the presence of a regular file & not symlink (/etc/init.d/cron)
is not sufficient.

Detect a sysvinit system by running `/sbin/init --version' and checking the
output contains the string "SysV".

* etc/guix-install.sh (chk_init_sys): fix sysvinit system detection.
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index d40d90b377..307c42d3fb 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -150,7 +150,7 @@ chk_init_sys()
         _msg "${INF}init system is: systemd"
         INIT_SYS="systemd"
         return 0
-    elif [[ -f /etc/init.d/cron && ! -h /etc/init.d/cron ]]; then
+    elif /sbin/init --version 2>/dev/null | grep -q SysV; then
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
-- 
2.29.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 5/5] guix-install.sh: Check daemonize package presence for sysv-init.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Dec 2020 17:30:04 +0000
Resent-Message-ID: <handler.40601.B40601.16084853457236 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 40601 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll@HIDDEN>
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16084853457236
          (code B ref 40601); Sun, 20 Dec 2020 17:30:04 +0000
Received: (at 40601) by debbugs.gnu.org; 20 Dec 2020 17:29:05 +0000
Received: from localhost ([127.0.0.1]:45504 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kr2W1-0001sZ-E9
	for submit <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:05 -0500
Received: from mail-wr1-f54.google.com ([209.85.221.54]:39808)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1kr2Vz-0001rM-3q
 for 40601 <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:29:03 -0500
Received: by mail-wr1-f54.google.com with SMTP id c5so8359756wrp.6
 for <40601 <at> debbugs.gnu.org>; Sun, 20 Dec 2020 09:29:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=9u5CgJdMT4W0Fwn47Pl5aTgr7wAAdBuDi+K5hmNDIdQ=;
 b=AUE4Ws/xhVd0opDd0JMq+nWndTMnW05RZ8+0AGAsWuluVHO1T1Atqcmw3tpe/9Hlsa
 ukq3EtiRay3Vst4nd4mCnuRUN4Hfo1s3FE9558ztHBMOT9q1ULR1PJolFH0DA/Vw5fyW
 ytIrj+qTshTstMalM0+i8tT7Nm4L8mzwh/EJ5tiRmNJWK1Pg++geWTTk5rBW8zFfuKPG
 dtCIpQWGX0b+oVOvsoppiDmOs6cAYupGUYs/pn3ph9s3EENdPCJNimctVVsUkqJxw0kb
 zRlGe23iYtiiXhPoN++K9mw/CUbyLtH88ywEzHoKeiiJAP6IBRf4pmWhYha+twDf0dNl
 0a9A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=9u5CgJdMT4W0Fwn47Pl5aTgr7wAAdBuDi+K5hmNDIdQ=;
 b=RC9CUcPaRrWecCR7X1uviPdkTTYqkjVl1iGkOoj6SSJuez7j7IoXRbqauGQZqNk/yK
 G9Rw8g0iQ7LbdWEoSkogPpqsr3kS/kfF1pTicTXWuExHexgNSM0nM9PWPg4q2pK+3z1G
 4V+1i3NjPvNjtRb55jlPpPALl9Ax2JV+AnAi2cOlj9ZNiYH7HzkDthaouhA4NhmCdVhN
 fFvvUqxb/rqgsVr9NvdnW2UhlBsnE89rUJHSu7E9WpVct31ckVpY+JwcR2Lto6TBCXka
 N4yvRiVV1bdT8hcpqWPkN77M/65WIvUJvNsPCPixNhEQcSUQCwcAQHBZj1V5sHWKZOu6
 WdJg==
X-Gm-Message-State: AOAM531vLIzuFzzkSwoQNxdWuUAKTLibCQb6bBwYu3oZwjGY1rHCZb+Y
 LLZW06a5I5tkkZJvUZRojbZz59hP+4M=
X-Google-Smtp-Source: ABdhPJy9Oib1b5crdDT63zVzhEAkTERsjt6dpV3g7w/PCIvKvrp1s0cGgUUZoSUyvXYShmDto+sCvA==
X-Received: by 2002:adf:fe05:: with SMTP id n5mr14799690wrr.9.1608485337583;
 Sun, 20 Dec 2020 09:28:57 -0800 (PST)
Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net.
 [82.242.148.1])
 by smtp.gmail.com with ESMTPSA id h3sm20783535wmm.4.2020.12.20.09.28.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 20 Dec 2020 09:28:57 -0800 (PST)
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 20 Dec 2020 18:28:39 +0100
Message-Id: <20201220172839.3059-5-vincent.legoll@HIDDEN>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20201220172839.3059-1-vincent.legoll@HIDDEN>
References: <20201220172839.3059-1-vincent.legoll@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/guix-install.sh (chk_init_sys): Call `chk_require daemonize'.
---
 etc/guix-install.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 307c42d3fb..ecc86f3e76 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -153,6 +153,10 @@ chk_init_sys()
     elif /sbin/init --version 2>/dev/null | grep -q SysV; then
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
+        chk_require daemonize || {
+            _err "${ERR}Init system: sysv-init requires the 'daemonize' package."
+            exit 1
+        }
         return 0
     elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC\) ]]; then
         _msg "${INF}init system is: OpenRC"
-- 
2.29.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] New reduced patchset, the easy bits first
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Dec 2020 17:31:02 +0000
Resent-Message-ID: <handler.40601.B40601.16084854268938 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Christopher Baines <mail@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16084854268938
          (code B ref 40601); Sun, 20 Dec 2020 17:31:02 +0000
Received: (at 40601) by debbugs.gnu.org; 20 Dec 2020 17:30:26 +0000
Received: from localhost ([127.0.0.1]:45511 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kr2XJ-0002Jo-Om
	for submit <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:30:25 -0500
Received: from mail-lf1-f52.google.com ([209.85.167.52]:35544)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1kr2XH-0002CC-GK
 for 40601 <at> debbugs.gnu.org; Sun, 20 Dec 2020 12:30:24 -0500
Received: by mail-lf1-f52.google.com with SMTP id h22so8669095lfu.2
 for <40601 <at> debbugs.gnu.org>; Sun, 20 Dec 2020 09:30:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=BXOvI7u3jopCVZKyGUe7GXNW5514DPvv4w4+aW+QKDg=;
 b=X2StZsAo2v39CPjCzHeluJIs5siJAGt+iK4TyOolvOpEsxqwGIamlwafyo7OBa7Id9
 PFY91J9wwRN5myXaDQSuQgyDXMTA8gFZruQOaR6i8d1kp2qVzDs2rkGcgpFpKzggGj7S
 nolMnPQ7f6L+H4k39Yv3VcCjCYwq5gOMbICJ0CBQ61hwVwGu+dKO4nxNbtjjCsLHf9cF
 t9yvD5o78yCnHRRKvwlqQYZdHXBRyCnZwUndswsZjHh6pCZxsX74HVW3nVilYooEO7rk
 wl6aLaY/PlJW/5sOMB6BYWkcUmDw22xrWBtSQ4XITXQ+qkWh8t8GeE+J+9KVCJ2khu1b
 mIdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=BXOvI7u3jopCVZKyGUe7GXNW5514DPvv4w4+aW+QKDg=;
 b=DK4W96K7ywaINTThgl/uqD75+MC6jEVYVVRRVqk0tbB6eZr9rIRu3knDVMdQidpybf
 d7pGMQxI9vRxePFARDyMHczBRal2cB/ioIiR8ccWkV1Q7wbWTLq17oUTAK/11fS8FSCT
 Hzg+a/fpD0v1Z/uJSo0jcrt5C6jzYiBJRIsUNxPOIze1bYgPLtlFbA20Ktyqi8xGVKJ7
 mE7Z1sfafk7tmdNJtIn0HD+JDO5iRFAees7P08QtWBDKBbN1gkjbcgNYCk+VeDWqC1Ll
 Hrqje4fefy/lKYtSjTdF8nXUhQZ8tNOaoumRivvhcI7ItPimhXI8wdS8FIJI6BSIR7MY
 7cwA==
X-Gm-Message-State: AOAM530U1W7PeUrLKcms4pAIhJ3rpvZWIth9hsoSm1c8JiF/E7EYOs/Q
 ZSWnXeLz94nv88qhI5j7Yjf3svPkTp51KottEgEJEtBo
X-Google-Smtp-Source: ABdhPJzaHrpu1KzavG6J5p0cMzfiIEUoIIp3f0QkwHzOCseIYnF30Cq177A+svO24gZ7oGuubD7S7CiFttFrjQ7LvFU=
X-Received: by 2002:a05:6512:94f:: with SMTP id
 u15mr4773722lft.389.1608485417459; 
 Sun, 20 Dec 2020 09:30:17 -0800 (PST)
MIME-Version: 1.0
References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@HIDDEN>
 <00b505a4-0c1a-2f6c-7242-57d7b5eb7d4f@HIDDEN> <87v9cz1eo5.fsf@HIDDEN>
 <CAEwRq=pUX4v4_OBA=THq7JYk+ef15HDFpPkD-6HmtZkx854KJA@HIDDEN>
In-Reply-To: <CAEwRq=pUX4v4_OBA=THq7JYk+ef15HDFpPkD-6HmtZkx854KJA@HIDDEN>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Sun, 20 Dec 2020 18:30:05 +0100
Message-ID: <CAEwRq=obFfwN+b55nGvZ1OubxVVp6fagFam-YpdrjRy6t+2YEw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

I rebased and sent the next batch

On Fri, Dec 18, 2020 at 8:35 PM Vincent Legoll <vincent.legoll@HIDDEN> wrote:
>
> Hello,
>
> > Thanks for sending a smaller set of patches, that makes reviewing
> > easier. I made some tweaks, and pushed 4 commits to master as
> > d2532317d136ac063a24baeec6688ea0e0ebe37b.
>
> Thanks for taking care of this, I'll have a look.
>
> > I'm not sure about the bashisms stuff, given the script seems to depend
> > on bash (see the exec bash bit at the start), I think using bash
> > functionality is reasonable. What was your motivation behind these
> > changes? (sorry if I've missed this earlier in the thread).
>
> Some distributions that I intended to add support for don't default to bash
> (nor have it installed by default). I think this script should aim for
> the broadest
> possible support, but that is only my opinion.
>
> And the patch set was not finished, I wanted to tackle the low hanging fruits
> first (also to test the interest from the guix team before doing too much).
>
> > Maybe once we've talked about the bashisms stuff, would you be able to
> > send another set of patches for review?
>
> I'll try to revive the patch set, and submit other portions I should have lying
> somewhere.
>
> Tchuss
>
> --
> Vincent Legoll



-- 
Vincent Legoll

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 2/5] guix-install.sh: Remove $UID bashism.
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Dec 2020 12:18:02 +0000
Resent-Message-ID: <handler.40601.B40601.16087258729847 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Vincent Legoll <vincent.legoll@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.16087258729847
          (code B ref 40601); Wed, 23 Dec 2020 12:18:02 +0000
Received: (at 40601) by debbugs.gnu.org; 23 Dec 2020 12:17:52 +0000
Received: from localhost ([127.0.0.1]:52289 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ks35U-0002Yl-9S
	for submit <at> debbugs.gnu.org; Wed, 23 Dec 2020 07:17:52 -0500
Received: from mira.cbaines.net ([212.71.252.8]:53126)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1ks35R-0002Yd-Uy
 for 40601 <at> debbugs.gnu.org; Wed, 23 Dec 2020 07:17:51 -0500
Received: from localhost (188.29.98.108.threembb.co.uk [188.29.98.108])
 by mira.cbaines.net (Postfix) with ESMTPSA id 1E13A27BC05;
 Wed, 23 Dec 2020 12:17:49 +0000 (GMT)
Received: from capella (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id f822405b;
 Wed, 23 Dec 2020 12:17:46 +0000 (UTC)
References: <20201220172839.3059-1-vincent.legoll@HIDDEN>
 <20201220172839.3059-2-vincent.legoll@HIDDEN>
User-agent: mu4e 1.4.13; emacs 27.1
From: Christopher Baines <mail@HIDDEN>
In-reply-to: <20201220172839.3059-2-vincent.legoll@HIDDEN>
Date: Wed, 23 Dec 2020 12:17:46 +0000
Message-ID: <874kkcbtsl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Vincent Legoll <vincent.legoll@HIDDEN> writes:

> * etc/guix-install.sh: Use `id -u' instead of $UID.
> ---
>  etc/guix-install.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index 26c8622855..0102901010 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -32,7 +32,7 @@ fi
>=20=20
>  set -e
>=20=20
> -[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
> +[ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit =
1; }
>=20=20
>  REQUIRE=3D(
>      "dirname"

Should id be added as a requirement?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/jNWpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xff4RAAqMyideqviA2RZITw4HRcGRDGDYzNwgaz
fQZNWWSrg2GLUNxAqyfeHOZm0gLwPYje9EH8KcNAVG5+NPj9QqDXcAdY2mEftqdV
IlxnZ+guZpWw7BccYseCqsGHb4Ns0wACkKP1lFKrX/fQsjQZoyFJEPJKimkggblY
7dKsJ9T7PI4DKJDQDv4zZgLM8BiqtjPrc1FMKxR8v5SJ3hRGp1jf8RwobIFl9zqf
i0/Zpm+9nchZPuBcBhpVF00O4Jode1x2A1a0kNUGDF6hNSeM6HmtoePLqyGOWxIk
SSN2YxSHEkppKLGMWVOm4KKBZyDWAxvpVLkU6aLHMWAt2IhBR9RJabMDeAtwyt/M
nDAc7UypGCzx5fH3mR5Y3CosWji50Dsa+c1tr2cmfEu3AMeR+UEsymJkpp4lLUDV
7qEYXOAcNQLYszvCG3iqrPgUNVXi1vDa4fTp2slqPY4VLYL7xosE6NRmESIX8Fyc
WCZBJFzuTzY05EbW/WQIXU+KM12e8bt/nHmpamZd/I4An9Qo5bWHZOoH+8+Wn3d+
GAvnxQo/JQ/11+IgfRpOeypNhM7wuiPzsn1hOKJ0Hge3ekGMXZPTaRWwpzQ0lywT
wPdQiP6ftm1hEMtgKNGnfnNpjSssA6aobTmOJKDdT94IPWTcqOXOcIDb4PDZnPZX
LzmESX8/Qwc=
=yZax
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#40601] [PATCH 2/5] guix-install.sh: Remove $UID bashism.
Resent-From: Vincent Legoll <vincent.legoll@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Dec 2020 15:00:02 +0000
Resent-Message-ID: <handler.40601.B40601.160873556110180 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 40601
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Christopher Baines <mail@HIDDEN>
Cc: 40601 <at> debbugs.gnu.org
Received: via spool by 40601-submit <at> debbugs.gnu.org id=B40601.160873556110180
          (code B ref 40601); Wed, 23 Dec 2020 15:00:02 +0000
Received: (at 40601) by debbugs.gnu.org; 23 Dec 2020 14:59:21 +0000
Received: from localhost ([127.0.0.1]:53801 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ks5bl-0002e8-KX
	for submit <at> debbugs.gnu.org; Wed, 23 Dec 2020 09:59:21 -0500
Received: from mail-lf1-f48.google.com ([209.85.167.48]:39361)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.legoll@HIDDEN>) id 1ks5bi-0002dq-AD
 for 40601 <at> debbugs.gnu.org; Wed, 23 Dec 2020 09:59:21 -0500
Received: by mail-lf1-f48.google.com with SMTP id a12so40737410lfl.6
 for <40601 <at> debbugs.gnu.org>; Wed, 23 Dec 2020 06:59:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=n+WwnB0V2R4AizcWwkRQ03C4MpRYvn4kCAOB4S5+bPs=;
 b=qeabBzJNNCi6HFNqbLF9+tQOGXXgzmwGSTYnFajgQEJkrW3wJBKLqWOu8IuNybrcNC
 cPzbTDYtmuL2U6q3WPV42xWKPQWx22N3h1Qz8MmsAYzr2w7hEJ+DfajVMWRR2cbDWy+a
 SyISwUV/6T+2THXa7eZo5sffKplBn2P7H7QmcxSphxsO8ni5FFgvTThQVAPBmsez2kko
 fyUv72nZvfLI3nJVAlEWsSp+zgNvUDkuMUaW/AqtuSa6i3PDRUyDvB5gjP98L5Nd7jUe
 88xQN8LUNEQyKg++c/u+t8bRPo9MQe8OSpPl3EmJJAMphzWSq9xYGKkqCiYLYSHOp2UX
 3CNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=n+WwnB0V2R4AizcWwkRQ03C4MpRYvn4kCAOB4S5+bPs=;
 b=OBkDkkodp8TdUEPzcB/2eeSDVmLPU6ctcFn2G+qM8tBtZVxQyw4kHBUIMR1ODvW7ZO
 91tikKCYdEUS6NX3VTAt3CsFEuhtWvORgyohAwIt7hLohaDWn+183vyFMOpe9Yxebxy2
 Vbx9pXByVhGipcRDTFMz34S61gSmqhbZq3ihMasICDP+ww4oVMcGkZsvZzGhN4cvnq4E
 5dDVr9Or1ADkf11+2mD+xIGM2u3ygmCgBcXqOJN86Fpo7EP8R5+XpgCrnHsL4HCH2++3
 1g9Iv/f8CWZQr6Inm9EPMrU+DsB3khiEuxd8uVKpZUVAGOZnl6PsrElwGCAsZAV8Apoi
 ZjLQ==
X-Gm-Message-State: AOAM533LZW+ZRZZW68N+tVYarfMW5jzVNwoK8lUEWGFBDYlKNQcTzwF+
 H/WyFJ6UEMMRJ+ilVhNWNWT6lHR8hd4v7iJ8c94=
X-Google-Smtp-Source: ABdhPJwmM7u6bppYSH7mLZbaWIx6VYgDEz52uA2eaqzz18+LmjmFBMsk45emPsjQvC74j7SV1mbqlyFBvEw7C/7Y5OU=
X-Received: by 2002:a2e:89d7:: with SMTP id c23mr11717698ljk.282.1608735552065; 
 Wed, 23 Dec 2020 06:59:12 -0800 (PST)
MIME-Version: 1.0
References: <20201220172839.3059-1-vincent.legoll@HIDDEN>
 <20201220172839.3059-2-vincent.legoll@HIDDEN> <874kkcbtsl.fsf@HIDDEN>
In-Reply-To: <874kkcbtsl.fsf@HIDDEN>
From: Vincent Legoll <vincent.legoll@HIDDEN>
Date: Wed, 23 Dec 2020 15:59:00 +0100
Message-ID: <CAEwRq=rtUUZeoKFZRaeHvmzVy1Jb++H3TBScpXTDHL_Szf7j4g@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

On Wed, Dec 23, 2020 at 1:17 PM Christopher Baines <mail@HIDDEN> wrote:
> > -[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
> > +[ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
> >
> >  REQUIRE=(
> >      "dirname"
>
> Should id be added as a requirement?

good catch !

thanks, I'll respin after this round of feedback

-- 
Vincent Legoll

Last modified: Wed, 23 Dec 2020 15:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.