GNU bug report logs - #40613
[PATCH] gnu: Add emacs-typing.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40613 in the body.
You can then email your comments to 40613 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx>
To: bug-guix <at> gnu.org
Subject: [PATCH] gnu: Add emacs-typing.
Date: Mon, 13 Apr 2020 19:11:24 -0500

* gnu/packages/emacs-xyz.scm (emacs-typing): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3631535da..6acbee00d3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22499,3 +22499,25 @@ which can be embedded in source code, comments or emails.")
 @code{4clojure.com} problems, you can open an specific question and move
 the next or previos.  You can also check you answers.")
    (license license:gpl3)))
+
+(define-public emacs-typing
+  (package
+    (name "emacs-typing")
+    (version "1.1.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/kensanata/typing.git")
+             (commit "a2ef25dde2d8eb91bd9c0c6164cb5208208647fa")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1dbh0srbf54lgd60ia79y9cfnq3kxlgw01qzdjs9mk3nfazzpgnv"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/kensanata/typing/")
+    (synopsis "Emacs game where you have to type fast")
+    (description "@code{emacs-typing} is a game for Emacs that
+forces you to type words correctly as fast as possible, otherwise
+you will die.  The game builds the list of words from the active buffer")
+    (license license:gpl2)))
-- 
2.26.0

Message #8 received at 40613 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 40591 <at> debbugs.gnu.org, 40593 <at> debbugs.gnu.org, 40616 <at> debbugs.gnu.org,
 40613 <at> debbugs.gnu.org
Date: Tue, 14 Apr 2020 02:55:02 +0200

[Message part 1 (text/plain, inline)]

For the record (and any reviewers), these patches should be 
applied in order:

#40591 emacs-org-roam
#40593 emacs-uml-mode
#40616 emacs-4clojure
#40613 emacs-typing

They're not interdependent, just patch-context-dependent.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40613 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx>
Cc: 40613 <at> debbugs.gnu.org
Subject: Re: bug#40613: [PATCH] gnu: Add emacs-typing.
Date: Tue, 14 Apr 2020 23:47:26 +0200

Hello,

Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx> writes:

> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.

Thank you.

> +(define-public emacs-typing
> +  (package
> +    (name "emacs-typing")
> +    (version "1.1.4")

This is not a regular release, this is extracted from the main file. We
need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".

> +    (description "@code{emacs-typing} is a game for Emacs that

I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
name of the game instead of the symbol.

> +forces you to type words correctly as fast as possible, otherwise
> +you will die.  The game builds the list of words from the active buffer")

The description is missing a final dot.

> +    (license license:gpl2)))

The license is gpl2+.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #16 received at 40613-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40613-done <at> debbugs.gnu.org,
 Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx>
Subject: Re: bug#40613: [PATCH] gnu: Add emacs-typing.
Date: Thu, 22 Oct 2020 17:33:17 -0400

Hello Nicolas, Alberto,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.
>
> Thank you.
>
>> +(define-public emacs-typing
>> +  (package
>> +    (name "emacs-typing")
>> +    (version "1.1.4")
>
> This is not a regular release, this is extracted from the main file. We
> need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".
>
>> +    (description "@code{emacs-typing} is a game for Emacs that
>
> I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
> name of the game instead of the symbol.
>
>> +forces you to type words correctly as fast as possible, otherwise
>> +you will die.  The game builds the list of words from the active buffer")
>
> The description is missing a final dot.
>
>> +    (license license:gpl2)))
>
> The license is gpl2+.
>
> Could you send an updated patch?

I modified the original definition with your above suggestions and
pushed as commit a49bfa1f6c22363c9e495070f51b82e60b1495af.

Closing.

Thank you!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.