GNU bug report logs - #40641
Building from git breaks when /bin/sh isn't bash

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Reported by: elaexuotee@HIDDEN; dated Wed, 15 Apr 2020 11:07:02 UTC; Maintainer for guix is bug-guix@HIDDEN.

Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 21 Jul 2022 15:29:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 21 11:29:25 2022
Received: from localhost ([127.0.0.1]:38678 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEY7B-0008R0-4X
	for submit <at> debbugs.gnu.org; Thu, 21 Jul 2022 11:29:25 -0400
Received: from mail-qk1-f180.google.com ([209.85.222.180]:38802)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1oEY76-0008Ql-Pt
 for 40641 <at> debbugs.gnu.org; Thu, 21 Jul 2022 11:29:23 -0400
Received: by mail-qk1-f180.google.com with SMTP id e16so1539105qka.5
 for <40641 <at> debbugs.gnu.org>; Thu, 21 Jul 2022 08:29:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=GNKrFD/UYKXKyHYvuGGquf1z+KK0TgNMxSlfV0/IHsw=;
 b=keLb5P02TxjDTej2qpbOv6CYRKf/D9oaPuYjE++n87NLVaq42mT+y+0nS8UXuUwn2T
 9hTQ60imiCSOGdenuyu6bbbDcIn3gmkcmQWy3oF2i3hdI5N0Fl8wGqB6jUkPUhQT6X1Q
 DOBLfHD5VnGWymCjSiT4Gg4OHy3JmPN+zPNWEG8+BuhQVHur8GO3HKPqvwyvOrQqyRlr
 jYQtYOPMZNJcmkpiFEMyxYGNyRmu+fH3LSzeXiWn8R5SgwtoHSt9eSUkhunGxhOLUEIR
 kbl55LOh/NXZOmCipUINNnyFHL3lj1G+bVr5PWtu7GM/2truH3lDhpXKMfaxjjo7rVew
 iE/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=GNKrFD/UYKXKyHYvuGGquf1z+KK0TgNMxSlfV0/IHsw=;
 b=8BsA9PUGSIvwkXotw6/slr+u34e5eHSg8MLuXVxoG8UqnPwHl/aNckl19u9pZ3XGCp
 5anLevK+zTV+zq8JVpcadFZAU05jz6GPsq48YozO9Rt7/MgxBBIbsJPNZgf2l2el+viA
 qd9MD5U3K/TbrmvogH2Nt+u0N1rhf2og5FF83YGMeR//OAh+WsADJ0JjVEsviYt5r0Nw
 ykJ4CYJYpkj89a/fivpaJsSLQwN9FobyrrG/MAQNlM7Dq9zvguRGMCisGMRLIdSaMwV1
 VH/Scp6+Gxbah95rzaUW/QiC3qcSdfKvzJbnwW8rtFSN0n09vzFoDc+zevpxmvDIPbbT
 LfMw==
X-Gm-Message-State: AJIora+JNYWScZhBxa8rn8Sm/T5kcQmTUJud4jqgvbmLo696t3MtQiyZ
 Y4gOwMSiVsNdrWrZ0MGrtQUPdkiLxL0=
X-Google-Smtp-Source: AGRyM1v53NZMtwdHKGcjN/GgXbd/uge2zeoA601613suun9G2tNfQJN4ahkDm7ssb1bLUExJrGweuQ==
X-Received: by 2002:a05:620a:1709:b0:6b5:ea99:472 with SMTP id
 az9-20020a05620a170900b006b5ea990472mr14410561qkb.486.1658417354948; 
 Thu, 21 Jul 2022 08:29:14 -0700 (PDT)
Received: from hurd (dsl-157-32.b2b2c.ca. [66.158.157.32])
 by smtp.gmail.com with ESMTPSA id
 u20-20020ac858d4000000b00304f3e320f2sm1539400qta.4.2022.07.21.08.29.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Jul 2022 08:29:14 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: elaexuotee@HIDDEN
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
 <87mtdhftw7.fsf@HIDDEN>
 <62caa649.1c69fb81.5b288.1112SMTPIN_ADDED_BROKEN@HIDDEN>
 <87wnckeo8j.fsf@HIDDEN> <87h73nep5x.fsf@HIDDEN>
 <3NB75IRB8776E.2JKL61N4Y2UUG@HIDDEN>
Date: Thu, 21 Jul 2022 11:29:13 -0400
In-Reply-To: <3NB75IRB8776E.2JKL61N4Y2UUG@HIDDEN>
 (elaexuotee@HIDDEN's message of "Tue, 19 Jul 2022 13:14:03
 +0900")
Message-ID: <8735euqyba.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

elaexuotee@HIDDEN writes:

> Maxim Cournoyer <maxim.cournoyer@HIDDEN> wrote:
>> I'll see if these Bashisms can be easily switched to POSIX variants,
>> else I'll experiment with setting the shebang of the test scripts to
>> bash.
>
> Is there any particular reason to go this route?

I can think of at least two:

1. GNU Autotools is designed to work across as many systems as possible,
and produces POSIX-compliant shell scripts such as configure; thus
keeping things in our build system (including the tests authored in
shell scripts) POSIX allows to build and test Guix from source in many
environments, not only in 'guix shell -D guix'.

2. Messing with Autotools-managed variables such as 'SHELL' may end up
causing confusions for those relying on Autotools documented behavior.

> Writing portable scripts is full of all sorts of pitfalls and ill-meaning
> dragons:
>
> - What if SHELL=tcsh?
> - What about incompatible behaviour between bash versions?
> - Do we want to write tests to future-proof fixes for the above?

You actually don't need to care about Bash incompatible behavior when
targetting POSIX shell script.  If the user goes out of their way to use
a non-POSIX shell... well they are on their own.

> In this case, since the build is running inside a guix shell, I don't really
> see any reason to *not* effectively pin the scripts to use the bash available
> in that environment.

That's true for the specific use case where someone tries to build Guix
inside a 'guix shell -D guix' environment, but there are also people
attempting to build Guix using they system provided dependencies and
shell, where the fix wouldn't help.

My previous experiment showed that the Bashisms used seem limited to
perhaps 2 tests; it doesn't seem too difficult to fix them using the
'shellcheck' tool to spot what syntax used is problematic and needs to
be adjusted.

Thanks,

Maxim

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 19 Jul 2022 04:14:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 19 00:14:20 2022
Received: from localhost ([127.0.0.1]:52532 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDecl-0007qW-JQ
	for submit <at> debbugs.gnu.org; Tue, 19 Jul 2022 00:14:20 -0400
Received: from m42-5.mailgun.net ([69.72.42.5]:61102)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bounce+148a03.08547a-40641=debbugs.gnu.org@HIDDEN>)
 id 1oDecf-0007qD-KO
 for 40641 <at> debbugs.gnu.org; Tue, 19 Jul 2022 00:14:17 -0400
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com;
 q=dns/txt; 
 s=krs; t=1658204053; x=1658412853; h=Message-Id: In-Reply-To:
 References: From: From: Subject: Subject: Cc: To: To: Date: Sender:
 Sender; bh=5cgJF+AnXyyjsrZUCOF2z4t6UCJ35V6EOq6ewugV5HQ=;
 b=fUmauhlmbZ9CAzIWgO+HGd+zeS5V4K5n91KYwOlNeujpoGqnBFMg7at1X556SgMFVUhkcGH9
 9p0P5A5ZYa6INmGgDaF4ZxDXxUQyxpKKGYhRj6MYDOVylpxtAoxoukUa30Ejqq4UZxVyMDpP
 /B+L7e9b6Iei6AlH52qjEo6LNxVD5Kt3ArmiIRcS8iXJWlH0Zujrfxo4p1tz5R/ydCMy5mna
 7GesKHbuDdYRGH3JczPdVdnPtsQhOSFIPexD55BF7GepOtwQ2Um5JH8QVhtyFI4GR/7ufwZI
 1fxCyTyO4SqF9x/WrtaYjZPyeDQGeqKR4kMIiPOHBlq/Bz4EMkB83Q==
X-Mailgun-Sending-Ip: 69.72.42.5
X-Mailgun-Sid: WyIxYmE0NCIsICI0MDY0MUBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0=
Received: from wilsonb.com (wilsonb.com [104.199.203.42]) by 647734358e59
 with SMTP id 62d62f8f520016f5e1b7fcae (version=TLS1.3,
 cipher=TLS_AES_128_GCM_SHA256); Tue, 19 Jul 2022 04:14:07 GMT
Received: from localhost (aj099096.dynamic.ppp.asahi-net.or.jp [220.150.99.96])
 by wilsonb.com (Postfix) with ESMTPSA id 58592A2926;
 Tue, 19 Jul 2022 04:14:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com;
 s=201703; t=1658204045;
 bh=5cgJF+AnXyyjsrZUCOF2z4t6UCJ35V6EOq6ewugV5HQ=;
 h=Date:To:Cc:Subject:From:References:In-Reply-To:From;
 b=Z8VShqF9jHIO9EoKtKGwnXW55CqshEk2GmSqOL5FIRzF41s3PUpremlHEHyJxYz5T
 7BoK19atfprmJsUmUP8mLI31GeJpUy/esICdmGDrRBT1qNQiGwmjagFum04pzaRixN
 /boZi5m9bPmaxJTOnwzPMqB9jm/zhvuV2ROsjJ7cEK0MwjBkpQpsmhHgzIEogHjsTt
 8SXLH1GGgkrZHIcQIYXK9CmloortyAxzwi2AVHOHJkzx9qt9HdnSYxN4SWb1kylkIQ
 aW0QQCSDqWCkIk4R519Ibg06QAqiA2IZQgfAq+7/jsdpQXDdfWv3Vdgx2WdGzcr+4D
 0fk5CyidzrSLakY40mgXiQlHJk0a6o9OI3+VxipKSF8h/Va/WwqGbRc6XkEGWZJjsJ
 xzhstUf2463RIBK0DDjN98HHqLhQLXQBT/4ez6aUxFtXCc6j69fF2MDJIRAyjLQIVk
 iPaEU/8yafm/Zwndt+RvMm0/fAp7QR0BC5qJZ0klSTHP+uMROm+eJmtx04fR3E1NxF
 mU3+n3wD7Vx8hGW05EwC7ZIZ3Ubrs2r3GNPbmGrVoAAjULlcN0jDrt+mYi1Yp1Vo8K
 NeWCmBMNiqsh5VYwq3RZc7+M29zALGNb97bOAMA2oo6kW/R8ZE8DW9DHo6RGttZmxl
 dExdZjGQEFbKUWOVvh5GcstI=
Date: Tue, 19 Jul 2022 13:14:03 +0900
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
From: elaexuotee@HIDDEN
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
 <87mtdhftw7.fsf@HIDDEN>
 <62caa649.1c69fb81.5b288.1112SMTPIN_ADDED_BROKEN@HIDDEN>
 <87wnckeo8j.fsf@HIDDEN> <87h73nep5x.fsf@HIDDEN>
In-Reply-To: <87h73nep5x.fsf@HIDDEN>
Message-Id: <3NB75IRB8776E.2JKL61N4Y2UUG@HIDDEN>
User-Agent: mblaze/1.2
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Maxim Cournoyer <maxim.cournoyer@HIDDEN> wrote:
> I'll see if these Bashisms can be easily switched to POSIX variants,
> else I'll experiment with setting the shebang of the test scripts to
> bash.

Is there any particular reason to go this route?

Writing portable scripts is full of all sorts of pitfalls and ill-meaning
dragons:

- What if SHELL=tcsh?
- What about incompatible behaviour between bash versions?
- Do we want to write tests to future-proof fixes for the above?

In this case, since the build is running inside a guix shell, I don't really
see any reason to *not* effectively pin the scripts to use the bash available
in that environment.

Am I missing something?

Cheers,
B

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 11 Jul 2022 13:48:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 11 09:48:25 2022
Received: from localhost ([127.0.0.1]:38914 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oAtlt-0004b8-43
	for submit <at> debbugs.gnu.org; Mon, 11 Jul 2022 09:48:25 -0400
Received: from mail-qt1-f180.google.com ([209.85.160.180]:37598)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1oAtlq-0004aj-S4
 for 40641 <at> debbugs.gnu.org; Mon, 11 Jul 2022 09:48:20 -0400
Received: by mail-qt1-f180.google.com with SMTP id j29so6523944qtv.4
 for <40641 <at> debbugs.gnu.org>; Mon, 11 Jul 2022 06:48:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=pmMfXv3dfFn3gAn5/enF6CtUyKdaaIqDWq/cNkioIY0=;
 b=Ku56iwIxqw3BDkOw+WCB6txmEGfu+GxvQSQPNqCyGGLIveBuuc0lB/72BYg+zomtks
 pnDO7NIC9RgYQYdieF/Pj82gdghnEQuu0Rd73bi/3FxfMGnZDh0BvAi6z7a/3HFozzUK
 lph+/pYZQIKij8BzJ3wvCzBRJeKXwaWQ30kODQM36nJMjYJAdFLb9KpDu0Y5RcYYTFjd
 bS/JNMXqqEGAa14rnyZmhMPE5G15ItgnaNI5qr6U3Lh/XA5Q8fZpIvJqm/k27YfwoAZU
 UkTnPEmNxbuqwQ/9AezeRAdLy2Mv4h8cVu+37Gk0s3/zZXENWn+pwHj1BCxwu111orOV
 oFPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=pmMfXv3dfFn3gAn5/enF6CtUyKdaaIqDWq/cNkioIY0=;
 b=Ga/qoJOgnhBnSMI51SHfnLBp5X5x0kLEC8DSgnLwKLeHHC6iijm7KREbuE+ey4IgS1
 tIuuuOzSXjchdtfi0KamGrzEb/ZHo473ufeOpmkIsGHpNKlbd4gOVMdk2w2jwq1M8ef/
 kUNS8+yKT6GVqvzIXHgXc7pM3r49nEu+htHcAudoCAlPKGbnEwwAnacx4Kdw+jm3myFk
 vp62nJj9zb0U/3wQZlotOs5+9pSfYekJUN2O7jsGabBFx7lsMx3hvG/ovTqnRi6X7GIK
 YKuEJp2qsOI59hYn+YLEWhO36A51LMujHKfVvZxgzdd1DXiP85TRCPgWbOQNpgaBYRUv
 d4cA==
X-Gm-Message-State: AJIora/YQbOvgQz0po0KW9ifayOD/UGpQvmc8YaUHwZHkkugpMb26gky
 7J33MIXWkk+k2lpfHIc+wq6UzPYXiYfbHg==
X-Google-Smtp-Source: AGRyM1sRvvK9SdkzrfXIhDapEpjeEQ5nNTX/WhjY0RMHpc5N2jjGtrGmoNh7lAa+AzUtkZMsLJYBxw==
X-Received: by 2002:a05:622a:152:b0:31b:bf62:9e78 with SMTP id
 v18-20020a05622a015200b0031bbf629e78mr13249004qtw.363.1657547292514; 
 Mon, 11 Jul 2022 06:48:12 -0700 (PDT)
Received: from hurd (dsl-155-226.b2b2c.ca. [66.158.155.226])
 by smtp.gmail.com with ESMTPSA id
 q22-20020a05620a2a5600b006b58facde91sm1734956qkp.106.2022.07.11.06.48.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 11 Jul 2022 06:48:11 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: elaexuotee@HIDDEN
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
 <87mtdhftw7.fsf@HIDDEN>
 <62caa649.1c69fb81.5b288.1112SMTPIN_ADDED_BROKEN@HIDDEN>
 <87wnckeo8j.fsf@HIDDEN>
Date: Mon, 11 Jul 2022 09:48:10 -0400
In-Reply-To: <87wnckeo8j.fsf@HIDDEN> (Maxim Cournoyer's message of "Sun, 10
 Jul 2022 15:55:56 -0400")
Message-ID: <87h73nep5x.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

[...]

> I've just 'ln -sf $(guix build dash)/bin/dash /bin/sh && export
> SHELL=3D/bin/sh' on my Guix System, and could rebuild Guix master from
> scratch successfully:
>
> make[1]: Leaving directory '/home/maxim/src/guix-master'
> $ echo $?
> 0
> $ ./pre-inst-env guix describe
> Git checkout:
>   repository: /home/maxim/src/guix/.git/worktrees
>   branch: test-dash-as-bin-sh
>   commit: bf0a646a5bcde489b602c58fbb63a93acb9d08f6
> $ echo $SHELL
> /bin/sh
> $ ls -al /bin/sh
> lrwxrwxrwx 1 root root 66 Jul 10 15:11 /bin/sh -> /gnu/store/nm0hccsphymx=
i8c24xmg6ixm9vcf25xb-dash-0.5.11.5/bin/dash
> $ grep SHELL Makefile
> [...]
> SHELL =3D /bin/sh
>
> I'll now try the tests.

I've now done so, and there are only 3 tests that fail due to /bin/sh ->
dash:

--8<---------------cut here---------------start------------->8---
FAIL: tests/guix-package.sh
FAIL: tests/guix-home.sh
FAIL: tests/guix-repl.sh

FAIL: tests/guix-package
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

+ guix package --version
guix package (GNU Guix) 1.3.0.22041-bf0a6
Copyright (C) 2022 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.htm=
l>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
+ module_dir=3Dt-guix-package-16322
+ profile=3Dt-profile-16322
+ tmpfile=3Dt-guix-package-file-16322
+ rm -f t-profile-16322 t-guix-package-file-16322
+ trap rm -f "$profile" "$profile.lock" "$profile-"[0-9]* "$tmpfile"; rm -r=
f "$module_dir" t-home-16322 EXIT
+ guix package --bootstrap -e +
guix package: error: expression "+" does not evaluate to a package
+ guix build guile-bootstrap
accepted connection from pid 16340, user maxim
+ guix package --bootstrap -p t-profile-16322 -i /home/maxim/src/guix-maste=
r/test-tmp/store/ff4yyg2g39ri2zpm0lbmvc2s2f5addv3-guile-bootstrap-2.0
accepted connection from pid 16347, user maxim
The following package will be installed:
   guile-bootstrap 2.0

The following derivation will be built:
  /home/maxim/src/guix-master/test-tmp/store/4m9bi66d6b4lvj33n792flj071cxip=
1k-profile.drv

building profile with 1 package...
hint: Consider setting the necessary environment variables by running:

     GUIX_PROFILE=3D"/home/maxim/src/guix-master/t-profile-16322"
     . "$GUIX_PROFILE/etc/profile"

Alternately, see `guix package --search-paths -p "/home/maxim/src/guix-mast=
er/t-profile-16322"'.

+ guix package -A guile-bootstrap
+ cut -f 1-2
+ guix package -p t-profile-16322 -I
+ cut -f 1-2
+ test guile-bootstrap	2.0 =3D guile-bootstrap	2.0
+ guix package -p t-profile-16322 -I
+ cut -f 3
+ test out =3D out
+ rm t-profile-16322
+ guix package --bootstrap -p t-profile-16322 -i guile-bootstrap
accepted connection from pid 16381, user maxim
The following package will be installed:
   guile-bootstrap 2.0

hint: Consider setting the necessary environment variables by running:

     GUIX_PROFILE=3D"/home/maxim/src/guix-master/t-profile-16322"
     . "$GUIX_PROFILE/etc/profile"

Alternately, see `guix package --search-paths -p "/home/maxim/src/guix-mast=
er/t-profile-16322"'.

+ test -L t-profile-16322
+ test -L t-profile-16322-1-link
+ test -f t-profile-16322/bin/guile
+ guix gc --list-live
+ readlink t-profile-16322-1-link
+ grep /home/maxim/src/guix-master/test-tmp/store/bbxfpsy329libdc30s62az73w=
8x0b7cv-profile
accepted connection from pid 16388, user maxim
finding garbage collector roots...
accepted connection from pid 16397, user maxim
determining live/dead paths...
/home/maxim/src/guix-master/test-tmp/store/bbxfpsy329libdc30s62az73w8x0b7cv=
-profile
+ guix package --bootstrap -p t-profile-16322 -i guile-bootstrap
accepted connection from pid 16404, user maxim
The following package will be upgraded:
   guile-bootstrap (dependencies or package changed)

nothing to be done
+ test -L t-profile-16322
+ test -L t-profile-16322-1-link
+ test -f t-profile-16322-2-link
+ test -f t-profile-16322/bin/guile
+ guix package -e (begin (use-modules (guix) (gnu packages base)) (package =
(inherit sed) (supported-systems (list)))) -n
accepted connection from pid 16411, user maxim
The following package would be installed:
   sed 4.8

guix package: error: package sed@HIDDEN does not support x86_64-linux
+ uname -m
+ guix package -i novena-eeprom -n
accepted connection from pid 16419, user maxim
The following package would be installed:
   novena-eeprom 2.3

guix package: error: package novena-eeprom@HIDDEN does not support x86_64-linux
+ break
+ guix package --bootstrap -n -p t-profile-16322 -i g-wrap guile@HIDDEN
accepted connection from pid 16427, user maxim
The following packages would be installed:
   g-wrap 1.9.15
   guile  2.0.14

guix package: error: profile contains conflicting entries for guile
guix package: error:   first entry: guile@HIDDEN /home/maxim/src/guix-maste=
r/test-tmp/store/7f6yrypzqyppdcap71ya9342i4kmb3wd-guile-2.0.14
guix package: error:   second entry: guile@HIDDEN /home/maxim/src/guix-maste=
r/test-tmp/store/wsnd10ajsz7vaapw2bxp8rw4h4x86406-guile-2.2.7
guix package: error:    ... propagated from g-wrap@HIDDEN
hint: Backtrace:
In ice-9/eval.scm:
    619:8 19 (_ #(#(#<directory (guile-user) 7f4e08128c80>)))
In guix/ui.scm:
   2238:7 18 (run-guix . _)
  2201:10 17 (run-guix-command _ . _)
In ice-9/boot-9.scm:
  1752:10 16 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In guix/status.scm:
    835:3 15 (_)
    815:4 14 (call-with-status-report _ _)
In guix/store.scm:
   1298:8 13 (call-with-build-handler #<procedure 7f4e06dfb2d0 at guix/ui.s=
cm:1170:2 (continue store =E2=80=A6> =E2=80=A6)
In guix/build/syscalls.scm:
   1425:3 12 (_)
   1392:4 11 (call-with-file-lock/no-wait _ _ _)
In guix/scripts/package.scm:
   151:19 10 (build-and-use-profile #<store-connection 256.99 7f4e081390a0>=
 "t-profile-16322" #<<mani=E2=80=A6> =E2=80=A6)
In guix/store.scm:
  2168:25  9 (run-with-store #<store-connection 256.99 7f4e081390a0> _ #:gu=
ile-for-build _ #:system _ # =E2=80=A6)
In guix/profiles.scm:
   1935:2  8 (_ _)
    358:4  7 (_ _)
In guix/store.scm:
   1883:0  6 (loop _ _)
In ice-9/boot-9.scm:
  1685:16  5 (raise-exception _ #:continuable? _)
In guix/ui.scm:
   757:16  4 (_ _)
   310:42  3 (display-hint "Try upgrading both @code{guile} and @code{g-wra=
p},\nor remove one of them=E2=80=A6" =E2=80=A6)
In ice-9/boot-9.scm:
  1747:15  2 (with-exception-handler #<procedure 7f4df271fdb0 at ice-9/boot=
-9.scm:1831:7 (exn)> _ # _ # =E2=80=A6)
In guix/build/syscalls.scm:
  2284:35  1 (_)
   2273:8  0 (terminal-window-size _)

guix/build/syscalls.scm:2273:8: In procedure terminal-window-size:
In procedure terminal-window-size: Inappropriate ioctl for device
+ guix package --bootstrap -n -p t-profile-16322 -i g-wrap guile@HIDDEN --allo=
w-collisions
accepted connection from pid 16434, user maxim
The following packages would be installed:
   g-wrap 1.9.15
   guile  2.0.14

+ guix package -p t-profile-16322 --search-paths
export PATH=3D"t-profile-16322/bin"
+ guix package -p t-profile-16322 --search-paths
+ grep ^export PATH=3D
export PATH=3D"t-profile-16322/bin"
+ guix package -p t-profile-16322 --search-paths
+ wc -l
+ test 1 =3D 1
+ set -e
+ set -x
+ guix package --search-paths=3Dprefix -p /home/maxim/src/guix-master/t-pro=
file-16322
+ eval export PATH=3D"/home/maxim/src/guix-master/t-profile-16322/bin${PATH=
:+:}$PATH"
+ export PATH=3D/home/maxim/src/guix-master/t-profile-16322/bin:/home/maxim=
/src/guix-master/scripts:/home/maxim/src/guix-master:/gnu/store/18zvp6m7c63=
r66849g0pj20bxi3mc501-profile/bin:/gnu/store/18zvp6m7c63r66849g0pj20bxi3mc5=
01-profile/sbin:/home/maxim/.nix-profile/bin:/home/maxim/.local/bin/:/run/s=
etuid-programs:/home/maxim/.config/guix/current/bin:/home/maxim/.guix-profi=
le/bin:/home/maxim/.guix-profile/sbin:/run/current-system/profile/bin:/run/=
current-system/profile/sbin
+ type -P guile
+ test -P: not found
guile is /home/maxim/src/guix-master/t-profile-16322/bin/guile =3D /home/ma=
xim/src/guix-master/t-profile-16322/bin/guile
+ rm -f t-profile-16322 t-profile-16322.lock t-profile-16322-1-link t-guix-=
package-file-16322
+ rm -rf t-guix-package-16322 t-home-16322
FAIL tests/guix-package.sh (exit status: 1)

cause: test -P


FAIL: tests/guix-home
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

+ set -e
+ guix home --version
guix show (GNU Guix) 1.3.0.22041-bf0a6
Copyright (C) 2022 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.htm=
l>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
+ guile -c (use-modules (guix config))(display %storedir)
+ NIX_STORE_DIR=3D/gnu/store
+ guile -c (use-modules (guix config))(display %localstatedir)
+ localstatedir=3D/var
+ GUIX_DAEMON_SOCKET=3D/var/guix/daemon-socket/socket
+ export NIX_STORE_DIR GUIX_DAEMON_SOCKET
+ guile -c (use-modules (guix)) (exit (false-if-exception (open-connection)=
))
+ dirname /gnu/store
+ STORE_PARENT=3D/gnu
+ export STORE_PARENT
+ test /gnu =3D /
+ mktemp -d
+ test_directory=3D/tmp/tmp.OAmVzSob58
+ trap chmod -Rf +w "$test_directory"; rm -rf "$test_directory" EXIT
+ cd /tmp/tmp.OAmVzSob58
+ cat
+ echo -n # dot-bashrc test file for guix home
+ guix home extension-graph home.scm
+ grep label =3D "home-activation"
  "140636280345728" [label =3D "home-activation", shape =3D box, fontname =
=3D sans];
+ guix home extension-graph home.scm
+ grep label =3D "home-symlink-manager"
  "140025808877824" [label =3D "home-symlink-manager", shape =3D box, fontn=
ame =3D sans];
+ guix home extension-graph home.scm
+ grep label =3D "home"
  "139908936525792" [label =3D "home", shape =3D box, fontname =3D sans];
+ guix home shepherd-graph home.scm
guix home: error: service of type 'home-shepherd' not found
+ container_supported
+ guile -c ((@ (guix scripts environment) assert-container-features))
+ return 0
+ guix home container home.scm -- true
[...]
The following derivations will be built:
  /gnu/store/2xy8zsfkw9v91ryin87ppqdj88ig4p84-home.drv
  /gnu/store/0s1m03p4vdcsxcy4iy0p7yn0i4bjbh3c-on-first-login.drv
  /gnu/store/c2py3dx3izjfslsdn6g7m1y0pvaz52ya-profile.drv
  /gnu/store/fwlni5mm6k9sv78xhrzl8gs6ypsqcwsw-activate.drv
  /gnu/store/4badi8l0vfddhg2hkn1rlbpk4f3s17r5-update-symlinks.drv

43.0 MB will be downloaded
listing Emacs sub-directories...
building profile with 2 packages...
...........................................
building /gnu/store/0s1m03p4vdcsxcy4iy0p7yn0i4bjbh3c-on-first-login.drv...
building /gnu/store/4badi8l0vfddhg2hkn1rlbpk4f3s17r5-update-symlinks.drv...
The following build is still in progress:
  /gnu/store/4badi8l0vfddhg2hkn1rlbpk4f3s17r5-update-symlinks.drv

building /gnu/store/fwlni5mm6k9sv78xhrzl8gs6ypsqcwsw-activate.drv...
building /gnu/store/2xy8zsfkw9v91ryin87ppqdj88ig4p84-home.drv...
substitute: .substitute: .[Kupdating substitutes from 'http://127.0.0.1:818=
1'...   0.0%.substitute: .[Kupdating substitutes from 'http://127.0.0.1:818=
1'... 100.0%
substitute: .substitute: .[Kupdating substitutes from 'https://ci.guix.gnu.=
org'...   0.0%.substitute: .[Kupdating substitutes from 'https://ci.guix.gn=
u.org'... 100.0%
substitute: .substitute: .[Kupdating substitutes from 'https://bordeaux.gui=
x.gnu.org'...   0.0%.substitute: .[Kupdating substitutes from 'https://bord=
eaux.guix.gnu.org'... 100.0%
The following derivations will be built:
  /gnu/store/j60d0x8dfg97l4rgrxhra2v66zcyv4g3-module-import.drv
  /gnu/store/a707jiqfsd287442lhx5k6l8rr68a4lp-module-import-compiled.drv
  /gnu/store/s4578ab9is6z1akkhg76dk9a03w78bj4-home-system-profile.drv

building /gnu/store/j60d0x8dfg97l4rgrxhra2v66zcyv4g3-module-import.drv...
listing Emacs sub-directories...
The following build is still in progress:
  /gnu/store/j60d0x8dfg97l4rgrxhra2v66zcyv4g3-module-import.drv

building profile with 1 package...
The following build is still in progress:
  /gnu/store/j60d0x8dfg97l4rgrxhra2v66zcyv4g3-module-import.drv

building /gnu/store/a707jiqfsd287442lhx5k6l8rr68a4lp-module-import-compiled=
.drv...
[...]
+ guix home container home.scm -- echo $HOME
+ test /home/maxim =3D /home/maxim
+ + guix home container home.scmgrep -- the content of cat
 ~/.config/test.conf
the content of ~/.config/test.conf
+ guix home container home.scm -- test -h ~/.bashrc
+ guix home container home.scm -- id -u
+ test 1000 =3D 1000
+ guix home container home.scm -- test -f $HOME/sample/home.scm
+ guix home container home.scm --expose=3D/tmp/tmp.OAmVzSob58=3D/home/maxim=
/sample -- test -f $HOME/sample/home.scm
+ guix home container home.scm --expose=3D/tmp/tmp.OAmVzSob58=3D/home/maxim=
/sample -- rm -v $HOME/sample/home.scm
rm: cannot remove '/home/maxim/sample/home.scm': Read-only file system
+ HOME=3D/tmp/tmp.OAmVzSob58
+ export HOME
+ echo # This file will be overridden and backed up.
+ mkdir /tmp/tmp.OAmVzSob58/.config
+ echo This file will be overridden too.
+ echo This file will stay around.
+ guix home reconfigure /tmp/tmp.OAmVzSob58/home.scm
guix home: warning: cannot determine provenance for current system
Symlinking /tmp/tmp.OAmVzSob58/.profile -> /gnu/store/dann7r1095xll0kji5yl0=
ql07096rc8j-shell-profile... done
Symlinking /tmp/tmp.OAmVzSob58/.bash_profile -> /gnu/store/flqaxzvgfv2g3415=
mhmq6c0zbzdzv2k4-bash_profile... done
Backing up /tmp/tmp.OAmVzSob58/.bashrc... done
Symlinking /tmp/tmp.OAmVzSob58/.bashrc -> /gnu/store/npd40qqa8hsvm7p5aqc3sj=
79hxjsrdin-bashrc... done
Backing up /tmp/tmp.OAmVzSob58/.config/test.conf... done
Symlinking /tmp/tmp.OAmVzSob58/.config/test.conf -> /gnu/store/bdixb09v30bv=
hpgi2f6ndiq25wzb9l74-tmp-file.txt... done
Symlinking /tmp/tmp.OAmVzSob58/.config/fontconfig/fonts.conf -> /gnu/store/=
4261pxafny0g2myhh9yj1771ry7k05lc-fonts.conf... done
 done
Finished updating symlinks.

Comparing /gnu/store/non-existing-generation/profile/share/fonts and
          /gnu/store/18h8fhfkpfyl8mvkfn9za8sj7dyxzzd4-home/profile/share/fo=
nts... done (same)
Evaluating on-change gexps.

On-change gexps evaluation finished.

+ test -d /tmp/tmp.OAmVzSob58/.guix-home
+ test -h /tmp/tmp.OAmVzSob58/.bash_profile
+ test -h /tmp/tmp.OAmVzSob58/.bashrc
+ tail -n 2 /tmp/tmp.OAmVzSob58/.bashrc
+ test # dot-bashrc test file for guix home
# the content of bashrc-test-config.sh =3D=3D # dot-bashrc test file for gu=
ix home
# the content of bashrc-test-config.sh
./tests/guix-home.sh: 137: test: # dot-bashrc test file for guix home
# the content of bashrc-test-config.sh: unexpected operator
+ chmod -Rf +w /tmp/tmp.OAmVzSob58
+ rm -rf /tmp/tmp.OAmVzSob58
FAIL tests/guix-home.sh (exit status: 2)

cause: bashism in bashrc-test-config.sh


FAIL: tests/guix-repl
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

+ guix repl --version
guix repl (GNU Guix) 1.3.0.22041-bf0a6
Copyright (C) 2022 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.htm=
l>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
+ mktemp -d
+ test_directory=3D/tmp/tmp.PREwMwz2Ln
+ export test_directory
+ trap chmod -Rf +w "$test_directory"; rm -rf "$test_directory" EXIT
+ tmpfile=3D/tmp/tmp.PREwMwz2Ln/foo.scm
+ rm -f /tmp/tmp.PREwMwz2Ln/foo.scm
+ trap rm -f "$tmpfile" EXIT
+ module_dir=3Dt-guix-repl-19912
+ mkdir t-guix-repl-19912
+ trap rm -rf "$module_dir" EXIT
+ cat
+ guix repl /tmp/tmp.PREwMwz2Ln/foo.scm
+ test coreutils =3D coreutils
+ dirname /tmp/tmp.PREwMwz2Ln/foo.scm
+ cd /tmp/tmp.PREwMwz2Ln
+ basename /tmp/tmp.PREwMwz2Ln/foo.scm
+ guix repl foo.scm
+ test coreutils =3D coreutils
+ cat
+ cat
+ guix repl /tmp/tmp.PREwMwz2Ln/foo.scm -L t-guix-repl-19912
+ test 42 =3D 42
+ cat
+ guix repl -- /tmp/tmp.PREwMwz2Ln/foo.scm -a b --input=3Dfoo.txt
+ test (-a b --input=3Dfoo.txt) =3D (-a b --input=3Dfoo.txt)
+ type -P env
+ cat
+ chmod 755 /tmp/tmp.PREwMwz2Ln/foo.scm
+ /tmp/tmp.PREwMwz2Ln/foo.scm -a b --input=3Dfoo.txt
./tests/guix-repl.sh: 1: /tmp/tmp.PREwMwz2Ln/foo.scm: not found
+ test  =3D (-a b --input=3Dfoo.txt)
+ rm -rf t-guix-repl-19912
FAIL tests/guix-repl.sh (exit status: 1)

cause: type -P
--8<---------------cut here---------------end--------------->8---

I'll see if these Bashisms can be easily switched to POSIX variants,
else I'll experiment with setting the shebang of the test scripts to
bash.

Thanks,

Maxim

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 10 Jul 2022 19:56:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 10 15:56:06 2022
Received: from localhost ([127.0.0.1]:37813 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oAd2E-00045Z-5v
	for submit <at> debbugs.gnu.org; Sun, 10 Jul 2022 15:56:06 -0400
Received: from mail-qk1-f180.google.com ([209.85.222.180]:36818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1oAd2C-000455-IW
 for 40641 <at> debbugs.gnu.org; Sun, 10 Jul 2022 15:56:04 -0400
Received: by mail-qk1-f180.google.com with SMTP id b2so27154qkk.3
 for <40641 <at> debbugs.gnu.org>; Sun, 10 Jul 2022 12:56:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=l3jjDAx8Mft8NDCI5aS+1jCx1/xeRu3JENv68XxZQHU=;
 b=kOuHqyZOeyS2SPvDPil7r4MhWOt7HPJV7WoVZO99dIGryLsJZ1U6o4CLrzP9gWx5dD
 O0EIZF4r2tm4YitL9wi3u2FbBH7LoODI91uxHVWKYsc5hZEjWVQAuuYdvpQZG9jOEgu7
 wK7lgXc9AH9/knSUHk7CvPSdEiQOgVY7z+UBJcXbjp75smMa2oR3qtUCDcHsXLGhStPJ
 ttiAxR9kitAHnAxOt5Jm2uQIYH2LfE390j4KFGgevO5xBC6FqnX+Zl43/DMpzM0P31pq
 ThJATMzrovfPsmjRgevrafdrJVltpmb4OQ/Z/gRJ6lcoO9jeeCMX2q07HrG6/pnH/Wca
 BF7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=l3jjDAx8Mft8NDCI5aS+1jCx1/xeRu3JENv68XxZQHU=;
 b=KEe/D4ZPi9jXfH+mMsg4gPTcH+oMa08jX/22PrhR/OoznIMdUFSgxkbBrRgiyvpI/m
 uEFQ50NldbOAAUgCtZVvtxnK4CyQSI+Jml/5vZASAqZuXzfFLvHVn5if6VrYOH4O0Czi
 B0MFN8xeD6GZXVg4u7sVc+K10GsJyVSIaWLIoHuO70hPcFz/eZArNMOoABH65QOtnZgS
 te/h6q+33UNA4YYQyIq6yETDpEafLrItd51/VJtFaya086KAKIievRXN0l/6RrM2b2XO
 hZZWCBpc8p2SOuANBZAGltT7lGLv8s+ySsqA1Xs6L4sQz08SwlSZJ8KbJwYTRKjeTeeL
 StOg==
X-Gm-Message-State: AJIora+n3kfJsv+F84c/dVYYQ+QKbWevG2d3PgXR6GB15QkpP78kF/u9
 z9N0HOT6AMVc5+2znjOfntf67Oh4RZwudw==
X-Google-Smtp-Source: AGRyM1sY7fGeEcuh8+xU6f4tltPaVSao3mSESGAr3nDe2Af2cDlsuJwFyeUVBBFTh3qYh3bk1L7NiQ==
X-Received: by 2002:a05:620a:288a:b0:6b5:3d7d:5c22 with SMTP id
 j10-20020a05620a288a00b006b53d7d5c22mr9061114qkp.603.1657482958689; 
 Sun, 10 Jul 2022 12:55:58 -0700 (PDT)
Received: from hurd (dsl-10-135-142.b2b2c.ca. [72.10.135.142])
 by smtp.gmail.com with ESMTPSA id
 f20-20020a05620a409400b006b5840f3eefsm1503955qko.130.2022.07.10.12.55.57
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 10 Jul 2022 12:55:58 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: elaexuotee@HIDDEN
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
 <87mtdhftw7.fsf@HIDDEN>
 <62caa649.1c69fb81.5b288.1112SMTPIN_ADDED_BROKEN@HIDDEN>
Date: Sun, 10 Jul 2022 15:55:56 -0400
In-Reply-To: <62caa649.1c69fb81.5b288.1112SMTPIN_ADDED_BROKEN@HIDDEN>
 (elaexuotee@HIDDEN's message of "Sun, 10 Jul 2022 19:13:24
 +0900")
Message-ID: <87wnckeo8j.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

elaexuotee@HIDDEN writes:

> CONFIG_SHELL simply acts as a user override; it's not part of autoconf's core
> logic. That role belongs to the SHELL macro, who's picks the first available of
> the following:
>
> - CONFIG_SHELL environment variable,
> - SHELL environment variable, or
> - /bin/sh
>
> See autoconf's m4sugar/m4sh.m4 for the gory details. Arguably, this should
> also be updated to point to a fixed /bin/sh output fallback.
>
> Anyway, AM_SUBST_NOTMAKE([SHELL]), cf. '(automake) Optional', simply tells
> automake to not define SHELL inside the generated Makefile. This means that
> make will instead use it's default, which in our case is hard-coded to the
> /bin/sh in its implicit bash-minimal dependency. For detailed info about this
> behaviour of make, see '(make) Choosing the Shell'. Note, however, you will
> have to do a mental sed-replace of "/bin/sh" with "<bash-minimal>/bin/sh" when
> reading that page.

Thanks for the extra details.  So if I understand correctly, and
re-reading your original message, the issue is that some tests shell
scripts contain Bashisms that fail to run on POSIX shells such as Dash?
Couldn't we just identify these tests with the proper shebang?
e.g. '#!/usr/bin/env bash' where it is required?

I've just 'ln -sf $(guix build dash)/bin/dash /bin/sh && export
SHELL=/bin/sh' on my Guix System, and could rebuild Guix master from
scratch successfully:

make[1]: Leaving directory '/home/maxim/src/guix-master'
$ echo $?
0
$ ./pre-inst-env guix describe
Git checkout:
  repository: /home/maxim/src/guix/.git/worktrees
  branch: test-dash-as-bin-sh
  commit: bf0a646a5bcde489b602c58fbb63a93acb9d08f6
$ echo $SHELL
/bin/sh
$ ls -al /bin/sh
lrwxrwxrwx 1 root root 66 Jul 10 15:11 /bin/sh -> /gnu/store/nm0hccsphymxi8c24xmg6ixm9vcf25xb-dash-0.5.11.5/bin/dash
$ grep SHELL Makefile
[...]
SHELL = /bin/sh

I'll now try the tests.

Thanks,

Maxim

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 10 Jul 2022 10:13:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 10 06:13:36 2022
Received: from localhost ([127.0.0.1]:36266 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oATwW-0004u0-Cu
	for submit <at> debbugs.gnu.org; Sun, 10 Jul 2022 06:13:36 -0400
Received: from m42-5.mailgun.net ([69.72.42.5]:14344)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bounce+148a03.08547a-40641=debbugs.gnu.org@HIDDEN>)
 id 1oATwU-0004tj-Nf
 for 40641 <at> debbugs.gnu.org; Sun, 10 Jul 2022 06:13:35 -0400
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com;
 q=dns/txt; 
 s=krs; t=1657448014; x=1657656814; h=Content-Transfer-Encoding:
 Content-Type: MIME-Version: Message-Id: In-Reply-To: References: From:
 From: Subject: Subject: Cc: To: To: Date: Sender: Sender;
 bh=xqq2S6JfxGmqjx4PGmeZnQxuqPMSkmzZsEsEbA/Iwl4=;
 b=tL+Zb0Qqt4RjfDxAcg/tPynjWx2ZI1c/aWEJUGoD3XTpU8ULIvT/Z4CtdMkqwRYmEsCMtdc9
 l3/59J+KB+dcZ+ezcEDKQdamf8T8hZ5gEHq0CicfKN8IMDpgKZMpOg1W3doYVBrzakRkVoEK
 cjxsjokff5Duk2SEy6UxPnmRH0cmxLmwEfw8PpVPSZtnsHOYDFq/6ww5WUrE4t22drsFGRfp
 RDGG/LU/dX0H0gM9Gh6LzyLUGPzNrqXFzhFoH5xM8IFBbFkaT/MFq4u2lA6CRmsE0Ml6b+8/
 omlFmE+7ZgOtCfrVOPKFev8ieiWlIHf2oJ42Z/HCeR3DDpSxJyKPPA==
X-Mailgun-Sending-Ip: 69.72.42.5
X-Mailgun-Sid: WyIxYmE0NCIsICI0MDY0MUBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0=
Received: from wilsonb.com (wilsonb.com [104.199.203.42]) by f72a003d2efe
 with SMTP id 62caa649be79400f6724c915 (version=TLS1.3,
 cipher=TLS_AES_128_GCM_SHA256); Sun, 10 Jul 2022 10:13:29 GMT
Received: from localhost (aj099096.dynamic.ppp.asahi-net.or.jp [220.150.99.96])
 by wilsonb.com (Postfix) with ESMTPSA id 06CEBA2938;
 Sun, 10 Jul 2022 10:13:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com;
 s=201703; t=1657448007;
 bh=xqq2S6JfxGmqjx4PGmeZnQxuqPMSkmzZsEsEbA/Iwl4=;
 h=Date:To:Cc:Subject:From:References:In-Reply-To:From;
 b=oUyW3ZAPLWXMX4lMJ/hgHbZRv30R9kiNDZjq4JqyANRZ4/OP8P/PoF1yPdmeeim4d
 nT7erbctDni/Egnm5JRZJjKwcvqp5ERhbOdJi+cQddZYl7PNutNqaFNjMrXM/MuaRC
 NM7Zeh0ONDyAosD6gFOONXsDbZc7MVK7A8CkC1nfUTo1McV+d6Sd5toT6sQTEsgR+2
 wBb9owsvAct+kQzlKBao9SPZWfP3gGo9NbJbm2WpNEzFnY6vlKKbhvrum3BxU/eImT
 BSayC1oGzBVOS837PJWjdD08J7J/UZ8exghExcjyZ4IQO81+BqjEMHWy31CwaGT4a7
 s0vRyuoyJrwZPzQc4k8aXpCh5h/DMaBD6DC1V/nPdM+5i5/rMSVn0PDhYTKLYMf3Pr
 ZaQCMhzbBjeR3pRXO3K8mZVjCzRZdvJTqMoZmuIZTau0WSR5Fm9ptHKwb90wUtwhef
 +kVqftLjELCGq5mK7bs6KnF9S1HBPvzfkBcTbztiEtEy2Xlv8jAzTQjyn7okepGhAE
 eGUeHvQ4F4n3HV9E6KWHbG6M/s/YXj9O4ldgoGkMTMKtWnmhaNaHV607Ad5J6MRg+v
 qwrm3onNcCVvtpXGlxsChhJBCh/rGW223oXsTObChB3rePBFfAj8cgV6DmiGyzcJW3
 4pmkz9UHCJ0vY5xbQkTctfFQ=
Date: Sun, 10 Jul 2022 19:13:24 +0900
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
From: elaexuotee@HIDDEN
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
 <87mtdhftw7.fsf@HIDDEN>
In-Reply-To: <87mtdhftw7.fsf@HIDDEN>
Message-Id: <33RZXP6OBFFCS.22N5QDGK5AQQA@"@WILSONB.COM>
User-Agent: mblaze/1.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 2.2 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  CONFIG_SHELL simply acts as a user override; it's not part
 of autoconf's core logic. That role belongs to the SHELL macro, who's picks
 the first available of the following: - CONFIG_SHELL environment variable,
 - SHELL environment variable, or - /bin/sh 
 Content analysis details:   (2.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.0 MSGID_MULTIPLE_AT      Message-ID contains multiple '@' characters
 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
 bl.spamcop.net
 [Blocked - see <https://www.spamcop.net/bl.shtml?69.72.42.5>]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [69.72.42.5 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [69.72.42.5 listed in wl.mailspike.net]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  CONFIG_SHELL simply acts as a user override; it's not part
    of autoconf's core logic. That role belongs to the SHELL macro, who's picks
    the first available of the following: - CONFIG_SHELL environment variable,
    - SHELL environment variable, or - /bin/sh 
 
 Content analysis details:   (1.2 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
                              no trust
                             [69.72.42.5 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
                             [69.72.42.5 listed in wl.mailspike.net]
  1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
                             bl.spamcop.net
                  [Blocked - see <https://www.spamcop.net/bl.shtml?69.72.42.5>]
  1.0 MSGID_MULTIPLE_AT      Message-ID contains multiple '@' characters
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

CONFIG_SHELL simply acts as a user override; it's not part of autoconf's co=
re
logic. That role belongs to the SHELL macro, who's picks the first availabl=
e of
the following:

- CONFIG_SHELL environment variable,
- SHELL environment variable, or
- /bin/sh

See autoconf's m4sugar/m4sh.m4 for the gory details. Arguably, this should
also be updated to point to a fixed /bin/sh output fallback.

Anyway, AM_SUBST_NOTMAKE([SHELL]), cf. '(automake) Optional', simply tells
automake to not define SHELL inside the generated Makefile. This means that=

make will instead use it's default, which in our case is hard-coded to the
/bin/sh in its implicit bash-minimal dependency. For detailed info about th=
is
behaviour of make, see '(make) Choosing the Shell'. Note, however, you will=

have to do a mental sed-replace of "/bin/sh" with "<bash-minimal>/bin/sh" w=
hen
reading that page.


Cheers,
B.

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 10 Jul 2022 04:56:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 10 00:56:19 2022
Received: from localhost ([127.0.0.1]:36144 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oAOzS-0004hv-MF
	for submit <at> debbugs.gnu.org; Sun, 10 Jul 2022 00:56:19 -0400
Received: from mail-qt1-f173.google.com ([209.85.160.173]:33450)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1oAOzQ-0004hj-LT
 for 40641 <at> debbugs.gnu.org; Sun, 10 Jul 2022 00:56:17 -0400
Received: by mail-qt1-f173.google.com with SMTP id r2so3538605qta.0
 for <40641 <at> debbugs.gnu.org>; Sat, 09 Jul 2022 21:56:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=6Gri++a2tR0Pccs7JlCDuakQcEeZ+fKkPkJ+cx661gk=;
 b=eeHQvHq1Ll9d89XPhJCq7DjB3clUCP33MGrIdvb4WkYdMPAYVGquEd6fOGBksn8ipj
 OV1ZWL0T/o+0m3BOCvgP4Xp+3zHaqODA8mGiLlzhgPzst2wL5s++7No4TfzIRkEvixgZ
 V6CzUX9lVjumMFm/RMOZ9kMw+f76AagyOyuqjiu3OUM5hYMXBio2R83BIFVCzwEzcDhs
 s7ywRonIx31elPdkBnsCl0pppLJ08+Ufi2rq7hlEbplp4fOkkqKgBFLyayq2SO2JT4Dg
 iHtos3OtxpTT3Hj6NYwgM4JdWYVgChQzczlymrtLyn2CeY3OLKK2HcDVp3Z8uICaWH/o
 6VeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=6Gri++a2tR0Pccs7JlCDuakQcEeZ+fKkPkJ+cx661gk=;
 b=Q9qlNp0e0BgBZVaiG4Cqt5obESvm7VHKvm07ALR53+n9vMPF90FHb8NnwDtceOkIe7
 AAbVh5W1WK7NBPKWUg6PiwzsIt8lYrfK/xyKTeqtb/7oafqsk/hnEU/WgV16xjxRgc2m
 0QRgumjmlVFJUjOg3ubt4KZ3OzRon3sftCi1rWRb+RrPsEHG6LtcjuqeKIgppdbAy1Tu
 MGucjz85G+xw7ISGlvmeT9N/FoTMT2jR79wYpWxYDoe4A0+VWz190WvYodxvhYN0YGzp
 uk0mi3Ripn5ZFbiy4erGfFNhnx1O0I6cGxQucAHrikk60cYAr1H/IbnrgI0cyo3e2M+Z
 daPQ==
X-Gm-Message-State: AJIora8eEKN9JGrQkkx5zFWAcfdzUtR0CSIRbPcps3FmmL+4qBdtRi7R
 vNXev0ULdMbooiylgt+Mq690jj6n7Rl1/w==
X-Google-Smtp-Source: AGRyM1vwuQf2Rlwzl2EzPC02/xumYIGl67VPHOxx5mRSVgamkVf+FWxObljKZBDEL8kWnPuy3QlNSQ==
X-Received: by 2002:ac8:5846:0:b0:31d:40aa:4c41 with SMTP id
 h6-20020ac85846000000b0031d40aa4c41mr9570086qth.662.1657428970730; 
 Sat, 09 Jul 2022 21:56:10 -0700 (PDT)
Received: from hurd (dsl-10-135-142.b2b2c.ca. [72.10.135.142])
 by smtp.gmail.com with ESMTPSA id
 w30-20020a05620a0e9e00b006b3583a106esm2899731qkm.87.2022.07.09.21.56.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 09 Jul 2022 21:56:10 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
Date: Sun, 10 Jul 2022 00:56:08 -0400
In-Reply-To: <878rp4c7em.fsf@HIDDEN> (pelzflorian@HIDDEN's
 message of "Fri, 08 Jul 2022 10:53:21 +0200")
Message-ID: <87mtdhftw7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, elaexuotee@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

"pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN> writes:

> Wait wait Maxim, the discussion was that
> "B. Wilson" <elaexuotee@HIDDEN> proposed
>> [PATCH] build: Let make use its hard-coded default shell
>  > To: guix-patches@HIDDEN
>>
>  > * configure.ac: Set AM_SUBST_NOTMAKE([SHELL])
>  > +# Use make's hard-coded default shell. The make in a guix profile
>  > +# defaults to the Right Thing, e.g. $GUIX_ENVIRONMENT/bin/sh
>> +AM_SUBST_NOTMAKE([SHELL])
>
> Then Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:
>> This seems odd to me. Perhaps it'd be cleaner to detect which shell is
>  > used at configure time to detect when /bin/sh !=3D Bash, and warn that=
 if
>  > there are issues, the user should set the SHELL variable to Bash.
>
> elaexuotee@HIDDEN writes:
>> Excellent. I agree it's probably not worth POSIXifying the scripts. Forc=
ing
>> make to default to guix's bash seems like the right approach IMHO, so +1=
 for
>> that fix.
>
> I think we=E2=80=99re not on the same page.  Is AM_SUBST_NOTMAKE([SHELL])=
 really
> problematic?  Is seems like there is a legitimate use-case that foreign
> distro users with /bin/sh =3D dash would want =E2=80=9Cguix shell -D guix=
 -- make=E2=80=9D
> to just work without workaround?  We could use elaexuotee=E2=80=99s
> AM_SUBST_NOTMAKE([SHELL]) patch, could we not?

Indeed, I had misunderstood, apologies.  I've read the Autoconf/Automake
Info manuals about AM_SUBST and AM_SUBST_NOTMAKE, but I don't have a
clear understanding of the mechanisms involved.

from info '(autoconf) config.status Invocation':

 -- Variable: CONFIG_SHELL
     The shell with which to run =E2=80=98configure=E2=80=99.  It must be
     Bourne-compatible, and the absolute name of the shell should be
     passed.  The default is a shell that supports =E2=80=98LINENO=E2=80=99=
 if
     available, and =E2=80=98/bin/sh=E2=80=99 otherwise.

So it appears to me that by default, it'd look for a shell that supports
LINENO if available, such as /bin/bash or something else?  E.g., not use
the user's SHELL environment variable directly, but that can be
overridden with CONFIG_SHELL.

Using AC_SUBST_NOTMAKE([SHELL]) would cause SHELL to be substituted in
the build system files but prevent setting Make variables such as SHELL
=3D '/bin/...' in generated Makefiles...  how do that end up causing the
Guix-provided Make to use its own "known" shell?

It seems to me that a potential pitfall would be that by adding
AC_SUBST_NOTMAKE([SHELL]), we'd change the default behavior of Autoconf,
which is to honor CONFIG_SHELL and set the SHELL Make variable based on
that; it seems it could be simpler to document that users on systems
using a Bourne incompatible shell should set CONFIG_SHELL to a Bourne
compatible one to build Guix from sources.

Is someone able to explain how the suggested fix work in more details?

Thanks,

Maxim

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 8 Jul 2022 09:52:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 08 05:52:14 2022
Received: from localhost ([127.0.0.1]:58872 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9kek-0005qF-7l
	for submit <at> debbugs.gnu.org; Fri, 08 Jul 2022 05:52:14 -0400
Received: from m42-5.mailgun.net ([69.72.42.5]:16455)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bounce+148a03.08547a-40641=debbugs.gnu.org@HIDDEN>)
 id 1o9keh-0005pu-9J
 for 40641 <at> debbugs.gnu.org; Fri, 08 Jul 2022 05:52:13 -0400
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com;
 q=dns/txt; 
 s=krs; t=1657273931; x=1657482731; h=Content-Transfer-Encoding:
 Content-Type: MIME-Version: Message-Id: In-Reply-To: References: From:
 From: Subject: Subject: Cc: To: To: Date: Sender: Sender;
 bh=BdPNJC/nVU81FLUy/e2D7GIRzWdhwhrFkoXpfEoRyAw=;
 b=dooEzaYZ0ukWRiqtzwzJkPQyn9hfKkAHbtAx3Vff2GP8w2ucZ0P/zh2s4z6gcYoIcT9Qvido
 ogOEtd+Sho2azU4JDWP9UXH+5wFsdKIGrsL+yP9wQwX73Zm7kc3ii1CtFFzOxZusaNqGVSUK
 64FnAMHRcQzxFILfJ70ANwVEqA3AjcfveMvRydiBlP3sg+CRlq7e3t5XRhwFB7nyDSPtUDXD
 3t81UaRPXOsp++NwWM8Hzvz+OL80fMy+2u8GU2vXFoqmVEK8E1D/oytxLfMD4KB58gcgxHtH
 2FFVEbBrXQyTvgY0ayHLzLK0JINM3+RDm/Ws5A6Z2qsdbEOlZi0LlA==
X-Mailgun-Sending-Ip: 69.72.42.5
X-Mailgun-Sid: WyIxYmE0NCIsICI0MDY0MUBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0=
Received: from wilsonb.com (wilsonb.com [104.199.203.42]) by 505391622f3a
 with SMTP id 62c7fe444f6d8044a831af56 (version=TLS1.3,
 cipher=TLS_AES_128_GCM_SHA256); Fri, 08 Jul 2022 09:52:04 GMT
Received: from localhost (aj099096.dynamic.ppp.asahi-net.or.jp [220.150.99.96])
 by wilsonb.com (Postfix) with ESMTPSA id D682CA292F;
 Fri,  8 Jul 2022 09:52:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com;
 s=201703; t=1657273922;
 bh=BdPNJC/nVU81FLUy/e2D7GIRzWdhwhrFkoXpfEoRyAw=;
 h=Date:To:Cc:Subject:From:References:In-Reply-To:From;
 b=PKWskBNjDLFQ/9sGcatdPk5TqlSKQlF6VPHCkIi2ZLZSPjyyCBW5HyhFTC50yolN5
 /h9G02iM0QqjUmIhx3DZzzWoXyX8k3dxc19nvRb5DSoMyzkUvEwOdKlM4mJ8goRbev
 kCv6CpXmmn+42DC3QDonYj8svo9hp62IBgXPklhax2WmPoJruKhZpyKAT7RDBzhbpX
 +WBVB49TRJEFJAxLARmaQTVKzW1fpLGzfCvtfEt+AB4okhEWpW7dLi65XCtzPIpQLK
 OWLPymagjpmn/J4ecR2S80GHvl7PV6SRL3TWzGNYwoUVdDQeiQ2AmgzcDjElN1dczX
 qaApW6FsYJbckdz/3peMGDiklD2WsN8LH3pHEXHQ79dHHr7IfYSamw+MrCtewwqJb5
 oTsxclEfbFKfh5flAE7g0rHOdjH6K1wwG7bUkAGDB1elnjKO3POEazM6AuASSTxPYj
 L4rF8twWGA0ku2Py8EcWXSo4aZxyDK4F3KhzF9ZDbR6gdH9hD77TiCLHjCw3lzxTyL
 THu2FfDKtsO8vXwtg7uO1gGJYoh/APnzqmk1vXCgaOPpe+5ubpsrpak9l+0BEqkf/b
 67c3xmlXVaijR7T+UJnz0UHedsLV0ih3XJSMp/iOM5zZviZCeiFp9Gi03FN8FHYwNY
 4xa+CbfyvASLqAuB/nLxERbQ=
Date: Fri, 08 Jul 2022 18:51:59 +0900
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
From: elaexuotee@HIDDEN
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
In-Reply-To: <878rp4c7em.fsf@HIDDEN>
Message-Id: <3VE840YMQJPO2.2G4HBP5YDDIV4@"@WILSONB.COM>
User-Agent: mblaze/1.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

> I think we=E2=80=99re not on the same page.  Is AM_SUBST_NOTMAKE([SHELL])=
 really
> problematic?  Is seems like there is a legitimate use-case that foreign
> distro users with /bin/sh =3D dash would want =E2=80=9Cguix shell -D guix=
 -- make=E2=80=9D
> to just work without workaround?  We could use elaexuotee=E2=80=99s
> AM_SUBST_NOTMAKE([SHELL]) patch, could we not?

Just to be clear, that CONFIG_SHELL workaround was a giant pain to figure o=
ut.
The errors produced when /bin/sh =3D dash are not at all obvious as to the =
root
cause, and finding the existence of CONFIG_SHELL takes a certain familiarit=
y
with autoconf, which I didn't have until significant manual reading.

Seems pretty draconian to leave that for foreign distro devs if we do indee=
d
have a good fix.

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 8 Jul 2022 08:58:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 08 04:58:08 2022
Received: from localhost ([127.0.0.1]:58821 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9joO-00016a-2l
	for submit <at> debbugs.gnu.org; Fri, 08 Jul 2022 04:58:08 -0400
Received: from relay.yourmailgateway.de ([188.68.61.106]:44379)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pelzflorian@HIDDEN>) id 1o9joL-00016N-SY
 for 40641 <at> debbugs.gnu.org; Fri, 08 Jul 2022 04:58:06 -0400
Received: from mors-relay-8405.netcup.net (localhost [127.0.0.1])
 by mors-relay-8405.netcup.net (Postfix) with ESMTPS id 4LfRy436q8z6w3X;
 Fri,  8 Jul 2022 10:58:04 +0200 (CEST)
Authentication-Results: mors-relay-8405.netcup.net;
 dkim=permerror (bad message/signature format)
Received: from policy02-mors.netcup.net (unknown [46.38.225.53])
 by mors-relay-8405.netcup.net (Postfix) with ESMTPS id 4LfRy42gGYz6w2r;
 Fri,  8 Jul 2022 10:58:04 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net
X-Spam-Flag: NO
X-Spam-Score: -2.899
X-Spam-Level: 
X-Spam-Status: No, score=-2.899 required=6.31 tests=[ALL_TRUSTED=-1,
 BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mxe217.netcup.net (unknown [10.243.12.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by policy02-mors.netcup.net (Postfix) with ESMTPS id 4LfRy360Lkz8scM;
 Fri,  8 Jul 2022 10:58:03 +0200 (CEST)
Received: from florianrock64 (ip5b40552a.dynamic.kabel-deutschland.de
 [91.64.85.42])
 by mxe217.netcup.net (Postfix) with ESMTPSA id 2EC3084161;
 Fri,  8 Jul 2022 10:58:01 +0200 (CEST)
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN> <878rp4c7em.fsf@HIDDEN>
Date: Fri, 08 Jul 2022 10:58:00 +0200
In-Reply-To: <878rp4c7em.fsf@HIDDEN> (pelzflorian@HIDDEN's
 message of "Fri, 08 Jul 2022 10:53:21 +0200")
Message-ID: <874jzsc76v.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-NC-CID: p0SYdPSNVw6LwNeq6zRRbtwWO4GdgU28lX85xNiymQW5thko9yS7pPBU
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, elaexuotee@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

"pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN> writes:
> =E2=80=9Cguix shell -D guix -- make=E2=80=9D
> to just work without workaround?

Argh, I meant to write =E2=80=9Cguix shell -D guix -- make check=E2=80=9D =
=E2=80=A6

Regards,
Florian

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 8 Jul 2022 08:53:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 08 04:53:32 2022
Received: from localhost ([127.0.0.1]:58775 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9jjw-0000qc-Dr
	for submit <at> debbugs.gnu.org; Fri, 08 Jul 2022 04:53:32 -0400
Received: from relay.yourmailgateway.de ([188.68.61.102]:36469)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pelzflorian@HIDDEN>) id 1o9jjs-0000qO-WF
 for 40641 <at> debbugs.gnu.org; Fri, 08 Jul 2022 04:53:31 -0400
Received: from mors-relay-8403.netcup.net (localhost [127.0.0.1])
 by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4LfRrl4Fngz80CR;
 Fri,  8 Jul 2022 10:53:27 +0200 (CEST)
Authentication-Results: mors-relay-8403.netcup.net;
 dkim=permerror (bad message/signature format)
Received: from policy02-mors.netcup.net (unknown [46.38.225.53])
 by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4LfRrl3tKVz80CQ;
 Fri,  8 Jul 2022 10:53:27 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net
X-Spam-Flag: NO
X-Spam-Score: -2.899
X-Spam-Level: 
X-Spam-Status: No, score=-2.899 required=6.31 tests=[ALL_TRUSTED=-1,
 BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mxe217.netcup.net (unknown [10.243.12.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by policy02-mors.netcup.net (Postfix) with ESMTPS id 4LfRrj21SXz8sb1;
 Fri,  8 Jul 2022 10:53:25 +0200 (CEST)
Received: from florianrock64 (ip5b40552a.dynamic.kabel-deutschland.de
 [91.64.85.42])
 by mxe217.netcup.net (Postfix) with ESMTPSA id 9A6DB8291C;
 Fri,  8 Jul 2022 10:53:22 +0200 (CEST)
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 <87edywvbdz.fsf@HIDDEN>
Date: Fri, 08 Jul 2022 10:53:21 +0200
In-Reply-To: <87edywvbdz.fsf@HIDDEN> (Maxim Cournoyer's message of "Thu, 07
 Jul 2022 17:52:24 -0400")
Message-ID: <878rp4c7em.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-NC-CID: 8lqXCD3C//hJrSAnMyKx0p/BDHk8vu1zQ8I7RBUyMMTsUTf1F/lceXEO
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, elaexuotee@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Wait wait Maxim, the discussion was that
"B. Wilson" <elaexuotee@HIDDEN> proposed
> [PATCH] build: Let make use its hard-coded default shell
 > To: guix-patches@HIDDEN
>
 > * configure.ac: Set AM_SUBST_NOTMAKE([SHELL])
 > +# Use make's hard-coded default shell. The make in a guix profile
 > +# defaults to the Right Thing, e.g. $GUIX_ENVIRONMENT/bin/sh
> +AM_SUBST_NOTMAKE([SHELL])
=20
Then Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:
> This seems odd to me. Perhaps it'd be cleaner to detect which shell is
 > used at configure time to detect when /bin/sh !=3D Bash, and warn that if
 > there are issues, the user should set the SHELL variable to Bash.

elaexuotee@HIDDEN writes:
> Excellent. I agree it's probably not worth POSIXifying the scripts. Forci=
ng
> make to default to guix's bash seems like the right approach IMHO, so +1 =
for
> that fix.

I think we=E2=80=99re not on the same page.  Is AM_SUBST_NOTMAKE([SHELL]) r=
eally
problematic?  Is seems like there is a legitimate use-case that foreign
distro users with /bin/sh =3D dash would want =E2=80=9Cguix shell -D guix -=
- make=E2=80=9D
to just work without workaround?  We could use elaexuotee=E2=80=99s
AM_SUBST_NOTMAKE([SHELL]) patch, could we not?

Regards,
Florian

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641-done <at> debbugs.gnu.org:

Received: (at 40641-done) by debbugs.gnu.org; 7 Jul 2022 21:52:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 07 17:52:36 2022
Received: from localhost ([127.0.0.1]:58226 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9ZQK-0000IP-2O
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 17:52:36 -0400
Received: from mail-qt1-f173.google.com ([209.85.160.173]:35580)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1o9ZQF-0000IA-Ge
 for 40641-done <at> debbugs.gnu.org; Thu, 07 Jul 2022 17:52:34 -0400
Received: by mail-qt1-f173.google.com with SMTP id l14so24807815qtx.2
 for <40641-done <at> debbugs.gnu.org>; Thu, 07 Jul 2022 14:52:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=LQQ4ci8oiRiyPJlTm0h7wr+KhgxyU5PTNODlqpCpMzU=;
 b=NLORNY/7AvJRuDfJG7+fBcKEbvmdvv4JKZ6k2fUgzUbGGN1BsPLJPGXaugm6ao4fUt
 0xgazy/Oev9a7YVzy+UeMeAJ4uvSO32J9D15XML7bQRmKkjKU7IDiGsSh18KOebFkm5i
 AtwQLoFGownZYB7vNhatgVubPKcC1fQRaLuB5GPn1WBwZVr5qmbi4HszqY5fgOG6xUyS
 SiQ04KcnGcbUrFaE7LF/s8inNE8bp2azk458etxSY1vHH4itB97Erjm3AIpvvLxulSOo
 NF5kQgV6PAdzOr9+MLa2N/r2HkoA532L1lacZhOPx1c6HPPiSMnZiG5/sE8K6PfrHj2e
 Ooaw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=LQQ4ci8oiRiyPJlTm0h7wr+KhgxyU5PTNODlqpCpMzU=;
 b=XEeJuKEtF4hZtsYc+bqPSL/E1sUNUpdLRQeNNfHmmuPQpDLZmkmZNUHkH0Fz0LafFg
 MUZ5GKCoLCgYHZEIByfyNTh1yNQEqowlftqGtX5vd8cGCMWi85qMTiUQX5C0eeWx4yrM
 i+D/OeCf42d7g+rVq2j1EqzFCQxOlgQJ5JKlWeEixNKwKwBHGRuILboAT7sOzvFpG5Bf
 0EJz2/k1nHNtZD4u+hh5OBXtmlXgvmpsbbOlginlYvkRhF9avnlnlmRl8Zr0BR/Gx0x3
 R2/aPnwpDBaUMwXbd5vDVzH5CmX4dpcM9t1yL9xMElAK2C/j4UtykYmhs2idTJon3ZNw
 /vnQ==
X-Gm-Message-State: AJIora8OKUoSuu25RaAZe9lb5SW9UWGFgZHrid1LYojG4TwgfxJyZgU0
 prWTdkjwip2UzgrKehvR1SsYGoeojvZIK6xg
X-Google-Smtp-Source: AGRyM1usnRuF+JLt3Sb82MV54Bd7rk0t0Eg+AyXQ/l25lzMg9aXgJOT7P/02AG4l2ejDYETL1p/gGQ==
X-Received: by 2002:a05:622a:341:b0:31d:3fda:5e2d with SMTP id
 r1-20020a05622a034100b0031d3fda5e2dmr256345qtw.129.1657230745621; 
 Thu, 07 Jul 2022 14:52:25 -0700 (PDT)
Received: from hurd (dsl-153-127.b2b2c.ca. [66.158.153.127])
 by smtp.gmail.com with ESMTPSA id
 g10-20020a05620a40ca00b006a758ce2ae1sm22621154qko.104.2022.07.07.14.52.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Jul 2022 14:52:25 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: elaexuotee@HIDDEN
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
 <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
Date: Thu, 07 Jul 2022 17:52:24 -0400
In-Reply-To: <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@HIDDEN>
 (elaexuotee@HIDDEN's message of "Mon, 04 Jul 2022 20:22:43
 +0900")
Message-ID: <87edywvbdz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641-done
Cc: 40641-done <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

elaexuotee@HIDDEN writes:

> "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN> wrote:
>> Thank you for getting back to the bug.  I am in the same situation in
>> that I use Guix System now. :D
>>=20
>> On Tue, Jun 21, 2022 at 09:20:28AM +0900, elaexuotee@HIDDEN wrote:
>> > so you could be able to sanity
>> > check with something like
>> >=20
>> >     $ guix shell -C dash guix make <etc>
>> >     $ ln -s $(command -v dash) /bin/sh
>> >     $ ./configure --localstatedir && make
>>=20
>> I had done exactly this.
>>=20
>> guix shell --container --network dash git pkg-config gnutls guile
>> guile-avahi guile-gcrypt guile-json guile-lib guile-sqlite3
>> guile-zlib guile-lzlib guile-zstd guile-ssh guile-git autoconf
>> automake gettext texinfo graphviz help2man po4a findutils sed
>> coreutils tar xz m4 diffutils grep gcc-toolchain sqlite libgcrypt
>> gawk make glibc-locales -- dash
>>=20
>> Many tests fail because of the container though, so I=E2=80=99m not sure=
 how
>> big the effect is.  At least tests/guix-package.sh still use type -P
>> which is not POSIX, but I don=E2=80=99t think it should be changed nor s=
hould
>> there be a check if $SHELL can do what we need, because we don=E2=80=99t=
 know
>> which bash features we need.
>
> Excellent. I agree it's probably not worth POSIXifying the scripts. Forci=
ng
> make to default to guix's bash seems like the right approach IMHO, so +1 =
for
> that fix.
>
> FWIW, I ended up working around the original issue by explicitly telling =
make
> to use guix's bash, anyway:
>
>     $ guix environment guix bash
>     $ CONFIG_SHELL=3D$(command -v bash) ./configure --localstatedir=3D/var

OK.  Good to know, glad it can be easily worked around.

Closing.

Maxim

Notification sent to elaexuotee@HIDDEN:
bug acknowledged by developer. Full text available.

Reply sent to Maxim Cournoyer <maxim.cournoyer@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 4 Jul 2022 11:22:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 04 07:22:56 2022
Received: from localhost ([127.0.0.1]:46319 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o8KAK-0006WM-4w
	for submit <at> debbugs.gnu.org; Mon, 04 Jul 2022 07:22:56 -0400
Received: from m42-5.mailgun.net ([69.72.42.5]:19345)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bounce+148a03.08547a-40641=debbugs.gnu.org@HIDDEN>)
 id 1o8KAI-0006W7-4y
 for 40641 <at> debbugs.gnu.org; Mon, 04 Jul 2022 07:22:55 -0400
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com;
 q=dns/txt; 
 s=krs; t=1656933774; x=1657142574; h=Content-Transfer-Encoding:
 Content-Type: MIME-Version: Message-Id: In-Reply-To: References: From:
 From: Subject: Subject: Cc: To: To: Date: Sender: Sender;
 bh=BjW9s14L2qykk0pKlyxSCg/8O42JcxRcyj1wxLsWdQo=;
 b=L63HffrrEkezQgE2rz+kIgo2R1ZkPx/M1xMqatuXvtRmgxU83n1PRCs2NEanXXgFkRg7XaVW
 bXUkaCxxPmXAxZio4vb9MQqvVZS3NdXLB7d+ifRCi8zFgynsdfUZ/tVCfIYWplvufhUE7VYn
 dqDDabBMDXnlUpw24ELS91P9YmeCoDXteSMSmmfJz5RNVIabvt629ME8stpafTl+nmPvhjUP
 EmEsgZE3OwAKiXXJ5AK2cQZHi38vss/ETWBg8u6e/aPPo0M+m38Mj2vwCG9VFn4b0qRq6xqh
 MSoXg4w8fx1JfyMGS9H19gaada9PCpU5xrUWRxwfa5qPwZfZeS4kHA==
X-Mailgun-Sending-Ip: 69.72.42.5
X-Mailgun-Sid: WyIxYmE0NCIsICI0MDY0MUBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0=
Received: from wilsonb.com (wilsonb.com [104.199.203.42]) by
 smtp-out-n01.prod.us-east-1.postgun.com with SMTP id
 62c2cd88d21fa7c2d209b8b8 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256);
 Mon, 04 Jul 2022 11:22:48 GMT
Received: from localhost (aj099096.dynamic.ppp.asahi-net.or.jp [220.150.99.96])
 by wilsonb.com (Postfix) with ESMTPSA id E0FEFA26B6;
 Mon,  4 Jul 2022 11:22:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com;
 s=201703; t=1656933766;
 bh=BjW9s14L2qykk0pKlyxSCg/8O42JcxRcyj1wxLsWdQo=;
 h=Date:To:Cc:Subject:From:References:In-Reply-To:From;
 b=UrywZ0RzyAl77tTvee0EbmCJaVUxp9h5g++Ej9Y0rklHxejeUZrdWt5m6BshJvFXf
 KHE094PjsTImaEqTs8jYOdgdQ2HeRY9YMfQCBStFEWhtQx7Iv7YRczzYnuopxCrHiK
 +z6OOBWdFBa8SpZKZxxdY1MFL18MARDjOILJ/l3O+JCrjtsIgQFO5Ao1Px8BWU6GFm
 lG80xwpzu9t9qLLmuMRcqGyqbuX6VpvSCSc1Bb5jjbg5oQ4hQ3S14Pa21JQVw6Hfbv
 CVBLO5T9YxBD5mFbNbxaDh0AgpuE5/9FNdA6QNGxrRpisq+GZfPMBpPmSt7Ainivws
 62f0wdkHO7WtGi9ajoQEOO7VYSe51dMyVgISJBjfR7LeEtOTEyPFmg27NXZiJpmtZd
 h1IPBdET4jIGt5Bd8VBCZHASiaTmGN4w81cIYGWaTAV0iRCjKwrELIgtQKfMSbTuGu
 pMcAihYdOYUUyYz78gplUZ3LY4Kwj4xTE8kKp/Vwp/btskdorFal9/OyjeVxENbpMN
 NN9NfUW3IyUcbuLqBqZz5geWKM30rZQgPBFj58t54cbl/sNWA0WUTLEIPjZyHcFGj5
 T8uGoFGRRxmxg76kzAoY68+gtp30SdtgEfpHHzv2JwlTuN2Y99w2kZQYS7YS90APsA
 kvoj57hoPAO0RGP3ygt+BWdg=
Date: Mon, 04 Jul 2022 20:22:43 +0900
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
From: elaexuotee@HIDDEN
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
 <20220621090254.kyskzwkliku53mob@HIDDEN>
In-Reply-To: <20220621090254.kyskzwkliku53mob@HIDDEN>
Message-Id: <3PFHFCEJGQHEZ.2UZN2W0ONMXEV@"@WILSONB.COM>
User-Agent: mblaze/1.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

"pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN> wrote:
> Thank you for getting back to the bug.  I am in the same situation in
> that I use Guix System now. :D
>=20
> On Tue, Jun 21, 2022 at 09:20:28AM +0900, elaexuotee@HIDDEN wrote:
> > so you could be able to sanity
> > check with something like
> >=20
> >     $ guix shell -C dash guix make <etc>
> >     $ ln -s $(command -v dash) /bin/sh
> >     $ ./configure --localstatedir && make
>=20
> I had done exactly this.
>=20
> guix shell --container --network dash git pkg-config gnutls guile guile-a=
vahi guile-gcrypt guile-json guile-lib guile-sqlite3 guile-zlib guile-lzlib=
 guile-zstd guile-ssh guile-git autoconf automake gettext texinfo graphviz =
help2man po4a findutils sed coreutils tar xz m4 diffutils grep gcc-toolchai=
n sqlite libgcrypt gawk make glibc-locales -- dash
>=20
> Many tests fail because of the container though, so I=E2=80=99m not sure =
how
> big the effect is.  At least tests/guix-package.sh still use type -P
> which is not POSIX, but I don=E2=80=99t think it should be changed nor sh=
ould
> there be a check if $SHELL can do what we need, because we don=E2=80=99t =
know
> which bash features we need.

Excellent. I agree it's probably not worth POSIXifying the scripts. Forcing=

make to default to guix's bash seems like the right approach IMHO, so +1 fo=
r
that fix.

FWIW, I ended up working around the original issue by explicitly telling ma=
ke
to use guix's bash, anyway:

    $ guix environment guix bash
    $ CONFIG_SHELL=3D$(command -v bash) ./configure --localstatedir=3D/var

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 21 Jun 2022 09:03:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 21 05:03:07 2022
Received: from localhost ([127.0.0.1]:59100 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o3Zmt-0003lD-LF
	for submit <at> debbugs.gnu.org; Tue, 21 Jun 2022 05:03:07 -0400
Received: from pelzflorian.de ([5.45.111.108]:55566 helo=mail.pelzflorian.de)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pelzflorian@HIDDEN>) id 1o3Zmn-0003kl-MV
 for 40641 <at> debbugs.gnu.org; Tue, 21 Jun 2022 05:03:06 -0400
Received: from pelzflorian.localdomain (unknown [5.45.111.108])
 by mail.pelzflorian.de (Postfix) with ESMTPSA id 15BDF360566;
 Tue, 21 Jun 2022 11:02:59 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de;
 s=mail; t=1655802180;
 bh=l0IqijTbVbVM3fTCG2UHLiN9Wl71iAUBo/AZmT5DaTA=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To;
 b=MS3vzJ8ORZvdTPUy2kybipw7SLe6sSbRxeZYSlPVH8EuBZk5SabNKbTW1ejtIDUho
 ZDGXrpZBADKSrZWSXnHzQbD7QPtII/xrlQFiYZAei3oOaG1AgFuPsUcbwb8FUAxSLN
 cnAtkIjGd/7u7rPurEjgAqefugFIxaL8kssZkdLo=
Date: Tue, 21 Jun 2022 11:02:54 +0200
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
To: elaexuotee@HIDDEN
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
Message-ID: <20220621090254.kyskzwkliku53mob@HIDDEN>
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN>
 <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN>
 <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Thank you for getting back to the bug.  I am in the same situation in
that I use Guix System now. :D

On Tue, Jun 21, 2022 at 09:20:28AM +0900, elaexuotee@HIDDEN wrote:
> so you could be able to sanity
> check with something like
> 
>     $ guix shell -C dash guix make <etc>
>     $ ln -s $(command -v dash) /bin/sh
>     $ ./configure --localstatedir && make

I had done exactly this.

guix shell --container --network dash git pkg-config gnutls guile guile-avahi guile-gcrypt guile-json guile-lib guile-sqlite3 guile-zlib guile-lzlib guile-zstd guile-ssh guile-git autoconf automake gettext texinfo graphviz help2man po4a findutils sed coreutils tar xz m4 diffutils grep gcc-toolchain sqlite libgcrypt gawk make glibc-locales -- dash

Many tests fail because of the container though, so I’m not sure how
big the effect is.  At least tests/guix-package.sh still use type -P
which is not POSIX, but I don’t think it should be changed nor should
there be a check if $SHELL can do what we need, because we don’t know
which bash features we need.

Regards,
Florian

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 21 Jun 2022 00:20:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 20 20:20:55 2022
Received: from localhost ([127.0.0.1]:58622 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o3RdX-0002z7-3c
	for submit <at> debbugs.gnu.org; Mon, 20 Jun 2022 20:20:55 -0400
Received: from m42-5.mailgun.net ([69.72.42.5]:42027)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bounce+148a03.08547a-40641=debbugs.gnu.org@HIDDEN>)
 id 1o3RdT-0002ys-Kf
 for 40641 <at> debbugs.gnu.org; Mon, 20 Jun 2022 20:20:53 -0400
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com;
 q=dns/txt; 
 s=krs; t=1655770851; x=1655979651; h=Content-Transfer-Encoding:
 Content-Type: MIME-Version: Message-Id: In-Reply-To: References: From:
 From: Subject: Subject: Cc: To: To: Date: Sender: Sender;
 bh=ink9OIRH0IMbGjs0hbt00EcezHNgR2L8/pIO6O8lhCQ=;
 b=rkKH/s/adxVjT2FjheqZ07S+SBaSjg0PGqlodsJH4uC2SpNkk559K43ruvE9zO1XH2cCLcwM
 5rD+gn1ouA/NGVP8kyZCSMXdOm1LjVaOtczM674cY6ELCLOAGm7FRD0kUsz+A8UDHN9YyBPP
 OoxjFw8dmSmMxZfqZvM+BhECThSnmN5oeNHTQrEHs44HhengEQOMAkivrUA4PSF7CbQPRcif
 mnBtcTR5TnLdomK8/rn6DXzWRqW5Lphxuf+0Ck68cP9Y+ICReRHzDHz8tly1LebfYH8qF4DN
 /I2mvu/TmJdM4Cyf+8NvvW3Gmx/WMfe9J4kzuA1ADqxcZonZpvKQ2g==
X-Mailgun-Sending-Ip: 69.72.42.5
X-Mailgun-Sid: WyIxYmE0NCIsICI0MDY0MUBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0=
Received: from wilsonb.com (wilsonb.com [104.199.203.42]) by
 smtp-out-n01.prod.us-west-2.postgun.com with SMTP id
 62b10ede1df735d244a85ad5 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256);
 Tue, 21 Jun 2022 00:20:46 GMT
Received: from localhost (q047142.dynamic.ppp.asahi-net.or.jp [203.181.47.142])
 by wilsonb.com (Postfix) with ESMTPSA id D4167A2906;
 Tue, 21 Jun 2022 00:20:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com;
 s=201703; t=1655770844;
 bh=ink9OIRH0IMbGjs0hbt00EcezHNgR2L8/pIO6O8lhCQ=;
 h=Date:To:Cc:Subject:From:References:In-Reply-To:From;
 b=1KWqqVXseJrSV4uZqHSFFjpi8oZxnpPTYd57sDHGtRthpjlcpgumdu9D6f1uGkE+T
 zsKEzcZXtrKWKEiniOrqHTeSUCXV1TZUB8hqCNNH5HKqMkgo6o9B/Za6w3eorr4G87
 WgaeQ42VshHe1VN0OmW7+wffIsgeR2+CgUIjIalf10MuBuuNPheJAnrt2O3CMSDygI
 EUaem2pUttYhk0HkIkpoltWUgauZBcGdfSkyvgGNnIGKdE/5LFDECDnAb55romdjNK
 yg8X7AHyePhnXFpDhypltwefjRYnZfKfqqKC5Hajb/BH+haX4rB5PLmyZ7lbeuzUgE
 IcBpo3H+6hfy+apKQCNsbA8eOkNHJP9GEeKl1jvl7qF0V8Ny+AdPer+iN8JrH2yM0S
 19ZAc63iwIxgkuxIkoBJN1Tn8aj3Alan8M8SJ2dxXLV4d1QEY+DbYXInGYdhNiwKyn
 NEH25HhWx6bxragGHHXV2B/nWAmICsdbWeqwMUo2asoOAsfJgOk09yHVXH8aMedZ2i
 dHeUlCAZcFpBGnLWfZ3Ppr5Oss2qtvURisyzHPF+KLwwUvylNLZPMnidGH635aRX3a
 D6zXcdM/q67J8CS0y1iaQzj6hqb0I8veSV5D7ucfCj7wEws8r3v2T1oFpW6GbcELL/
 Qxemw9cyH6o+FyAvcQI/4PH4=
Date: Tue, 21 Jun 2022 09:20:28 +0900
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
From: elaexuotee@HIDDEN
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 <874k0nfcq6.fsf@HIDDEN>
In-Reply-To: <874k0nfcq6.fsf@HIDDEN>
Message-Id: <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM>
User-Agent: mblaze/1.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

> Wilson, could you confirm whether there's still something to fix here?
> Else, let's close this ticket and move on.

The original issue arose on a Void Linux foreign distro installation. I hav=
e
long since converted to Guix System, so cannot easily test the original
environment.

However, Void just runs dash as it's default sh, so you could be able to sa=
nity
check with something like

    $ guix shell -C dash guix make <etc>
    $ ln -s $(command -v dash) /bin/sh
    $ ./configure --localstatedir && make

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 14 Jun 2022 16:10:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 14 12:10:03 2022
Received: from localhost ([127.0.0.1]:35545 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o197D-0000yZ-4v
	for submit <at> debbugs.gnu.org; Tue, 14 Jun 2022 12:10:03 -0400
Received: from mail-qk1-f172.google.com ([209.85.222.172]:35456)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1o197B-0000xx-EX
 for 40641 <at> debbugs.gnu.org; Tue, 14 Jun 2022 12:10:02 -0400
Received: by mail-qk1-f172.google.com with SMTP id b142so6738506qkg.2
 for <40641 <at> debbugs.gnu.org>; Tue, 14 Jun 2022 09:10:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=zM7J4Q4NyQaV0XBAHSQGtZBwtbghCUUUqnLQpK1wCWU=;
 b=R6u0Fm5ZH+pVEes32j/zq4KALaX0nhuJRTxY6QZNk5rYCylV903Hx24wqnowtEGYGg
 kGNbQBVRTy0niFyNy9W0VuV49uSOZz2EP1O5FCHa0PaUWe7BpzWdftz6NO++3WKe5fku
 fSm5m4x/OpwRy1ata5deg0SOLsIQymTcggvcfgxk2tW8cDnIHUnFa3UQK6jMBUQIASpE
 Idby9YRJynHFn0hh31VP57/iUZn1ZAcPliIMtphcLl4KuNf/T/Cv33R9K8CFb6reRb9i
 fPian61tB5rG2MXq4WnW6Wh2B29xRoFRyQldg8S63Kh/KqRKTrPFZ6P8XSzj5oKEb9Du
 Ak3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=zM7J4Q4NyQaV0XBAHSQGtZBwtbghCUUUqnLQpK1wCWU=;
 b=OV7Njm6c7niwex1vCrScampZvec0iAa/TQo7SwzCrF9W/6IZtGafITib0t6/rMH7vl
 J/c4nr2lRIpYj57KzxKbpfiPzay84uE0+bzD+ccw9DOR/Sc37Wx05ESQqgQutp1BvxPt
 x0MjU1Bf1iUY6915uMRGzm2MUy0XctYn3OJB7fNYvuRTCz0K9P+yBJU+0tKHfG9hGnW6
 dQh5ZKYtCmWXNLyL3akA21JK7+fN+uMfFl9vz+XfUdI5/sr7M1oJWgJGgXBzszUDwmCQ
 cdBXAbHWhYU/9CjGbiMuWZ68UzX9/Ql9BZU65jbH6JMHGX7YpKsoiSWRz5G8T50pqWQI
 xH9A==
X-Gm-Message-State: AOAM5320pxdbcjenF2HNJ9leDEKmA70YoD9w0XTOuHBod9rSf0UincSL
 w5sbGuFoE+fls/bhZWgLrrCEPw2o71Y6nnIT
X-Google-Smtp-Source: ABdhPJwQp2OU7A6zKVUfOlzDrOS/JlfvnJR8+CPuVzxHnt+T6qXJHvMG/4knSlP94uG9BYYcLLnMfw==
X-Received: by 2002:a05:620a:248f:b0:6a6:ee8e:712e with SMTP id
 i15-20020a05620a248f00b006a6ee8e712emr4610540qkn.690.1655222995351; 
 Tue, 14 Jun 2022 09:09:55 -0700 (PDT)
Received: from hurd (dsl-10-149-55.b2b2c.ca. [72.10.149.55])
 by smtp.gmail.com with ESMTPSA id
 i5-20020a05620a248500b006a5d8d96681sm10422487qkn.100.2022.06.14.09.09.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 14 Jun 2022 09:09:54 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN> <87h74tgxui.fsf@HIDDEN>
 <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
Date: Tue, 14 Jun 2022 12:09:53 -0400
In-Reply-To: <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
 (pelzflorian@HIDDEN's message of "Mon, 13 Jun 2022 16:40:19
 +0200")
Message-ID: <874k0nfcq6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, elaexuotee@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

"pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN> writes:

> Only the tests are affected, as far as I can tell.  make runs fine.
> The issue with =E2=80=9Cgnu/local.mk=E2=80=9D from [1] got fixed in 2019 =
via
> 92d00ca4661e186022732a47956a2bc0ef16be96.
>
> But Makefile.am has=20
>
> SH_LOG_COMPILER =3D $(top_builddir)/test-env $(SHELL)
> AM_SH_LOG_FLAGS =3D -x -e
>
> Probably autoconf can be made to detect if $(SHELL) is bash or zsh
> somehow=E2=84=A2.  But I suppose it is not important and I won=E2=80=99t =
fix it.

Wilson, could you confirm whether there's still something to fix here?
Else, let's close this ticket and move on.

Thanks,

Maxim

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 13 Jun 2022 14:40:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 13 10:40:50 2022
Received: from localhost ([127.0.0.1]:60051 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o0lF9-00054Z-0N
	for submit <at> debbugs.gnu.org; Mon, 13 Jun 2022 10:40:50 -0400
Received: from pelzflorian.de ([5.45.111.108]:58120 helo=mail.pelzflorian.de)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pelzflorian@HIDDEN>) id 1o0lF5-00054P-Hp
 for 40641 <at> debbugs.gnu.org; Mon, 13 Jun 2022 10:40:37 -0400
Received: from pelzflorian.localdomain (unknown [5.45.111.108])
 by mail.pelzflorian.de (Postfix) with ESMTPSA id E20403605C9;
 Mon, 13 Jun 2022 16:40:32 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de;
 s=mail; t=1655131233;
 bh=8vKPAv+bzG2+bDL3QCFlA6/6OMo84E/5MQ3apVWwyiE=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To;
 b=nnt1YTPvllIVb4GgOMeTIs3vkhZodt6HMMEzG5WQMOVltertNZG7snSfXov19pwde
 EIxZr7q0mj2ixhsioCKe4f9YxmM9fGqfLDIDU7X6f3BvlSP7rsHgXj9Dr/afLPloR0
 A3PbtV4zzEhRhWs24ka9benxaDCttx4ts+jDJ+Ls=
Date: Mon, 13 Jun 2022 16:40:19 +0200
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
Message-ID: <20220613144005.gv2j5igdmisnaiqv@HIDDEN>
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN>
 <87h74tgxui.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87h74tgxui.fsf@HIDDEN>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org, elaexuotee@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Only the tests are affected, as far as I can tell.  make runs fine.
The issue with “gnu/local.mk” from [1] got fixed in 2019 via
92d00ca4661e186022732a47956a2bc0ef16be96.

But Makefile.am has 

SH_LOG_COMPILER = $(top_builddir)/test-env $(SHELL)
AM_SH_LOG_FLAGS = -x -e

Probably autoconf can be made to detect if $(SHELL) is bash or zsh
somehow™.  But I suppose it is not important and I won’t fix it.

Regards,
Florian

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 10 Jun 2022 00:35:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 09 20:35:00 2022
Received: from localhost ([127.0.0.1]:48248 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nzSc7-0003E8-Iz
	for submit <at> debbugs.gnu.org; Thu, 09 Jun 2022 20:34:59 -0400
Received: from mail-qk1-f180.google.com ([209.85.222.180]:46653)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1nzSc2-0003Dq-JP
 for 40641 <at> debbugs.gnu.org; Thu, 09 Jun 2022 20:34:58 -0400
Received: by mail-qk1-f180.google.com with SMTP id o68so18907667qkf.13
 for <40641 <at> debbugs.gnu.org>; Thu, 09 Jun 2022 17:34:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=bOFzRRpiU9ZsZFoZ36jlL+ITtYEjeLyOHha39IPjqR4=;
 b=RpAkPUc6nPNSxVMyc8qWQ+yKCJ+6oEDyl6ou93cAl8E2AVB83TbdetDoKm5yBW2UYk
 xCO+KT9yAH6TiTC//UENTSACoNm3SFVbIeUnS0GhndKFrM+DzKGqb8egG4Rc+3Uh5DOp
 bh8O8A8FFvV8HZ3c2oH1SY49rtVBEYzzvVnaLvSu2T0ou3StGL6CcAPf0sIeuqXCg1Dy
 7vMt8uuUwGBWCDVPRnWGh6u3KD/K8nIfl8jT8EhmtNdl2L04zDbGAxzSvNw6tC0ZwSeT
 NhkzCzG8RABq+dI+LLTDe0QpfOQyYqqGkoR4U77T8Zl+dfAepMJr8jItdaYaWqhegqyI
 8D7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=bOFzRRpiU9ZsZFoZ36jlL+ITtYEjeLyOHha39IPjqR4=;
 b=M2OlPK/1ABTHLOPc5FgM8EwDKI7L2AYfAQjtuKpxCp/l3OB+6EfjiXS+g051ng+sA+
 AmR0dbD+2MBiryXipthCO86r1rfUkk6Rn9UiMAV/jWICFYd9PPwy5wSDPqfjA+G8Och1
 lQF0I55uDFPCE87KhyPVrLzMWWlHQ1ttylbFRhH2bu+t3Sg5HNXY17XDZzjTr8cexVbH
 JmF8MygIsdkg8dUVY76ScNiUeabijv8TnCNroKe3b8I+zAXaT3A6qiZi49wIEL2tuFoZ
 JX0X9mlX7NCFwfsYFFURqgIaTWlLe+RvScmsI8LLAN12MFDgHQ0uvl39EXEczYpY7XXy
 xQSA==
X-Gm-Message-State: AOAM531rqn4jEO3WelwSQa8mIQsj12FVoJqJmAepHujVkW4gFPK84IBK
 ST0AAXE9hpMjp3lKxgEtLiqelIlRGsg7jA+d
X-Google-Smtp-Source: ABdhPJwCUHPkTDOiz1rW3zQyr7inYfn7MsYilCL6kUcOTOLuws1RQjwpv+LIlBQdSbh0FwoxmYd8Ag==
X-Received: by 2002:a37:5404:0:b0:6a6:48c7:b137 with SMTP id
 i4-20020a375404000000b006a648c7b137mr28682515qkb.284.1654821288290; 
 Thu, 09 Jun 2022 17:34:48 -0700 (PDT)
Received: from hurd (dsl-155-254.b2b2c.ca. [66.158.155.254])
 by smtp.gmail.com with ESMTPSA id
 f11-20020a05620a280b00b006a6bd7028d5sm11924843qkp.18.2022.06.09.17.34.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 09 Jun 2022 17:34:47 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: elaexuotee@HIDDEN
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
 <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN>
Date: Thu, 09 Jun 2022 20:34:45 -0400
In-Reply-To: <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN>
 (elaexuotee@HIDDEN's message of "Fri, 17 Apr 2020 23:57:04
 +0900")
Message-ID: <87h74tgxui.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org,
 "pelzflorian \(Florian Pelz\)" <pelzflorian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

elaexuotee@HIDDEN writes:

> "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN> wrote:
>> On Wed, Apr 15, 2020 at 06:06:25PM +0900, elaexuotee--- via Bug reports for GNU Guix wrote:
>> > When building from git, ./bootstrap ends up generating (via automake) several
>> > Makefiles that set SHELL = /bin/sh. However, some targets contain rules that
>> > make use of bashisms. This leads to breakage when /bin/sh is something other
>> > than bash.
>> > 
>> > In particular, I am building from a foreign distro which links /bin/sh to dash.
>> > Currently, this ends up breaking the build, the details of which I reported
>> > to guix-devel in [0].
>> 
>> <https://bugs.gnu.org/25258> is related.  Your workaround may be more welcome.
>> 
>> Regards,
>> Florian
>
>
> Florian,
>
> Thanks for the pointer. I ended up doing a little bit of sleuthing and think
> I figured out a relatively clean fix---a simple one-liner in configure.ac.
> Attached is a proof-of-concept patch against master (974bf81776).
>
> Currently, autoconf sets make's shell to whatever it thinks is best. On a
> foreign distribution, this often ends up something external to guix profile.
> However, when this isn't bash, we run into problems.
>
> The patch's idea is to let make use its hard-coded default shell. A guix-built
> make will correctly fallback to whichever sh is in the profile, so for `guix
> environment guix' this effectively becomes $GUIX_ENVIRONMENT/bin/sh. For
> example,
>
>     $ echo '$(info $(SHELL))' | make -f -
>     /gnu/store/29jhbbg1hf557x8j53f9sxd9imlmf02a-bash-minimal-5.0.7/bin/sh
>     make: *** No targets.  Stop.
>
> I belive this should do the Right Thing. However, is there anything I am
> missing? Perhaps this change would break build scenaries I am not thinking of?

This seems odd to me.  Perhaps it'd be cleaner to detect which shell is
used at configure time to detect when /bin/sh != Bash, and warn that if
there are issues, the user should set the SHELL variable to Bash.

Or if the Bashisms are scarce enough, perhaps we can rewrite the
routines in POSIXly correct shell, although this being a GNU project I
don't really see the merit of forcing lesser shells (and less readable
code) on ourselves.

Could you provide a list of the problematic targets?  Or if my
suggestion sounds good, give it a shot?

Thanks :-)

Maxim

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 17 Apr 2020 16:12:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 17 12:12:14 2020
Received: from localhost ([127.0.0.1]:41577 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jPTb8-00022Z-J5
	for submit <at> debbugs.gnu.org; Fri, 17 Apr 2020 12:12:14 -0400
Received: from m42-5.mailgun.net ([69.72.42.5]:15746)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bounce+148a03.08547a-40641=debbugs.gnu.org@HIDDEN>)
 id 1jPTQm-0001jx-OH
 for 40641 <at> debbugs.gnu.org; Fri, 17 Apr 2020 12:01:38 -0400
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com;
 q=dns/txt; 
 s=krs; t=1587139294; h=Content-Type: MIME-Version: Message-Id:
 In-Reply-To: References: From: Subject: Cc: To: Date: Sender;
 bh=QmBxSAqjTSxcAQZeknpw02S3nuJKNAkvRKWA83hSpHg=;
 b=Sjx7F7fBxJ8s2UVojqXOqAMtEV4XjUw0tl2oULBG+Tduu92axf+2vFN29gVM/uwxx6tM4dIC
 R0KSPFcOTq7A0sXYrTGoxF5xBdQMGxIYnD4Y6aL9qeNx66ZLGJ8JRGXoKdsFPGG+MDsGjIuI
 82VhMD5und9aOjgevIGpSoMm+40OS5JE7U1eg4qxa81aU85PYIa1ZmuqaaUThLZu+kab+O+o
 4vN22DHJzujlJH01gn0UIIVpn+t224x+kwit+QJ5WeK3ht0N6dYdnkynk0jEZH3fxI+3sCaJ
 GcN1I9+8LADXFnmY/Ft4ZKkuK6vb13XX9mPiykNsRGr3oqi0ot3vbg==
X-Mailgun-Sending-Ip: 69.72.42.5
X-Mailgun-Sid: WyIxYmE0NCIsICI0MDY0MUBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0=
Received: from wilsonb.com (wilsonb.com [104.199.203.42])
 by mxa.mailgun.org with ESMTP id 5e99d2aa.7f4d45d432a0-smtp-out-n05;
 Fri, 17 Apr 2020 16:00:42 -0000 (UTC)
Received: from localhost (sp1-79-85-7.msb.spmode.ne.jp [1.79.85.7])
 by wilsonb.com (Postfix) with ESMTPSA id EB9C0A1A5E;
 Fri, 17 Apr 2020 16:00:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com;
 s=201703; t=1587139239;
 bh=QmBxSAqjTSxcAQZeknpw02S3nuJKNAkvRKWA83hSpHg=;
 h=Date:To:Cc:Subject:From:References:In-Reply-To:From;
 b=sIliEQi4BtvXn1WILhoMS7JNB+l6Nn8tRjekWF388hgPH7fyYyLfZaMUI0yDCJL/c
 EsgTGxNngrQZ5Gd0sZ033hwFhY3qX1STFaueO+cGCPmhwNx+b9IuErtCPHKnzxx8D6
 mbmbSUvUpDBzrWN/2Lh0/pNDD8s6q27uiAf1EBocEiSJHOjTFQEYHMD6TvWxyBXilq
 OOk8b+ZGSCtoF3ysDwL3kfo/dl4R3bp8qnBYXxDzVIWxLqOTpMib8zuxfMf/C6AYZ4
 yTt7weSZYXCrOXz74jT3WGbKpym+ui6Zd/vbRgLpOkrG9cFtn03uvXbCTQGKllZFuu
 8ldNAYwGXB03n5kGSAU95vwcGZUZZye1JOZ2hg/GoP/k3wkdak4wABL6YRIdWFDweq
 oVmV/4squc1AmNqOdr+vVUkVwZvc324z7PmgzVTjICiG3PQ6a0Zg3eIqxfphM1xca/
 4Knk4W5nOsInqLN8xoNzF8lmPSGfzDuYk4vLh1F0ikmQxTfr0riXsKcNU+qVtQ6H71
 swP1Cbg89zQNSNY1jj2Aq7y9LG39TVoccx2BjFzL9FP+QEsNppLsWzCStW2QHInobS
 +srxevHyu971ZGKkU05vGhOl4ThUPj7PnN1UMPvS8jUJ11sKPl+Mk9C1pEp/q1ArC4
 QQro2mG0WyfLkwKrjQ9wdfOY=
Date: Fri, 17 Apr 2020 23:57:04 +0900
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
From: elaexuotee@HIDDEN
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
 <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
In-Reply-To: <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
Message-Id: <38M8QJ1PDKHCI.2ZBQF20W9BE03@HIDDEN>
User-Agent: mblaze/0.5.1
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha1";
 protocol="application/pgp-signature";
 boundary="----_=_064465a37bd4286b3a903232_=_"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 40641
X-Mailman-Approved-At: Fri, 17 Apr 2020 12:12:08 -0400
Cc: 40641 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multipart message in MIME format.

------_=_064465a37bd4286b3a903232_=_
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_40e4eb697d18a189045b3508_=_"

This is a multipart message in MIME format.

------_=_40e4eb697d18a189045b3508_=_
Content-Type: text/plain; charset=UTF-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

"pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN> wrote:
> On Wed, Apr 15, 2020 at 06:06:25PM +0900, elaexuotee--- via Bug reports f=
or GNU Guix wrote:
> > When building from git, ./bootstrap ends up generating (via automake) s=
everal
> > Makefiles that set SHELL =3D /bin/sh. However, some targets contain rul=
es that
> > make use of bashisms. This leads to breakage when /bin/sh is something =
other
> > than bash.
> >=20
> > In particular, I am building from a foreign distro which links /bin/sh =
to dash.
> > Currently, this ends up breaking the build, the details of which I repo=
rted
> > to guix-devel in [0].
>=20
> <https://bugs.gnu.org/25258> is related.  Your workaround may be more wel=
come.
>=20
> Regards,
> Florian


Florian,

Thanks for the pointer. I ended up doing a little bit of sleuthing and thin=
k
I figured out a relatively clean fix---a simple one-liner in configure.ac.
Attached is a proof-of-concept patch against master (974bf81776).

Currently, autoconf sets make's shell to whatever it thinks is best. On a
foreign distribution, this often ends up something external to guix profile=
=2E
However, when this isn't bash, we run into problems.

The patch's idea is to let make use its hard-coded default shell. A guix-bu=
ilt
make will correctly fallback to whichever sh is in the profile, so for `gui=
x
environment guix' this effectively becomes $GUIX_ENVIRONMENT/bin/sh. For
example,

    $ echo '$(info $(SHELL))' | make -f -
    /gnu/store/29jhbbg1hf557x8j53f9sxd9imlmf02a-bash-minimal-5.0.7/bin/sh
    make: *** No targets.  Stop.

I belive this should do the Right Thing. However, is there anything I am
missing? Perhaps this change would break build scenaries I am not thinking =
of?

Cheers,
B. Wilson


------_=_40e4eb697d18a189045b3508_=_
Content-Disposition: attachment;
 filename*0*=UTF-8''0001-build-Let-make-use-its-hard-coded-default-shell.;
 filename*1*=patch
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

From 6a5533fde0580a777a10f1155714f23a003003d9 Mon Sep 17 00:00:00 2001
From: "B. Wilson" <elaexuotee@HIDDEN>
Date: Thu, 16 Apr 2020 17:02:06 +0900
Subject: [PATCH] build: Let make use its hard-coded default shell
To: guix-patches@HIDDEN

* configure.ac: Set AM_SUBST_NOTMAKE([SHELL])
---
 configure.ac | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/configure.ac b/configure.ac
index 6a6a020585..dbb06f2258 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11,6 +11,10 @@ AC_CONFIG_AUX_DIR([build-aux])
 AM_INIT_AUTOMAKE([1.14 gnu silent-rules subdir-objects \
  color-tests parallel-tests -Woverride -Wno-portability])
 
+# Use make's hard-coded default shell. The make in a guix profile
+# defaults to the Right Thing, e.g. $GUIX_ENVIRONMENT/bin/sh
+AM_SUBST_NOTMAKE([SHELL])
+
 # Enable silent rules by default.
 AM_SILENT_RULES([yes])
 
-- 
2.26.1


------_=_40e4eb697d18a189045b3508_=_--

------_=_064465a37bd4286b3a903232_=_
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYIADUWIQQ7FdZn/PDWvxE6cmR2pStZ7i7CgQUCXpnSlRccZWxhZXh1b3Rl
ZUB3aWxzb25iLmNvbQAKCRB2pStZ7i7CgbieAQD6NNh9jtg6Cimpgrv78M9hgwTU
XMTiaXaT2xddzJPnJAEAhUWbcFLeLWphvbYNHVzPBJ296wzWQYh2x2ACy1NVLAk=
=mxC5
-----END PGP SIGNATURE-----

------_=_064465a37bd4286b3a903232_=_--

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at 40641 <at> debbugs.gnu.org:

Received: (at 40641) by debbugs.gnu.org; 15 Apr 2020 12:21:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 15 08:21:54 2020
Received: from localhost ([127.0.0.1]:35342 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jOh3C-0002rZ-NW
	for submit <at> debbugs.gnu.org; Wed, 15 Apr 2020 08:21:54 -0400
Received: from pelzflorian.de ([5.45.111.108]:58520 helo=mail.pelzflorian.de)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pelzflorian@HIDDEN>) id 1jOh3A-0002rO-UO
 for 40641 <at> debbugs.gnu.org; Wed, 15 Apr 2020 08:21:53 -0400
Received: from pelzflorian.localdomain (unknown [5.45.111.108])
 by mail.pelzflorian.de (Postfix) with ESMTPSA id 4566436055C;
 Wed, 15 Apr 2020 14:21:51 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de;
 s=mail; t=1586953311;
 bh=lVvZK+WVjb2Z856Ty2e/jGECUJqqphRSxX2XRrOwk9U=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To;
 b=z84lvoP7gqH0OXbEgEr1clFzGJh6Nh9BmYvkUfRrrnrg+SZll/dfI1jbainXlY/HY
 T8bv3qQg0shl6c2R2BLvf5LrxLx/NfPPewJQxM9wJclylQpfHMOHWUU3Rp8ykMVa5a
 OUf+eflQEEyJLtgkrsrZXXWhP7kkNs34gmxLon+s=
Date: Wed, 15 Apr 2020 14:21:49 +0200
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
To: elaexuotee@HIDDEN
Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash
Message-ID: <20200415122149.j7b6bcgvrp5cpq5l@HIDDEN>
References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 40641
Cc: 40641 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wed, Apr 15, 2020 at 06:06:25PM +0900, elaexuotee--- via Bug reports for GNU Guix wrote:
> When building from git, ./bootstrap ends up generating (via automake) several
> Makefiles that set SHELL = /bin/sh. However, some targets contain rules that
> make use of bashisms. This leads to breakage when /bin/sh is something other
> than bash.
> 
> In particular, I am building from a foreign distro which links /bin/sh to dash.
> Currently, this ends up breaking the build, the details of which I reported
> to guix-devel in [0].

<https://bugs.gnu.org/25258> is related.  Your workaround may be more welcome.

Regards,
Florian

Information forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 15 Apr 2020 11:06:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 15 07:06:04 2020
Received: from localhost ([127.0.0.1]:35318 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jOfro-0007HA-7E
	for submit <at> debbugs.gnu.org; Wed, 15 Apr 2020 07:06:04 -0400
Received: from lists.gnu.org ([209.51.188.17]:54222)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bounce+7434c3.08547a-bug-guix=gnu.org@HIDDEN>)
 id 1jOfqx-0007FX-V9
 for submit <at> debbugs.gnu.org; Wed, 15 Apr 2020 07:05:12 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48703)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bounce+7434c3.08547a-bug-guix=gnu.org@HIDDEN>)
 id 1jOfqw-0002Eu-KW
 for bug-guix@HIDDEN; Wed, 15 Apr 2020 07:05:11 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, 
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <bounce+7434c3.08547a-bug-guix=gnu.org@HIDDEN>)
 id 1jOfqv-0004ky-B1
 for bug-guix@HIDDEN; Wed, 15 Apr 2020 07:05:10 -0400
Received: from m42-5.mailgun.net ([69.72.42.5]:62036)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71)
 (envelope-from <bounce+7434c3.08547a-bug-guix=gnu.org@HIDDEN>)
 id 1jOfqv-0004iq-30
 for bug-guix@HIDDEN; Wed, 15 Apr 2020 07:05:09 -0400
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com;
 q=dns/txt; 
 s=krs; t=1586948709; h=Content-Type: MIME-Version: Message-Id: Subject:
 From: To: Date: Sender;
 bh=rrr4M13gspNTFBv6slR1sz/c3Hp8RVe4U3AcyodxGso=;
 b=1d/uuKlY/oxIaM2cDvF9lqKOF2jMTX8ipO5M4da/DuSjKPZKY5814vvbF5RdmtP+B6yZ5xA/
 vCBSiIq2NAPzEAFTg/LpzVnnWJKzJtX2sto5gzSF1wbeGRHjP8JSPLxkbj5Eiu02WzOC56h4
 x2trK2OaJnfkQRgH3eqr0/rwlKd4zqqjET6e/4gh8beclMC8gvm9Z6c8aChkFkLIimJUfTLz
 Sh+qLPNH0WnLvbqFLJzbc+UReLqWTUXOBBXQOiLXsuLFiMQ9uLOI/vC6X50CVcPScfcAZM9X
 LRP++776QRoxO11i7Jlua+i1boQELJZ+UHu2kGrk/zxLy7WEL6DFbQ==
X-Mailgun-Sending-Ip: 69.72.42.5
X-Mailgun-Sid: WyJkMDM0YyIsICJidWctZ3VpeEBnbnUub3JnIiwgIjA4NTQ3YSJd
Received: from wilsonb.com (wilsonb.com [104.199.203.42])
 by mxa.mailgun.org with ESMTP id 5e96ea61.7ffb0a79d420-smtp-out-n05;
 Wed, 15 Apr 2020 11:05:05 -0000 (UTC)
Received: from localhost (KD111239207205.au-net.ne.jp [111.239.207.205])
 by wilsonb.com (Postfix) with ESMTPSA id 76F39A1A5C
 for <bug-guix@HIDDEN>; Wed, 15 Apr 2020 11:05:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com;
 s=201703; t=1586948702;
 bh=rrr4M13gspNTFBv6slR1sz/c3Hp8RVe4U3AcyodxGso=;
 h=Date:To:From:Subject:From;
 b=I40LUWi5VrAyrj8+bA+E+5B+3wTGe8zJHTEoA3YN/eOibGpSsSSewMWoKDyWg+JJ6
 rah7Had3tqgrBNCuEmbVseYr/VwQc7nnMnnmfjIyqADe7ph6PJ0bC0NtW9HZ+F+qav
 XMcF9BctjWUA5XtHNblVwCd+3ukIYrgvhIgS4q2AYQm4iK/UwRITlfvfP/K+TixusB
 QrRImvCgt2sAxlDvbXquXoTLG3749MDBxs6ULrJQxqzxgwtOSQgNttrEW3PyS84+/x
 TjQrviRoJHWvAyF9UJ5AyDQ55Og4tRGwEwW2NoQahuYtR7UJVQ7+/xY4ko8y7leIa3
 FvEVjPuJGy6xBjL4MPe4GdJDXlkNZAXw/T/irqW3FCHwTaBVIxVZXZcM1K3LM12Mzb
 8nwhGqIbmUAuD50+K41Kw7EZhBiPo6crEsI25j8E8gZlLlNFYXSub7OkHxNuML6xXq
 jFASltEQPDJprGDBT9BJ81IjnQCfBKO+2JoXMqXLG9CUnZ7TrF9DJO1NpypV9B0A0q
 xJrZuyMGp+n7RAy8sH68I5VQzY0j/fJdd5gfFgo+Fv9JpmkggcbE+IY+9YlYvo0Yyw
 JDbyFkhW/5SDBKGv6LuzyVjKLJ/9+/BDpNCEFS+maTKDjqr2Asa0kWeppKZkJvZyrw
 oxowBdOuIiUQMB3FoMIia30M=
Date: Wed, 15 Apr 2020 18:06:25 +0900
To: bug-guix@HIDDEN
From: elaexuotee@HIDDEN
Subject: Building from git breaks when /bin/sh isn't bash
Message-Id: <2O2NKRGHD2OZD.30CKDJBOP4LE3@HIDDEN>
User-Agent: mblaze/0.5.1
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha1";
 protocol="application/pgp-signature";
 boundary="----_=_5d193d5246943d7612a15089_=_"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 69.72.42.5
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Wed, 15 Apr 2020 07:06:01 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

This is a multipart message in MIME format.

------_=_5d193d5246943d7612a15089_=_
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_56b7ec4a6fd3ad4e063d78c1_=_"

This is a multipart message in MIME format.

------_=_56b7ec4a6fd3ad4e063d78c1_=_
Content-Type: text/plain; charset=UTF-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

When building from git, ./bootstrap ends up generating (via automake) sever=
al
Makefiles that set SHELL =3D /bin/sh. However, some targets contain rules t=
hat
make use of bashisms. This leads to breakage when /bin/sh is something othe=
r
than bash.

In particular, I am building from a foreign distro which links /bin/sh to d=
ash.
Currently, this ends up breaking the build, the details of which I reported=

to guix-devel in [0].

As a workaround, at the moment we have to force make's SHELL to point to ba=
sh.
The cleanest way to do this is probably as follows:

    $ make SHELL=3D$(command -v sh)

since from within guix environment --pure guix, sh ends up pointing to bash=
=2E
Just for clarity, here is how this looks for me, currently:

    $ git rev-parse HEAD
    2708ae3d69b54d8323ca84fd9a7fb108a6ee96ba
    $ guix environment --pure guix
    $ readlink -f $(command -v sh)
    /gnu/store/29jhbbg1hf557x8j53f9sxd9imlmf02a-bash-minimal-5.0.7/bin/bash=


[0]:https://lists.gnu.org/archive/html/guix-devel/2020-04/msg00232.html

------_=_56b7ec4a6fd3ad4e063d78c1_=_--

------_=_5d193d5246943d7612a15089_=_
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYIADUWIQQ7FdZn/PDWvxE6cmR2pStZ7i7CgQUCXpbqRxccZWxhZXh1b3Rl
ZUB3aWxzb25iLmNvbQAKCRB2pStZ7i7CgSo9AP4s30rS0uhv4WMDHjA4/SWlFmKW
mN2F9WXD3TQiPdulaQD+L1aG8ULb5wRtGVaqJcAdVbXZOySCfs+2Y3NumYHRcAQ=
=bVJh
-----END PGP SIGNATURE-----

------_=_5d193d5246943d7612a15089_=_--

Acknowledgement sent to elaexuotee@HIDDEN:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.

Report forwarded to bug-guix@HIDDEN:
bug#40641; Package guix. Full text available.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Last modified: Thu, 21 Jul 2022 20:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.

GNU bug report logs - #40641 Building from git breaks when /bin/sh isn't bash

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641-done <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at 40641 <at> debbugs.gnu.org:

Message received at submit <at> debbugs.gnu.org:

GNU bug report logs - #40641
Building from git breaks when /bin/sh isn't bash