GNU bug report logs - #40654
[PATCH core-updates] gnu: gnutls: Enable p11-kit.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Christopher Baines <mail@HIDDEN>; Keywords: patch; dated Thu, 16 Apr 2020 08:35:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Changed bug title to '[PATCH core-updates] gnu: gnutls: Enable p11-kit.' from '[PATCH] gnu: gnutls: Enable p11-kit.' Request was from Jakub Kądziołka <kuba@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 40654 <at> debbugs.gnu.org:


Received: (at 40654) by debbugs.gnu.org; 16 Apr 2020 12:16:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 16 08:16:34 2020
Received: from localhost ([127.0.0.1]:37679 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jP3RZ-0003jG-M1
	for submit <at> debbugs.gnu.org; Thu, 16 Apr 2020 08:16:33 -0400
Received: from pat.zlotemysli.pl ([37.59.186.212]:48792)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kuba@HIDDEN>) id 1jP3RX-0003fe-El
 for 40654 <at> debbugs.gnu.org; Thu, 16 Apr 2020 08:16:32 -0400
Received: (qmail 3505 invoked by uid 1009); 16 Apr 2020 14:16:29 +0200
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
 (envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st 
 (clamdscan: 0.98.6/25783. spamassassin: 3.4.0. perlscan: 2.08st.  
 Clear:RC:1(188.123.215.55):. 
 Processed in 0.024542 secs); 16 Apr 2020 12:16:29 -0000
Received: from unknown (HELO gravity) (kuba@HIDDEN@188.123.215.55)
 by pat.zlotemysli.pl with SMTP; 16 Apr 2020 14:16:29 +0200
Date: Thu, 16 Apr 2020 14:16:27 +0200
From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN>
To: Christopher Baines <mail@HIDDEN>
Subject: Re: [PATCH] gnu: gnutls: Enable p11-kit.
Message-ID: <20200416121627.6uaox5yd3vmpym53@gravity>
References: <20200416083409.6230-1-mail@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="vfyeluu527suj5rx"
Content-Disposition: inline
In-Reply-To: <20200416083409.6230-1-mail@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 40654
Cc: 40654 <at> debbugs.gnu.org, control <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--vfyeluu527suj5rx
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

retitle 40654 [PATCH core-updates] gnu: gnutls: Enable p11-kit.
thanks

On Thu, Apr 16, 2020 at 09:34:09AM +0100, Christopher Baines wrote:
> Everywhere except mips64el, where a comment says it doesn't work. I can't=
 test
> as I can't build this on mips64el anyway.
>=20
> This change will enable running the tests for libcacard.
>=20
> * gnu/packages/tls.scm (gnutls)[arguments]: Only specify --without-p11-ki=
t on
> mips64el.
> [inputs]: Include the p11-kit for all systems except mips64el.

Chris,

not sure if you noticed, but even though `guix refresh --list-dependent
gnutls' lists only 2 packages, this change will trigger a
core-updates-worthy rebuild due to the graft currently used for gnutls.

I was under the impression that, as a convention, we mark such patches
with [PATCH core-updates] in the subject, which made me uncertain as to
whether you realized that this will rebuild the world. (Though, now that
I think of it, testing this has probably required a significant amount
of time...)

Have a nice day!

Jakub K=C4=85dzio=C5=82ka

--vfyeluu527suj5rx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl6YTJsACgkQ4xWnWEYT
FWQnaA//b/zsGvpCP6qGuSWajQ6JUCoM1fDOlypnqtC7JjfYymBXfh1jiDQs7+f3
6NFXTtzIREn5IbB9lpOpSRsgDLs3JBwKzliOhcxIC8u0kEpW3EMBEEC58hJV69K7
ruUudoiTTUtgC51tHniKTSO6kWh4h0SOVpzMP+2zfL9c8qVfA9+wuHs4LZPmlTIp
KVotsBTvt/BAG8J/IdF3Tg8ATV18kOy9Jn1OVlIG+/wKXxLWnVWNioCwUujZBdWv
608O+Nn3MgkZMpVzMDFliuLW0A5kKgv31KQW3F4ePcVMdiJ7RWu49DCWJQzM3UB4
Bp4uTPitmR5rN8BPN+nhec0YbUqUlF7cl3IdmLRjQmTZxrhD3c6lLNT3m3UvHIhq
L6aiOwwc/M4xXqukIVW+rb63S2JF1Fl4vsY1hf3hSpPZZzObtauJZL2ZcyBwhFC+
URLzyx62K/WsckHA4B7bt4JdOApVDZvaho0GSwNvm4XI1Lemie8Ft+t6MVpDH41I
cMMX6A213mJLr5L/N1au9bAhnU3j9wIP+zGXeLcc/bR72jLeXT1iClArQP53C87a
PE4aR501lUClTJEt3c3AAxqq+q58IHvHbmE68e4J8yzzYRKXSQj86JkULGQFxmHH
u1M3p7ZFFi18mqE538dgIFHMPjJRyPa0GtQ3vWQtKFXUF909nsE=
=UJe5
-----END PGP SIGNATURE-----

--vfyeluu527suj5rx--




Information forwarded to guix-patches@HIDDEN:
bug#40654; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 16 Apr 2020 08:34:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 16 04:34:18 2020
Received: from localhost ([127.0.0.1]:37499 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jOzyT-0002sf-RB
	for submit <at> debbugs.gnu.org; Thu, 16 Apr 2020 04:34:18 -0400
Received: from lists.gnu.org ([209.51.188.17]:34650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1jOzyS-0002sY-Is
 for submit <at> debbugs.gnu.org; Thu, 16 Apr 2020 04:34:16 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46103)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@HIDDEN>) id 1jOzyQ-0001me-El
 for guix-patches@HIDDEN; Thu, 16 Apr 2020 04:34:16 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,UNPARSEABLE_RELAY
 autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@HIDDEN>) id 1jOzyP-00088B-3Z
 for guix-patches@HIDDEN; Thu, 16 Apr 2020 04:34:14 -0400
Received: from mira.cbaines.net ([212.71.252.8]:54324)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <mail@HIDDEN>) id 1jOzyO-00087v-UI
 for guix-patches@HIDDEN; Thu, 16 Apr 2020 04:34:13 -0400
Received: from localhost (unknown [46.237.160.17])
 by mira.cbaines.net (Postfix) with ESMTPSA id AAEE827BBE1
 for <guix-patches@HIDDEN>; Thu, 16 Apr 2020 09:34:11 +0100 (BST)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 0af077fa
 for <guix-patches@HIDDEN>; Thu, 16 Apr 2020 08:34:09 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: gnutls: Enable p11-kit.
Date: Thu, 16 Apr 2020 09:34:09 +0100
Message-Id: <20200416083409.6230-1-mail@HIDDEN>
X-Mailer: git-send-email 2.26.0
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 212.71.252.8
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Everywhere except mips64el, where a comment says it doesn't work. I can't=
 test
as I can't build this on mips64el anyway.

This change will enable running the tests for libcacard.

* gnu/packages/tls.scm (gnutls)[arguments]: Only specify --without-p11-ki=
t on
mips64el.
[inputs]: Include the p11-kit for all systems except mips64el.
---
 gnu/packages/tls.scm | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index 3eb32fc27a..85f159a401 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -181,7 +181,7 @@ living in the same process.")
      `(; Ensure we don't keep a reference to this buggy software.
        #:disallowed-references (,net-tools)
        #:configure-flags
-       (list
+       (cons*
              ;; GnuTLS doesn't consult any environment variables to spec=
ify
              ;; the location of the system-wide trust store.  Instead it=
 has a
              ;; configure-time option.  Unless specified, its configure =
script
@@ -202,9 +202,14 @@ living in the same process.")
              (string-append "--with-guile-extension-dir=3D"
                             "$(libdir)/guile/$(GUILE_EFFECTIVE_VERSION)/=
extensions")
=20
-             ;; FIXME: Temporarily disable p11-kit support since it is n=
ot
-             ;; working on mips64el.
-             "--without-p11-kit")
+             (let ((system ,(or (%current-target-system)
+                                (%current-system))))
+               (if (string-prefix? "mips64el" system)
+                   (list
+                    ;; FIXME: Temporarily disable p11-kit support since =
it is
+                    ;; not working on mips64el.
+                    "--without-p11-kit")
+                   '())))
=20
        #:phases (modify-phases %standard-phases
                   (add-after
@@ -227,7 +232,12 @@ living in the same process.")
        ("pkg-config" ,pkg-config)
        ("which" ,which)))
     (inputs
-     `(("guile" ,guile-2.2)))
+     `(("guile" ,guile-2.2)
+       ,@(let ((system (or (%current-target-system)
+                           (%current-system))))
+           (if (string-prefix? "mips64el" system)
+               '()
+               `(("p11-kit" ,p11-kit))))))
     (propagated-inputs
      ;; These are all in the 'Requires.private' field of gnutls.pc.
      `(("libtasn1" ,libtasn1)
--=20
2.26.0





Acknowledgement sent to Christopher Baines <mail@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#40654; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 16 Apr 2020 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.