GNU bug report logs - #40947
Add emacs-boon

Previous Next

Package: guix-patches;

Reported by: Elais Player <elais <at> fastmail.com>

Date: Tue, 28 Apr 2020 21:01:02 UTC

Severity: normal

Tags: patch

Merged with 40970

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40947 in the body.
You can then email your comments to 40947 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40947; Package guix-patches. (Tue, 28 Apr 2020 21:01:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Elais Player <elais <at> fastmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 28 Apr 2020 21:01:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elais Player <elais <at> fastmail.com>
To: guix-patches <at> gnu.org
Subject: Add emacs-boon
Date: Tue, 28 Apr 2020 13:57:48 -0600
[Message part 1 (text/plain, inline)]
Hi,

This patch adds the boon modal editing package

[Message part 2 (text/html, inline)]
[0001-Add-emacs-boon-package.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#40947; Package guix-patches. (Wed, 29 Apr 2020 14:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 40947 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Elais Player <elais <at> fastmail.com>
Cc: 40947 <at> debbugs.gnu.org
Subject: Re: [bug#40947] Add emacs-boon
Date: Wed, 29 Apr 2020 16:48:02 +0200
Hello,

Elais Player <elais <at> fastmail.com> writes:

> This patch adds the boon modal editing package

Thank you.

> Subject: [PATCH 1/1] Add emacs-boon package
>
> This patch adds boon modal editing packages.

The expected commit message is slightly different.

  gnu: Add emacs-boon.

  * gnu/packages/emacs-xyz.scm (emacs-boon): New variable.

If you use Yasnippets, using "add <TAB>" in an empty commit message
generates it for you. See (info "(guix)The Perfect Setup").

>  provides a simple but convenient user interface to manage those trashed
>  files.")
>      (license license:gpl3+)))

As a rule of thumb, please do not append new packages at the end of the
file. It is more likely to generate merge conflicts.

> +       (sha256
> +        (base32
> +         "1ss9bjs34q41pa0g0nbdzd8fwpjcbd2239rdlx5aykfv9v0b8j77"))))

Nitpick: could you move the string on the same line as `base32'?

> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-expand-region" ,emacs-expand-region)
> +       ("spaceline" ,emacs-spaceline)
> +       ("powerline" ,emacs-powerline)
> +       ("emacs-dash" ,emacs-dash)
> +       ("emacs-multiple-cursors" ,emacs-multiple-cursors)))

Could you re-order inputs alphabetically?

> +    (home-page "https://github.com/jyp/boon")
> +    (synopsis "Ergonomic Command Mode for Emacs.")

Synopsis is not expected to end with a full stop. You may want to run
guix lint on the package.

> +    (description
> +     "Boon brings modal editing capabilities to Emacs and...
> +
> +- It tries to be as ergonomic as possible.
> +- It remains lightweight (~300 loc for its core.)
> +- It attempts to integrate with Emacs as smoothly as possible")

Here you should write Texinfo markup: 

    @itemize
    @item it tries to...
    @item ...
    ...
    @end itemize

However, you way want to extract the description from the project's
GitHub front page instead of the main file.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou




Merged 40947 40970. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 17 Jun 2020 10:05:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 15 Dec 2020 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 104 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.