GNU bug report logs - #40970
[PATCH] gnu: add emacs-boon

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40970 in the body.
You can then email your comments to 40970 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elais Player <elais <at> fastmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add emacs-boon
Date: Wed, 29 Apr 2020 12:54:58 -0600

[Message part 1 (text/plain, inline)]

Hi,

This patch adds the emacs-boon package with changes recommended by 
Nicolas Goaziou.

Best,

--
Elais Player

[0001-gnu-Add-emacs-boon.patch (text/x-patch, attachment)]

Message #8 received at 40970 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Elais Player <elais <at> fastmail.com>
Cc: 40970 <at> debbugs.gnu.org
Subject: Re: [bug#40970] [PATCH] gnu: add emacs-boon
Date: Fri, 01 May 2020 22:49:09 +0200

Hello,

Elais Player <elais <at> fastmail.com> writes:

> This patch adds the emacs-boon package with changes recommended by
> Nicolas Goaziou.

Thank you.

> +    (description
> +     "Boon is a complete package for modal editing, which is not Evil.
> +Strong points:

Nitpick: I suggest to use a complete sentence here.

> +@itemize
> +@item Ergonomic: common commands are easy to type.
> +@item Emacs-friendly: Emacs conventions are respected as much as compatible
> +with design goals. This means that Boon integrates well with existing Emacs
> +infrastructure, and leverages it. Existing user configuration can often be
> +re-used.
> +@item Modular: No need to buy into the whole system: mix-and-match the parts

"No need" -> "no need"

Also, you need to put two spaces at the end of sentences in description.

Otherwise, LGTM.

You generated a new patch on top of the previous one. Could you merge
both, fix the above, and send one last patch?

Regards,

-- 
Nicolas Goaziou

Message #15 received at 40970-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Elais Player <elais <at> fastmail.com>
Cc: 40970-done <at> debbugs.gnu.org
Subject: Re: [bug#40970] [PATCH] gnu: add emacs-boon
Date: Mon, 16 Nov 2020 20:22:38 +0100

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Elais Player <elais <at> fastmail.com> writes:
>
>> This patch adds the emacs-boon package with changes recommended by
>> Nicolas Goaziou.
>
> Thank you.
>
>> +    (description
>> +     "Boon is a complete package for modal editing, which is not Evil.
>> +Strong points:
>
> Nitpick: I suggest to use a complete sentence here.
>
>> +@itemize
>> +@item Ergonomic: common commands are easy to type.
>> +@item Emacs-friendly: Emacs conventions are respected as much as compatible
>> +with design goals. This means that Boon integrates well with existing Emacs
>> +infrastructure, and leverages it. Existing user configuration can often be
>> +re-used.
>> +@item Modular: No need to buy into the whole system: mix-and-match the parts
>
> "No need" -> "no need"
>
> Also, you need to put two spaces at the end of sentences in description.
>
> Otherwise, LGTM.
>
> You generated a new patch on top of the previous one. Could you merge
> both, fix the above, and send one last patch?

I pushed a new iteration of this patch. I'm closing this one.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.